28005 2009-08-04 16:50:06 -0700 Keypress should exit from pan scrolling mode 2009-08-04 22:21:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein adele oldest_to_newest 137189 0 bweinstein 2009-08-04 16:50:06 -0700 Pressing a key should exit the WebView from pan scrolling mode. This matches what IE and Opera do. We currently exit the WebView on escape, matching Firefox, but this could be hard to discover for users who may have middle clicked on accident. <rdar://6591806> 137190 1 34100 bweinstein 2009-08-04 16:54:46 -0700 Created attachment 34100 Any Key Press 137197 2 34100 adele 2009-08-04 17:16:12 -0700 Comment on attachment 34100 Any Key Press What do other browsers that support pan scrolling do? 137200 3 bweinstein 2009-08-04 17:19:49 -0700 IE, Opera -> Exit pan scrolling on any keypress. Firefox -> Exit only on escape Safari, Chrome -> Exit only on escape - for now. From the radar (Steve): This is kind of nasty, since if a user accidently middle clicks on a webpage, they can't type until they left click or hit escape. 137202 4 adele 2009-08-04 17:23:16 -0700 Do IE and Opera also both cancel the pan scroll on keydown (instead of keyup)? 137205 5 bweinstein 2009-08-04 17:25:48 -0700 Yes, and Firefox cancels on escape down. 137253 6 bweinstein 2009-08-04 22:21:53 -0700 Clearing review flag - landed in http://trac.webkit.org/changeset/46793 34100 2009-08-04 16:54:46 -0700 2009-08-04 22:21:24 -0700 Any Key Press 0001-Keypress-should-exit-from-pan-scrolling-mode.patch text/plain 2085 bweinstein RnJvbSBjMjVhZDMzZTI3MmY2MzdlOTlhOTUyODgwNjVlYTRlMWE5ODMzODc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmlhbiBXZWluc3RlaW4gPGJ3ZWluc3RlaW5AYXBwbGUuY29t PgpEYXRlOiBUdWUsIDQgQXVnIDIwMDkgMTY6NTM6MjkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBL ZXlwcmVzcyBzaG91bGQgZXhpdCBmcm9tIHBhbiBzY3JvbGxpbmcgbW9kZS4KCi0tLQogV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYkNvcmUvcGFn ZS9FdmVudEhhbmRsZXIuY3BwIHwgICAgNCArLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2Vy dGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNDA2MTZlLi41NmE4ZDQyIDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDA5LTA4LTA0ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBLZXlwcmVzcyBz aG91bGQgZXhpdCBmcm9tIHBhbiBzY3JvbGxpbmcgbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MDA1CisKKyAgICAgICAgQ2hhbmdlIHRoZSBs b2dpYyBmcm9tIG9ubHkgZXhpdGluZyBwYW4gc2Nyb2xsaW5nIG9uIGVzY2FwZSB0byBleGl0aW5n IG9uIGFueSBrZXkgcHJlc3MsCisgICAgICAgIG1ha2luZyBpdCBlYXNpZXIgZm9yIHVzZXJzIHRv IGJhY2sgb3V0IG9mIGFuIGFjY2lkZW50YWwgcGFuIHNjcm9sbC4KKworICAgICAgICAqIHBhZ2Uv RXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6a2V5RXZl bnQpOgorCiAyMDA5LTA4LTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmlu ZGV4IGNiYmNkNjQuLjA5OGI0MDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuY3BwCisrKyBiL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC0xOTQ0LDEwICsx OTQ0LDggQEAgYm9vbCBFdmVudEhhbmRsZXI6OmtleUV2ZW50KGNvbnN0IFBsYXRmb3JtS2V5Ym9h cmRFdmVudCYgaW5pdGlhbEtleUV2ZW50KQogI2lmIEVOQUJMRShQQU5fU0NST0xMSU5HKQogICAg IGlmIChQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpKSB7CiAgICAgICAgIGlmIChwYWdlLT5t YWluRnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPnBhblNjcm9sbEluUHJvZ3Jlc3MoKSB8fCBtX2F1 dG9zY3JvbGxJblByb2dyZXNzKSB7Ci0gICAgICAgICAgICBzdGF0aWMgY29uc3QgY2hhciogY29u c3QgZXNjYXBlS2V5SWRlbnRpZmllciA9ICJVKzAwMUIiOwotCiAgICAgICAgICAgICAvLyBJZiBh IGtleSBpcyBwcmVzc2VkIHdoaWxlIHRoZSBhdXRvc2Nyb2xsL3BhblNjcm9sbCBpcyBpbiBwcm9n cmVzcyB0aGVuIHdlIHdhbnQgdG8gc3RvcAotICAgICAgICAgICAgaWYgKGluaXRpYWxLZXlFdmVu dC5rZXlJZGVudGlmaWVyKCkgPT0gZXNjYXBlS2V5SWRlbnRpZmllciAmJiBpbml0aWFsS2V5RXZl bnQudHlwZSgpID09IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6S2V5VXApIAorICAgICAgICAgICAg aWYgKGluaXRpYWxLZXlFdmVudC50eXBlKCkgPT0gUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpLZXlE b3duIHx8IGluaXRpYWxLZXlFdmVudC50eXBlKCkgPT0gUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpS YXdLZXlEb3duKSAKICAgICAgICAgICAgICAgICBzdG9wQXV0b3Njcm9sbFRpbWVyKCk7CiAKICAg ICAgICAgICAgIC8vIElmIHdlIHdlcmUgaW4gYXV0b3Njcm9sbC9wYW5zY3JvbGwgbW9kZSwgd2Ug c3dhbGxvdyB0aGUga2V5IGV2ZW50Ci0tIAoxLjYuMQoK