27996 2009-08-04 14:24:42 -0700 [V8] Fix an assert in WebCoreStringResource that causes worker script evaluation failed. 2009-08-04 15:52:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli levin oldest_to_newest 137125 0 jianli 2009-08-04 14:24:42 -0700 There is an assert in WebCoreStringResource that causes worker script evaluation failed. We should check for the same thread, instead of the main thread, in WebCoreStringResource. 137128 1 34087 jianli 2009-08-04 14:29:44 -0700 Created attachment 34087 Proposed Patch 137133 2 34087 levin 2009-08-04 14:41:59 -0700 Comment on attachment 34087 Proposed Patch It would be nice to mention in the ChangeLog why this is needed. Even thought Chromium's workers only use v8 in a single thread, they don't use it on the main thread. 137162 3 jianli 2009-08-04 15:52:47 -0700 Committed as http://trac.webkit.org/changeset/46782. 34087 2009-08-04 14:29:44 -0700 2009-08-04 14:41:59 -0700 Proposed Patch 27996 text/plain 2454 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjQwNjE2ZS4uNzQ1ZDE2YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0wNCAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBGaXggYW4gYXNzZXJ0IGluIFdlYkNvcmVTdHJpbmdSZXNvdXJjZSB0 aGF0IGNhdXNlcyB3b3JrZXIgc2NyaXB0CisgICAgICAgIGV2YWx1YXRpb24gZmFpbGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5OTYKKworICAg ICAgICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJD b3JlU3RyaW5nUmVzb3VyY2U6OldlYkNvcmVTdHJpbmdSZXNvdXJjZSk6CisgICAgICAgIChXZWJD b3JlOjpXZWJDb3JlU3RyaW5nUmVzb3VyY2U6On5XZWJDb3JlU3RyaW5nUmVzb3VyY2UpOgorICAg ICAgICAoV2ViQ29yZTo6V2ViQ29yZVN0cmluZ1Jlc291cmNlOjphdG9taWNTdHJpbmcpOgorCiAy MDA5LTA4LTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKaW5k ZXggYmMwZTlkOC4uYzVkNTgwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJp bmRpbmcuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcApAQCAtNTEs NyArNTEsOSBAQCBwdWJsaWM6CiAgICAgZXhwbGljaXQgV2ViQ29yZVN0cmluZ1Jlc291cmNlKGNv bnN0IFN0cmluZyYgc3RyaW5nKQogICAgICAgICA6IG1fcGxhaW5TdHJpbmcoc3RyaW5nKQogICAg IHsKLSAgICAgICAgQVNTRVJUKFdURjo6aXNNYWluVGhyZWFkKCkpOworI2lmbmRlZiBOREVCVUcK KyAgICAgICAgbV90aHJlYWRJZCA9IFdURjo6Y3VycmVudFRocmVhZCgpOworI2VuZGlmCiAgICAg ICAgIHY4OjpWODo6QWRqdXN0QW1vdW50T2ZFeHRlcm5hbEFsbG9jYXRlZE1lbW9yeSgyICogbGVu Z3RoKCkpOwogICAgIH0KIApAQCAtNTksMTMgKzYxLDE3IEBAIHB1YmxpYzoKICAgICAgICAgOiBt X3BsYWluU3RyaW5nKHN0cmluZykKICAgICAgICAgLCBtX2F0b21pY1N0cmluZyhzdHJpbmcpCiAg ICAgewotICAgICAgICBBU1NFUlQoV1RGOjppc01haW5UaHJlYWQoKSk7CisjaWZuZGVmIE5ERUJV RworICAgICAgICBtX3RocmVhZElkID0gV1RGOjpjdXJyZW50VGhyZWFkKCk7CisjZW5kaWYKICAg ICAgICAgdjg6OlY4OjpBZGp1c3RBbW91bnRPZkV4dGVybmFsQWxsb2NhdGVkTWVtb3J5KDIgKiBs ZW5ndGgoKSk7CiAgICAgfQogCiAgICAgdmlydHVhbCB+V2ViQ29yZVN0cmluZ1Jlc291cmNlKCkK ICAgICB7Ci0gICAgICAgIEFTU0VSVChXVEY6OmlzTWFpblRocmVhZCgpKTsKKyNpZm5kZWYgTkRF QlVHCisgICAgICAgIEFTU0VSVChtX3RocmVhZElkID09IFdURjo6Y3VycmVudFRocmVhZCgpKTsK KyNlbmRpZgogICAgICAgICBpbnQgcmVkdWNlZEV4dGVybmFsTWVtb3J5ID0gLTIgKiBsZW5ndGgo KTsKICAgICAgICAgaWYgKCFtX3BsYWluU3RyaW5nLmltcGwoKS0+aW5UYWJsZSgpKQogICAgICAg ICAgICAgcmVkdWNlZEV4dGVybmFsTWVtb3J5ICo9IDI7CkBAIC04Myw3ICs4OSw5IEBAIHB1Ymxp YzoKIAogICAgIEF0b21pY1N0cmluZyBhdG9taWNTdHJpbmcoKQogICAgIHsKLSAgICAgICAgQVNT RVJUKFdURjo6aXNNYWluVGhyZWFkKCkpOworI2lmbmRlZiBOREVCVUcKKyAgICAgICAgQVNTRVJU KG1fdGhyZWFkSWQgPT0gV1RGOjpjdXJyZW50VGhyZWFkKCkpOworI2VuZGlmCiAgICAgICAgIGlm IChtX2F0b21pY1N0cmluZy5pc051bGwoKSkgewogICAgICAgICAgICAgbV9hdG9taWNTdHJpbmcg PSBBdG9taWNTdHJpbmcobV9wbGFpblN0cmluZyk7CiAgICAgICAgICAgICBpZiAoIW1fcGxhaW5T dHJpbmcuaW1wbCgpLT5pblRhYmxlKCkpCkBAIC0xMDYsNiArMTE0LDEwIEBAIHByaXZhdGU6CiAg ICAgLy8gdGhlIG9yaWdpbmFsIHN0cmluZyBhbGl2ZSBiZWNhdXNlIHY4IG1heSBrZWVwIGRlcml2 ZWQgcG9pbnRlcnMKICAgICAvLyBpbnRvIHRoYXQgc3RyaW5nLgogICAgIEF0b21pY1N0cmluZyBt X2F0b21pY1N0cmluZzsKKworI2lmbmRlZiBOREVCVUcKKyAgICBXVEY6OlRocmVhZElkZW50aWZp ZXIgbV90aHJlYWRJZDsKKyNlbmRpZgogfTsKIAogU3RyaW5nIHY4U3RyaW5nVG9XZWJDb3JlU3Ry aW5nKHY4OjpIYW5kbGU8djg6OlN0cmluZz4gdjhTdHJpbmcsIEV4dGVybmFsTW9kZSBleHRlcm5h bCwK