<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27977</bug_id>
          
          <creation_ts>2009-08-04 02:08:31 -0700</creation_ts>
          <short_desc>bugzilla-tool unit tests need a test harness</short_desc>
          <delta_ts>2009-08-04 15:46:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>27991</dependson>
    
    <dependson>26916</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ddkilzer</cc>
    
    <cc>eric</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>136948</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 02:08:31 -0700</bug_when>
    <thetext>Turns out to be trivial.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136950</commentid>
    <comment_count>1</comment_count>
      <attachid>34051</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 02:09:30 -0700</bug_when>
    <thetext>Created attachment 34051
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136980</commentid>
    <comment_count>2</comment_count>
      <attachid>34051</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-08-04 07:45:18 -0700</bug_when>
    <thetext>Comment on attachment 34051
Patch v1

I think you&apos;re missing some files from this patch.  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136983</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-08-04 07:47:15 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 34051 [details])
&gt; I think you&apos;re missing some files from this patch.  :)

Specifically:

bugzilla_unittest.py
committers_unittest.py

And &quot;commiters_unittest&quot; is misspelled in run-bugzilla-tool-tests:

&gt; from modules.commiters_unittest import CommittersTest</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136992</commentid>
    <comment_count>4</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2009-08-04 08:23:53 -0700</bug_when>
    <thetext>How about making it all just a bugzilla-tool command (e.g bugzilla-tool self-test) or naming it bugzilla-tool-tests so that it will sort right next to bugzilla-tool.

I learned about several tools by going through the files in this directory.

Note that you can put imports inside of a block, if you&apos;re concerned about globally importing the unit test items.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136997</commentid>
    <comment_count>5</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-04 08:40:27 -0700</bug_when>
    <thetext>Agreed, this is probably easiest done as a bugzilla-tool command.  Unless we&apos;re going to make it run all the unit tests in modules.

Also, I need to fix commiters_unittest, I realized shortly after I committed it that I misspelled the file name. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137028</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 09:42:20 -0700</bug_when>
    <thetext>I&apos;m confused about what I should do to move forward with this patch.  The &quot;missing files&quot; are already in the repo.  The misspelling is already there too.  I guess I could rename the file in the same patch.  Do we want to make this a bugzillatool command?  I was thinking we&apos;d want to integrate the testing with the buildbot and I&apos;m not sure how to make that easiest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137032</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-04 09:50:58 -0700</bug_when>
    <thetext>Ignore the mispelling and dave&apos;s confusion about the missing files.

I think this should be either made into a general &quot;run all the unit tests we have&quot; command, or a self-test command on bugzilla.  Either way is fine with me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137043</commentid>
    <comment_count>8</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 10:16:22 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; I think this should be either made into a general &quot;run all the unit tests we
&gt; have&quot; command, or a self-test command on bugzilla.  Either way is fine with me.

Running all the unit tests seems more future-proof to me.  I&apos;ll update the patch in a bit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137046</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-08-04 10:20:51 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Ignore the mispelling and dave&apos;s confusion about the missing files.

Sorry, I was looking at an outdated repository.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137139</commentid>
    <comment_count>10</comment_count>
      <attachid>34089</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 14:52:32 -0700</bug_when>
    <thetext>Created attachment 34089
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137141</commentid>
    <comment_count>11</comment_count>
      <attachid>34090</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 15:00:26 -0700</bug_when>
    <thetext>Created attachment 34090
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137142</commentid>
    <comment_count>12</comment_count>
      <attachid>34091</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 15:02:04 -0700</bug_when>
    <thetext>Created attachment 34091
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137144</commentid>
    <comment_count>13</comment_count>
      <attachid>34091</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-04 15:05:49 -0700</bug_when>
    <thetext>Comment on attachment 34091
Patch v1

LGTM.  I wonder if people will complain about run-w being stolen for tab-complete by this script. ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137145</commentid>
    <comment_count>14</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 15:07:21 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (From update of attachment 34091 [details])
&gt; LGTM.  I wonder if people will complain about run-w being stolen for
&gt; tab-complete by this script. ;)

abarth@dhcp-45-156:~/svn/webkit4$ ./WebKitTools/Scripts/run-webkit-
run-webkit-app          run-webkit-nightly.cmd  run-webkit-unittests    
run-webkit-httpd        run-webkit-tests        

It doesn&apos;t add any tab-complete problems.  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137159</commentid>
    <comment_count>15</comment_count>
      <attachid>34091</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 15:46:34 -0700</bug_when>
    <thetext>Comment on attachment 34091
Patch v1

Clearing review flag on attachment: 34091

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	A	WebKitTools/Scripts/run-webkit-unittests
Committed r46781
	M	WebKit/wx/WebKitSupport/InspectorClientWx.cpp
	M	WebKit/wx/WebKitSupport/InspectorClientWx.h
	M	WebKit/wx/ChangeLog
r46780 = dc5b52be13b15b6b4e3e9773f1780412f01881f2 (trunk)
	M	WebKitTools/ChangeLog
	A	WebKitTools/Scripts/run-webkit-unittests
r46781 = 2282d863ec463529cb2b4182d652cb02ba484a38 (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46781</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137160</commentid>
    <comment_count>16</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 15:46:39 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34051</attachid>
            <date>2009-08-04 02:09:30 -0700</date>
            <delta_ts>2009-08-04 14:52:23 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-27977-20090804020928.patch</filename>
            <type>text/plain</type>
            <size>2474</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA0NzE2NzM1Li5mOWJhZDg4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDgt
MDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBidWd6aWxsYS10b29sIHVuaXQgdGVzdHMgbmVl
ZCBhIHRlc3QgaGFybmVzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9Mjc5NzcKKworICAgICAgICAqIFNjcmlwdHMvcnVuLWJ1Z3ppbGxhLXRvb2wtdGVz
dHM6IEFkZGVkLgorCiAyMDA5LTA4LTA0ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v
bHMvU2NyaXB0cy9ydW4tYnVnemlsbGEtdG9vbC10ZXN0cyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv
cnVuLWJ1Z3ppbGxhLXRvb2wtdGVzdHMKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAw
MC4uNDM1YjQxNQotLS0gL2Rldi9udWxsCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLWJ1
Z3ppbGxhLXRvb2wtdGVzdHMKQEAgLTAsMCArMSwzNiBAQAorIyEvdXNyL2Jpbi9weXRob24KKyMg
Q29weXJpZ2h0IChjKSAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisj
IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg
b3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0
aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMgCisjICAgICAqIFJlZGlzdHJp
YnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Cisj
IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh
aW1lci4KKyMgICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9k
dWNlIHRoZSBhYm92ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9u
cyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisjIGluIHRoZSBkb2N1bWVudGF0aW9uIGFu
ZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyMgZGlzdHJpYnV0aW9uLgor
IyAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2Yg
aXRzCisjIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJv
ZHVjdHMgZGVyaXZlZCBmcm9tCisjIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlv
ciB3cml0dGVuIHBlcm1pc3Npb24uCisjIAorIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZ
IFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFO
WSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJ
TUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBG
SVRORVNTIEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8g
RVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElB
QkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhF
TVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBM
SU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBM
T1NTIE9GIFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9O
KSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRI
RVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBO
RUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF
CisjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg
T0YgU1VDSCBEQU1BR0UuCisKK2ltcG9ydCB1bml0dGVzdAorCitmcm9tIG1vZHVsZXMuYnVnemls
bGFfdW5pdHRlc3QgaW1wb3J0IEJ1Z3ppbGxhVGVzdAorZnJvbSBtb2R1bGVzLmNvbW1pdGVyc191
bml0dGVzdCBpbXBvcnQgQ29tbWl0dGVyc1Rlc3QKKworaWYgX19uYW1lX18gPT0gIl9fbWFpbl9f
IjoKKyAgICB1bml0dGVzdC5tYWluKCk=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34089</attachid>
            <date>2009-08-04 14:52:32 -0700</date>
            <delta_ts>2009-08-04 15:00:15 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-27977-20090804145232.patch</filename>
            <type>text/plain</type>
            <size>2927</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ2Nzc2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDgtMDQgIEFkYW0gQmFydGggIDxhYmFy
dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBidWd6aWxsYS10b29sIHVuaXQgdGVzdHMgbmVlZCBhIHRlc3QgaGFybmVzcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5NzcKKworICAg
ICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC11bml0dGVzdHM6IEFkZGVkLgorCiAyMDA5LTA4LTA0
ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQg
YnkgR2F2aW4gIkdhdnZ5IiBCYXJyYWNsb3VnaC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMv
cnVuLXdlYmtpdC11bml0dGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9y
dW4td2Via2l0LXVuaXR0ZXN0cwkocmV2aXNpb24gMCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMv
cnVuLXdlYmtpdC11bml0dGVzdHMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDEgQEAKKyMhL3Vz
ci9iaW4vcHl0aG9uCisjIENvcHlyaWdodCAoYykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRz
IHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu
YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk
IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjIAor
IyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi
b3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg
Zm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkg
Zm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBs
aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBpbiB0aGUg
ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisj
IGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBu
b3IgdGhlIG5hbWVzIG9mIGl0cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3Jz
ZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNvZnR3YXJlIHdpdGhv
dXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorIyAKKyMgVEhJUyBTT0ZUV0FS
RSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUwor
IyAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO
RywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNI
QU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyMgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJ
U0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09O
VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws
CisjIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJ
TkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09E
UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisjIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lO
RVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0Yg
TElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU
CisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB
WSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg
VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitpbXBvcnQgdW5pdHRlc3QKKworZnJv
bSBtb2R1bGVzLmJ1Z3ppbGxhX3VuaXR0ZXN0IGltcG9ydCBCdWd6aWxsYVRlc3QKK2Zyb20gbW9k
dWxlcy5jb21taXRlcnNfdW5pdHRlc3QgaW1wb3J0IENvbW1pdHRlcnNUZXN0Citmcm9tIG1vZHVs
ZXMuY3BwX3N0eWxlX3VuaXR0ZXN0IGltcG9ydCBDcHBTdHlsZVRlc3QsIENsZWFuc2VkTGluZXNU
ZXN0LCBPcmRlck9mSW5jbHVkZXNUZXN0LCBDaGVja0ZvckZ1bmN0aW9uTGVuZ3Roc1Rlc3QsIE5v
Tm9uVmlydHVhbERlc3RydWN0b3JzVGVzdCwgQ3BwU3R5bGVTdGF0ZVRlc3QsIFdlYktpdFN0eWxl
VGVzdAorZnJvbSBtb2R1bGVzLmRpZmZfcGFyc2VyX3VuaXR0ZXN0IGltcG9ydCBEaWZmUGFyc2Vy
VGVzdAorCisjIEZJWE1FOiBUaGlzIHRlc3QgZG9lc24ndCB3aXRoIG9sZCB2ZXJzaW9ucyBvZiBT
Vk4uICBSZS1lbmFibGVkIHdoZW4gaXQgd29ya3MuCisjIGZyb20gbW9kdWxlcy5zY21fdW5pdHRl
c3QgaW1wb3J0IFNWTlRlc3QsIEdpdFRlc3QKKworaWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoK
KyAgICB1bml0dGVzdC5tYWluKCk=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34090</attachid>
            <date>2009-08-04 15:00:26 -0700</date>
            <delta_ts>2009-08-04 15:01:59 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-27977-20090804150025.patch</filename>
            <type>text/plain</type>
            <size>2842</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ2Nzc2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDgtMDQgIEFkYW0gQmFydGggIDxhYmFy
dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBidWd6aWxsYS10b29sIHVuaXQgdGVzdHMgbmVlZCBhIHRlc3QgaGFybmVzcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5NzcKKworICAg
ICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC11bml0dGVzdHM6IEFkZGVkLgorCiAyMDA5LTA4LTA0
ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQg
YnkgR2F2aW4gIkdhdnZ5IiBCYXJyYWNsb3VnaC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMv
cnVuLXdlYmtpdC11bml0dGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9y
dW4td2Via2l0LXVuaXR0ZXN0cwkocmV2aXNpb24gMCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMv
cnVuLXdlYmtpdC11bml0dGVzdHMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzkgQEAKKyMhL3Vz
ci9iaW4vcHl0aG9uCisjIENvcHlyaWdodCAoYykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRz
IHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu
YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk
IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjIAor
IyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi
b3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg
Zm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkg
Zm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBs
aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBpbiB0aGUg
ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisj
IGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBu
b3IgdGhlIG5hbWVzIG9mIGl0cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3Jz
ZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNvZnR3YXJlIHdpdGhv
dXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorIyAKKyMgVEhJUyBTT0ZUV0FS
RSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUwor
IyAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO
RywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNI
QU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyMgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJ
U0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09O
VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws
CisjIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJ
TkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09E
UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisjIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lO
RVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0Yg
TElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU
CisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB
WSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg
VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitpbXBvcnQgdW5pdHRlc3QKKworZnJv
bSBtb2R1bGVzLmJ1Z3ppbGxhX3VuaXR0ZXN0IGltcG9ydCBCdWd6aWxsYVRlc3QKK2Zyb20gbW9k
dWxlcy5jb21taXRlcnNfdW5pdHRlc3QgaW1wb3J0IENvbW1pdHRlcnNUZXN0Citmcm9tIG1vZHVs
ZXMuY3BwX3N0eWxlX3VuaXR0ZXN0IGltcG9ydCBDcHBTdHlsZVRlc3QsIENsZWFuc2VkTGluZXNU
ZXN0LCBPcmRlck9mSW5jbHVkZXNUZXN0LCBDaGVja0ZvckZ1bmN0aW9uTGVuZ3Roc1Rlc3QsIE5v
Tm9uVmlydHVhbERlc3RydWN0b3JzVGVzdCwgQ3BwU3R5bGVTdGF0ZVRlc3QsIFdlYktpdFN0eWxl
VGVzdAorZnJvbSBtb2R1bGVzLmRpZmZfcGFyc2VyX3VuaXR0ZXN0IGltcG9ydCBEaWZmUGFyc2Vy
VGVzdAorZnJvbSBtb2R1bGVzLnNjbV91bml0dGVzdCBpbXBvcnQgU1ZOVGVzdCwgR2l0VGVzdAor
CitpZiBfX25hbWVfXyA9PSAiX19tYWluX18iOgorICAgIHVuaXR0ZXN0Lm1haW4oKQ==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34091</attachid>
            <date>2009-08-04 15:02:04 -0700</date>
            <delta_ts>2009-08-04 15:46:34 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-27977-20090804150204.patch</filename>
            <type>text/plain</type>
            <size>2645</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ2Nzc2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDgtMDQgIEFkYW0gQmFydGggIDxhYmFy
dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBidWd6aWxsYS10b29sIHVuaXQgdGVzdHMgbmVlZCBhIHRlc3QgaGFybmVzcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5NzcKKworICAg
ICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC11bml0dGVzdHM6IEFkZGVkLgorCiAyMDA5LTA4LTA0
ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQg
YnkgR2F2aW4gIkdhdnZ5IiBCYXJyYWNsb3VnaC4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMv
cnVuLXdlYmtpdC11bml0dGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9y
dW4td2Via2l0LXVuaXR0ZXN0cwkocmV2aXNpb24gMCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMv
cnVuLXdlYmtpdC11bml0dGVzdHMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzkgQEAKKyMhL3Vz
ci9iaW4vcHl0aG9uCisjIENvcHlyaWdodCAoYykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRz
IHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu
YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk
IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6CisjIAor
IyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi
b3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg
Zm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkg
Zm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBs
aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBpbiB0aGUg
ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisj
IGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBu
b3IgdGhlIG5hbWVzIG9mIGl0cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3Jz
ZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNvZnR3YXJlIHdpdGhv
dXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorIyAKKyMgVEhJUyBTT0ZUV0FS
RSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUwor
IyAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO
RywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNI
QU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyMgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJ
U0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09O
VFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUws
CisjIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJ
TkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09E
UyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisjIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lO
RVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0Yg
TElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JU
CisjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB
WSBPVVQgT0YgVEhFIFVTRQorIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0Yg
VEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitpbXBvcnQgdW5pdHRlc3QKKworZnJv
bSBtb2R1bGVzLmJ1Z3ppbGxhX3VuaXR0ZXN0IGltcG9ydCAqCitmcm9tIG1vZHVsZXMuY29tbWl0
ZXJzX3VuaXR0ZXN0IGltcG9ydCAqCitmcm9tIG1vZHVsZXMuY3BwX3N0eWxlX3VuaXR0ZXN0IGlt
cG9ydCAqCitmcm9tIG1vZHVsZXMuZGlmZl9wYXJzZXJfdW5pdHRlc3QgaW1wb3J0ICoKK2Zyb20g
bW9kdWxlcy5zY21fdW5pdHRlc3QgaW1wb3J0ICoKKworaWYgX19uYW1lX18gPT0gIl9fbWFpbl9f
IjoKKyAgICB1bml0dGVzdC5tYWluKCk=
</data>
<flag name="commit-queue"
          id="18259"
          type_id="3"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>