27975 2009-08-04 01:51:10 -0700 [v8] Fix crash in collection-null-like-arguments 2009-08-04 02:29:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 christian.plesner.hansen webkit-unassigned abarth levin oldest_to_newest 136939 0 christian.plesner.hansen 2009-08-04 01:51:10 -0700 Fix issue where atomic string conversion will crash if given the empty string. 136944 1 34049 christian.plesner.hansen 2009-08-04 01:59:49 -0700 Created attachment 34049 Initial 136945 2 34049 abarth 2009-08-04 02:01:01 -0700 Comment on attachment 34049 Initial ChangeLog? LayoutTest? 136947 3 christian.plesner.hansen 2009-08-04 02:03:48 -0700 Good point, sorry... 136949 4 34050 christian.plesner.hansen 2009-08-04 02:08:42 -0700 Created attachment 34050 Added ChangeLog 136951 5 34050 abarth 2009-08-04 02:12:14 -0700 Comment on attachment 34050 Added ChangeLog Thanks! 136954 6 34050 abarth 2009-08-04 02:29:08 -0700 Comment on attachment 34050 Added ChangeLog Clearing review flag on attachment: 34050 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/V8Binding.cpp Committed r46756 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla_unittest.py M WebKitTools/Scripts/modules/bugzilla.py r46755 = b917198eebcb893beceb9ea46db5aebffa61305f (trunk) M WebCore/ChangeLog M WebCore/bindings/v8/V8Binding.cpp r46756 = a965b2f2f1a669e8644387516dcde8ea650d6111 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46756 136955 7 abarth 2009-08-04 02:29:12 -0700 All reviewed patches have been landed. Closing bug. 34049 2009-08-04 01:59:49 -0700 2009-08-04 02:08:36 -0700 Initial bug-27975-20090804105947.patch text/plain 971 christian.plesner.hansen SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAJKHJldmlzaW9uIDQ2NzUyKQorKysgV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDMsOCAr MTQzLDEzIEBAIEF0b21pY1N0cmluZyB2OFN0cmluZ1RvQXRvbWljV2ViQ29yZVN0cmkKICAgICBX ZWJDb3JlU3RyaW5nUmVzb3VyY2UqIHN0cmluZ1Jlc291cmNlID0gV2ViQ29yZVN0cmluZ1Jlc291 cmNlOjp0b1N0cmluZ1Jlc291cmNlKHY4U3RyaW5nKTsKICAgICBpZiAoIXN0cmluZ1Jlc291cmNl KSB7CiAgICAgICAgIC8vIElmIHRoaXMgc3RyaW5nIGhhc24ndCBiZWVuIGV4dGVybmFsaXplZCwg d2UgZm9yY2UgaXQgbm93LgotICAgICAgICB2OFN0cmluZ1RvV2ViQ29yZVN0cmluZyh2OFN0cmlu ZywgRXh0ZXJuYWxpemUsIEF0b21pY1N0cmluZ1R5cGUpOworICAgICAgICBTdHJpbmcgcGxhaW4g PSB2OFN0cmluZ1RvV2ViQ29yZVN0cmluZyh2OFN0cmluZywgRXh0ZXJuYWxpemUsIEF0b21pY1N0 cmluZ1R5cGUpOworICAgICAgICAvLyBJZiB0aGUgc3RyaW5nIGlzIGVtcHR5IHRoZXJlJ3Mgbm8g cm9vbSB0byBjYWNoZSBhbiBhdG9taWMKKyAgICAgICAgLy8gc3RyaW5nIHNvIHdlIGJhaWwgb3V0 LgorICAgICAgICBpZiAocGxhaW4uaXNFbXB0eSgpKQorICAgICAgICAgICAgcmV0dXJuIHBsYWlu OwogICAgICAgICBzdHJpbmdSZXNvdXJjZSA9IFdlYkNvcmVTdHJpbmdSZXNvdXJjZTo6dG9TdHJp bmdSZXNvdXJjZSh2OFN0cmluZyk7CisgICAgICAgIEFTU0VSVChzdHJpbmdSZXNvdXJjZSAhPSBO VUxMKTsKICAgICB9CiAgICAgcmV0dXJuIHN0cmluZ1Jlc291cmNlLT5hdG9taWNTdHJpbmcoKTsK IH0= 34050 2009-08-04 02:08:42 -0700 2009-08-04 02:29:08 -0700 Added ChangeLog bug-27975-20090804110841.patch text/plain 1648 christian.plesner.hansen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Njc1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMDQgIENocmlzdGlhbiBQbGVzbmVyIEhhbnNlbiAgPGNo cmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBGaXggY3Jhc2ggd2hlbiBjb252ZXJ0aW5n IGVtcHR5IHY4IHN0cmluZyB0byBhdG9taWMgd2Via2l0IHN0cmluZy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3OTc1CisKKyAgICAgICAgY29sbGVj dGlvbi1udWxsLWxpa2UtYXJndW1lbnRzLmh0bWwgdGVzdHMgZm9yIHRoaXMuCisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6djhTdHJpbmdU b0F0b21pY1dlYkNvcmVTdHJpbmcpOgorCiAyMDA5LTA4LTA0ICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDog V2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv YmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAkocmV2aXNpb24gNDY3NTIpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0Myw4ICsxNDMsMTMg QEAgQXRvbWljU3RyaW5nIHY4U3RyaW5nVG9BdG9taWNXZWJDb3JlU3RyaQogICAgIFdlYkNvcmVT dHJpbmdSZXNvdXJjZSogc3RyaW5nUmVzb3VyY2UgPSBXZWJDb3JlU3RyaW5nUmVzb3VyY2U6OnRv U3RyaW5nUmVzb3VyY2UodjhTdHJpbmcpOwogICAgIGlmICghc3RyaW5nUmVzb3VyY2UpIHsKICAg ICAgICAgLy8gSWYgdGhpcyBzdHJpbmcgaGFzbid0IGJlZW4gZXh0ZXJuYWxpemVkLCB3ZSBmb3Jj ZSBpdCBub3cuCi0gICAgICAgIHY4U3RyaW5nVG9XZWJDb3JlU3RyaW5nKHY4U3RyaW5nLCBFeHRl cm5hbGl6ZSwgQXRvbWljU3RyaW5nVHlwZSk7CisgICAgICAgIFN0cmluZyBwbGFpbiA9IHY4U3Ry aW5nVG9XZWJDb3JlU3RyaW5nKHY4U3RyaW5nLCBFeHRlcm5hbGl6ZSwgQXRvbWljU3RyaW5nVHlw ZSk7CisgICAgICAgIC8vIElmIHRoZSBzdHJpbmcgaXMgZW1wdHkgdGhlcmUncyBubyByb29tIHRv IGNhY2hlIGFuIGF0b21pYworICAgICAgICAvLyBzdHJpbmcgc28gd2UgYmFpbCBvdXQuCisgICAg ICAgIGlmIChwbGFpbi5pc0VtcHR5KCkpCisgICAgICAgICAgICByZXR1cm4gcGxhaW47CiAgICAg ICAgIHN0cmluZ1Jlc291cmNlID0gV2ViQ29yZVN0cmluZ1Jlc291cmNlOjp0b1N0cmluZ1Jlc291 cmNlKHY4U3RyaW5nKTsKKyAgICAgICAgQVNTRVJUKHN0cmluZ1Jlc291cmNlICE9IE5VTEwpOwog ICAgIH0KICAgICByZXR1cm4gc3RyaW5nUmVzb3VyY2UtPmF0b21pY1N0cmluZygpOwogfQ==