27973 2009-08-04 01:29:29 -0700 REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs 2009-08-04 08:43:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth ddkilzer levin vestbo oldest_to_newest 136933 0 eric 2009-08-04 01:29:29 -0700 REGRESSION: bugzilla-tool land-diff double-spaces ChangeLogs An example of the badness: http://trac.webkit.org/changeset/46750 I have no clue what broke this. It must have been very recent, since I use land-diff to land all my changes... 136934 1 eric 2009-08-04 01:31:27 -0700 I wonder if it could be this change: http://trac.webkit.org/changeset/46700/trunk/WebKitTools/Scripts/bugzilla-tool I kinda doubt it though. 136936 2 eric 2009-08-04 01:43:01 -0700 It seems to be in the reviewer update code (not un-expected): bugzilla-tool --dry-run land-diff --no-build --reviewer="Bozo" reproduces the bug. 136938 3 eric 2009-08-04 01:49:54 -0700 Ha! http://trac.webkit.org/changeset/46700/trunk/WebKitTools/Scripts/bugzilla-tool is the regression! Can you find it? ;) 136940 4 34047 eric 2009-08-04 01:52:13 -0700 Created attachment 34047 Patch v1 136941 5 34047 abarth 2009-08-04 01:56:23 -0700 Comment on attachment 34047 Patch v1 Yay. Now if only we had better unit testing... 136943 6 eric 2009-08-04 01:59:38 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r46754 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r46754 = 3d81d05269c879e0aac096ceee849d47735726dd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46754 136979 7 34047 ddkilzer 2009-08-04 07:42:39 -0700 Comment on attachment 34047 Patch v1 >+ The trailing comma (suppresses newlines) was lost in r46700. Heh...I thought the trailing comma was a typo. That's one of the weirdest language behaviors I've ever seen. 136999 8 eric 2009-08-04 08:43:41 -0700 The comma is the tuple operator in python. So I assume print detects this by detecting if it's passed a list/tuple instead of a string. http://mail.python.org/pipermail/python-list/2005-July/332230.html talks more about this strange behavior. 34047 2009-08-04 01:52:13 -0700 2009-08-04 07:42:39 -0700 Patch v1 bug-27973-20090804015211.patch text/plain 1290 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmNTg3NmE4Li4xZDg0ZGNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMDktMDgt MDQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjQ2NzAwKTogYnVnemlsbGEt dG9vbCBsYW5kLWRpZmYgZG91YmxlLXNwYWNlcyBDaGFuZ2VMb2dzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzk3MworCisgICAgICAgIFRoZSB0cmFp bGluZyBjb21tYSAoc3VwcHJlc3NlcyBuZXdsaW5lcykgd2FzIGxvc3QgaW4gcjQ2NzAwLgorCisg ICAgICAgICogU2NyaXB0cy9idWd6aWxsYS10b29sOgorCisyMDA5LTA4LTA0ICBFcmljIFNlaWRl bCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBObyByZXZpZXcsIENoYW5nZUxvZyBmaXgg b25seS4KIAogICAgICAgICBGaXggYSBDaGFuZ2VMb2cgbGluZS1zcGFjaW5nIGRpc2FzdGVyIGNh dXNlZCBieToKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBi L1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAppbmRleCAxZjczMjI0Li5jNzlmOGUx IDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCkBAIC04Niw3ICs4Niw3IEBAIGRlZiBsYXRl c3RfY2hhbmdlbG9nX2VudHJ5KGNoYW5nZWxvZ19wYXRoKToKIGRlZiBzZXRfcmV2aWV3ZXJfaW5f Y2hhbmdlbG9nKGNoYW5nZWxvZ19wYXRoLCByZXZpZXdlcik6CiAgICAgIyBpbnBsYWNlPTEgY3Jl YXRlcyBhIGJhY2t1cCBmaWxlIGFuZCByZS1kaXJlY3RzIHN0ZG91dCB0byB0aGUgZmlsZQogICAg IGZvciBsaW5lIGluIGZpbGVpbnB1dC5GaWxlSW5wdXQoY2hhbmdlbG9nX3BhdGgsIGlucGxhY2U9 MSk6Ci0gICAgICAgIHByaW50IGxpbmUucmVwbGFjZSgiTk9CT0RZIChPT1BTISkiLCByZXZpZXdl ci5lbmNvZGUoInV0Zi04IikpCisgICAgICAgIHByaW50IGxpbmUucmVwbGFjZSgiTk9CT0RZIChP T1BTISkiLCByZXZpZXdlci5lbmNvZGUoInV0Zi04IikpLAogCiBkZWYgbW9kaWZpZWRfY2hhbmdl bG9ncyhzY20pOgogICAgIGNoYW5nZWxvZ19wYXRocyA9IFtd