27969 2009-08-03 23:30:10 -0700 bugzilla-tool has too many fatal errors 2009-08-04 02:21:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 136905 0 abarth 2009-08-03 23:30:10 -0700 A bunch of the calls to error should raise a ScriptError instead so the commit-queue can continue chugging along. 136907 1 34038 abarth 2009-08-03 23:35:48 -0700 Created attachment 34038 Patch v1 136919 2 34038 eric 2009-08-04 00:25:31 -0700 Comment on attachment 34038 Patch v1 Looks fine. We might eventually go back to an error() method which just does the raise for us. I don't really like logging.py 136921 3 34038 eric 2009-08-04 00:28:53 -0700 Comment on attachment 34038 Patch v1 At least one of these changes is unit_testable w/o setting up a git repository. :) I plan to work up a git/svn testing setup soon to make scm.py changes more testable. Eventually I'll work up a local bugzilla setup too. 136952 4 abarth 2009-08-04 02:21:40 -0700 http://trac.webkit.org/changeset/46753 34038 2009-08-03 23:35:48 -0700 2009-08-04 00:28:53 -0700 Patch v1 bug-27969-20090803233547.patch text/plain 4014 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYjg1N2IyLi4zYmVhOTI2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBidWd6aWxsYS10b29sIGhh cyB0b28gbWFueSBmYXRhbCBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3OTY5CisKKyAgICAgICAgUmVwbGFjZSBzZXZlcmFsIGZhdGFsIGVy cm9ycyB3aXRoIFNjcmlwdEVycm9yIGV4Y2VwdGlvbnMuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1 Z3ppbGxhLXRvb2w6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5OgorICAg ICAgICAqIFNjcmlwdHMvbW9kdWxlcy9zY20ucHk6CisKKzIwMDktMDgtMDMgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKwogICAgICAgICBjb21taXQtcXVldWUgbW9kZSBmb3IgYnVnemlsbGEtdG9vbAogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5MTgKIApkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9idWd6aWxsYS10b29sCmluZGV4IDQ5OGE4MDcuLjI3ZTJlYWYgMTAwNzU1Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAorKysgYi9XZWJLaXRUb29scy9TY3JpcHRz L2J1Z3ppbGxhLXRvb2wKQEAgLTk5LDkgKzk5LDkgQEAgZGVmIG1vZGlmaWVkX2NoYW5nZWxvZ3Mo c2NtKToKIGRlZiBjb21taXRfbWVzc2FnZV9mb3JfdGhpc19jb21taXQoc2NtKToKICAgICBjaGFu Z2Vsb2dfcGF0aHMgPSBtb2RpZmllZF9jaGFuZ2Vsb2dzKHNjbSkKICAgICBpZiBub3QgbGVuKGNo YW5nZWxvZ19wYXRocyk6Ci0gICAgICAgIGVycm9yKCJGb3VuZCBubyBtb2RpZmllZCBDaGFuZ2VM b2dzLCBjYW5ub3QgY3JlYXRlIGEgY29tbWl0IG1lc3NhZ2UuXG4iCi0gICAgICAgICAgICAgICJB bGwgY2hhbmdlcyByZXF1aXJlIGEgQ2hhbmdlTG9nLiAgU2VlOlxuIgotICAgICAgICAgICAgICAi aHR0cDovL3dlYmtpdC5vcmcvY29kaW5nL2NvbnRyaWJ1dGluZy5odG1sIikKKyAgICAgICAgcmFp c2UgU2NyaXB0RXJyb3IoIkZvdW5kIG5vIG1vZGlmaWVkIENoYW5nZUxvZ3MsIGNhbm5vdCBjcmVh dGUgYSBjb21taXQgbWVzc2FnZS5cbiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIkFsbCBj aGFuZ2VzIHJlcXVpcmUgYSBDaGFuZ2VMb2cuICBTZWU6XG4iCisgICAgICAgICAgICAgICAgICAg ICAgICAgICJodHRwOi8vd2Via2l0Lm9yZy9jb2RpbmcvY29udHJpYnV0aW5nLmh0bWwiKQogCiAg ICAgY2hhbmdlbG9nX21lc3NhZ2VzID0gW10KICAgICBmb3IgcGF0aCBpbiBjaGFuZ2Vsb2dfcGF0 aHM6CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkg Yi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKaW5kZXggZDU2N2VhNi4u MGJiNzMwMiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxh LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQpAQCAtMjgz LDcgKzI4Myw3IEBAIGNsYXNzIEJ1Z3ppbGxhOgogICAgICAgICAjIElmIHRoZSByZXN1bHRpbmcg cGFnZSBoYXMgYSB0aXRsZSwgYW5kIGl0IGNvbnRhaW5zIHRoZSB3b3JkICJpbnZhbGlkIiBhc3N1 bWUgaXQncyB0aGUgbG9naW4gZmFpbHVyZSBwYWdlLgogICAgICAgICBpZiBtYXRjaCBhbmQgcmUu c2VhcmNoKCJJbnZhbGlkIiwgbWF0Y2guZ3JvdXAoMSksIHJlLklHTk9SRUNBU0UpOgogICAgICAg ICAgICAgIyBGSVhNRTogV2UgY291bGQgYWRkIHRoZSBhYmlsaXR5IHRvIHRyeSBhZ2FpbiBvbiBm YWlsdXJlLgotICAgICAgICAgICAgZXJyb3IoIkJ1Z3ppbGxhIGxvZ2luIGZhaWxlZDogJXMiICUg bWF0Y2guZ3JvdXAoMSkpCisgICAgICAgICAgICByYWlzZSBTY3JpcHRFcnJvcigiQnVnemlsbGEg bG9naW4gZmFpbGVkOiAlcyIgJSBtYXRjaC5ncm91cCgxKSkKIAogICAgICAgICBzZWxmLmF1dGhl bnRpY2F0ZWQgPSBUcnVlCiAKQEAgLTMyNSw3ICszMjUsNyBAQCBjbGFzcyBCdWd6aWxsYToKICAg ICAgICAgaWYgbWF0Y2g6CiAgICAgICAgICAgICB0ZXh0X2xpbmVzID0gQmVhdXRpZnVsU291cCht YXRjaC5ncm91cCgnZXJyb3JfbWVzc2FnZScpKS5maW5kQWxsKHRleHQ9VHJ1ZSkKICAgICAgICAg ICAgIGVycm9yX21lc3NhZ2UgPSAiXG4iICsgJ1xuJy5qb2luKFsiICAiICsgbGluZS5zdHJpcCgp IGZvciBsaW5lIGluIHRleHRfbGluZXMgaWYgbGluZS5zdHJpcCgpXSkKLSAgICAgICAgZXJyb3Io IkJ1ZyBub3QgY3JlYXRlZDogJXMiICUgZXJyb3JfbWVzc2FnZSkKKyAgICAgICAgcmFpc2UgU2Ny aXB0RXJyb3IoIkJ1ZyBub3QgY3JlYXRlZDogJXMiICUgZXJyb3JfbWVzc2FnZSkKIAogICAgIGRl ZiBjcmVhdGVfYnVnX3dpdGhfcGF0Y2goc2VsZiwgYnVnX3RpdGxlLCBidWdfZGVzY3JpcHRpb24s IGNvbXBvbmVudCwgcGF0Y2hfZmlsZV9vYmplY3QsIHBhdGNoX2Rlc2NyaXB0aW9uLCBjYywgbWFy a19mb3JfcmV2aWV3PUZhbHNlKToKICAgICAgICAgc2VsZi5hdXRoZW50aWNhdGUoKQpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9zY20ucHkKaW5kZXggYzY3N2JjYS4uNzA3ZGI0NyAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvc2NtLnB5CkBAIC0xMTYsNyArMTE2LDcgQEAgY2xhc3MgU0NNOgogICAgIGRl ZiBlbnN1cmVfY2xlYW5fd29ya2luZ19kaXJlY3Rvcnkoc2VsZiwgZm9yY2UpOgogICAgICAgICBp ZiBub3QgZm9yY2UgYW5kIG5vdCBzZWxmLndvcmtpbmdfZGlyZWN0b3J5X2lzX2NsZWFuKCk6CiAg ICAgICAgICAgICBwcmludCBzZWxmLnJ1bl9jb21tYW5kKHNlbGYuc3RhdHVzX2NvbW1hbmQoKSwg cmFpc2Vfb25fZmFpbHVyZT1GYWxzZSkKLSAgICAgICAgICAgIGVycm9yKCJXb3JraW5nIGRpcmVj dG9yeSBoYXMgbW9kaWZpY2F0aW9ucywgcGFzcyAtLWZvcmNlLWNsZWFuIG9yIC0tbm8tY2xlYW4g dG8gY29udGludWUuIikKKyAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKCJXb3JraW5nIGRp cmVjdG9yeSBoYXMgbW9kaWZpY2F0aW9ucywgcGFzcyAtLWZvcmNlLWNsZWFuIG9yIC0tbm8tY2xl YW4gdG8gY29udGludWUuIikKICAgICAgICAgCiAgICAgICAgIGxvZygiQ2xlYW5pbmcgd29ya2lu ZyBkaXJlY3RvcnkiKQogICAgICAgICBzZWxmLmNsZWFuX3dvcmtpbmdfZGlyZWN0b3J5KCkKQEAg LTM4Myw3ICszODMsNyBAQCBjbGFzcyBHaXQoU0NNKToKICAgICAgICAgY29tbWl0X2lkcyA9IFtd CiAgICAgICAgIGZvciBjb21taXRpc2ggaW4gYXJnczoKICAgICAgICAgICAgIGlmICcuLi4nIGlu IGNvbW1pdGlzaDoKLSAgICAgICAgICAgICAgICBlcnJvcigiJy4uLicgaXMgbm90IHN1cHBvcnRl ZCAoZm91bmQgaW4gJyVzJykuIERpZCB5b3UgbWVhbiAnLi4nPyIgJSBjb21taXRpc2gpCisgICAg ICAgICAgICAgICAgcmFpc2UgU2NyaXB0RXJyb3IoIicuLi4nIGlzIG5vdCBzdXBwb3J0ZWQgKGZv dW5kIGluICclcycpLiBEaWQgeW91IG1lYW4gJy4uJz8iICUgY29tbWl0aXNoKQogICAgICAgICAg ICAgZWxpZiAnLi4nIGluIGNvbW1pdGlzaDoKICAgICAgICAgICAgICAgICBjb21taXRfaWRzICs9 IHNlbGYucnVuX2NvbW1hbmQoWydnaXQnLCAncmV2LWxpc3QnLCBjb21taXRpc2hdKS5zcGxpdGxp bmVzKCkKICAgICAgICAgICAgIGVsc2U6