279660 2024-09-13 02:19:45 -0700 REGRESSION(283334@main): [GLIB] Script for updating third-party libs does not work anymore for flatpak 2024-09-13 08:27:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=279261 InRadar P2 Normal --- 1 clopez clopez webkit-bug-importer oldest_to_newest 2059943 0 clopez 2024-09-13 02:19:45 -0700 Since 283334@main the scripts update-webkitgtk-libs and update-webkitwpe-libs does not work anymore. This is because the call to the script update-webkit-flatpak is now inside now a condition shouldUseFlatpak() that is always false at the invocation of that script due to this two reasons: 1. The subroutine shouldUseFlatpak() returns false if the ports is not specified, and this two scripts are usually called without passed the flag --gtk or --wpe 2. Even if you call the script passing the port as in "update-webkitgtk-libs --gtk" shouldUseFlatpak() will only return true if the flatpak is already installed, but it will not return true on the first run (no WebKitBuild dir) and we want to default to using flatpak unless the environment tells us to do something different. 2059945 1 clopez 2024-09-13 02:28:11 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33609 2060011 2 ews-feeder 2024-09-13 08:26:25 -0700 Committed 283621@main (6ddc6a2f2f12): <https://commits.webkit.org/283621@main> Reviewed commits have been landed. Closing PR #33609 and removing active labels. 2060012 3 webkit-bug-importer 2024-09-13 08:27:15 -0700 <rdar://problem/135955438>