279581 2024-09-11 23:42:43 -0700 Remove Quirk triggerOptionalStorageAccessQuirk for domains not part of Kinja anymore 2024-09-12 15:02:25 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED http://kinja.com/ InRadar P2 Normal --- 213418 1 karlcow karlcow webkit-bug-importer oldest_to_newest 2059606 0 karlcow 2024-09-11 23:42:43 -0700 On Bug 213418 / rdar://64549429 triggerOptionalStorageAccessQuirk was added in addition to isKinjaLoginAvatarElement Quirk ``` static NeverDestroyed<HashSet<RegistrableDomain>> kinjaQuirks = [] { HashSet<RegistrableDomain> set; set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("avclub.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("deadspin.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("jalopnik.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("jezebel.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("kotaku.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("lifehacker.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("theroot.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("thetakeout.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("theonion.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("theinventory.com"_s)); return set; }(); ``` This list is then used later in: if (kinjaQuirks.get().contains(domain) && isKinjaLoginAvatarElement(element)) { … } So it becomes moot when these are not part anymore of Kinja Login system. The list of domains to remove is: * avclub.com * deadspin.com * jezebel.com * lifehacker.com * thetakeout.com * theonion.com 2059607 1 webkit-bug-importer 2024-09-11 23:42:52 -0700 <rdar://problem/135854408> 2059609 2 karlcow 2024-09-11 23:53:38 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33530 2059787 3 ews-feeder 2024-09-12 15:02:24 -0700 Committed 283581@main (17d716bf8215): <https://commits.webkit.org/283581@main> Reviewed commits have been landed. Closing PR #33530 and removing active labels.