27957 2009-08-03 15:41:31 -0700 Inspector: DOM Storage Live Updating Should Not Affect Tabbing 2009-08-03 19:22:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned abarth timothy oldest_to_newest 136807 0 joepeck 2009-08-03 15:41:31 -0700 Live Updates preempts tab-through editing. I disable and re-enable the storage events. 136811 1 34011 joepeck 2009-08-03 15:44:17 -0700 Created attachment 34011 patch 136876 2 34011 abarth 2009-08-03 17:52:14 -0700 Comment on attachment 34011 patch Going to use this bug as a guinea pig for the commit-queue. 136886 3 34011 abarth 2009-08-03 19:22:02 -0700 Comment on attachment 34011 patch Clearing review flag on attachment: 34011 Sending WebCore/ChangeLog Sending WebCore/inspector/front-end/DOMStorageDataGrid.js Sending WebCore/inspector/front-end/DatabasesPanel.js Transmitting file data ... Committed revision 46744. http://trac.webkit.org/changeset/46744 136887 4 abarth 2009-08-03 19:22:06 -0700 All reviewed patches have been landed. Closing bug. 34011 2009-08-03 15:44:17 -0700 2009-08-03 19:22:02 -0700 patch patch.patch text/plain 3085 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Zjc3YzY3OS4uMTQyYWIwYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAwOS0wOC0wMyAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVjazAyQGdtYWlsLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbnNwZWN0b3I6IERPTSBTdG9yYWdlIExpdmUgVXBkYXRpbmcg U2hvdWxkIE5vdCBBZmZlY3QgVGFiYmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5NTcKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv RE9NU3RvcmFnZURhdGFHcmlkLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VE YXRhR3JpZC5wcm90b3R5cGUuX3N0YXJ0RWRpdGluZ0NvbHVtbk9mRGF0YUdyaWROb2RlKTogZGlz YWJsZSBzdG9yYWdlIGV2ZW50IGxpc3RlbmVyCisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NU3Rv cmFnZURhdGFHcmlkLnByb3RvdHlwZS5fc3RhcnRFZGl0aW5nKTogZGlzYWJsZSBzdG9yYWdlIGV2 ZW50IGxpc3RlbmVyCisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZURhdGFHcmlkLnBy b3RvdHlwZS5fZWRpdGluZ0NhbmNlbGxlZCk6IGVuYWJsZSBzdG9yYWdlIGV2ZW50IGxpc3RlbmVy CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhYmFzZXNQYW5lbC5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5EYXRhYmFzZXNQYW5lbC5wcm90b3R5cGUuX3VucmVnaXN0ZXJTdG9y YWdlRXZlbnRMaXN0ZW5lcik6IHF1aWNrIHJldHVybiBpZiBubyBsaXN0ZW5lcgorCisyMDA5LTA4 LTAzICBKb3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrMDJAZ21haWwuY29tPgorCiAgICAgICAgIFJl dmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KIAogICAgICAgICBJbnNwZWN0b3I6IE1ha2UgQm90 dG9tICJEcmF3ZXIiIE1vcmUgRXh0ZW5zaWJsZSBUbyBTdXBwb3J0IE90aGVyIFZpZXdzCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZURhdGFHcmlkLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RPTVN0b3JhZ2VEYXRhR3JpZC5qcwppbmRl eCBkMTY2ODU3Li4wMzI2YmM3IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRE9NU3RvcmFnZURhdGFHcmlkLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9ET01TdG9yYWdlRGF0YUdyaWQuanMKQEAgLTQ0LDYgKzQ0LDcgQEAgV2ViSW5zcGVjdG9yLkRP TVN0b3JhZ2VEYXRhR3JpZC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2VkaXRpbmcgPSB0 cnVlOwogICAgICAgICB0aGlzLl9lZGl0aW5nTm9kZSA9IG5vZGU7CiAgICAgICAgIHRoaXMuX2Vk aXRpbmdOb2RlLnNlbGVjdCgpOworICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLmRhdGFiYXNl cy5fdW5yZWdpc3RlclN0b3JhZ2VFdmVudExpc3RlbmVyKCk7CiAKICAgICAgICAgdmFyIGVsZW1l bnQgPSB0aGlzLl9lZGl0aW5nTm9kZS5fZWxlbWVudC5jaGlsZHJlbltjb2x1bW5dOwogICAgICAg ICBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nKGVsZW1lbnQsIHRoaXMuX2VkaXRpbmdDb21taXR0 ZWQuYmluZCh0aGlzKSwgdGhpcy5fZWRpdGluZ0NhbmNlbGxlZC5iaW5kKHRoaXMpLCBlbGVtZW50 LnRleHRDb250ZW50KTsKQEAgLTY4LDYgKzY5LDcgQEAgV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VE YXRhR3JpZC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm4gdGhpcy5fc3RhcnRFZGl0 aW5nQ29sdW1uT2ZEYXRhR3JpZE5vZGUodGhpcy5fZWRpdGluZ05vZGUsIDApOwogCiAgICAgICAg IHRoaXMuX2VkaXRpbmcgPSB0cnVlOworICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLmRhdGFi YXNlcy5fdW5yZWdpc3RlclN0b3JhZ2VFdmVudExpc3RlbmVyKCk7CiAgICAgICAgIFdlYkluc3Bl Y3Rvci5zdGFydEVkaXRpbmcoZWxlbWVudCwgdGhpcy5fZWRpdGluZ0NvbW1pdHRlZC5iaW5kKHRo aXMpLCB0aGlzLl9lZGl0aW5nQ2FuY2VsbGVkLmJpbmQodGhpcyksIGVsZW1lbnQudGV4dENvbnRl bnQpOwogICAgICAgICB3aW5kb3cuZ2V0U2VsZWN0aW9uKCkuc2V0QmFzZUFuZEV4dGVudChlbGVt ZW50LCAwLCBlbGVtZW50LCAxKTsKICAgICB9LApAQCAtMTQ1LDYgKzE0Nyw3IEBAIFdlYkluc3Bl Y3Rvci5ET01TdG9yYWdlRGF0YUdyaWQucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgZGVs ZXRlIHRoaXMuX2VkaXRpbmc7CiAgICAgICAgIHRoaXMuX2VkaXRpbmdOb2RlID0gbnVsbDsKKyAg ICAgICAgV2ViSW5zcGVjdG9yLnBhbmVscy5kYXRhYmFzZXMuX3JlZ2lzdGVyU3RvcmFnZUV2ZW50 TGlzdGVuZXIoKTsKICAgICB9LAogCiAgICAgZGVsZXRlU2VsZWN0ZWRSb3c6IGZ1bmN0aW9uKCkK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhYmFzZXNQYW5lbC5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhYmFzZXNQYW5lbC5qcwppbmRleCA5 YmVmYzIyLi42MTg5YWU0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RGF0YWJhc2VzUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFi YXNlc1BhbmVsLmpzCkBAIC00MTMsNiArNDEzLDkgQEAgV2ViSW5zcGVjdG9yLkRhdGFiYXNlc1Bh bmVsLnByb3RvdHlwZSA9IHsKIAogICAgIF91bnJlZ2lzdGVyU3RvcmFnZUV2ZW50TGlzdGVuZXI6 IGZ1bmN0aW9uKCkKICAgICB7CisgICAgICAgIGlmICghdGhpcy5fc3RvcmFnZUV2ZW50TGlzdGVu ZXIpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdmFyIGluc3BlY3RlZFdpbmRvdyA9 IEluc3BlY3RvckNvbnRyb2xsZXIuaW5zcGVjdGVkV2luZG93KCk7CiAgICAgICAgIGlmICghaW5z cGVjdGVkV2luZG93IHx8ICFpbnNwZWN0ZWRXaW5kb3cuZG9jdW1lbnQpCiAgICAgICAgICAgICBy ZXR1cm47Cg==