279516 2024-09-11 08:21:31 -0700 [css-transitions] `transition-behavior: allow-discrete` may not start a transition for a custom property 2024-09-18 15:55:33 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/48115 InRadar P2 Normal --- 1 graouts graouts graouts webkit-bug-importer oldest_to_newest 2059296 0 472524 graouts 2024-09-11 08:21:31 -0700 Created attachment 472524 Test Consider the attached test case which does the following: const target = document.body; target.style.setProperty("--foo", "10"); getComputedStyle(target).getPropertyValue("--foo"); target.style.transition = "--foo 1s allow-discrete"; target.style.setProperty("--foo", "20"); This does not yield a transition. I believe this is because we enter the `transitionPropertiesContainAll` code path under `Styleable::updateCSSTransitions()` which fails to account for custom properties, or at least non-registered properties. 2059297 1 472525 graouts 2024-09-11 08:22:00 -0700 Created attachment 472525 Test with `transition-property: all` Another failing test case, likely failing for the same reason. 2059298 2 graouts 2024-09-11 08:24:40 -0700 "Test" only works in Firefox Nightly. The other test fails in Chrome, Firefox and Safari. 2059305 3 webkit-bug-importer 2024-09-11 09:02:41 -0700 <rdar://problem/135805387> 2059306 4 graouts 2024-09-11 09:08:02 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33470 2059380 5 ews-feeder 2024-09-11 12:24:13 -0700 Committed 283498@main (ca687c87a080): <https://commits.webkit.org/283498@main> Reviewed commits have been landed. Closing PR #33470 and removing active labels. 2059623 6 graouts 2024-09-12 01:16:37 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/48115 2061239 7 ews-feeder 2024-09-18 15:55:33 -0700 Committed 283286.73@safari-7620-branch (2d811327a267): <https://commits.webkit.org/283286.73@safari-7620-branch> Reviewed commits have been landed. Closing PR #1822 and removing active labels. 472524 2024-09-11 08:21:31 -0700 2024-09-11 08:21:31 -0700 Test css-transition-behavior-allow-discrete-with-custom-property.html text/html 426 graouts PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CjxtZXRhIGNoYXJzZXQ9IlVU Ri04Ij4KPC9oZWFkPgo8Ym9keT4KPC9ib2R5Pgo8c2NyaXB0PgoKY29uc3QgdGFyZ2V0ID0gZG9j dW1lbnQuYm9keTsKdGFyZ2V0LnN0eWxlLnNldFByb3BlcnR5KCItLWZvbyIsICIxMCIpOwpnZXRD b21wdXRlZFN0eWxlKHRhcmdldCkuZ2V0UHJvcGVydHlWYWx1ZSgiLS1mb28iKTsKdGFyZ2V0LnN0 eWxlLnRyYW5zaXRpb24gPSAiLS1mb28gMXMgYWxsb3ctZGlzY3JldGUiOwp0YXJnZXQuc3R5bGUu c2V0UHJvcGVydHkoIi0tZm9vIiwgIjIwIik7CmNvbnN0IHRyYW5zaXRpb24gPSBkb2N1bWVudC5n ZXRBbmltYXRpb25zKClbMF07CmRvY3VtZW50LndyaXRlKHRyYW5zaXRpb24gPyAiUEFTUyIgOiAi RkFJTCIpOwoKPC9zY3JpcHQ+CjwvaHRtbD4K 472525 2024-09-11 08:22:00 -0700 2024-09-11 08:22:00 -0700 Test with `transition-property: all` css-transition-property-all-and-transition-behavior-allow-discrete-with-custom-property.html text/html 465 graouts PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CjxtZXRhIGNoYXJzZXQ9IlVU Ri04Ij4KPC9oZWFkPgo8Ym9keT4KPC9ib2R5Pgo8c2NyaXB0PgoKY29uc3QgdGFyZ2V0ID0gZG9j dW1lbnQuYm9keTsKdGFyZ2V0LnN0eWxlLnRyYW5zaXRpb25EdXJhdGlvbiA9ICIxcyI7CnRhcmdl dC5zdHlsZS50cmFuc2l0aW9uQmVoYXZpb3IgPSAiYWxsb3ctZGlzY3JldGUiOwp0YXJnZXQuc3R5 bGUuc2V0UHJvcGVydHkoIi0tZm9vIiwgIjEwIik7CmdldENvbXB1dGVkU3R5bGUodGFyZ2V0KS5n ZXRQcm9wZXJ0eVZhbHVlKCItLWZvbyIpOwp0YXJnZXQuc3R5bGUuc2V0UHJvcGVydHkoIi0tZm9v IiwgIjIwIik7CmNvbnN0IHRyYW5zaXRpb24gPSBkb2N1bWVudC5nZXRBbmltYXRpb25zKClbMF07 CmRvY3VtZW50LndyaXRlKHRyYW5zaXRpb24gPyAiUEFTUyIgOiAiRkFJTCIpOwoKPC9zY3JpcHQ+ CjwvaHRtbD4K