279514 2024-09-11 07:06:52 -0700 [css-transitions] `getKeyframes()` returns the same values for "from" and "to" with a custom property 2024-09-18 14:59:19 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=279252 https://github.com/web-platform-tests/wpt/pull/48103 InRadar P2 Normal --- 1 graouts graouts bramus graouts webkit-bug-importer oldest_to_newest 2059286 0 472522 graouts 2024-09-11 07:06:52 -0700 Created attachment 472522 Test See the attached test case and notice how transitioning a custom property will yield a CSSTransition with the same reported value for the custom property for both the "from" and "to" keyframe. This simply can't be right, otherwise no transition would be created. It also appears that the computed style for the targeted element is incorrect, which could be the same underlying issue. 2059290 1 graouts 2024-09-11 07:31:25 -0700 I think the issue is that we're lacking the equivalent of `ComputedStyleExtractor::valueForPropertyInStyle()` for custom properties and we're wrongly calling `ComputedStyleExtractor::customPropertyValue()` in the `customPropertyValue` lambda under `KeyframeEffect::getKeyframes()`. This means we'll only ever show the current computed value for the target element rather than the keyframe value. 2059294 2 webkit-bug-importer 2024-09-11 08:02:48 -0700 <rdar://problem/135802510> 2059295 3 graouts 2024-09-11 08:04:05 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33468 2059299 4 graouts 2024-09-11 08:25:26 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/48103 2059311 5 ews-feeder 2024-09-11 09:14:47 -0700 Committed 283485@main (cd5cb9415972): <https://commits.webkit.org/283485@main> Reviewed commits have been landed. Closing PR #33468 and removing active labels. 2061212 6 ews-feeder 2024-09-18 14:59:19 -0700 Committed 283286.69@safari-7620-branch (fedfc266a326): <https://commits.webkit.org/283286.69@safari-7620-branch> Reviewed commits have been landed. Closing PR #1821 and removing active labels. 472522 2024-09-11 07:06:52 -0700 2024-09-11 07:06:52 -0700 Test css-transition-custom-property-same-to-and-from-values.html text/html 813 graouts PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KCjxoZWFkPgogIDxtZXRhIGNoYXJzZXQ9 IlVURi04Ij4KICA8dGl0bGU+UGFnZSBUaXRsZTwvdGl0bGU+CiAgPG1ldGEgbmFtZT0idmlld3Bv cnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCxpbml0aWFsLXNjYWxlPTEiPgo8L2hlYWQ+ Cgo8Ym9keT4KPC9ib2R5Pgo8c3R5bGU+CiAgQHByb3BlcnR5IC0tZm9vIHsKICAgIHN5bnRheDog IjxudW1iZXI+IjsKICAgIGluaXRpYWwtdmFsdWU6IDA7CiAgICBpbmhlcml0czogZmFsc2U7CiAg fQoKICA6cm9vdCB7CiAgICB0cmFuc2l0aW9uOiAtLWZvbyAwcyBjYWxjKGluZmluaXR5ICogMXMp OwogIH0KCiAgQHN0YXJ0aW5nLXN0eWxlIHsKICAgIDpyb290IHsKICAgICAgLS1mb286IDE7CiAg ICB9CiAgfQoKPC9zdHlsZT4KPHNjcmlwdD4KCiAgICBjb25zdCB0cmFuc2l0aW9uID0gZG9jdW1l bnQuZ2V0QW5pbWF0aW9ucygpWzBdOwogICAgY29uc3Qga2V5ZnJhbWVzID0gdHJhbnNpdGlvbi5l ZmZlY3QuZ2V0S2V5ZnJhbWVzKCk7CiAgICBjb25zb2xlLmxvZyhgZnJvbSB2YWx1ZSBpcyAke2tl eWZyYW1lc1swXVsiLS1mb28iXX0sIGV4cGVjdGVkIDEuYCk7CiAgICBjb25zb2xlLmxvZyhgdG8g dmFsdWUgaXMgJHtrZXlmcmFtZXNbMV1bIi0tZm9vIl19LCBleHBlY3RlZCAwLmApOwogICAgY29u c29sZS5sb2coYGJvZHkgY29tcHV0ZWQgc3R5bGUgaXMgJHtnZXRDb21wdXRlZFN0eWxlKGRvY3Vt ZW50LmJvZHkpLmdldFByb3BlcnR5VmFsdWUoIi0tZm9vIil9LCBleHBlY3RlZCAxLmApOwoKPC9z Y3JpcHQ+CjwvaHRtbD4K