27951 2009-08-03 13:53:19 -0700 [commit+] Invalid assert in v8 SVG bindings (hit during acid3 test). 2009-08-03 14:01:05 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 deanm abarth abarth oldest_to_newest 136769 0 deanm 2009-08-03 13:53:19 -0700 We're asserting that a PassRefPtr is not NULL, but the pointer has already be taken my assigning it to a refptr. The patch is simple. It is already covered by tests. 136771 1 34002 deanm 2009-08-03 13:55:28 -0700 Created attachment 34002 Patch 136773 2 34002 abarth 2009-08-03 13:57:41 -0700 Comment on attachment 34002 Patch Thanks dean. 136774 3 abarth 2009-08-03 13:59:05 -0700 Will land. 136775 4 34002 abarth 2009-08-03 14:01:01 -0700 Comment on attachment 34002 Patch Clearing review flag on attachment: 34002 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/V8SVGPODTypeWrapper.h Committed r46730 M WebCore/ChangeLog M WebCore/bindings/v8/V8SVGPODTypeWrapper.h r46730 = 40d39dba04f64d485ce7ee3a2141c31d193d805a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46730 136776 5 abarth 2009-08-03 14:01:05 -0700 All reviewed patches have been landed. Closing bug. 34002 2009-08-03 13:55:28 -0700 2009-08-03 14:01:01 -0700 Patch x.diff text/plain 1103 deanm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTJkNmFmMS4uMDdkYzU5MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOC0wMyAgRGVhbiBNY05hbWVl ICA8ZGVhbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENvcnJlY3QgYW4gYXNzZXJ0IG9uIGEgUGFzc1JlZlB0ciBpbiB0aGUg djggc3ZnIGJpbmRpbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mjc5NTEKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4U1ZHUE9EVHlwZVdyYXBw ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4U1ZHRHluYW1pY1BPRFR5cGVXcmFwcGVyOjpWOFNW R0R5bmFtaWNQT0RUeXBlV3JhcHBlcik6CisKIDIwMDktMDgtMDMgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTVkdQT0RUeXBlV3JhcHBlci5oIGIvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFNWR1BPRFR5cGVXcmFwcGVyLmgKaW5kZXggODVmMTNmYS4uYjZl NDdhZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFNWR1BPRFR5cGVXcmFwcGVy LmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFNWR1BPRFR5cGVXcmFwcGVyLmgKQEAgLTIz MCw3ICsyMzAsNyBAQCBwcml2YXRlOgogICAgICAgICAsIG1fc2V0dGVyKHNldHRlcikKICAgICAg ICAgLCBtX2NhY2hlUmVtb3ZhbENhbGxiYWNrKGNhY2hlUmVtb3ZhbENhbGxiYWNrKQogICAgIHsK LSAgICAgICAgQVNTRVJUKGNyZWF0b3IpOworICAgICAgICBBU1NFUlQobV9jcmVhdG9yKTsgIC8v IHxjcmVhdG9yfCdzIHBvaW50ZXIgd2FzIHRha2VuIGJ5IG1fY3JlYXRvci4KICAgICAgICAgQVNT RVJUKGdldHRlcik7CiAgICAgICAgIEFTU0VSVChzZXR0ZXIpOwogICAgICAgICBBU1NFUlQoY2Fj aGVSZW1vdmFsQ2FsbGJhY2spOwo=