27947 2009-08-03 11:36:30 -0700 A bug in SQLiteTransaction can lead to a failed ASSERT 2009-08-03 16:00:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi andersca aroben beidson darin dglazkov oldest_to_newest 136722 0 dumi 2009-08-03 11:36:30 -0700 SQLiteTransaction::begin() sets m_db.m_transactionInProgress to true even if m_db.executeCommand("BEGIN;") fails. This can lead to an ASSERT failing incorrectly in SQLTransaction::openTransaction() (steps 1 + 2). 136740 1 33997 dumi 2009-08-03 12:28:17 -0700 Created attachment 33997 patch 136747 2 33997 darin 2009-08-03 12:46:27 -0700 Comment on attachment 33997 patch Seems fine. Is there any way to make a regression test for this? Under what circumstances will the BEGIN command fail? r=me 136749 3 dglazkov 2009-08-03 12:56:11 -0700 Should we need another assert after BEGIN. This shouldn't be happening normally, right? It seems like we should be doing something more than just reporting !inProgress in these cases. 136765 4 34000 dumi 2009-08-03 13:44:22 -0700 Created attachment 34000 test case (In reply to comment #2) > (From update of attachment 33997 [details]) > Seems fine. Is there any way to make a regression test for this? Under what > circumstances will the BEGIN command fail? > > r=me BEGIN seems to fail if the same DB thread tries to run 2 transactions in 2 different Database objects that point to the same DB file. I attached the example we used. I don't have a detailed explanation for what's going on yet -- we think there's a race condition here and I'm still debugging it (details + patch to come in a future bug). However, always setting m_db.m_transactionInProgress to true seems wrong and leads to crashes in Chromium's and Safari's debug builds (you might have to click the "Test" button a couple of times). So I thought it wouldn't hurt to submit a quick patch for this before we're done investigating the bigger issue. 136820 5 dglazkov 2009-08-03 16:00:11 -0700 Landed as http://trac.webkit.org/changeset/46736. Please create a bug for tracking the origin of the issue. 33997 2009-08-03 12:28:17 -0700 2009-08-03 12:46:26 -0700 patch patch text/plain 1993 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjcyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDgtMDMgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggYSBidWcgdGhhdCBjb3VsZCBjYXVzZSBhbiBBU1NFUlQgdG8gZmFpbCBpbmNvcnJlY3Rs eSwgbGVhZGluZworICAgICAgICB0byBhIHJlbmRlcmVyIGNyYXNoIGluIENocm9taXVtLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzk0NworCisg ICAgICAgIEFsbCB0ZXN0cyBpbiBzdG9yYWdlLyBwYXNzLgorCisgICAgICAgICogcGxhdGZvcm0v c3FsL1NRTGl0ZVRyYW5zYWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNRTGl0ZVRyYW5z YWN0aW9uOjp+U1FMaXRlVHJhbnNhY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlVHJh bnNhY3Rpb246OmJlZ2luKToKKwogMjAwOS0wOC0wMyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9zcWwvU1FMaXRlVHJhbnNhY3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVRyYW5zYWN0aW9uLmNwcAkocmV2aXNpb24gNDY3MjYpCisr KyBXZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVUcmFuc2FjdGlvbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIwLDcgKzIwLDcgQEAKICAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElP TikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKICAqIE9GIExJQUJJTElUWSwgV0hF VEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAogICogKElOQ0xVRElO RyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUg VVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklM SVRZIE9GIFNVQ0ggREFNQUdFLiAKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAogI2luY2x1ZGUgImNv bmZpZy5oIgpAQCAtMzgsMTYgKzM4LDE2IEBAIFNRTGl0ZVRyYW5zYWN0aW9uOjpTUUxpdGVUcmFu c2FjdGlvbihTUUwKIAogU1FMaXRlVHJhbnNhY3Rpb246On5TUUxpdGVUcmFuc2FjdGlvbigpCiB7 Ci0gICAgaWYgKG1faW5Qcm9ncmVzcykgCisgICAgaWYgKG1faW5Qcm9ncmVzcykKICAgICAgICAg cm9sbGJhY2soKTsKIH0KLSAgICAKKwogdm9pZCBTUUxpdGVUcmFuc2FjdGlvbjo6YmVnaW4oKQog ewogICAgIGlmICghbV9pblByb2dyZXNzKSB7CiAgICAgICAgIEFTU0VSVCghbV9kYi5tX3RyYW5z YWN0aW9uSW5Qcm9ncmVzcyk7CiAgICAgICAgIG1faW5Qcm9ncmVzcyA9IG1fZGIuZXhlY3V0ZUNv bW1hbmQoIkJFR0lOOyIpOwotICAgICAgICBtX2RiLm1fdHJhbnNhY3Rpb25JblByb2dyZXNzID0g dHJ1ZTsKKyAgICAgICAgbV9kYi5tX3RyYW5zYWN0aW9uSW5Qcm9ncmVzcyA9IG1faW5Qcm9ncmVz czsKICAgICB9CiB9CiAKQEAgLTc2LDUgKzc2LDUgQEAgdm9pZCBTUUxpdGVUcmFuc2FjdGlvbjo6 c3RvcCgpCiAgICAgbV9pblByb2dyZXNzID0gZmFsc2U7CiAgICAgbV9kYi5tX3RyYW5zYWN0aW9u SW5Qcm9ncmVzcyA9IGZhbHNlOwogfQotICAgIAorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 34000 2009-08-03 13:44:22 -0700 2009-08-03 13:44:22 -0700 test case db_test.html text/html 1594 dumi PGh0bWw+DQo8aGVhZD4NCjx0aXRsZT5UZXN0aW5nIDIgREIgb2JqZWN0cyBmb3IgdGhlIHNhbWUg ZGF0YWJhc2U8L3RpdGxlPg0KPHNjcmlwdD4NCmZ1bmN0aW9uIGNyZWF0ZSgpIHsNCiAgdHJ5IHsN CiAgICB2YXIgZGIgPSBvcGVuRGF0YWJhc2UoIlRlc3REQiIsICIxLjAiLCAiVGVzdCBEQiIsIDEw MDAwMCk7DQogICAgZGIudHJhbnNhY3Rpb24oZnVuY3Rpb24odHgpIHsNCiAgICAgICAgdHguZXhl Y3V0ZVNxbCgiQ1JFQVRFIFRBQkxFIFRlc3QgKEZvbyBpbnQpOyIsIFtdLA0KICAgICAgICAgICAg ICAgICAgICAgIGZ1bmN0aW9uKHJlc3VsdCkge30sIGZ1bmN0aW9uKHR4LCBlcnJvcikge30pOw0K ICAgICAgICB9KTsNCiAgfSBjYXRjaChlcnIpIHt9DQp9DQoNCmZ1bmN0aW9uIHRlc3QoKSB7DQog IHZhciBkYjEsIGRiMjsNCiAgdHJ5IHsNCiAgICBkYjEgPSBvcGVuRGF0YWJhc2UoIlRlc3REQiIs ICIxLjAiLCAiVGVzdCBEQiIsIDEwMDAwMCk7DQogICAgZGIyID0gb3BlbkRhdGFiYXNlKCJUZXN0 REIiLCAiMS4wIiwgIlRlc3QgREIiLCAxMDAwMDApOw0KDQogICAgaWYgKGRiMSA9PSBkYjIpIHsN CiAgICAgIGFsZXJ0KCJkYjEgPT0gZGIyIik7DQogICAgfSBlbHNlIHsNCiAgICAgIGRiMS50cmFu c2FjdGlvbihmdW5jdGlvbih0eCkgew0KICAgICAgICAgIHR4LmV4ZWN1dGVTcWwoIlNFTEVDVCBD T1VOVCgqKSBGUk9NIFRlc3Q7IiwgW10sDQogICAgICAgICAgICAgICAgICAgICAgICBmdW5jdGlv bihyZXN1bHQpIHt9LA0KICAgICAgICAgICAgICAgICAgICAgICAgZnVuY3Rpb24odHgsIGVycm9y KSB7IGFsZXJ0KGVycm9yLm1lc3NhZ2UpOyB9KTsNCiAgICAgICAgICB0eC5leGVjdXRlU3FsKCJJ TlNFUlQgSU5UTyBUZXN0IFZBTFVFUyAoMSk7IiwgW10sDQogICAgICAgICAgICAgICAgICAgICAg ICBmdW5jdGlvbihyZXN1bHQpIHsgYWxlcnQoIjEiKTsgfSwNCiAgICAgICAgICAgICAgICAgICAg ICAgIGZ1bmN0aW9uKHR4LCBlcnJvcikgeyBhbGVydChlcnJvci5tZXNzYWdlKTsgfSk7DQogICAg ICAgICAgfSk7DQogICAgICBkYjIudHJhbnNhY3Rpb24oZnVuY3Rpb24odHgpIHsNCiAgICAgICAg ICB0eC5leGVjdXRlU3FsKCJTRUxFQ1QgQ09VTlQoKikgRlJPTSBUZXN0OyIsIFtdLA0KICAgICAg ICAgICAgICAgICAgICAgICAgZnVuY3Rpb24ocmVzdWx0KSB7fSwNCiAgICAgICAgICAgICAgICAg ICAgICAgIGZ1bmN0aW9uKHR4LCBlcnJvcikgeyBhbGVydChlcnJvci5tZXNzYWdlKTsgfSk7DQog ICAgICAgICAgdHguZXhlY3V0ZVNxbCgiSU5TRVJUIElOVE8gVGVzdCBWQUxVRVMgKDIpOyIsIFtd LA0KICAgICAgICAgICAgICAgICAgICAgICAgZnVuY3Rpb24ocmVzdWx0KSB7IGFsZXJ0KCIyIik7 IH0sDQogICAgICAgICAgICAgICAgICAgICAgICBmdW5jdGlvbih0eCwgZXJyb3IpIHsgYWxlcnQo ZXJyb3IubWVzc2FnZSk7IH0pOw0KICAgICAgICAgIH0pOw0KICAgIH0NCiAgfSBjYXRjaChlcnIp IHt9DQp9DQo8L3NjcmlwdD4NCjwvaGVhZD4NCjxib2R5IG9ubG9hZD0iY3JlYXRlKCkiPg0KPGJ1 dHRvbiBvbmNsaWNrPSJ0ZXN0KCkiPlRlc3Q8L2J1dHRvbj4NCjwvYm9keT4NCjwvaHRtbD4NCg==