27946 2009-08-03 10:36:28 -0700 [commit+] PluginView.h included in Page.cpp breaks Chromium build 2009-08-03 11:47:40 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony abarth abarth jhoneycutt oldest_to_newest 136701 0 tony 2009-08-03 10:36:28 -0700 In r46649, an include for PluginView.h was added to Page.cpp. Chromium doesn't use PluginView.h so this causes a build break for us. I'm not sure what the right fix is, but simply removing the include seems to allow Chromium to compile since the pointer never needs to be dereferenced. I'll upload a patch with an if !PLATFORM(CHROMIUM), although I'm not sure that's the right way to fix this. 136710 1 33991 tony 2009-08-03 10:48:45 -0700 Created attachment 33991 v1 Actually, just remove the include on all platforms since it's not needed anywhere for the reason mentioned above. 136717 2 abarth 2009-08-03 11:20:42 -0700 Assigned for landing. 136724 3 33991 abarth 2009-08-03 11:47:36 -0700 Comment on attachment 33991 v1 Clearing review flag on attachment: 33991 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/Page.cpp Committed r46726 M JavaScriptCore/wtf/FastMalloc.cpp M JavaScriptCore/ChangeLog r46724 = 056fc244b7649a0b3a8df71d4f3a5944f92e9241 (trunk) M JavaScriptCore/wtf/FastMalloc.cpp M JavaScriptCore/ChangeLog r46725 = 4d74f16e1ad25e92277cb09ec5cda6ab62bb1607 (trunk) M WebCore/ChangeLog M WebCore/page/Page.cpp r46726 = 5692de3f2b92d7b7a4600c2dbe329a81192f194b (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46726 136725 4 abarth 2009-08-03 11:47:40 -0700 All reviewed patches have been landed. Closing bug. 33991 2009-08-03 10:48:45 -0700 2009-08-03 11:47:36 -0700 v1 plugin-view.diff text/plain 1126 tony SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjcyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMDMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg Q2hyb21pdW0gYnVpbGQgYnkgcmVtb3ZpbmcgUGx1Z2luVmlldy5oIGZyb20gUGFnZS5jcHAuCisg ICAgICAgIENocm9taXVtIGRvZXNuJ3QgdXNlIFBsdWdpblZpZXcgYW5kIHRoZSBwb2ludGVyIGlz IG5ldmVyCisgICAgICAgIGRlcmVmZXJlbmNlZCBzbyB0aGUgaGVhZGVyIGRvZXNuJ3QgbmVlZCB0 byBiZSBpbmNsdWRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI3OTQ2CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhpcyBpcyBhIGJ1 aWxkIGZpeC4KKworICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisKIDIwMDktMDgtMDMgIEVyaWMg Q2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4IGFm dGVyIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjcyMC4KSW5kZXg6 IFdlYkNvcmUvcGFnZS9QYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvUGFnZS5j cHAJKHJldmlzaW9uIDQ2NzIyKQorKysgV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00NSw3ICs0NSw2IEBACiAjaW5jbHVkZSAiTmV0d29ya1N0YXRlTm90aWZpZXIuaCIK ICNpbmNsdWRlICJQYWdlR3JvdXAuaCIKICNpbmNsdWRlICJQbHVnaW5EYXRhLmgiCi0jaW5jbHVk ZSAiUGx1Z2luVmlldy5oIgogI2luY2x1ZGUgIlByb2dyZXNzVHJhY2tlci5oIgogI2luY2x1ZGUg IlJlbmRlcldpZGdldC5oIgogI2luY2x1ZGUgIlJlbmRlclRoZW1lLmgiCg==