27940 2009-08-03 07:11:36 -0700 Build fix if Netscape plugin support is turned off 2009-08-03 10:32:51 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned darin kenneth vestbo oldest_to_newest 136626 0 laszlo.gombos 2009-08-03 07:11:36 -0700 After r46649 and r46697 turning off Netscape plugin support makes the build fail. 136627 1 33974 laszlo.gombos 2009-08-03 07:27:21 -0700 Created attachment 33974 proposed patch. PluginView.cpp - Do not call NPN_MemFree if NPAPI is disabled PluginViewNone.cpp - Add empty stub for platformStart() 136658 2 33974 eric 2009-08-03 09:30:34 -0700 Comment on attachment 33974 proposed patch. LGTM. 136670 3 kenneth 2009-08-03 09:58:11 -0700 The patch contains trailing spaces. I will fix it when I land it 136673 4 kenneth 2009-08-03 10:01:26 -0700 Landed in 46719. 136674 5 darin 2009-08-03 10:02:39 -0700 Why do the functions in PluginViewNone.cpp have notImplemented() in them? I'd think they could just be empty function. The notImplemented() function is intended to alert the person working on the port that a particular non-implemented stub was hit. But in the case of "none" we don't ever plan to implement these. They should either be empty, or have ASSERT_NOT_REACHED() in them, or not exist at all, depending on our needs. 136683 6 kenneth 2009-08-03 10:14:20 -0700 I think the reasoning was that ports use PluginViewNone when they still have not added support for plugins and thus, will run into a not implemented. If that is not the purpose of PluginViewNone, this ofcourse should be fixed. 136684 7 darin 2009-08-03 10:16:27 -0700 (In reply to comment #6) > I think the reasoning was that ports use PluginViewNone when they still have > not added support for plugins and thus, will run into a not implemented. If > that is not the purpose of PluginViewNone, this of course should be fixed. OK. That makes sense. On the other hand, I could imagine a port that doesn't want plug-in support at all. 136687 8 kenneth 2009-08-03 10:19:09 -0700 In that case I believe they should be able to disable the plugin support via the settings API. 136690 9 laszlo.gombos 2009-08-03 10:21:54 -0700 (In reply to comment #7) > (In reply to comment #6) > > I think the reasoning was that ports use PluginViewNone when they still have > > not added support for plugins and thus, will run into a not implemented. If > > that is not the purpose of PluginViewNone, this of course should be fixed. > > OK. That makes sense. On the other hand, I could imagine a port that doesn't > want plug-in support at all. I think Darin has a valid point. i just used notImplemented() to stay consistent with the rest of the file. PluginViewNone.cpp was initially developed for the wx port only and I proposed a patch to promote it to all ports to enable turning off NPAPI support. I think notImplemented should go. I will create a patch. 136698 10 kenneth 2009-08-03 10:32:51 -0700 If that is the case, I agree with you :-) I talked with Kevin Ollivier on irc and he agrees with you Laszlo 33974 2009-08-03 07:27:21 -0700 2009-08-03 09:30:34 -0700 proposed patch. patch_27940.txt text/plain 1707 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjcxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMDMgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1aWxkIGZpeCBpZiBOZXRzY2FwZSBwbHVnaW4gc3VwcG9ydCBpcyB0dXJuZWQgb2Zm CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzk0MAor CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBs dWdpblZpZXc6OnN0b3ApOiBEbyBub3QgY2FsbCBOUE5fTWVtRnJlZSBpZiBOUEFQSSBpcworICAg ICAgICBkaXNhYmxlZAorICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwOiAKKyAg ICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnBsYXRmb3JtU3RhcnQpOiBFbXB0eSBzdHViLgor CiAyMDA5LTA4LTAyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgogCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmll dy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCShyZXZp c2lvbiA0NjcxNikKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjU5LDEyICsyNTksMTQgQEAgdm9pZCBQbHVnaW5WaWV3OjpzdG9wKCkKICAgICBM T0dfTlBFUlJPUihucEVycik7CiAgICAgUGx1Z2luVmlldzo6c2V0Q3VycmVudFBsdWdpblZpZXco MCk7CiAKKyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBpZiAoc2F2ZWREYXRh KSB7CiAgICAgICAgIC8vIFRPRE86IEFjdHVhbGx5IHNhdmUgdGhpcyBkYXRhIGluc3RlYWQgb2Yg anVzdCBkaXNjYXJkaW5nIGl0CiAgICAgICAgIGlmIChzYXZlZERhdGEtPmJ1ZikKICAgICAgICAg ICAgIE5QTl9NZW1GcmVlKHNhdmVkRGF0YS0+YnVmKTsKICAgICAgICAgTlBOX01lbUZyZWUoc2F2 ZWREYXRhKTsKICAgICB9CisjZW5kaWYKIAogICAgIG1faW5zdGFuY2UtPnBkYXRhID0gMDsKIH0K SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdOb25lLmNwcAkocmV2aXNpb24gNDY3MTYpCisrKyBX ZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQs NCArMTM0LDkgQEAgdm9pZCBQbHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQoKQogICAgIG5v dEltcGxlbWVudGVkKCk7CiB9CiAKK3ZvaWQgUGx1Z2luVmlldzo6cGxhdGZvcm1TdGFydCgpCit7 IAorICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK