27936 2009-08-02 23:39:45 -0700 Build fail on ubuntu/x86_64 2009-08-03 05:21:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned jmalonzo oldest_to_newest 136588 0 ukai 2009-08-02 23:39:45 -0700 In file included from ../JavaScriptCore/interpreter/Register.h:32, from ../JavaScriptCore/jit/JITStubs.h:35, from ../JavaScriptCore/runtime/JSGlobalData.h:34, from ../JavaScriptCore/runtime/Identifier.h:24, from ../WebCore/platform/text/PlatformString.h:35, from ../WebCore/page/Console.h:32, from ../WebCore/page/ChromeClient.h:23, from ../WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:23, from ../WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:24: ../JavaScriptCore/runtime/JSValue.h: In constructor ‘JSC::JSValue::JSValue(JSC::JSCell*)’: ../JavaScriptCore/runtime/JSValue.h:472: error: cast from ‘JSC::JSCell*’ to ‘int32_t’ loses precision ../JavaScriptCore/runtime/JSValue.h: In constructor ‘JSC::JSValue::JSValue(const JSC::JSCell*)’: ../JavaScriptCore/runtime/JSValue.h:478: error: cast from ‘JSC::JSCell*’ to ‘int32_t’ loses precision make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1 I believe we should set JSVALUE64 instead of JSVALUE32_64 on all X86_64 platform. 136589 1 33960 ukai 2009-08-02 23:46:52 -0700 Created attachment 33960 2009-08-02 Xan Lopez <xlopez@igalia.com> Fix the GTK+ build. * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46712 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 2 files changed, 7 insertions(+), 1 deletions(-) 136590 2 33961 ukai 2009-08-02 23:47:32 -0700 Created attachment 33961 use JSVALUE64 --- 2 files changed, 12 insertions(+), 1 deletions(-) 136612 3 33969 ukai 2009-08-03 04:26:24 -0700 Created attachment 33969 use JSVALUE64 for X86_64 LINUX, except Qt --- 2 files changed, 12 insertions(+), 1 deletions(-) 136616 4 33969 jmalonzo 2009-08-03 05:01:10 -0700 Comment on attachment 33969 use JSVALUE64 for X86_64 LINUX, except Qt r=me. 136617 5 jmalonzo 2009-08-03 05:21:40 -0700 (In reply to comment #4) > (From update of attachment 33969 [details]) > r=me. Landed as http://trac.webkit.org/changeset/46716. 33960 2009-08-02 23:46:52 -0700 2009-08-02 23:47:27 -0700 2009-08-02 Xan Lopez <xlopez@igalia.com> bug-27936-20090803154651.patch text/plain 937 ukai ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAyZDg2MjcxLi43NjJiZGVhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsOSBA QAorMjAwOS0wOC0wMiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAg Rml4IHRoZSBHVEsrIGJ1aWxkLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMDkt MDgtMDIgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm b3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCA0ZDVkMzkzLi5mMWZk MjRkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9KYXZh U2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAtNTY1LDcgKzU2NSw3IEBACiAjaWYgIWRlZmlu ZWQoV1RGX1VTRV9KU1ZBTFVFNjQpICYmICFkZWZpbmVkKFdURl9VU0VfSlNWQUxVRTMyKSAmJiAh ZGVmaW5lZChXVEZfVVNFX0pTVkFMVUUzMl82NCkKICNpZiBQTEFURk9STShYODZfNjQpICYmIFBM QVRGT1JNKE1BQykKICNkZWZpbmUgV1RGX1VTRV9KU1ZBTFVFNjQgMQotI2VsaWYgUExBVEZPUk0o UVQpIC8vIEFsbCBRdCBsYXlvdXQgdGVzdHMgY3Jhc2ggaW4gSlNWQUxVRTMyXzY0IG1vZGUuCisj ZWxpZiBQTEFURk9STShRVCkgLyogQWxsIFF0IGxheW91dCB0ZXN0cyBjcmFzaCBpbiBKU1ZBTFVF MzJfNjQgbW9kZS4gKi8KICNkZWZpbmUgV1RGX1VTRV9KU1ZBTFVFMzIgMQogI2Vsc2UKICNkZWZp bmUgV1RGX1VTRV9KU1ZBTFVFMzJfNjQgMQ== 33961 2009-08-02 23:47:32 -0700 2009-08-03 04:26:19 -0700 use JSVALUE64 bug-27936-20090803154730.patch text/plain 1043 ukai ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA3NjJiZGVhLi40N2NlNjAxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDktMDgtMDIgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIGJy ZWFrIG9uIEd0ay94ODZfNjQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNzkzNgorCisgICAgICAgIFVzZSBKU1ZBTFVFNjQgZm9yIFg4Nl82NCBMSU5V WC4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDA5LTA4LTAyICBYYW4gTG9wZXog IDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggdGhlIEdUSysgYnVpbGQuCmRpZmYg LS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaCBiL0phdmFTY3JpcHRDb3JlL3d0 Zi9QbGF0Zm9ybS5oCmluZGV4IGYxZmQyNGQuLjkyMTUwZTYgMTAwNjQ0Ci0tLSBhL0phdmFTY3Jp cHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5o CkBAIC01NjMsNyArNTYzLDcgQEAKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoV1RGX1VTRV9KU1ZB TFVFNjQpICYmICFkZWZpbmVkKFdURl9VU0VfSlNWQUxVRTMyKSAmJiAhZGVmaW5lZChXVEZfVVNF X0pTVkFMVUUzMl82NCkKLSNpZiBQTEFURk9STShYODZfNjQpICYmIFBMQVRGT1JNKE1BQykKKyNp ZiBQTEFURk9STShYODZfNjQpICYmIChQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKExJTlVYKSkK ICNkZWZpbmUgV1RGX1VTRV9KU1ZBTFVFNjQgMQogI2VsaWYgUExBVEZPUk0oUVQpIC8qIEFsbCBR dCBsYXlvdXQgdGVzdHMgY3Jhc2ggaW4gSlNWQUxVRTMyXzY0IG1vZGUuICovCiAjZGVmaW5lIFdU Rl9VU0VfSlNWQUxVRTMyIDE= 33969 2009-08-03 04:26:24 -0700 2009-08-03 05:01:09 -0700 use JSVALUE64 for X86_64 LINUX, except Qt bug-27936-20090803202622.patch text/plain 1073 ukai ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA3NjJiZGVhLi4xZDIyMDdhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDktMDgtMDIgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIGJy ZWFrIG9uIEd0ay94ODZfNjQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNzkzNgorCisgICAgICAgIFVzZSBKU1ZBTFVFNjQgZm9yIFg4Nl82NCBMSU5V WCwgZXhjZXB0IFF0LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMDktMDgtMDIg IFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeCB0aGUgR1RLKyBi dWlsZC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvSmF2YVNj cmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5kZXggZjFmZDI0ZC4uOWMyNmU4NSAxMDA2NDQKLS0t IGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3Rm L1BsYXRmb3JtLmgKQEAgLTU2Myw3ICs1NjMsNyBAQAogI2VuZGlmCiAKICNpZiAhZGVmaW5lZChX VEZfVVNFX0pTVkFMVUU2NCkgJiYgIWRlZmluZWQoV1RGX1VTRV9KU1ZBTFVFMzIpICYmICFkZWZp bmVkKFdURl9VU0VfSlNWQUxVRTMyXzY0KQotI2lmIFBMQVRGT1JNKFg4Nl82NCkgJiYgUExBVEZP Uk0oTUFDKQorI2lmIFBMQVRGT1JNKFg4Nl82NCkgJiYgKFBMQVRGT1JNKE1BQykgfHwgKFBMQVRG T1JNKExJTlVYKSAmJiAhUExBVEZPUk0oUVQpKSkKICNkZWZpbmUgV1RGX1VTRV9KU1ZBTFVFNjQg MQogI2VsaWYgUExBVEZPUk0oUVQpIC8qIEFsbCBRdCBsYXlvdXQgdGVzdHMgY3Jhc2ggaW4gSlNW QUxVRTMyXzY0IG1vZGUuICovCiAjZGVmaW5lIFdURl9VU0VfSlNWQUxVRTMyIDE=