279345 2024-09-09 00:05:45 -0700 Remove Quirk shouldPreventDispatchOfTouchEvent for sites.google.com 2024-09-09 00:05:54 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW http://sites.google.com/ InRadar P2 Normal --- 210143 1 karlcow webkit-unassigned webkit-bug-importer oldest_to_newest 2058555 0 karlcow 2024-09-09 00:05:45 -0700 On Bug 210143 / rdar 58653069, a quirk has been added to make it possible to expand the submenus in sites.google.com on iPad on Safari. Steps to reproduce: 1. With an iPad 2. Go to https://sites.google.com/ 3. Choose a template 4. On the right side column, select Pages 5. A series is being displayed. 6. When hovering click on the 3 vertical dots 7. A menu appears, choose Add a subpage 8. Give it a name and create it 9. A subpage appears in the menu and a triangle at the beginning of the parent page 10. Click on the triangle icon Result: With Site Specific Hacks ENABLED, the triangle icon hide or show the subpages With Site Specific Hacks DISABLED, the triangle icon is not working. When clicking on the icon these are the events being emitted. Site Specific Hacks ENABLED [Log] event: touchstart, target: [object HTMLSpanElement] [Log] event: touchstart, target: [object HTMLSpanElement] [Log] event: mousemove, target: [object HTMLSpanElement] [Log] event: mousemove, target: [object HTMLSpanElement] [Log] event: mousedown, target: [object HTMLSpanElement] (x2) [Log] event: mousedown, target: [object HTMLSpanElement] [Log] event: mousedown, target: [object HTMLSpanElement] [Log] event: mouseup, target: [object HTMLSpanElement] (x2) [Log] event: mouseup, target: [object HTMLSpanElement] [Log] event: mouseup, target: [object HTMLSpanElement] [Log] event: click, target: [object HTMLSpanElement] [Log] event: click, target: [object HTMLSpanElement] [Log] event: transitionend, target: [object HTMLDivElement] (x6) Site Specific Hacks DISABLED [Log] event: touchstart, target: [object HTMLSpanElement] [Log] event: touchstart, target: [object HTMLSpanElement] [Log] event: touchend, target: [object HTMLSpanElement] [Log] event: touchend, target: [object HTMLSpanElement] [Log] event: transitionend, target: [object HTMLDivElement] (x6) The code on WebKit has no call in the rest of the source code https://github.com/search?q=repo%3AWebKit%2FWebKit+shouldPreventDispatchOfTouchEvent&type=code It means that it requires a PR on Safari code too. The current Quirk is acting on touchendEvent As of today the current Quirk CAN NOT be removed. 2058556 1 webkit-bug-importer 2024-09-09 00:05:54 -0700 <rdar://problem/135531665>