27934 2009-08-02 19:35:47 -0700 [Qt] Consolidate common gcc flags to WebKit.pri 2009-08-03 19:14:31 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned abarth oldest_to_newest 136579 0 laszlo.gombos 2009-08-02 19:35:47 -0700 All Qt projects include WebKit.pri, so by moving the common flags to WebKit.pri all projects would share a common baseline. One of the practical use of this is to disable all the unused parameter warnings when TestNetscapePlugin gets build. 136580 1 33958 laszlo.gombos 2009-08-02 19:46:54 -0700 Created attachment 33958 proposed patch 136653 2 33958 eric 2009-08-03 09:26:00 -0700 Comment on attachment 33958 proposed patch Looks sane enough, so long as everything still builds. :) 136884 3 33958 abarth 2009-08-03 19:14:28 -0700 Comment on attachment 33958 proposed patch Clearing review flag on attachment: 33958 Sending ChangeLog Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/JavaScriptCore.pro Sending WebCore/ChangeLog Sending WebCore/WebCore.pro Sending WebKit.pri Transmitting file data ...... Committed revision 46743. http://trac.webkit.org/changeset/46743 136885 4 abarth 2009-08-03 19:14:31 -0700 All reviewed patches have been landed. Closing bug. 33958 2009-08-02 19:46:54 -0700 2009-08-03 19:14:28 -0700 proposed patch patch_27934.txt text/plain 3406 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NzA5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDgt MDIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ29uc29saWRhdGUg Y29tbW9uIGdjYyBmbGFncyB0byBXZWJLaXQucHJpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzkzNAorCisgICAgICAgICogV2ViS2l0LnByaToKKwog MjAwOS0wNy0yOSAgQXJpeWEgSGlkYXlhdCAgPGFyaXlhLmhpZGF5YXRAbm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViS2l0LnByaQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQucHJpCShyZXZpc2lvbiA0NjcwNikKKysrIFdlYktpdC5wcmkJKHdv cmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDEwIEBAIENPTkZJRyhyZWxlYXNlLCBkZWJ1Z3xyZWxl YXNlKSB7CiBCQVNFX0RJUiA9ICQkUFdECiBJTkNMVURFUEFUSCArPSAkJFBXRC9XZWJLaXQvcXQv QXBpCiAKK0NPTkZJRyAtPSB3YXJuX29uCisqLWcrKyo6UU1BS0VfQ1hYRkxBR1MgKz0gLVdyZXR1 cm4tdHlwZSAtZm5vLXN0cmljdC1hbGlhc2luZworI1FNQUtFX0NYWEZMQUdTICs9IC1XYWxsIC1X bm8tdW5kZWYgLVduby11bnVzZWQtcGFyYW1ldGVyCisKICMgRW5hYmxlIEdOVSBjb21waWxlciBl eHRlbnNpb25zIHRvIHRoZSBBUk0gY29tcGlsZXIgZm9yIGFsbCBRdCBwb3J0cyB1c2luZyBSVkNU CiAqLWFybWNjIHsKICAgICBRTUFLRV9DRkxBR1MgKz0gLS1nbnUKSW5kZXg6IEphdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJl dmlzaW9uIDQ2NzA5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDgtMDIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5n b21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gQ29uc29saWRhdGUgY29tbW9uIGdjYyBmbGFncyB0byBXZWJLaXQucHJp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzkzNAor CisgICAgICAgICogSmF2YVNjcmlwdENvcmUucHJvOgorCiAyMDA5LTA4LTAyICBHZW9mZnJleSBH YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5p Zy4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8JKHJldmlzaW9uIDQ2NzA2KQorKysg SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0zMywx MCArMzMsNiBAQCBJTkNMVURFUEFUSCArPSAkJEdFTkVSQVRFRF9TT1VSQ0VTX0RJUgogICAgIH0K IH0KIAotQ09ORklHIC09IHdhcm5fb24KLSotZysrKjpRTUFLRV9DWFhGTEFHUyArPSAtV3JldHVy bi10eXBlIC1mbm8tc3RyaWN0LWFsaWFzaW5nCi0jUU1BS0VfQ1hYRkxBR1MgKz0gLVdhbGwgLVdu by11bmRlZiAtV25vLXVudXNlZC1wYXJhbWV0ZXIKLQogQ09ORklHKHJlbGVhc2UpOiFDT05GSUco UVRESVJfYnVpbGQpIHsKICAgICBjb250YWlucyhRVF9DT05GSUcsIHJlZHVjZV9leHBvcnRzKTpD T05GSUcgKz0gaGlkZV9zeW1ib2xzCiAgICAgdW5peDpjb250YWlucyhRVF9DT05GSUcsIHJlZHVj ZV9yZWxvY2F0aW9ucyk6Q09ORklHICs9IGJzeW1ib2xpY19mdW5jdGlvbnMKSW5kZXg6IFdlYkNv cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA0 NjcwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMDktMDgtMDIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g Q29uc29saWRhdGUgY29tbW9uIGdjYyBmbGFncyB0byBXZWJLaXQucHJpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzkzNAorCisgICAgICAgICogV2Vi Q29yZS5wcm86CisKIDIwMDktMDgtMDIgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0 Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5k ZXg6IFdlYkNvcmUvV2ViQ29yZS5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnBy bwkocmV2aXNpb24gNDY3MDYpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJvCSh3b3JraW5nIGNvcHkp CkBAIC00NSwxNCArNDUsOSBAQCB1bml4IHsKICAgICBsZXNzVGhhbihRVF9NSU5PUl9WRVJTSU9O LCA0KTogUU1BS0VfUEtHQ09ORklHX1JFUVVJUkVTICs9IFF0WG1sCiB9CiAKLUNPTkZJRyAtPSB3 YXJuX29uCi0qLWcrKyo6UU1BS0VfQ1hYRkxBR1MgKz0gLVdyZXR1cm4tdHlwZSAtZm5vLXN0cmlj dC1hbGlhc2luZwotCiB1bml4OiFtYWM6Ki1nKysqOlFNQUtFX0NYWEZMQUdTICs9IC1mZnVuY3Rp b24tc2VjdGlvbnMgLWZkYXRhLXNlY3Rpb25zIAogdW5peDohbWFjOiotZysrKjpRTUFLRV9MRkxB R1MgKz0gLVdsLC0tZ2Mtc2VjdGlvbnMKIAotI1FNQUtFX0NYWEZMQUdTICs9IC1XYWxsIC1Xbm8t dW5kZWYgLVduby11bnVzZWQtcGFyYW1ldGVyCi0KIENPTkZJRyhyZWxlYXNlKTohQ09ORklHKFFU RElSX2J1aWxkKSB7CiAgICAgY29udGFpbnMoUVRfQ09ORklHLCByZWR1Y2VfZXhwb3J0cyk6Q09O RklHICs9IGhpZGVfc3ltYm9scwogICAgIHVuaXg6Y29udGFpbnMoUVRfQ09ORklHLCByZWR1Y2Vf cmVsb2NhdGlvbnMpOkNPTkZJRyArPSBic3ltYm9saWNfZnVuY3Rpb25zCg==