27930 2009-08-02 00:52:30 -0700 bugzilla-tool hates Tor Arne Vestbø 2009-08-02 11:06:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned ddkilzer eric vestbo oldest_to_newest 136522 0 abarth 2009-08-02 00:52:30 -0700 abarth@zenque:~/git/webkit$ ./WebKitTools/Scripts/bugzilla-tool land-diff 27866 --no-build Fetching: https://bugs.webkit.org/show_bug.cgi?id=27866&ctype=xml Guessing "Tor Arne Vestbø" as reviewer from attachment 33856 on bug 27866. Traceback (most recent call last): File "./WebKitTools/Scripts/bugzilla-tool", line 663, in <module> main() File "./WebKitTools/Scripts/bugzilla-tool", line 660, in main return tool.main() File "./WebKitTools/Scripts/bugzilla-tool", line 655, in main return command_object.execute(command_options, command_args, self) File "./WebKitTools/Scripts/bugzilla-tool", line 251, in execute self.update_changelogs_with_reviewer(options.reviewer, bug_id, tool) File "./WebKitTools/Scripts/bugzilla-tool", line 245, in update_changelogs_with_reviewer set_reviewer_in_changelog(changelog, reviewer) File "./WebKitTools/Scripts/bugzilla-tool", line 89, in set_reviewer_in_changelog print line.replace("NOBODY (OOPS!)", reviewer), UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 34: ordinal not in range(128) 136551 1 ddkilzer 2009-08-02 06:28:50 -0700 The wisdom of the web says this should fix it: - print line.replace("NOBODY (OOPS!)", reviewer), + print line.replace("NOBODY (OOPS!)", reviewer.encode("utf-8")) 136552 2 33951 ddkilzer 2009-08-02 06:50:53 -0700 Created attachment 33951 Patch v1 Reviewed by NOBODY (OOPS!). * Scripts/bugzilla-tool: (set_reviewer_in_changelog): Made sure reviewer is properly encoded when calling replace(). --- 2 files changed, 11 insertions(+), 1 deletions(-) 136557 3 33951 ddkilzer 2009-08-02 07:27:49 -0700 Comment on attachment 33951 Patch v1 Clearing review flag on attachment: 33951 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r46700 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r46700 = eb267d44bd231e0ebd2bff224253aeef38af6591 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46700 136558 4 ddkilzer 2009-08-02 07:27:54 -0700 All reviewed patches have been landed. Closing bug. 136561 5 eric 2009-08-02 08:00:20 -0700 Does bugzilla 3.0 now have everything encoded as utf8 now? You would think in this modern world we wouldn't have to re-encode everything all the time. ;) 136565 6 ddkilzer 2009-08-02 10:20:48 -0700 (In reply to comment #5) > Does bugzilla 3.0 now have everything encoded as utf8 now? You would think in > this modern world we wouldn't have to re-encode everything all the time. ;) We're using Bugzilla 3.2, and yes, the UTF-8 encoding option is enabled for bugs.webkit.org. The other thing I just realized is that I landed the patch with "old" version of this tool, and it worked just fine. Maybe it's related to Adam's local setup? 136566 7 abarth 2009-08-02 10:22:48 -0700 (In reply to comment #6) > The other thing I just realized is that I landed the patch with "old" version > of this tool, and it worked just fine. Maybe it's related to Adam's local > setup? It's possible. I just use a mac. Maybe the system version of python needs an upgrade? 136567 8 eric 2009-08-02 11:06:06 -0700 I've never touched my system version of python, and I've not had trouble. But this change is also fine. :) 33951 2009-08-02 06:50:53 -0700 2009-08-02 07:27:49 -0700 Patch v1 bug-27930-20090802065047.patch text/plain 1206 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZGI0ODgxLi43ZmQ0OWM3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDgt MDIgIERhdmlkIEQuIEtpbHplciAgPGRka2lsemVyQHdlYmtpdC5vcmc+CisKKyAgICAgICAgPGh0 dHA6Ly93ZWJraXQub3JnL2IvMjc5MzA+IGJ1Z3ppbGxhLXRvb2wgaGF0ZXMgVG9yIEFybmUgVmVz dGLDuAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9idWd6aWxsYS10b29sOgorICAgICAgICAoc2V0X3Jldmlld2VyX2luX2NoYW5nZWxv Zyk6IE1hZGUgc3VyZSByZXZpZXdlciBpcyBwcm9wZXJseQorICAgICAgICBlbmNvZGVkIHdoZW4g Y2FsbGluZyByZXBsYWNlKCkuCisKIDIwMDktMDgtMDIgIEtldmluIE9sbGl2aWVyICA8a2V2aW5v QHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wgYi9XZWJLaXRUb29s cy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKaW5kZXggMmU3ZWIwYS4uNDdlNjdlYyAxMDA3NTUKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvYnVnemlsbGEtdG9vbApAQCAtODYsNyArODYsNyBAQCBkZWYgbGF0ZXN0X2NoYW5nZWxv Z19lbnRyeShjaGFuZ2Vsb2dfcGF0aCk6CiBkZWYgc2V0X3Jldmlld2VyX2luX2NoYW5nZWxvZyhj aGFuZ2Vsb2dfcGF0aCwgcmV2aWV3ZXIpOgogICAgICMgaW5wbGFjZT0xIGNyZWF0ZXMgYSBiYWNr dXAgZmlsZSBhbmQgcmUtZGlyZWN0cyBzdGRvdXQgdG8gdGhlIGZpbGUKICAgICBmb3IgbGluZSBp biBmaWxlaW5wdXQuRmlsZUlucHV0KGNoYW5nZWxvZ19wYXRoLCBpbnBsYWNlPTEpOgotICAgICAg ICBwcmludCBsaW5lLnJlcGxhY2UoIk5PQk9EWSAoT09QUyEpIiwgcmV2aWV3ZXIpLAorICAgICAg ICBwcmludCBsaW5lLnJlcGxhY2UoIk5PQk9EWSAoT09QUyEpIiwgcmV2aWV3ZXIuZW5jb2RlKCJ1 dGYtOCIpKQogCiBkZWYgbW9kaWZpZWRfY2hhbmdlbG9ncyhzY20pOgogICAgIGNoYW5nZWxvZ19w YXRocyA9IFtd