27929 2009-08-02 00:23:52 -0700 [Gtk] macros in webkit.m4 should be defined once only 2009-08-05 04:41:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo jmalonzo xan.lopez oldest_to_newest 136515 0 jmalonzo 2009-08-02 00:23:52 -0700 Macros like WEBKIT_INIT, WEBKIT_CHECK_DEPENDENCIES, etc... should be defined once only as they're not meant to be called multiple times. 136517 1 33946 jmalonzo 2009-08-02 00:28:15 -0700 Created attachment 33946 Patch v1 136569 2 33946 eric 2009-08-02 15:08:02 -0700 Comment on attachment 33946 Patch v1 Just gonna trust you here. rs=me. 136610 3 jmalonzo 2009-08-03 03:50:34 -0700 (In reply to comment #2) > (From update of attachment 33946 [details]) > Just gonna trust you here. rs=me. Thank you. Landed as http://trac.webkit.org/changeset/46714 and 46715. 137275 4 xan.lopez 2009-08-05 01:14:33 -0700 I had to revert this, since it was making us build debug images by default... 137276 5 33946 xan.lopez 2009-08-05 01:14:51 -0700 Comment on attachment 33946 Patch v1 Clearing flags. 137283 6 jmalonzo 2009-08-05 03:35:46 -0700 (In reply to comment #4) > I had to revert this, since it was making us build debug images by default... Without this patch -g still gets passed on my machine. Are you sure it's this patch that made it build debug images? 137284 7 xan.lopez 2009-08-05 03:37:58 -0700 (In reply to comment #6) > (In reply to comment #4) > > I had to revert this, since it was making us build debug images by default... > > Without this patch -g still gets passed on my machine. Are you sure it's this > patch that made it build debug images? Reverting it worked on my machine, but I guess you can never be sure of anything with autotools :) 137286 8 jmalonzo 2009-08-05 04:07:03 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #4) > > > I had to revert this, since it was making us build debug images by default... > > > > Without this patch -g still gets passed on my machine. Are you sure it's this > > patch that made it build debug images? > > Reverting it worked on my machine, but I guess you can never be sure of > anything with autotools :) The issue here seems to be that AC_PROG_CXX gets expanded before we're able to set CXXFLAGS and CFLAGS (AC_PROG_CXX adds "-g -O2" if CXXFLAGS/CFLAGS are not defined). So we need to make sure those flags are set before AC_PROG_CXX is expanded. 137287 9 34126 jmalonzo 2009-08-05 04:24:40 -0700 Created attachment 34126 Patch v1 137288 10 34126 xan.lopez 2009-08-05 04:32:47 -0700 Comment on attachment 34126 Patch v1 OK, makes sense :) 137289 11 jmalonzo 2009-08-05 04:41:08 -0700 (In reply to comment #10) > (From update of attachment 34126 [details]) > OK, makes sense :) Landed as http://trac.webkit.org/changeset/46797. Thanks! 33946 2009-08-02 00:28:15 -0700 2009-08-05 04:24:35 -0700 Patch v1 bug-27929-20090802172810.patch text/plain 1934 jmalonzo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkMjk5YWJkLi5jMGRkMWFk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMDktMDgtMDIgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gbWFj cm9zIGluIHdlYmtpdC5tNCBzaG91bGQgYmUgZGVmaW5lZCBvbmNlIG9ubHkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3OTI5CisKKyAgICAgICAgVGhl IG1hY3JvcyBpbiB3ZWJraXQubTQgYXJlIG5vdCBtZWFudCB0byBiZSBjYWxsZWQgbXVsdGlwbGUg dGltZXMKKyAgICAgICAgc28gd2UnbGwgbWFrZSB0aGVtIEFDX0RFRlVOX09OQ0UuIEFsc28gbWFr ZSBBQ19IRUFERVJfU1REQyBhbmQgQUNfUFJPR19DWFgKKyAgICAgICAgQUNfUkVRVUlSRSB0byBy ZW1vdmUgdGhlIGF1dG9tYWtlIHdhcm5pbmdzIHdoZW4gZG9pbmcgYXV0b2dlbi5zaC4KKworICAg ICAgICAqIGF1dG90b29scy93ZWJraXQubTQ6CisKIDIwMDktMDctMjkgIEFyaXlhIEhpZGF5YXQg IDxhcml5YS5oaWRheWF0QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBI YXVzbWFubi4KZGlmZiAtLWdpdCBhL2F1dG90b29scy93ZWJraXQubTQgYi9hdXRvdG9vbHMvd2Vi a2l0Lm00CmluZGV4IDY1Zjc5MzMuLjc1M2U5YzkgMTAwNjQ0Ci0tLSBhL2F1dG90b29scy93ZWJr aXQubTQKKysrIGIvYXV0b3Rvb2xzL3dlYmtpdC5tNApAQCAtNyw3ICs3LDcgQEAgZG5sIFdlYktp dCBhbmQgSmF2YVNjcmlwdENvcmUgYnVpbGRzLgogbTRfZGVmaW5lKFtpbml0aWFsaXplZF0sIFtu b10pCiAKICMgY2hlY2sgZm9yIHBrZy1jb25maWcKLUFDX0RFRlVOKFtXRUJLSVRfSU5JVF0sCitB Q19ERUZVTl9PTkNFKFtXRUJLSVRfSU5JVF0sCiBbZG5sCiBkbmwgY2hlY2sgaWYgd2UgaGF2ZSB0 aGUgcmVxdWlyZWQgcGFja2FnZXMgdG8gaGF2ZSBzdWNjZXNzZnVsIGNoZWNrcwogZG5sCkBAIC01 NSw3ICs1NSw3IEBAIGZpCiAKIEFNX1BST0dfQ0NfU1REQwogQU1fUFJPR19DQ19DX08KLUFDX1BS T0dfQ1hYCitBQ19SRVFVSVJFKFtBQ19QUk9HX0NYWF0pCiBBQ19QUk9HX0lOU1RBTEwKIEFDX1NZ U19MQVJHRUZJTEUKIApAQCAtNzEsMTMgKzcxLDEzIEBAIEFDX0NfSU5MSU5FCiBBQ19DX1ZPTEFU SUxFCiAKICMgQy9DKysgSGVhZGVycwotQUNfSEVBREVSX1NUREMKK0FDX1JFUVVJUkUoW0FDX0hF QURFUl9TVERDXSkKIEFDX0hFQURFUl9TVERCT09MCiAKIG00X2RlZmluZShbaW5pdGlhbGl6ZWRd LCBbeWVzXSkKIF0pCiAKLUFDX0RFRlVOKFtXRUJLSVRfQ0hFQ0tfREVQRU5ERU5DSUVTXSwKK0FD X0RFRlVOX09OQ0UoW1dFQktJVF9DSEVDS19ERVBFTkRFTkNJRVNdLAogW2RubAogZG5sIGNoZWNr IGZvciBtb2R1bGUgZGVwZW5kZW5jaWVzCiBmb3IgbW9kdWxlIGluICQxCkBAIC05MSw3ICs5MSw3 IEBAIGRvCiBkb25lCiBdKQogCi1BQ19ERUZVTihbX1dFQktJVF9DSEVDS19HTElCXSwKK0FDX0RF RlVOX09OQ0UoW19XRUJLSVRfQ0hFQ0tfR0xJQl0sCiBbZG5sCiBkbmwgY2hlY2sgZm9yIGdsaWIK ICMgVmVyc2lvbiByZXF1aXJlbWVudHMKQEAgLTExNSw3ICsxMTUsNyBAQCBpZiB0ZXN0IC16ICIk R0xJQl9HRU5NQVJTSEFMIiB8fCB0ZXN0IC16ICIkR0xJQl9NS0VOVU1TIjsgdGhlbgogZmkKIF0p CiAKLUFDX0RFRlVOKFtfV0VCS0lUX0NIRUNLX1VOSUNPREVdLAorQUNfREVGVU5fT05DRShbX1dF QktJVF9DSEVDS19VTklDT0RFXSwKIFtkbmwKIGRubCBkZXRlcm1pbmUgdGhlIFVuaWNvZGUgYmFj a2VuZAogQUNfTVNHX0NIRUNLSU5HKFt3aGljaCBVbmljb2RlIGJhY2tlbmQgdG8gdXNlXSk= 34126 2009-08-05 04:24:40 -0700 2009-08-05 04:32:46 -0700 Patch v1 bug-27929-20090805212439.patch text/plain 2899 jmalonzo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmOTcwZWRhLi45M2VlOWI5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMDktMDgtMDUgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gbWFj cm9zIGluIHdlYmtpdC5tNCBzaG91bGQgYmUgZGVmaW5lZCBvbmNlIG9ubHkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3OTI5CisKKyAgICAgICAgVGhl IG1hY3JvcyBpbiB3ZWJraXQubTQgYXJlIG5vdCBtZWFudCB0byBiZSBjYWxsZWQgbXVsdGlwbGUg dGltZXMKKyAgICAgICAgc28gd2UnbGwgbWFrZSB0aGVtIEFDX0RFRlVOX09OQ0UuIEFsc28gbWFr ZSBBQ19IRUFERVJfU1REQyBhbmQgQUNfUFJPR19DWFgKKyAgICAgICAgQUNfUkVRVUlSRSB0byBy ZW1vdmUgdGhlIGF1dG9tYWtlIHdhcm5pbmdzIHdoZW4gZG9pbmcgYXV0b2dlbi5zaC4KKworICAg ICAgICAqIGF1dG90b29scy93ZWJraXQubTQ6CisKIDIwMDktMDgtMDUgIFhhbiBMb3BleiAgPHhs b3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmVydCByNDY3MTQsIGl0IHdhcyBtYWtpbmcg dXMgYnVpbGQgZGVidWcgaW1hZ2VzIGJ5IGRlZmF1bHQuCmRpZmYgLS1naXQgYS9hdXRvdG9vbHMv d2Via2l0Lm00IGIvYXV0b3Rvb2xzL3dlYmtpdC5tNAppbmRleCA2NWY3OTMzLi5lY2U1NGQyIDEw MDY0NAotLS0gYS9hdXRvdG9vbHMvd2Via2l0Lm00CisrKyBiL2F1dG90b29scy93ZWJraXQubTQK QEAgLTYsOCArNiwyMSBAQCBkbmwgV2ViS2l0IGFuZCBKYXZhU2NyaXB0Q29yZSBidWlsZHMuCiAj IGdsb2JhbCBzdGF0ZXMKIG00X2RlZmluZShbaW5pdGlhbGl6ZWRdLCBbbm9dKQogCitBQ19ERUZV TihbQkVGT1JFX0FDX1BST0dfQ1hYXSwKK1tkbmwKKyMgSWYgQ1hYRkxBR1MgYW5kIENGTEFHUyBh cmUgdW5zZXQsIGRlZmF1bHQgdG8gZW1wdHkuCisjIFRoaXMgaXMgdG8gdGVsbCBhdXRvbWFrZSBu b3QgdG8gaW5jbHVkZSAnLWcnIGlmIENYWEZMQUdTIGlzIG5vdCBzZXQKKyMgRm9yIG1vcmUgaW5m byAtIGh0dHA6Ly93d3cuZ251Lm9yZy9zb2Z0d2FyZS9hdXRvbWFrZS9tYW51YWwvYXV0b2NvbmYu aHRtbCNDXzAwMmJfMDAyYi1Db21waWxlcgoraWYgdGVzdCAteiAiJENYWEZMQUdTIjsgdGhlbgor ICAgQ1hYRkxBR1M9IiIKK2ZpCitpZiB0ZXN0IC16ICIkQ0ZMQUdTIjsgdGhlbgorICAgQ0ZMQUdT PSIiCitmaQorXSkKKwogIyBjaGVjayBmb3IgcGtnLWNvbmZpZwotQUNfREVGVU4oW1dFQktJVF9J TklUXSwKK0FDX0RFRlVOX09OQ0UoW1dFQktJVF9JTklUXSwKIFtkbmwKIGRubCBjaGVjayBpZiB3 ZSBoYXZlIHRoZSByZXF1aXJlZCBwYWNrYWdlcyB0byBoYXZlIHN1Y2Nlc3NmdWwgY2hlY2tzCiBk bmwKQEAgLTQzLDE5ICs1NiwxMiBAQCBpZiB0ZXN0IC16ICIkTVYiOyB0aGVuCiAgICBBQ19NU0df RVJST1IoW1lvdSBuZWVkICdtdicgdG8gY29tcGlsZSBXZWJLaXRdKQogZmkKIAotIyBJZiBDWFhG TEFHUyBhbmQgQ0ZMQUdTIGFyZSB1bnNldCwgZGVmYXVsdCB0byBlbXB0eS4KLSMgVGhpcyBpcyB0 byB0ZWxsIGF1dG9tYWtlIG5vdCB0byBpbmNsdWRlICctZycgaWYgQ1hYRkxBR1MgaXMgbm90IHNl dAotIyBGb3IgbW9yZSBpbmZvIC0gaHR0cDovL3d3dy5nbnUub3JnL3NvZnR3YXJlL2F1dG9tYWtl L21hbnVhbC9hdXRvY29uZi5odG1sI0NfMDAyYl8wMDJiLUNvbXBpbGVyCi1pZiB0ZXN0IC16ICIk Q1hYRkxBR1MiOyB0aGVuCi0gICBDWFhGTEFHUz0iIgotZmkKLWlmIHRlc3QgLXogIiRDRkxBR1Mi OyB0aGVuCi0gICBDRkxBR1M9IiIKLWZpCi0KIEFNX1BST0dfQ0NfU1REQwogQU1fUFJPR19DQ19D X08KLUFDX1BST0dfQ1hYCisjIE1ha2Ugc3VyZSBDWFhGTEFHUyBhbmQgQ0ZMQUdTIGFyZSBzZXQg YmVmb3JlIGV4cGFuZGluZyBBQ19QUk9HX0NYWCB0byBhdm9pZAorIyBidWlsZGluZyB3aXRoICct ZyAtTzInIG9uIFJlbGVhc2UgYnVpbGRzLgorQUNfUkVRVUlSRShbQkVGT1JFX0FDX1BST0dfQ1hY XSkKK0FDX1JFUVVJUkUoW0FDX1BST0dfQ1hYXSkKIEFDX1BST0dfSU5TVEFMTAogQUNfU1lTX0xB UkdFRklMRQogCkBAIC03MSwxMyArNzcsMTMgQEAgQUNfQ19JTkxJTkUKIEFDX0NfVk9MQVRJTEUK IAogIyBDL0MrKyBIZWFkZXJzCi1BQ19IRUFERVJfU1REQworQUNfUkVRVUlSRShbQUNfSEVBREVS X1NURENdKQogQUNfSEVBREVSX1NUREJPT0wKIAogbTRfZGVmaW5lKFtpbml0aWFsaXplZF0sIFt5 ZXNdKQogXSkKIAotQUNfREVGVU4oW1dFQktJVF9DSEVDS19ERVBFTkRFTkNJRVNdLAorQUNfREVG VU5fT05DRShbV0VCS0lUX0NIRUNLX0RFUEVOREVOQ0lFU10sCiBbZG5sCiBkbmwgY2hlY2sgZm9y IG1vZHVsZSBkZXBlbmRlbmNpZXMKIGZvciBtb2R1bGUgaW4gJDEKQEAgLTkxLDcgKzk3LDcgQEAg ZG8KIGRvbmUKIF0pCiAKLUFDX0RFRlVOKFtfV0VCS0lUX0NIRUNLX0dMSUJdLAorQUNfREVGVU5f T05DRShbX1dFQktJVF9DSEVDS19HTElCXSwKIFtkbmwKIGRubCBjaGVjayBmb3IgZ2xpYgogIyBW ZXJzaW9uIHJlcXVpcmVtZW50cwpAQCAtMTE1LDcgKzEyMSw3IEBAIGlmIHRlc3QgLXogIiRHTElC X0dFTk1BUlNIQUwiIHx8IHRlc3QgLXogIiRHTElCX01LRU5VTVMiOyB0aGVuCiBmaQogXSkKIAot QUNfREVGVU4oW19XRUJLSVRfQ0hFQ0tfVU5JQ09ERV0sCitBQ19ERUZVTl9PTkNFKFtfV0VCS0lU X0NIRUNLX1VOSUNPREVdLAogW2RubAogZG5sIGRldGVybWluZSB0aGUgVW5pY29kZSBiYWNrZW5k CiBBQ19NU0dfQ0hFQ0tJTkcoW3doaWNoIFVuaWNvZGUgYmFja2VuZCB0byB1c2VdKQ==