27924 2009-08-01 12:58:56 -0700 Need to test throwing exceptions from Workers after calling close() 2009-08-05 22:19:51 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson abarth oldest_to_newest 136477 0 atwilson 2009-08-01 12:58:56 -0700 After we call close(), any exceptions thrown from Worker context should still be propagated back to page context via the Worker.onerror handler. This seems to work properly, but we should add a layout test to confirm this. 136481 1 33940 atwilson 2009-08-01 13:05:41 -0700 Created attachment 33940 patch containing layout test Patch only contains layout tests, since the code seems to work as-is. 136900 2 33940 levin 2009-08-03 23:13:29 -0700 Comment on attachment 33940 patch containing layout test Just a few minor things to consider or address which will make it possible to land this easily > diff --git a/LayoutTests/fast/workers/resources/worker-close.js b/LayoutTests/fast/workers/resources/worker-close.js > @@ -22,6 +22,9 @@ onmessage = function(evt) > postMessage("pong"); > } else if (evt.data == "throw") { > throw "should never be executed"; > + } else if (evt.data == "closeWithError") { > + close(); > + generateError(); // Undefined function - throws exception Even time I see this I want to look for the generateError function. Just an idea but what do you think about calling it nonExistantFunction(); > diff --git a/LayoutTests/fast/workers/worker-close.html b/LayoutTests/fast/workers/worker-close.html > + // Test that errors are delivered after close Please end with "." > + worker = new Worker('resources/worker-close.js'); > + worker.postMessage("closeWithError"); > + worker.onerror = function(event) { > + log("PASS: Error arrived after close: " + event.message); > + testPendingEvents(); > + return false; Indentation is off. > + } > +} 137075 3 34077 atwilson 2009-08-04 11:43:15 -0700 Created attachment 34077 Patch addressing levin's comments That indentation error was due to a tab somehow getting into the code. Weird. Maybe I used vi to edit a file inadvertently... 137515 4 34077 abarth 2009-08-05 22:19:47 -0700 Comment on attachment 34077 Patch addressing levin's comments Clearing review flag on attachment: 34077 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/workers/resources/worker-close.js M LayoutTests/fast/workers/worker-close-expected.txt M LayoutTests/fast/workers/worker-close.html Committed r46830 M LayoutTests/ChangeLog M LayoutTests/fast/workers/worker-close.html M LayoutTests/fast/workers/worker-close-expected.txt M LayoutTests/fast/workers/resources/worker-close.js r46830 = 515c284335367a97d1e0796b7395e6c92eeaea89 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46830 137516 5 abarth 2009-08-05 22:19:51 -0700 All reviewed patches have been landed. Closing bug. 33940 2009-08-01 13:05:41 -0700 2009-08-04 11:43:15 -0700 patch containing layout test x text/plain 3000 atwilson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OGEwMWExLi4yMTQ2MmNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgt MDEgIERyZXcgV2lsc29uICA8YXR3aWxzb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIHRvIHRlc3QgdGhyb3dpbmcgZXhj ZXB0aW9ucyBmcm9tIFdvcmtlcnMgYWZ0ZXIgY2FsbGluZyBjbG9zZSgpLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5MjQKKworICAgICAgICAqIGZh c3Qvd29ya2Vycy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzOgorICAgICAgICAqIGZhc3Qvd29y a2Vycy93b3JrZXItY2xvc2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3Qvd29ya2Vycy93 b3JrZXItY2xvc2UuaHRtbDoKKwogMjAwOS0wNy0zMCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvcmVzb3VyY2VzL3dvcmtlci1jbG9zZS5q cyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzCmlu ZGV4IDFiMDRiMDUuLjAzMjI3OGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vy cy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vy cy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzCkBAIC0yMiw2ICsyMiw5IEBAIG9ubWVzc2FnZSA9 IGZ1bmN0aW9uKGV2dCkKICAgICAgICAgcG9zdE1lc3NhZ2UoInBvbmciKTsKICAgICB9IGVsc2Ug aWYgKGV2dC5kYXRhID09ICJ0aHJvdyIpIHsKICAgICAgICAgdGhyb3cgInNob3VsZCBuZXZlciBi ZSBleGVjdXRlZCI7CisgICAgfSBlbHNlIGlmIChldnQuZGF0YSA9PSAiY2xvc2VXaXRoRXJyb3Ii KSB7CisgICAgICAgIGNsb3NlKCk7CisgICAgICAgIGdlbmVyYXRlRXJyb3IoKTsgIC8vIFVuZGVm aW5lZCBmdW5jdGlvbiAtIHRocm93cyBleGNlcHRpb24KICAgICB9IGVsc2UgewogICAgICAgICBw b3N0TWVzc2FnZSgiRkFJTDogVW5rbm93biBtZXNzYWdlIHR5cGU6ICIgKyBldnQuZGF0YSk7CiAg ICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1jbG9zZS1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLWV4cGVj dGVkLnR4dAppbmRleCBjZGY0MGM4Li5mMGU4MmZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9m YXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLWV4cGVjdGVkLnR4dApAQCAtMyw2ICszLDcgQEAgVGVz dCBXb3JrZXJDb250ZXh0LmNsb3NlIGZ1bmN0aW9uYWxpdHkuIFNob3VsZCBwcmludCBhIHNlcmll cyBvZiBQQVNTIG1lc3NhZ2VzLAogUEFTUzogdHlwZW9mIGNsb3NlOiBmdW5jdGlvbgogUEFTUzog cmVjZWl2ZWQgbWVzc2FnZSBiZWZvcmUgY2xvc2UKIFBBU1M6IG1lc3NhZ2VzIHNlbnQgYWZ0ZXIg Y2xvc2UoKSBhcmUgaWdub3JlZAorUEFTUzogRXJyb3IgYXJyaXZlZCBhZnRlciBjbG9zZTogUmVm ZXJlbmNlRXJyb3I6IENhbid0IGZpbmQgdmFyaWFibGU6IGdlbmVyYXRlRXJyb3IKIFBBU1M6IGNs b3NlKCkgZGlkIG5vdCBkaXNwYXRjaCBwZW5kaW5nIGV2ZW50cwogRE9ORQogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLmh0bWwKaW5kZXggOWQ2MGI4Yi4uYzhjY2Y3NiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1jbG9zZS5odG1sCisr KyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItY2xvc2UuaHRtbApAQCAtNTEsMTMg KzUxLDI0IEBAIGZ1bmN0aW9uIHRlc3RNZXNzYWdlQWZ0ZXJDbG9zZShldnQpIHsKICAgICAgICAg bG9nKCJGQUlMOiBtZXNzYWdlIGRlbGl2ZXJlZCBhZnRlciBjbG9zZSgpOiAiICsgZXZ0Lm1lc3Nh Z2UpOwogICAgICAgICBkb25lKCk7CiAgICAgfQotICAgIHRpbWVvdXQgPSBzZXRUaW1lb3V0KHRl c3RQZW5kaW5nRXZlbnRzLCAxMDAwKTsKKyAgICB0aW1lb3V0ID0gc2V0VGltZW91dCh0ZXN0RXJy b3JBZnRlckNsb3NlLCAxMDAwKTsKIH0KIAotZnVuY3Rpb24gdGVzdFBlbmRpbmdFdmVudHMoKQor ZnVuY3Rpb24gdGVzdEVycm9yQWZ0ZXJDbG9zZSgpCiB7CiAgICAgbG9nKCJQQVNTOiBtZXNzYWdl cyBzZW50IGFmdGVyIGNsb3NlKCkgYXJlIGlnbm9yZWQiKTsKKyAgICAvLyBUZXN0IHRoYXQgZXJy b3JzIGFyZSBkZWxpdmVyZWQgYWZ0ZXIgY2xvc2UKKyAgICB3b3JrZXIgPSBuZXcgV29ya2VyKCdy ZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzJyk7CisgICAgd29ya2VyLnBvc3RNZXNzYWdlKCJjbG9z ZVdpdGhFcnJvciIpOworICAgIHdvcmtlci5vbmVycm9yID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAg ICAgICAgbG9nKCJQQVNTOiBFcnJvciBhcnJpdmVkIGFmdGVyIGNsb3NlOiAiICsgZXZlbnQubWVz c2FnZSk7CisgICAgICAgIHRlc3RQZW5kaW5nRXZlbnRzKCk7CisJcmV0dXJuIGZhbHNlOworICAg IH0KK30KIAorZnVuY3Rpb24gdGVzdFBlbmRpbmdFdmVudHMoKQorewogICAgIC8vIE5vdyB0ZXN0 IHRoYXQgd29ya2VycyBkbyBub3QgZGVsaXZlciBwZW5kaW5nIGV2ZW50cwogICAgIHdvcmtlciA9 IG5ldyBXb3JrZXIoJ3Jlc291cmNlcy93b3JrZXItY2xvc2UuanMnKTsKICAgICB3b3JrZXIucG9z dE1lc3NhZ2UoImNsb3NlV2l0aFBlbmRpbmdFdmVudHMiKTsK 34077 2009-08-04 11:43:15 -0700 2009-08-05 22:19:47 -0700 Patch addressing levin's comments x text/plain 3020 atwilson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OGEwMWExLi4yMTQ2MmNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgt MDEgIERyZXcgV2lsc29uICA8YXR3aWxzb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIHRvIHRlc3QgdGhyb3dpbmcgZXhj ZXB0aW9ucyBmcm9tIFdvcmtlcnMgYWZ0ZXIgY2FsbGluZyBjbG9zZSgpLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc5MjQKKworICAgICAgICAqIGZh c3Qvd29ya2Vycy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzOgorICAgICAgICAqIGZhc3Qvd29y a2Vycy93b3JrZXItY2xvc2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3Qvd29ya2Vycy93 b3JrZXItY2xvc2UuaHRtbDoKKwogMjAwOS0wNy0zMCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvcmVzb3VyY2VzL3dvcmtlci1jbG9zZS5q cyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzCmlu ZGV4IDFiMDRiMDUuLmE0NzQxNTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vy cy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vy cy9yZXNvdXJjZXMvd29ya2VyLWNsb3NlLmpzCkBAIC0yMiw2ICsyMiw5IEBAIG9ubWVzc2FnZSA9 IGZ1bmN0aW9uKGV2dCkKICAgICAgICAgcG9zdE1lc3NhZ2UoInBvbmciKTsKICAgICB9IGVsc2Ug aWYgKGV2dC5kYXRhID09ICJ0aHJvdyIpIHsKICAgICAgICAgdGhyb3cgInNob3VsZCBuZXZlciBi ZSBleGVjdXRlZCI7CisgICAgfSBlbHNlIGlmIChldnQuZGF0YSA9PSAiY2xvc2VXaXRoRXJyb3Ii KSB7CisgICAgICAgIGNsb3NlKCk7CisgICAgICAgIG5vbkV4aXN0ZW50RnVuY3Rpb24oKTsgIC8v IFVuZGVmaW5lZCBmdW5jdGlvbiAtIHRocm93cyBleGNlcHRpb24KICAgICB9IGVsc2UgewogICAg ICAgICBwb3N0TWVzc2FnZSgiRkFJTDogVW5rbm93biBtZXNzYWdlIHR5cGU6ICIgKyBldnQuZGF0 YSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1j bG9zZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3Nl LWV4cGVjdGVkLnR4dAppbmRleCBjZGY0MGM4Li43NmZiY2FmIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLWV4cGVjdGVkLnR4dApAQCAtMyw2ICszLDcg QEAgVGVzdCBXb3JrZXJDb250ZXh0LmNsb3NlIGZ1bmN0aW9uYWxpdHkuIFNob3VsZCBwcmludCBh IHNlcmllcyBvZiBQQVNTIG1lc3NhZ2VzLAogUEFTUzogdHlwZW9mIGNsb3NlOiBmdW5jdGlvbgog UEFTUzogcmVjZWl2ZWQgbWVzc2FnZSBiZWZvcmUgY2xvc2UKIFBBU1M6IG1lc3NhZ2VzIHNlbnQg YWZ0ZXIgY2xvc2UoKSBhcmUgaWdub3JlZAorUEFTUzogRXJyb3IgYXJyaXZlZCBhZnRlciBjbG9z ZTogUmVmZXJlbmNlRXJyb3I6IENhbid0IGZpbmQgdmFyaWFibGU6IG5vbkV4aXN0ZW50RnVuY3Rp b24KIFBBU1M6IGNsb3NlKCkgZGlkIG5vdCBkaXNwYXRjaCBwZW5kaW5nIGV2ZW50cwogRE9ORQog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLmh0bWwKaW5kZXggOWQ2MGI4 Yi4uZmQ4ZGZkOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1j bG9zZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItY2xvc2UuaHRt bApAQCAtNTEsMTMgKzUxLDI0IEBAIGZ1bmN0aW9uIHRlc3RNZXNzYWdlQWZ0ZXJDbG9zZShldnQp IHsKICAgICAgICAgbG9nKCJGQUlMOiBtZXNzYWdlIGRlbGl2ZXJlZCBhZnRlciBjbG9zZSgpOiAi ICsgZXZ0Lm1lc3NhZ2UpOwogICAgICAgICBkb25lKCk7CiAgICAgfQotICAgIHRpbWVvdXQgPSBz ZXRUaW1lb3V0KHRlc3RQZW5kaW5nRXZlbnRzLCAxMDAwKTsKKyAgICB0aW1lb3V0ID0gc2V0VGlt ZW91dCh0ZXN0RXJyb3JBZnRlckNsb3NlLCAxMDAwKTsKIH0KIAotZnVuY3Rpb24gdGVzdFBlbmRp bmdFdmVudHMoKQorZnVuY3Rpb24gdGVzdEVycm9yQWZ0ZXJDbG9zZSgpCiB7CiAgICAgbG9nKCJQ QVNTOiBtZXNzYWdlcyBzZW50IGFmdGVyIGNsb3NlKCkgYXJlIGlnbm9yZWQiKTsKKyAgICAvLyBU ZXN0IHRoYXQgZXJyb3JzIGFyZSBkZWxpdmVyZWQgYWZ0ZXIgY2xvc2UuCisgICAgd29ya2VyID0g bmV3IFdvcmtlcigncmVzb3VyY2VzL3dvcmtlci1jbG9zZS5qcycpOworICAgIHdvcmtlci5wb3N0 TWVzc2FnZSgiY2xvc2VXaXRoRXJyb3IiKTsKKyAgICB3b3JrZXIub25lcnJvciA9IGZ1bmN0aW9u KGV2ZW50KSB7CisgICAgICAgIGxvZygiUEFTUzogRXJyb3IgYXJyaXZlZCBhZnRlciBjbG9zZTog IiArIGV2ZW50Lm1lc3NhZ2UpOworICAgICAgICB0ZXN0UGVuZGluZ0V2ZW50cygpOworICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgfQorfQogCitmdW5jdGlvbiB0ZXN0UGVuZGluZ0V2ZW50cygp Cit7CiAgICAgLy8gTm93IHRlc3QgdGhhdCB3b3JrZXJzIGRvIG5vdCBkZWxpdmVyIHBlbmRpbmcg ZXZlbnRzCiAgICAgd29ya2VyID0gbmV3IFdvcmtlcigncmVzb3VyY2VzL3dvcmtlci1jbG9zZS5q cycpOwogICAgIHdvcmtlci5wb3N0TWVzc2FnZSgiY2xvc2VXaXRoUGVuZGluZ0V2ZW50cyIpOwo=