27920 2009-08-01 02:04:12 -0700 Right click on timeline of media controls panel cause seek 2009-08-11 22:14:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hclam webkit-unassigned ajwong eric.carlson levin simon.fraser oldest_to_newest 136435 0 hclam 2009-08-01 02:04:12 -0700 Steps to reproduce the bug: 1. Open a page with <video controls src="something"></video> 2. Play the movie 3. Right click on the time bar Expected behavior: Nothing should happen Actual behavior: Seeked to the current playback position. So the result is that if you right click many many times, you will seek to the current playback position over and over again. 136437 1 33934 hclam 2009-08-01 02:50:58 -0700 Created attachment 33934 patch 137704 2 33934 eric 2009-08-06 18:03:14 -0700 Comment on attachment 33934 patch Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes 137705 3 33934 eric 2009-08-06 18:03:14 -0700 Comment on attachment 33934 patch Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes 137822 4 34256 hclam 2009-08-07 01:10:34 -0700 Created attachment 34256 patch 137823 5 34257 hclam 2009-08-07 01:13:09 -0700 Created attachment 34257 patch 137907 6 34257 eric 2009-08-07 08:51:41 -0700 Comment on attachment 34257 patch LGTM! Thanks! 137986 7 hclam 2009-08-07 11:13:27 -0700 Thanks for the review! 138169 8 ajwong 2009-08-07 14:48:48 -0700 Committed as http://trac.webkit.org/changeset/46915. 139224 9 simon.fraser 2009-08-11 21:33:58 -0700 This caused a bad regression in mouse handling (bug 28211). Please address as soon as possible, or revert this change. 139231 10 hclam 2009-08-11 22:14:04 -0700 I'm looking into the regression now. 33934 2009-08-01 02:50:58 -0700 2009-08-07 01:10:34 -0700 patch fix-controls-rightclick text/plain 4382 hclam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjY2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMDEgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSaWdo dCBjbGljayBvbiB0aW1lbGluZSBvZiBtZWRpYSBjb250cm9scyBwYW5lbCBjYXVzZSBzZWVrCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzkyMAorCisg ICAgICAgIEZpeCB0aGUgYnVnIG9mIHVud2FudGVkIHNlZWsgd2hlbiByaWdodCBjbGlja2luZyBv biB0aGUgdGltZWJhcgorICAgICAgICBvZiBtZWRpYSBjb250cm9scy4gVGhlIGNoYW5nZSBpbmhp Yml0cyBhY3Rpb25zIGlmIG1vdXNlIGV2ZW50cworICAgICAgICBhcmUgbm90IGZyb20gdGhlIGxl ZnQgYnV0dG9uLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL2NvbnRyb2xzLXJpZ2h0LWNsaWNrLW9u LXRpbWViYXIuaHRtbAorCisgICAgICAgICogY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3M6 CisgICAgICAgICogcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cik6CisKIDIwMDktMDgtMDEgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9yZW5kZXJp bmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVy aW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAkocmV2aXNpb24gNDYzNDYpCisrKyBXZWJDb3Jl L3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4 Miw2ICs0ODIsOSBAQCBNZWRpYUNvbnRyb2xUaW1lbGluZUVsZW1lbnQ6Ok1lZGlhQ29udHJvCiAK IHZvaWQgTWVkaWFDb250cm9sVGltZWxpbmVFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2 ZW50KiBldmVudCkKIHsKKyAgICBpZiAoIWV2ZW50LT5pc01vdXNlRXZlbnQoKSB8fCBzdGF0aWNf Y2FzdDxNb3VzZUV2ZW50Kj4oZXZlbnQpLT5idXR0b24oKSkKKyAgICAgICAgcmV0dXJuOworCiAg ICAgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLm1vdXNlZG93bkV2ZW50KQogICAg ICAgICBtX21lZGlhRWxlbWVudC0+YmVnaW5TY3J1YmJpbmcoKTsKIApJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gNDY2NjgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNiBAQAorMjAwOS0wOC0wMSAgQWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJpZ2h0IGNs aWNrIG9uIHRpbWVsaW5lIG9mIG1lZGlhIGNvbnRyb2xzIHBhbmVsIGNhdXNlIHNlZWsKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3OTIwCisKKyAgICAg ICAgQWRkIGEgdGVzdCBzaW11bGF0ZSB0aGUgYmVoYXZpb3Igb2Ygc2Vla2luZyBieSByaWdodCBj bGlja2luZworICAgICAgICBvbiB0aGUgdGltZSBiYXIgb2YgbWVkaWEgY29udHJvbHMgd2hpbGUg cGxheWluZy4KKworICAgICAgICAqIG1lZGlhL2NvbnRyb2xzLXJpZ2h0LWNsaWNrLW9uLXRpbWVi YXItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS9jb250cm9scy1yaWdodC1j bGljay1vbi10aW1lYmFyLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA4LTAxICBFdmFuIE1hcnRpbiAg PGV2YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCklu ZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy1yaWdodC1jbGljay1vbi10aW1lYmFyLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy1yaWdo dC1jbGljay1vbi10aW1lYmFyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL21lZGlhL2NvbnRyb2xzLXJpZ2h0LWNsaWNrLW9uLXRpbWViYXItZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDcgQEAKK1Rlc3QgdGhhdCByaWdodCBjbGlja2luZyBvbiB0 aGUgdGltZWJhciBkb2VzIG5vdCBjYXVzZSBhIHNlZWsuCisKK1JVTih2aWRlby5hdXRvcGxheSA9 IHRydWUpCitSVU4odmlkZW8uc3JjID0gJ2NvbnRlbnQvdGVzdC5tcDQnKQorRVZFTlQocGxheWlu ZykKK0VORCBPRiBURVNUCisKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL2NvbnRyb2xzLXJpZ2h0 LWNsaWNrLW9uLXRpbWViYXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9j b250cm9scy1yaWdodC1jbGljay1vbi10aW1lYmFyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9tZWRpYS9jb250cm9scy1yaWdodC1jbGljay1vbi10aW1lYmFyLmh0bWwJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsNDYgQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8dGl0 bGU+cmlnaHQgY2xpY2sgb24gdGltZWJhciB0ZXN0PC90aXRsZT4KKyAgICAgICAgPHNjcmlwdCBz cmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgICAgICBmdW5jdGlvbiBjbGlj aygpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRl cikKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgIHZhciB4ID0gdmlkZW8u b2Zmc2V0TGVmdCArIHZpZGVvLm9mZnNldFdpZHRoIC8gMjsKKyAgICAgICAgICAgICAgICAgICAg dmFyIHkgPSB2aWRlby5vZmZzZXRUb3AgKyB2aWRlby5vZmZzZXRIZWlnaHQgLSAxMDsKKyAgICAg ICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7CisgICAgICAgICAg ICAgICAgICAgIGV2ZW50U2VuZGVyLmNvbnRleHRDbGljaygpOworICAgICAgICAgICAgICAgIH0K KyAgICAgICAgICAgICAgICB3aW5kb3cuc2V0VGltZW91dCgiZW5kVGVzdCgpIiwgMjAwKTsKKyAg ICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gcGxheWluZygpCisgICAgICAgICAg ICB7CisgICAgICAgICAgICAgICAgd2luZG93LnNldFRpbWVvdXQoImNsaWNrKCkiLCAxMDApOwor ICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBzZWVrZWQoKQorICAgICAgICAg ICAgeworICAgICAgICAgICAgICAgIGZhaWxUZXN0KCJTaG91bGQgbm90IHNlZWsuIik7CisgICAg ICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkKKyAgICAgICAgICAgIHsK KyAgICAgICAgICAgICAgICBmaW5kTWVkaWFFbGVtZW50KCk7CisgICAgICAgICAgICAgICAgd2Fp dEZvckV2ZW50KCdwbGF5aW5nJywgcGxheWluZyk7CisgICAgICAgICAgICAgICAgd2FpdEZvckV2 ZW50KCdzZWVrZWQnLCBzZWVrZWQpOworICAgICAgICAgICAgICAgIHJ1bigidmlkZW8uYXV0b3Bs YXkgPSB0cnVlIik7CisgICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5zcmMgPSAnY29udGVudC90 ZXN0Lm1wNCciKTsKKyAgICAgICAgICAgIH0gICAgCisgICAgICAgIDwvc2NyaXB0PgorICAgIDwv aGVhZD4KKworICAgIDxib2R5IG9ubG9hZD0ic3RhcnQoKSI+CisgICAgPHA+VGVzdCB0aGF0IHJp Z2h0IGNsaWNraW5nIG9uIHRoZSB0aW1lYmFyIGRvZXMgbm90IGNhdXNlIGEgc2Vlay48L3A+Cisg ICAgPHZpZGVvIGNvbnRyb2xzPjwvdmlkZW8+CisgICAgPC9ib2R5PgorPC9odG1sPgo= 34256 2009-08-07 01:10:34 -0700 2009-08-07 01:13:09 -0700 patch fix-controls-rightclick text/plain 4427 hclam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjY2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMDEgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSaWdo dCBjbGljayBvbiB0aW1lbGluZSBvZiBtZWRpYSBjb250cm9scyBwYW5lbCBjYXVzZSBzZWVrCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzkyMAorCisg ICAgICAgIEZpeCB0aGUgYnVnIG9mIHVud2FudGVkIHNlZWsgd2hlbiByaWdodCBjbGlja2luZyBv biB0aGUgdGltZWJhcgorICAgICAgICBvZiBtZWRpYSBjb250cm9scy4gVGhlIGNoYW5nZSBpbmhp Yml0cyBhY3Rpb25zIGlmIG1vdXNlIGV2ZW50cworICAgICAgICBhcmUgbm90IGZyb20gdGhlIGxl ZnQgYnV0dG9uLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL2NvbnRyb2xzLXJpZ2h0LWNsaWNrLW9u LXRpbWViYXIuaHRtbAorCisgICAgICAgICogY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3M6 CisgICAgICAgICogcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cik6CisKIDIwMDktMDgtMDEgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9yZW5kZXJp bmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVy aW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAkocmV2aXNpb24gNDYzNDYpCisrKyBXZWJDb3Jl L3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4 Miw2ICs0ODIsMTAgQEAgTWVkaWFDb250cm9sVGltZWxpbmVFbGVtZW50OjpNZWRpYUNvbnRybwog CiB2b2lkIE1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihF dmVudCogZXZlbnQpCiB7CisgICAgLy8gTGVmdCBidXR0b24gaXMgMC4gQWNjZXB0cyBvbmx5IGlm IG1vdXNlIGV2ZW50IGlzIGZyb20gbGVmdCBidXR0b24uCisgICAgaWYgKCFldmVudC0+aXNNb3Vz ZUV2ZW50KCkgfHwgc3RhdGljX2Nhc3Q8TW91c2VFdmVudCo+KGV2ZW50KS0+YnV0dG9uKCkpCisg ICAgICAgIHJldHVybjsKKwogICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5t b3VzZWRvd25FdmVudCkKICAgICAgICAgbV9tZWRpYUVsZW1lbnQtPmJlZ2luU2NydWJiaW5nKCk7 CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjY4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMDEgIEFscGhhIExhbSAgPGhj bGFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSaWdodCBjbGljayBvbiB0aW1lbGluZSBvZiBtZWRpYSBjb250cm9scyBwYW5l bCBjYXVzZSBzZWVrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNzkyMAorCisgICAgICAgIEFkZCBhIHRlc3Qgc2ltdWxhdGUgdGhlIGJlaGF2aW9yIG9m IHNlZWtpbmcgYnkgcmlnaHQgY2xpY2tpbmcKKyAgICAgICAgb24gdGhlIHRpbWUgYmFyIG9mIG1l ZGlhIGNvbnRyb2xzIHdoaWxlIHBsYXlpbmcuCisKKyAgICAgICAgKiBtZWRpYS9jb250cm9scy1y aWdodC1jbGljay1vbi10aW1lYmFyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVk aWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24tdGltZWJhci5odG1sOiBBZGRlZC4KKwogMjAwOS0w OC0wMSAgRXZhbiBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtcmlnaHQt Y2xpY2stb24tdGltZWJhci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv bWVkaWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24tdGltZWJhci1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy1yaWdodC1jbGljay1vbi10aW1l YmFyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3IEBACitUZXN0IHRoYXQg cmlnaHQgY2xpY2tpbmcgb24gdGhlIHRpbWViYXIgZG9lcyBub3QgY2F1c2UgYSBzZWVrLgorCitS VU4odmlkZW8uYXV0b3BsYXkgPSB0cnVlKQorUlVOKHZpZGVvLnNyYyA9ICdjb250ZW50L3Rlc3Qu bXA0JykKK0VWRU5UKHBsYXlpbmcpCitFTkQgT0YgVEVTVAorCkluZGV4OiBMYXlvdXRUZXN0cy9t ZWRpYS9jb250cm9scy1yaWdodC1jbGljay1vbi10aW1lYmFyLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24tdGltZWJhci5odG1sCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24t dGltZWJhci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ1IEBACis8aHRtbD4KKyAgICA8 aGVhZD4KKyAgICAgICAgPHRpdGxlPnJpZ2h0IGNsaWNrIG9uIHRpbWViYXIgdGVzdDwvdGl0bGU+ CisgICAgICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CisgICAgICAgIDxz Y3JpcHQ+CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg ICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgICAg ICAgICAgZnVuY3Rpb24gY2xpY2soKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlm ICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgICAgICAgICAgICAgdmFyIHggPSB2aWRl by5vZmZzZXRMZWZ0ICsgdmlkZW8ub2Zmc2V0V2lkdGggLyAyOworICAgICAgICAgICAgICAgICAg ICB2YXIgeSA9IHZpZGVvLm9mZnNldFRvcCArIHZpZGVvLm9mZnNldEhlaWdodCAtIDEwOworICAg ICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4LCB5KTsKKyAgICAgICAg ICAgICAgICAgICAgZXZlbnRTZW5kZXIuY29udGV4dENsaWNrKCk7CisgICAgICAgICAgICAgICAg fQorICAgICAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KCJlbmRUZXN0KCkiLCAyMDApOwor CSAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHBsYXlpbmcoKQorCSAgICB7CisgICAgICAg ICAgICAgICAgd2luZG93LnNldFRpbWVvdXQoImNsaWNrKCkiLCAxMDApOworICAgICAgICAgICAg fQorCisgICAgICAgICAgICBmdW5jdGlvbiBzZWVrZWQoKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgIGZhaWxUZXN0KCJTaG91bGQgbm90IHNlZWsuIik7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAg ICAgICBmaW5kTWVkaWFFbGVtZW50KCk7CisgICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50KCdw bGF5aW5nJywgcGxheWluZyk7CisgICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50KCdzZWVrZWQn LCBzZWVrZWQpOworICAgICAgICAgICAgICAgIHJ1bigidmlkZW8uYXV0b3BsYXkgPSB0cnVlIik7 CisgICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5zcmMgPSAnY29udGVudC90ZXN0Lm1wNCciKTsK KyAgICAgICAgICAgIH0gICAgCisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKworICAg IDxib2R5IG9ubG9hZD0ic3RhcnQoKSI+CisgICAgPHA+VGVzdCB0aGF0IHJpZ2h0IGNsaWNraW5n IG9uIHRoZSB0aW1lYmFyIGRvZXMgbm90IGNhdXNlIGEgc2Vlay48L3A+CisgICAgPHZpZGVvIGNv bnRyb2xzPjwvdmlkZW8+CisgICAgPC9ib2R5PgorPC9odG1sPgo= 34257 2009-08-07 01:13:09 -0700 2009-08-07 08:51:41 -0700 patch fix-controls-rightclick text/plain 4441 hclam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjY2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMDEgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSaWdo dCBjbGljayBvbiB0aW1lbGluZSBvZiBtZWRpYSBjb250cm9scyBwYW5lbCBjYXVzZSBzZWVrCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzkyMAorCisg ICAgICAgIEZpeCB0aGUgYnVnIG9mIHVud2FudGVkIHNlZWsgd2hlbiByaWdodCBjbGlja2luZyBv biB0aGUgdGltZWJhcgorICAgICAgICBvZiBtZWRpYSBjb250cm9scy4gVGhlIGNoYW5nZSBpbmhp Yml0cyBhY3Rpb25zIGlmIG1vdXNlIGV2ZW50cworICAgICAgICBhcmUgbm90IGZyb20gdGhlIGxl ZnQgYnV0dG9uLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL2NvbnRyb2xzLXJpZ2h0LWNsaWNrLW9u LXRpbWViYXIuaHRtbAorCisgICAgICAgICogY3NzL21lZGlhQ29udHJvbHNDaHJvbWl1bS5jc3M6 CisgICAgICAgICogcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl cik6CisKIDIwMDktMDgtMDEgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9yZW5kZXJp bmcvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVy aW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAkocmV2aXNpb24gNDYzNDYpCisrKyBXZWJDb3Jl L3JlbmRlcmluZy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4 Miw2ICs0ODIsMTAgQEAgTWVkaWFDb250cm9sVGltZWxpbmVFbGVtZW50OjpNZWRpYUNvbnRybwog CiB2b2lkIE1lZGlhQ29udHJvbFRpbWVsaW5lRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihF dmVudCogZXZlbnQpCiB7CisgICAgLy8gTGVmdCBidXR0b24gaXMgMC4gQWNjZXB0cyBvbmx5IGlm IG1vdXNlIGV2ZW50IGlzIGZyb20gbGVmdCBidXR0b24uCisgICAgaWYgKCFldmVudC0+aXNNb3Vz ZUV2ZW50KCkgfHwgc3RhdGljX2Nhc3Q8TW91c2VFdmVudCo+KGV2ZW50KS0+YnV0dG9uKCkpCisg ICAgICAgIHJldHVybjsKKwogICAgIGlmIChldmVudC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5t b3VzZWRvd25FdmVudCkKICAgICAgICAgbV9tZWRpYUVsZW1lbnQtPmJlZ2luU2NydWJiaW5nKCk7 CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjY4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMDEgIEFscGhhIExhbSAgPGhj bGFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSaWdodCBjbGljayBvbiB0aW1lbGluZSBvZiBtZWRpYSBjb250cm9scyBwYW5l bCBjYXVzZSBzZWVrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNzkyMAorCisgICAgICAgIEFkZCBhIHRlc3Qgc2ltdWxhdGUgdGhlIGJlaGF2aW9yIG9m IHNlZWtpbmcgYnkgcmlnaHQgY2xpY2tpbmcKKyAgICAgICAgb24gdGhlIHRpbWUgYmFyIG9mIG1l ZGlhIGNvbnRyb2xzIHdoaWxlIHBsYXlpbmcuCisKKyAgICAgICAgKiBtZWRpYS9jb250cm9scy1y aWdodC1jbGljay1vbi10aW1lYmFyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVk aWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24tdGltZWJhci5odG1sOiBBZGRlZC4KKwogMjAwOS0w OC0wMSAgRXZhbiBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtcmlnaHQt Y2xpY2stb24tdGltZWJhci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv bWVkaWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24tdGltZWJhci1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9jb250cm9scy1yaWdodC1jbGljay1vbi10aW1l YmFyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3IEBACitUZXN0IHRoYXQg cmlnaHQgY2xpY2tpbmcgb24gdGhlIHRpbWViYXIgZG9lcyBub3QgY2F1c2UgYSBzZWVrLgorCitS VU4odmlkZW8uYXV0b3BsYXkgPSB0cnVlKQorUlVOKHZpZGVvLnNyYyA9ICdjb250ZW50L3Rlc3Qu bXA0JykKK0VWRU5UKHBsYXlpbmcpCitFTkQgT0YgVEVTVAorCkluZGV4OiBMYXlvdXRUZXN0cy9t ZWRpYS9jb250cm9scy1yaWdodC1jbGljay1vbi10aW1lYmFyLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24tdGltZWJhci5odG1sCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtcmlnaHQtY2xpY2stb24t dGltZWJhci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ1IEBACis8aHRtbD4KKyAgICA8 aGVhZD4KKyAgICAgICAgPHRpdGxlPnJpZ2h0IGNsaWNrIG9uIHRpbWViYXIgdGVzdDwvdGl0bGU+ CisgICAgICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CisgICAgICAgIDxz Y3JpcHQ+CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg ICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgICAg ICAgICAgZnVuY3Rpb24gY2xpY2soKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlm ICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgICAgICAgICAgICAgdmFyIHggPSB2aWRl by5vZmZzZXRMZWZ0ICsgdmlkZW8ub2Zmc2V0V2lkdGggLyAyOworICAgICAgICAgICAgICAgICAg ICB2YXIgeSA9IHZpZGVvLm9mZnNldFRvcCArIHZpZGVvLm9mZnNldEhlaWdodCAtIDEwOworICAg ICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4LCB5KTsKKyAgICAgICAg ICAgICAgICAgICAgZXZlbnRTZW5kZXIuY29udGV4dENsaWNrKCk7CisgICAgICAgICAgICAgICAg fQorICAgICAgICAgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KCJlbmRUZXN0KCkiLCAyMDApOwor ICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiBwbGF5aW5nKCkKKyAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICB3aW5kb3cuc2V0VGltZW91dCgiY2xpY2soKSIsIDEwMCk7 CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHNlZWtlZCgpCisgICAgICAg ICAgICB7CisgICAgICAgICAgICAgICAgZmFpbFRlc3QoIlNob3VsZCBub3Qgc2Vlay4iKTsKKyAg ICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gc3RhcnQoKQorICAgICAgICAgICAg eworICAgICAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgICAgICAgICB3 YWl0Rm9yRXZlbnQoJ3BsYXlpbmcnLCBwbGF5aW5nKTsKKyAgICAgICAgICAgICAgICB3YWl0Rm9y RXZlbnQoJ3NlZWtlZCcsIHNlZWtlZCk7CisgICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5hdXRv cGxheSA9IHRydWUiKTsKKyAgICAgICAgICAgICAgICBydW4oInZpZGVvLnNyYyA9ICdjb250ZW50 L3Rlc3QubXA0JyIpOworICAgICAgICAgICAgfSAgICAKKyAgICAgICAgPC9zY3JpcHQ+CisgICAg PC9oZWFkPgorCisgICAgPGJvZHkgb25sb2FkPSJzdGFydCgpIj4KKyAgICA8cD5UZXN0IHRoYXQg cmlnaHQgY2xpY2tpbmcgb24gdGhlIHRpbWViYXIgZG9lcyBub3QgY2F1c2UgYSBzZWVrLjwvcD4K KyAgICA8dmlkZW8gY29udHJvbHM+PC92aWRlbz4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==