27915 2009-07-31 20:58:43 -0700 [commit+] Add a top level build option to control datagrid support 2009-07-31 23:29:51 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned abarth oldest_to_newest 136377 0 laszlo.gombos 2009-07-31 20:58:43 -0700 Turn on datagrid support on by default in build-webkit. By adding the option to control datagrid support will also enable the --minimal option to turn datagrid option off. 136378 1 33928 laszlo.gombos 2009-07-31 21:03:01 -0700 Created attachment 33928 proposed patch. 136382 2 33928 eric 2009-07-31 21:21:20 -0700 Comment on attachment 33928 proposed patch. OK. 136383 3 33928 eric 2009-07-31 21:22:00 -0700 Comment on attachment 33928 proposed patch. Should datagrid be on by default? 136388 4 laszlo.gombos 2009-07-31 21:30:04 -0700 (In reply to comment #3) > (From update of attachment 33928 [details]) > Should datagrid be on by default? Eric, thanks for the review. I think I have it on by default in the patch. define => "ENABLE_DATAGRID", default => 1 136419 5 33928 abarth 2009-07-31 23:29:48 -0700 Comment on attachment 33928 proposed patch. Clearing review flag on attachment: 33928 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/build-webkit Committed r46662 M WebKitTools/ChangeLog M WebKitTools/Scripts/build-webkit r46662 = 4350e2dffbf736a02d1b8fa1509acffa1b61fbc4 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46662 136420 6 abarth 2009-07-31 23:29:51 -0700 All reviewed patches have been landed. Closing bug. 33928 2009-07-31 21:03:01 -0700 2009-07-31 23:29:47 -0700 proposed patch. patch_27915.txt text/plain 1812 laszlo.gombos SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjU3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDctMzEgIExhc3psbyBHb21ib3MgIDxs YXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBhIHRvcCBsZXZlbCBidWlsZCBvcHRpb24gdG8gY29udHJv bCBkYXRhZ3JpZCBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNzkxNQorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisKIDIw MDktMDctMzEgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gVHJlYXQuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkocmV2 aXNpb24gNDY2NTQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkod29ya2lu ZyBjb3B5KQpAQCAtNDUsNyArNDUsNyBAQCBteSAkY2xlYW4gPSAwOwogbXkgJG1pbmltYWwgPSAw OwogbXkgJG1ha2VBcmdzOwogCi1teSAoJHRocmVlRFJlbmRlcmluZ1N1cHBvcnQsICRjaGFubmVs TWVzc2FnaW5nU3VwcG9ydCwgJGRhdGFiYXNlU3VwcG9ydCwgJGRvbVN0b3JhZ2VTdXBwb3J0LAor bXkgKCR0aHJlZURSZW5kZXJpbmdTdXBwb3J0LCAkY2hhbm5lbE1lc3NhZ2luZ1N1cHBvcnQsICRk YXRhYmFzZVN1cHBvcnQsICRkYXRhZ3JpZFN1cHBvcnQsICRkb21TdG9yYWdlU3VwcG9ydCwKICAg ICAkZmlsdGVyc1N1cHBvcnQsICRnZW9sb2NhdGlvblN1cHBvcnQsICRnbm9tZUtleXJpbmdTdXBw b3J0LCAkaWNvbkRhdGFiYXNlU3VwcG9ydCwKICAgICAkamF2YVNjcmlwdERlYnVnZ2VyU3VwcG9y dCwgJG9mZmxpbmVXZWJBcHBsaWNhdGlvblN1cHBvcnQsICRydWJ5U3VwcG9ydCwgJHNoYXJlZFdv cmtlcnNTdXBwb3J0LCAKICAgICAkc3ZnU3VwcG9ydCwgJHN2Z0FuaW1hdGlvblN1cHBvcnQsICRz dmdBc0ltYWdlU3VwcG9ydCwgJHN2Z0RPTU9iakNCaW5kaW5nc1N1cHBvcnQsICRzdmdGb250c1N1 cHBvcnQsCkBAIC02NSw2ICs2NSw5IEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICB7IG9wdGlvbiA9 PiAiZGF0YWJhc2UiLCBkZXNjID0+ICJUb2dnbGUgRGF0YWJhc2UgU3VwcG9ydCIsCiAgICAgICBk ZWZpbmUgPT4gIkVOQUJMRV9EQVRBQkFTRSIsIGRlZmF1bHQgPT4gMSwgdmFsdWUgPT4gXCRkYXRh YmFzZVN1cHBvcnQgfSwKIAorICAgIHsgb3B0aW9uID0+ICJkYXRhZ3JpZCIsIGRlc2MgPT4gIlRv Z2dsZSBEYXRhZ3JpZCBTdXBwb3J0IiwKKyAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0RBVEFHUklE IiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJGRhdGFncmlkU3VwcG9ydCB9LAorICAgICAgICAg IAogICAgIHsgb3B0aW9uID0+ICJkb20tc3RvcmFnZSIsIGRlc2MgPT4gIlRvZ2dsZSBET00gU3Rv cmFnZSBTdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0RPTV9TVE9SQUdFIiwgZGVm YXVsdCA9PiAxLCB2YWx1ZSA9PiBcJGRvbVN0b3JhZ2VTdXBwb3J0IH0sCiAK