279033 2024-09-02 13:13:45 -0700 Refactor `computePositionedLogicalWidthUsing` to use shrink-to-fit in one step 2025-12-14 21:17:02 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 282213 1 ahmad.saleem792 ahmad.saleem792 bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 2057090 0 ahmad.saleem792 2024-09-02 13:13:45 -0700 Hi Team, This is just refactoring in `computePositionedLogicalWidthUsing` by reduce reuse of variables: auto shrinkToFitLogicalWidth = [this](LayoutUnit availableLogicalWidth, LayoutUnit bordersPlusPadding) -> LayoutUnit { LayoutUnit preferredLogicalWidth = maxPreferredLogicalWidth() - bordersPlusPadding; LayoutUnit preferredMinLogicalWidth = minPreferredLogicalWidth() - bordersPlusPadding; return std::min(std::max(preferredMinLogicalWidth, availableLogicalWidth), preferredLogicalWidth); }; and then changing from: computedValues.m_extent = std::min(std::max(preferredMinWidth, availableWidth), preferredWidth); to: computedValues.m_extent = shrinkToFitLogicalWidth(availableSpace - logicalLeftValue, bordersPlusPadding); ___ It is here: https://github.com/WebKit/WebKit/blob/12aaa71a5803d48572e89111e28771be7969119b/Source/WebCore/rendering/RenderBox.cpp#L4284 Thanks! 2057091 1 ahmad.saleem792 2024-09-02 13:15:02 -0700 We can even use std:clamp here - return std::clamp(availableLogicalWidth, preferredMinLogicalWidth, preferredLogicalWidth); 2057098 2 webkit-bug-importer 2024-09-02 14:08:39 -0700 <rdar://problem/135156089> 2057099 3 ahmad.saleem792 2024-09-02 14:11:42 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33042 2057132 4 ews-feeder 2024-09-02 17:57:09 -0700 Committed 283073@main (6b0b9db9aa93): <https://commits.webkit.org/283073@main> Reviewed commits have been landed. Closing PR #33042 and removing active labels. 2071098 5 commit-queue 2024-10-28 16:52:30 -0700 Re-opened since this is blocked by bug 282213 2165815 6 ahmad.saleem792 2025-12-14 21:17:02 -0800 can't seems to find this code, so it might be gone, so it is not applicable anymore.