27894 2009-07-31 13:31:05 -0700 bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5 2009-07-31 14:03:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned eric levin oldest_to_newest 136230 0 ddkilzer 2009-07-31 13:31:05 -0700 $ ./WebKitTools/Scripts/bugzilla-tool land-patches --no-clean --no-build --no-test 27849 Fetching: https://bugs.webkit.org/show_bug.cgi?id=27849&ctype=xml Landing 1 patch from 1 bug. Updating working directory Current branch master is up to date. % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 101 1215 101 1215 0 0 1578 0 --:--:-- --:--:-- --:--:-- 2525 patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/bugzilla-tool Parsing ChangeLog: WebKitTools/ChangeLog Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... Logging in as ddkilzer@webkit.org... Clearing review flag on attachment: 33837 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r46637 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r46637 = 20f0cf4533b301428fa09b392316943bedee805a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46637 Traceback (most recent call last): File "./WebKitTools/Scripts/bugzilla-tool", line 668, in <module> main() File "./WebKitTools/Scripts/bugzilla-tool", line 665, in main return tool.main() File "./WebKitTools/Scripts/bugzilla-tool", line 660, in main return command_object.execute(command_options, command_args, self) File "./WebKitTools/Scripts/bugzilla-tool", line 349, in execute self.land_patches(bug_id, bugs_to_patches[bug_id], options, tool) File "./WebKitTools/Scripts/bugzilla-tool", line 323, in land_patches tool.bugs.clear_attachment_review_flag(patch['id'], comment_text) File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/modules/bugzilla.py", line 366, in clear_attachment_review_flag self.browser['comment'] = comment_text File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 2895, in __setitem__ File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3222, in find_control File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3304, in _find_control ClientForm.AmbiguityError: more than one control matching name 'comment' 136236 1 33901 ddkilzer 2009-07-31 13:45:09 -0700 Created attachment 33901 Patch v1 136239 2 33901 eric 2009-07-31 13:50:09 -0700 Comment on attachment 33901 Patch v1 LGTM. Are there other places we need to worry about? We have several places we set the comment... r=me to change the rest too. 136240 3 eric 2009-07-31 13:51:06 -0700 This was actually caused by bugzilla 3.0 iirc. I swear I fixed one of these before. :) 136244 4 ddkilzer 2009-07-31 13:56:23 -0700 (In reply to comment #2) > (From update of attachment 33901 [details]) > LGTM. Are there other places we need to worry about? We have several places > we set the comment... r=me to change the rest too. These were the only two on the attachments.cgi?action=edit pages that I saw. 136245 5 33901 eric 2009-07-31 14:00:57 -0700 Comment on attachment 33901 Patch v1 I only saw one in your change, but I assume I must have fixed the other one before (or someone did) and forgot to fix this one! eep! :) Thanks again. 136247 6 ddkilzer 2009-07-31 14:03:53 -0700 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed r46640 http://trac.webkit.org/changeset/46640 33901 2009-07-31 13:45:09 -0700 2009-07-31 14:00:57 -0700 Patch v1 bug-27894-20090731134508.patch text/plain 1227 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlOTYzOWIzLi42ZDE0ODM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDct MzEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0cDov L3dlYmtpdC5vcmcvYi8yNzg5ND4gYnVnemlsbGEtdG9vbDogQnVnemlsbGEuY2xlYXJfYXR0YWNo bWVudF9yZXZpZXdfZmxhZygpIGZhaWxzIHdpdGggQ2xpZW50Rm9ybS0wLjIuMTAgYW5kIHB5dGhv bi0yLjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weToKKyAgICAgICAgKEJ1Z3ppbGxhLmNsZWFyX2F0 dGFjaG1lbnRfcmV2aWV3X2ZsYWcpOiBTcGVjaWZ5IHdoaWNoICdjb21tZW50JworICAgICAgICBm b3JtIGZpZWxkIHRvIHVzZSB3aGVuIHNldHRpbmcgaXRzIHZhbHVlLgorCiAyMDA5LTA3LTMxICBF cmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZp ZCBLaWx6ZXIuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemls bGEucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKaW5kZXggMGZm NWE3My4uMzc5NzcxZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1 Z3ppbGxhLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQpA QCAtMzYzLDcgKzM2Myw3IEBAIGNsYXNzIEJ1Z3ppbGxhOgogCiAgICAgICAgIHNlbGYuYnJvd3Nl ci5vcGVuKHNlbGYuYXR0YWNobWVudF91cmxfZm9yX2lkKGF0dGFjaG1lbnRfaWQsICdlZGl0Jykp CiAgICAgICAgIHNlbGYuYnJvd3Nlci5zZWxlY3RfZm9ybShucj0xKQotICAgICAgICBzZWxmLmJy b3dzZXJbJ2NvbW1lbnQnXSA9IGNvbW1lbnRfdGV4dAorICAgICAgICBzZWxmLmJyb3dzZXIuc2V0 X3ZhbHVlKGNvbW1lbnRfdGV4dCwgbmFtZT0nY29tbWVudCcsIG5yPTApCiAgICAgICAgIHNlbGYu YnJvd3Nlci5maW5kX2NvbnRyb2wodHlwZT0nc2VsZWN0JywgbnI9MCkudmFsdWUgPSAoIlgiLCkK ICAgICAgICAgc2VsZi5icm93c2VyLnN1Ym1pdCgp