<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27893</bug_id>
          
          <creation_ts>2009-07-31 13:09:52 -0700</creation_ts>
          <short_desc>run-webkit-tests Skipped Only mode includes tests that are skipped by other flags.</short_desc>
          <delta_ts>2009-08-04 12:06:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Mike Fenton">mifenton</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>manyoso</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>136223</commentid>
    <comment_count>0</comment_count>
    <who name="Mike Fenton">mifenton</who>
    <bug_when>2009-07-31 13:09:52 -0700</bug_when>
    <thetext>Current when run-webkit-tests is run with the --skipped=only option all tests currently in the Skipped file for the platform are run without consideration for other flags like -no-http or platform defaults for the tests configurations.

The current mode of --skipped=only should be transitioned to a new mode (--skipped=only-all) which maintains the current behavior.

--skipped=only should be updated to correctly use the existing flags in the script to only run skipped tests that the functionality exists to potentially pass the test.

This update will match the behavior of --skipped=ignore which does obey flags used by run-webkit-tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136231</commentid>
    <comment_count>1</comment_count>
      <attachid>33899</attachid>
    <who name="Mike Fenton">mifenton</who>
    <bug_when>2009-07-31 13:32:02 -0700</bug_when>
    <thetext>Created attachment 33899
Patch to improve the behavior of --skipped=only and add --skipped=only-all mode to run-webkit-tests</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136254</commentid>
    <comment_count>2</comment_count>
      <attachid>33899</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-31 14:34:11 -0700</bug_when>
    <thetext>Comment on attachment 33899
Patch to improve the behavior of --skipped=only and add --skipped=only-all mode to run-webkit-tests

I&apos;m not sure only-all is useful, maybe it is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136970</commentid>
    <comment_count>3</comment_count>
    <who name="Mike Fenton">mifenton</who>
    <bug_when>2009-08-04 05:25:35 -0700</bug_when>
    <thetext>I tend to agree, however, I didn&apos;t want to remove the old functionality entirely.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136971</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Treat">manyoso</who>
    <bug_when>2009-08-04 05:41:39 -0700</bug_when>
    <thetext>I happen to agree with Eric.  This is a bug fix pure and simple.  No need for --only-all which is confusing to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136977</commentid>
    <comment_count>5</comment_count>
      <attachid>34059</attachid>
    <who name="Mike Fenton">mifenton</who>
    <bug_when>2009-08-04 07:34:14 -0700</bug_when>
    <thetext>Created attachment 34059
Updated patch without skipped=only-all mode

I&apos;ve updated the patch to strictly fix the --skipped=only mode.  No only-all mode is included in this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136986</commentid>
    <comment_count>6</comment_count>
      <attachid>34059</attachid>
    <who name="Adam Treat">manyoso</who>
    <bug_when>2009-08-04 07:58:39 -0700</bug_when>
    <thetext>Comment on attachment 34059
Updated patch without skipped=only-all mode

&gt; +2009-07-31  Mike Fenton  &lt;mike.fenton@torchmobile.com&gt;
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).
&gt; +
&gt; +        Change --skipped=only mode to use $ignoreDirectories to only
&gt; +        run tests that configured by the script, or by the default
&gt; +        values used in the script.

I think the ChangeLog could do a better job of explaining what is happening here.  Basically, you want --skipped=only to honor the --no-http flag.  That is not currently happening.  If I understand things correctly, your patch explicitly fixes this by making --skipped=only honor the ignoreDirectories, one of which is &apos;http&apos; if --no-http is passed.

Spell this out as the explicit goal in the ChangeLog and how it was accomplished.

Also, it is not clear to me that this patch accomplishes what the bug report says it does: to make --skipped=only honor *all* other flags.  It seems that this bugfix was rather narrowly tailored to --no-http.  Which is fine!  But it is good to be clear about this.

&gt; +sub ignoreFileByDirectory {
&gt; +    my($filePath) = @_;
&gt; +    foreach my $ignoredDir (keys %ignoredDirectories) {
&gt; +        if ($filePath =~ m/^$ignoredDir/) {
&gt; +            return 1;
&gt; +        }
&gt; +    }

Perhaps &apos;fileShouldBeIgnored&apos; instead to be more descriptive?

r- for ChangeLog mostly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136993</commentid>
    <comment_count>7</comment_count>
      <attachid>34064</attachid>
    <who name="Mike Fenton">mifenton</who>
    <bug_when>2009-08-04 08:27:34 -0700</bug_when>
    <thetext>Created attachment 34064
Updated changeLog and rename of function.

This patch makes the suggested changes to the previous patch.

1) Rename the function.

2) Update the changelog to more clearly identify the reason for the change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137079</commentid>
    <comment_count>8</comment_count>
      <attachid>34064</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 12:06:14 -0700</bug_when>
    <thetext>Comment on attachment 34064
Updated changeLog and rename of function.

Clearing review flag on attachment: 34064

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests
Committed r46771
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests
r46771 = 042145e38e9fb864caea4ce6b7799aa60e67b093 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46771</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>137080</commentid>
    <comment_count>9</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-04 12:06:18 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33899</attachid>
            <date>2009-07-31 13:32:02 -0700</date>
            <delta_ts>2009-08-04 07:34:14 -0700</delta_ts>
            <desc>Patch to improve the behavior of --skipped=only and add --skipped=only-all mode to run-webkit-tests</desc>
            <filename>RunTestsSkipPatch.diff</filename>
            <type>text/plain</type>
            <size>4217</size>
            <attacher name="Mike Fenton">mifenton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBiMTUxNmQ4Li5iZWI5MDZiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct
MzEgIE1pa2UgRmVudG9uICA8bWlrZS5mZW50b25AdG9yY2htb2JpbGUuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgY3VycmVudCAtLXNr
aXBwZWQ9b25seSBtb2RlIHRvIC0tc2tpcHBlZD1vbmx5LWFsbAorICAgICAgICBDaGFuZ2UgLS1z
a2lwcGVkPW9ubHkgbW9kZSB0byB1c2UgJGlnbm9yZURpcmVjdG9yaWVzIHRvIG9ubHkKKyAgICAg
ICAgcnVuIHRlc3RzIHRoYXQgY29uZmlndXJlZCBieSB0aGUgc2NyaXB0LCBvciBieSB0aGUgZGVm
YXVsdAorICAgICAgICB2YWx1ZXMgdXNlZCBpbiB0aGUgc2NyaXB0LgorCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzg5MworCisgICAgICAgICogU2Ny
aXB0cy9ydW4td2Via2l0LXRlc3RzOgorCiAyMDA5LTA3LTI5ICBEYXZpZCBLaWx6ZXIgIDxkZGtp
bHplckBhcHBsZS5jb20+CiAKICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMjcxMTk+IGJ1
Z3ppbGxhLXRvb2w6IEFkZCBjcmVhdGUtYnVnIGNvbW1hbmQKZGlmZiAtLWdpdCBhL1dlYktpdFRv
b2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdl
YmtpdC10ZXN0cwppbmRleCA1YmE1OGFjLi43YzBjOGFkIDEwMDc1NQotLS0gYS9XZWJLaXRUb29s
cy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4t
d2Via2l0LXRlc3RzCkBAIC0yMTAsMTAgKzIxMCwxMiBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtv
cHRpb25zXSBbdGVzdGRpcnx0ZXN0cGF0aCAuLi5dCiAgIC0tcm9vdCAgICAgICAgICAgICAgICAg
ICAgICAgICAgUGF0aCB0byByb290IHRvb2xzIGJ1aWxkCiAgIC0tW25vLV1zYW1wbGUtb24tdGlt
ZW91dCAgICAgICAgUnVuIHNhbXBsZSBvbiB0aW1lb3V0IChkZWZhdWx0OiAkc2FtcGxlRGVmYXVs
dCkgKE1hYyBPUyBYIG9ubHkpCiAgIC0xfC0tc2luZ2x5ICAgICAgICAgICAgICAgICAgICAgSXNv
bGF0ZSBlYWNoIHRlc3QgY2FzZSBydW4gKGltcGxpZXMgLS12ZXJib3NlKQotICAtLXNraXBwZWQ9
W2RlZmF1bHR8aWdub3JlfG9ubHldIFNwZWNpZmllcyBob3cgdG8gdHJlYXQgdGhlIFNraXBwZWQg
ZmlsZQorICAtLXNraXBwZWQ9W2RlZmF1bHR8aWdub3JlfG9ubHl8b25seS1hbGxdIFNwZWNpZmll
cyBob3cgdG8gdHJlYXQgdGhlIFNraXBwZWQgZmlsZQogICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGRlZmF1bHQ6IFRlc3RzL2RpcmVjdG9yaWVzIGxpc3RlZCBpbiB0aGUgU2tp
cHBlZCBmaWxlIGFyZSBub3QgdGVzdGVkCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgaWdub3JlOiAgVGhlIFNraXBwZWQgZmlsZSBpcyBpZ25vcmVkCiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgb25seTogICAgT25seSB0aG9zZSB0ZXN0cy9kaXJlY3Rv
cmllcyBsaXN0ZWQgaW4gdGhlIFNraXBwZWQgZmlsZSB3aWxsIGJlIHJ1bgorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIG9ubHktYWxsOiAgT25seSB0aG9zZSB0ZXN0cy9kaXJl
Y3RvcmllcyBsaXN0ZWQgaW4gdGhlIFNraXBwZWQgZmlsZSBpbmNsdWRpbmcgYWxsCisgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlY3RvcmllcyBpZ25v
cmVkIGJ5IGNvbmZpZ3VyYXRpb24uCiAgIC0tc2xvd2VzdCAgICAgICAgICAgICAgICAgICAgICAg
UmVwb3J0IHRoZSAxMCBzbG93ZXN0IHRlc3RzCiAgIC0tc3RyaWN0ICAgICAgICAgICAgICAgICAg
ICAgICAgRG8gYSBjb21wYXJpc29uIHdpdGggdGhlIG91dHB1dCBvbiBNYWMgKFF0IG9ubHkpCiAg
IC0tW25vLV1zdHJpcC1lZGl0aW5nLWNhbGxiYWNrcyAgUmVtb3ZlIGVkaXRpbmcgY2FsbGJhY2tz
IGZyb20gZXhwZWN0ZWQgcmVzdWx0cwpAQCAtMjY4LDcgKzI3MCw4IEBAIGlmICghJGdldE9wdGlv
bnNSZXN1bHQgfHwgJHNob3dIZWxwKSB7CiB9CiAKIG15ICRpZ25vcmVTa2lwcGVkID0gJHRyZWF0
U2tpcHBlZCBlcSAiaWdub3JlIjsKLW15ICRza2lwcGVkT25seSA9ICR0cmVhdFNraXBwZWQgZXEg
Im9ubHkiOworbXkgJHNraXBwZWRPbmx5QWxsID0gJHRyZWF0U2tpcHBlZCBlcSAib25seS1hbGwi
OworbXkgJHNraXBwZWRPbmx5ID0gKCRza2lwcGVkT25seUFsbCB8fCAkdHJlYXRTa2lwcGVkIGVx
ICJvbmx5Iik7CiAKICEkc2tpcHBlZE9ubHkgfHwgQEFSR1YgPT0gMCBvciBkaWUgIi0tc2tpcHBl
ZD1vbmx5IGNhbm5vdCBiZSB1c2VkIHdoZW4gdGVzdHMgYXJlIHNwZWNpZmllZCBvbiB0aGUgY29t
bWFuZCBsaW5lLiI7CiAKQEAgLTQwMiwxMCArNDA1LDIwIEBAIGlmICgkaWdub3JlVGVzdHMpIHsK
ICAgICBwcm9jZXNzSWdub3JlVGVzdHMoJGlnbm9yZVRlc3RzLCAiaWdub3JlLXRlc3RzIik7CiB9
CiAKK3N1YiBpZ25vcmVGaWxlQnlEaXJlY3RvcnkgeworICAgIG15KCRmaWxlUGF0aCkgPSBAXzsK
KyAgICBmb3JlYWNoIG15ICRpZ25vcmVkRGlyIChrZXlzICVpZ25vcmVkRGlyZWN0b3JpZXMpIHsK
KyAgICAgICAgaWYgKCRmaWxlUGF0aCA9fiBtL14kaWdub3JlZERpci8pIHsKKyAgICAgICAgICAg
IHJldHVybiAxOworICAgICAgICB9CisgICAgfQorICAgIHJldHVybiAwOworfQorCiBpZiAoISRp
Z25vcmVTa2lwcGVkKSB7CiAgICAgZm9yZWFjaCBteSAkbGV2ZWwgKEBwbGF0Zm9ybVRlc3RIaWVy
YXJjaHkpIHsKICAgICAgICAgaWYgKG9wZW4gU0tJUFBFRCwgIjwiLCAiJGxldmVsL1NraXBwZWQi
KSB7Ci0gICAgICAgICAgICBpZiAoJHZlcmJvc2UgJiYgISRza2lwcGVkT25seSkgeworICAgICAg
ICAgICAgaWYgKCR2ZXJib3NlICYmICEkc2tpcHBlZE9ubHlBbGwpIHsKICAgICAgICAgICAgICAg
ICBteSAoJGRpciwgJG5hbWUpID0gc3BsaXRwYXRoKCRsZXZlbCk7CiAgICAgICAgICAgICAgICAg
cHJpbnQgIlNraXBwZWQgdGVzdHMgaW4gJG5hbWU6XG4iOwogICAgICAgICAgICAgfQpAQCAtNDE3
LDcgKzQzMCwxMSBAQCBpZiAoISRpZ25vcmVTa2lwcGVkKSB7CiAgICAgICAgICAgICAgICAgJHNr
aXBwZWQgPX4gcy9bIFxuXHJdKyQvLzsKICAgICAgICAgICAgICAgICBpZiAoJHNraXBwZWQgJiYg
JHNraXBwZWQgIX4gL14jLykgewogICAgICAgICAgICAgICAgICAgICBpZiAoJHNraXBwZWRPbmx5
KSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBBUkdWLCAkc2tpcHBlZCk7CisgICAg
ICAgICAgICAgICAgICAgICAgICBpZiAoJHNraXBwZWRPbmx5QWxsIHx8ICEmaWdub3JlRmlsZUJ5
RGlyZWN0b3J5KCRza2lwcGVkKSkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2go
QEFSR1YsICRza2lwcGVkKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxzaWYgKCR2ZXJi
b3NlKSB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJpbnQgIiAgICAkc2tpcHBlZFxu
IjsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAgICAgfSBlbHNl
IHsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmICgkdmVyYm9zZSkgewogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIHByaW50ICIgICAgJHNraXBwZWRcbiI7CkBAIC0xNjYyLDcgKzE2Nzks
NyBAQCBzdWIgdG9VUkwoJCkKIHN1YiB2YWxpZGF0ZVNraXBwZWRBcmcoJCQ7JCkKIHsKICAgICBt
eSAoJG9wdGlvbiwgJHZhbHVlLCAkdmFsdWUyKSA9IEBfOwotICAgIG15ICV2YWxpZFNraXBwZWRW
YWx1ZXMgPSBtYXAgeyAkXyA9PiAxIH0gcXcoZGVmYXVsdCBpZ25vcmUgb25seSk7CisgICAgbXkg
JXZhbGlkU2tpcHBlZFZhbHVlcyA9IG1hcCB7ICRfID0+IDEgfSBxdyhkZWZhdWx0IGlnbm9yZSBv
bmx5IG9ubHktYWxsKTsKICAgICAkdmFsdWUgPSBsYygkdmFsdWUpOwogICAgIGRpZSAiSW52YWxp
ZCBhcmd1bWVudCAnIiAuICR2YWx1ZSAuICInIGZvciBvcHRpb24gJG9wdGlvbiIgdW5sZXNzICR2
YWxpZFNraXBwZWRWYWx1ZXN7JHZhbHVlfTsKICAgICAkdHJlYXRTa2lwcGVkID0gJHZhbHVlOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34059</attachid>
            <date>2009-08-04 07:34:14 -0700</date>
            <delta_ts>2009-08-04 08:27:34 -0700</delta_ts>
            <desc>Updated patch without skipped=only-all mode</desc>
            <filename>RunWebkitTestsSkippedOnlyPatch.diff</filename>
            <type>text/plain</type>
            <size>2101</size>
            <attacher name="Mike Fenton">mifenton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBiMTUxNmQ4Li44ZWRlODNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDct
MzEgIE1pa2UgRmVudG9uICA8bWlrZS5mZW50b25AdG9yY2htb2JpbGUuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSAtLXNraXBwZWQ9
b25seSBtb2RlIHRvIHVzZSAkaWdub3JlRGlyZWN0b3JpZXMgdG8gb25seQorICAgICAgICBydW4g
dGVzdHMgdGhhdCBjb25maWd1cmVkIGJ5IHRoZSBzY3JpcHQsIG9yIGJ5IHRoZSBkZWZhdWx0Cisg
ICAgICAgIHZhbHVlcyB1c2VkIGluIHRoZSBzY3JpcHQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODkzCisKKyAgICAgICAgKiBTY3JpcHRzL3J1
bi13ZWJraXQtdGVzdHM6CisKIDIwMDktMDctMjkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFw
cGxlLmNvbT4KIAogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8yNzExOT4gYnVnemlsbGEt
dG9vbDogQWRkIGNyZWF0ZS1idWcgY29tbWFuZApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy9ydW4td2Via2l0LXRlc3RzIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRl
c3RzCmluZGV4IDViYTU4YWMuLjliYTlkOWMgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw
dHMvcnVuLXdlYmtpdC10ZXN0cworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQt
dGVzdHMKQEAgLTQwMiwxMCArNDAyLDIwIEBAIGlmICgkaWdub3JlVGVzdHMpIHsKICAgICBwcm9j
ZXNzSWdub3JlVGVzdHMoJGlnbm9yZVRlc3RzLCAiaWdub3JlLXRlc3RzIik7CiB9CiAKK3N1YiBp
Z25vcmVGaWxlQnlEaXJlY3RvcnkgeworICAgIG15KCRmaWxlUGF0aCkgPSBAXzsKKyAgICBmb3Jl
YWNoIG15ICRpZ25vcmVkRGlyIChrZXlzICVpZ25vcmVkRGlyZWN0b3JpZXMpIHsKKyAgICAgICAg
aWYgKCRmaWxlUGF0aCA9fiBtL14kaWdub3JlZERpci8pIHsKKyAgICAgICAgICAgIHJldHVybiAx
OworICAgICAgICB9CisgICAgfQorICAgIHJldHVybiAwOworfQorCiBpZiAoISRpZ25vcmVTa2lw
cGVkKSB7CiAgICAgZm9yZWFjaCBteSAkbGV2ZWwgKEBwbGF0Zm9ybVRlc3RIaWVyYXJjaHkpIHsK
ICAgICAgICAgaWYgKG9wZW4gU0tJUFBFRCwgIjwiLCAiJGxldmVsL1NraXBwZWQiKSB7Ci0gICAg
ICAgICAgICBpZiAoJHZlcmJvc2UgJiYgISRza2lwcGVkT25seSkgeworICAgICAgICAgICAgaWYg
KCR2ZXJib3NlKSB7CiAgICAgICAgICAgICAgICAgbXkgKCRkaXIsICRuYW1lKSA9IHNwbGl0cGF0
aCgkbGV2ZWwpOwogICAgICAgICAgICAgICAgIHByaW50ICJTa2lwcGVkIHRlc3RzIGluICRuYW1l
OlxuIjsKICAgICAgICAgICAgIH0KQEAgLTQxNyw3ICs0MjcsMTEgQEAgaWYgKCEkaWdub3JlU2tp
cHBlZCkgewogICAgICAgICAgICAgICAgICRza2lwcGVkID1+IHMvWyBcblxyXSskLy87CiAgICAg
ICAgICAgICAgICAgaWYgKCRza2lwcGVkICYmICRza2lwcGVkICF+IC9eIy8pIHsKICAgICAgICAg
ICAgICAgICAgICAgaWYgKCRza2lwcGVkT25seSkgewotICAgICAgICAgICAgICAgICAgICAgICAg
cHVzaChAQVJHViwgJHNraXBwZWQpOworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCEmaWdu
b3JlRmlsZUJ5RGlyZWN0b3J5KCRza2lwcGVkKSkgeworICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHB1c2goQEFSR1YsICRza2lwcGVkKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxz
aWYgKCR2ZXJib3NlKSB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJpbnQgIiAgICAk
c2tpcHBlZFxuIjsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAg
ICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGlmICgkdmVyYm9zZSkgewogICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHByaW50ICIgICAgJHNraXBwZWRcbiI7Cg==
</data>
<flag name="review"
          id="18228"
          type_id="1"
          status="-"
          setter="manyoso"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34064</attachid>
            <date>2009-08-04 08:27:34 -0700</date>
            <delta_ts>2009-08-04 12:06:14 -0700</delta_ts>
            <desc>Updated changeLog and rename of function.</desc>
            <filename>RunWebkitTestsSkippedOnlyPatch.diff</filename>
            <type>text/plain</type>
            <size>2201</size>
            <attacher name="Mike Fenton">mifenton</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBiMTUxNmQ4Li44ZWRlODNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDct
MzEgIE1pa2UgRmVudG9uICA8bWlrZS5mZW50b25AdG9yY2htb2JpbGUuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCAtLXNraXBwZWQ9b25s
eSBtb2RlIHRvIGhvbm9yIGZsYWdzIHN1Y2ggYXMgLS1uby1odHRwIGFuZCBwbGF0Zm9ybSBpZ25v
cmVkIGRpcmVjdG9yaWVzIGJ5IGNoZWNraW5nCisgICAgICAgIHRvIG1ha2Ugc3VyZSB0aGUgU2tp
cHBlZCBlbnRyaWVzIGFyZSBub3QgaW4gdGhlICRpZ25vcmVkRGlyZWN0b3JpZXMgYXJyYXkuICBE
aXJlY3RvcmllcyBjb21tb25seSBpbmNsdWRlZAorICAgICAgICBhcmUgKGh0dHAsIG1lZGlhLCBj
b21wb3NpdGluZywgd21sLCB3Y3NzKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4OTMKKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10
ZXN0czoKKwogMjAwOS0wNy0yOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgog
CiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzI3MTE5PiBidWd6aWxsYS10b29sOiBBZGQg
Y3JlYXRlLWJ1ZyBjb21tYW5kCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13
ZWJraXQtdGVzdHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKaW5kZXgg
NWJhNThhYy4uOWJhOWQ5YyAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Vi
a2l0LXRlc3RzCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwpAQCAt
NDAyLDEwICs0MDIsMjAgQEAgaWYgKCRpZ25vcmVUZXN0cykgewogICAgIHByb2Nlc3NJZ25vcmVU
ZXN0cygkaWdub3JlVGVzdHMsICJpZ25vcmUtdGVzdHMiKTsKIH0KIAorc3ViIGZpbGVTaG91bGRC
ZUlnbm9yZWQgeworICAgIG15KCRmaWxlUGF0aCkgPSBAXzsKKyAgICBmb3JlYWNoIG15ICRpZ25v
cmVkRGlyIChrZXlzICVpZ25vcmVkRGlyZWN0b3JpZXMpIHsKKyAgICAgICAgaWYgKCRmaWxlUGF0
aCA9fiBtL14kaWdub3JlZERpci8pIHsKKyAgICAgICAgICAgIHJldHVybiAxOworICAgICAgICB9
CisgICAgfQorICAgIHJldHVybiAwOworfQorCiBpZiAoISRpZ25vcmVTa2lwcGVkKSB7CiAgICAg
Zm9yZWFjaCBteSAkbGV2ZWwgKEBwbGF0Zm9ybVRlc3RIaWVyYXJjaHkpIHsKICAgICAgICAgaWYg
KG9wZW4gU0tJUFBFRCwgIjwiLCAiJGxldmVsL1NraXBwZWQiKSB7Ci0gICAgICAgICAgICBpZiAo
JHZlcmJvc2UgJiYgISRza2lwcGVkT25seSkgeworICAgICAgICAgICAgaWYgKCR2ZXJib3NlKSB7
CiAgICAgICAgICAgICAgICAgbXkgKCRkaXIsICRuYW1lKSA9IHNwbGl0cGF0aCgkbGV2ZWwpOwog
ICAgICAgICAgICAgICAgIHByaW50ICJTa2lwcGVkIHRlc3RzIGluICRuYW1lOlxuIjsKICAgICAg
ICAgICAgIH0KQEAgLTQxNyw3ICs0MjcsMTEgQEAgaWYgKCEkaWdub3JlU2tpcHBlZCkgewogICAg
ICAgICAgICAgICAgICRza2lwcGVkID1+IHMvWyBcblxyXSskLy87CiAgICAgICAgICAgICAgICAg
aWYgKCRza2lwcGVkICYmICRza2lwcGVkICF+IC9eIy8pIHsKICAgICAgICAgICAgICAgICAgICAg
aWYgKCRza2lwcGVkT25seSkgewotICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAQVJHViwg
JHNraXBwZWQpOworICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCEmZmlsZVNob3VsZEJlSWdu
b3JlZCgkc2tpcHBlZCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBBUkdW
LCAkc2tpcHBlZCk7CisgICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2lmICgkdmVyYm9zZSkg
eworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByaW50ICIgICAgJHNraXBwZWRcbiI7Cisg
ICAgICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7CiAg
ICAgICAgICAgICAgICAgICAgICAgICBpZiAoJHZlcmJvc2UpIHsKICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBwcmludCAiICAgICRza2lwcGVkXG4iOwo=
</data>
<flag name="commit-queue"
          id="18234"
          type_id="3"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>