27888 2009-07-31 10:22:48 -0700 Geolocation clean up when no longer updating 2009-07-31 14:57:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bolsinga bolsinga sam oldest_to_newest 136194 0 bolsinga 2009-07-31 10:22:48 -0700 When Geolocation::disconnectFrame() is called, need to call Document::setUsingGeolocation(false) to mirror the true call when it is set up. When handling an error, and there are no more listeners, call GeolocationService::stopUpdating(). 136195 1 33886 bolsinga 2009-07-31 10:25:14 -0700 Created attachment 33886 patch to implement bug fix 136256 2 33886 eric 2009-07-31 14:35:08 -0700 Comment on attachment 33886 patch to implement bug fix Any way to test this? We really need some sort of geolocationController for DumpRenderTree it seems. 136257 3 bolsinga 2009-07-31 14:50:44 -0700 (In reply to comment #2) > (From update of attachment 33886 [details]) > Any way to test this? We really need some sort of geolocationController for > DumpRenderTree it seems. Bug 21717 was to get those tests in. Thanks! 136258 4 bolsinga 2009-07-31 14:57:43 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/Geolocation.cpp Committed r46642 33886 2009-07-31 10:25:14 -0700 2009-07-31 14:35:08 -0700 patch to implement bug fix 0001-2009-07-31-Greg-Bolsinga-bolsinga-apple.com.patch text/plain 2523 bolsinga RnJvbSAwMGY2MzU1ZGI0NWEzZTM4ZWZiOTQyNmQ0MGJhMzRjNjkzNDFiMGY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIEJvbHNpbmdhIDxib2xzaW5nYUBhcHBsZS5jb20+CkRh dGU6IEZyaSwgMzEgSnVsIDIwMDkgMTA6MjQ6MzQgLTA3MDAKU3ViamVjdDogW1BBVENIXSAyMDA5 LTA3LTMxICBHcmVnIEJvbHNpbmdhICA8Ym9sc2luZ2FAYXBwbGUuY29tPgoKICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgR2VvbG9jYXRpb24gY2xlYW4gdXAgd2hl biBubyBsb25nZXIgdXBkYXRpbmcKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjc4ODgKCiAgICAgICAgV2hlbiBHZW9sb2NhdGlvbjo6ZGlzY29ubmVjdEZy YW1lKCkgaXMgY2FsbGVkLCBuZWVkIHRvIGNhbGwKICAgICAgICBEb2N1bWVudDo6c2V0VXNpbmdH ZW9sb2NhdGlvbihmYWxzZSkgdG8gbWlycm9yIHRoZSB0cnVlIGNhbGwKICAgICAgICB3aGVuIGl0 IGlzIHNldCB1cC4KCiAgICAgICAgV2hlbiBoYW5kbGluZyBhbiBlcnJvciwgYW5kIHRoZXJlIGFy ZSBubyBtb3JlIGxpc3RlbmVycywgY2FsbAogICAgICAgIEdlb2xvY2F0aW9uU2VydmljZTo6c3Rv cFVwZGF0aW5nKCkuCgogICAgICAgICogcGFnZS9HZW9sb2NhdGlvbi5jcHA6CiAgICAgICAgKFdl YkNvcmU6Okdlb2xvY2F0aW9uOjpkaXNjb25uZWN0RnJhbWUpOgogICAgICAgIChXZWJDb3JlOjpH ZW9sb2NhdGlvbjo6aGFuZGxlRXJyb3IpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNw cCB8ICAgIDUgKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDRmNzRlZTYuLjEzMjY4NzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMDktMDctMzEgIEdy ZWcgQm9sc2luZ2EgIDxib2xzaW5nYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2VvbG9jYXRpb24gY2xlYW4gdXAgd2hlbiBubyBs b25nZXIgdXBkYXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI3ODg4CisKKyAgICAgICAgV2hlbiBHZW9sb2NhdGlvbjo6ZGlzY29ubmVjdEZyYW1l KCkgaXMgY2FsbGVkLCBuZWVkIHRvIGNhbGwgCisgICAgICAgIERvY3VtZW50OjpzZXRVc2luZ0dl b2xvY2F0aW9uKGZhbHNlKSB0byBtaXJyb3IgdGhlIHRydWUgY2FsbCAKKyAgICAgICAgd2hlbiBp dCBpcyBzZXQgdXAuCisKKyAgICAgICAgV2hlbiBoYW5kbGluZyBhbiBlcnJvciwgYW5kIHRoZXJl IGFyZSBubyBtb3JlIGxpc3RlbmVycywgY2FsbAorICAgICAgICBHZW9sb2NhdGlvblNlcnZpY2U6 OnN0b3BVcGRhdGluZygpLgorCisgICAgICAgICogcGFnZS9HZW9sb2NhdGlvbi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbjo6ZGlzY29ubmVjdEZyYW1lKToKKyAgICAgICAgKFdl YkNvcmU6Okdlb2xvY2F0aW9uOjpoYW5kbGVFcnJvcik6CisKKzIwMDktMDctMzEgIEdyZWcgQm9s c2luZ2EgIDxib2xzaW5nYUBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgR2Vvcmdl IFN0YWlrb3MuCiAKICAgICAgICAgQ29uc29saWRhdGUgR2VvTG9jYXRpb24gY29kZSB0byBzZW5k IHBvc2l0aW9ucyBhbmQgZXJyb3JzCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvR2VvbG9jYXRp b24uY3BwIGIvV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNwcAppbmRleCAxYmNiNjIxLi4yNGUy ZTVmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCisrKyBiL1dlYkNv cmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAKQEAgLTczLDYgKzczLDggQEAgR2VvbG9jYXRpb246Okdl b2xvY2F0aW9uKEZyYW1lKiBmcmFtZSkKIHZvaWQgR2VvbG9jYXRpb246OmRpc2Nvbm5lY3RGcmFt ZSgpCiB7CiAgICAgbV9zZXJ2aWNlLT5zdG9wVXBkYXRpbmcoKTsKKyAgICBpZiAobV9mcmFtZSAm JiBtX2ZyYW1lLT5kb2N1bWVudCgpKQorICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5zZXRV c2luZ0dlb2xvY2F0aW9uKGZhbHNlKTsKICAgICBtX2ZyYW1lID0gMDsKIH0KIApAQCAtMjQyLDYg KzI0NCw5IEBAIHZvaWQgR2VvbG9jYXRpb246OmhhbmRsZUVycm9yKFBvc2l0aW9uRXJyb3IqIGVy cm9yKQogICAgIHNlbmRFcnJvclRvV2F0Y2hlcnMoZXJyb3IpOwogCiAgICAgbV9vbmVTaG90cy5j bGVhcigpOworCisgICAgaWYgKCFoYXNMaXN0ZW5lcnMoKSkKKyAgICAgICAgbV9zZXJ2aWNlLT5z dG9wVXBkYXRpbmcoKTsKIH0KIAogdm9pZCBHZW9sb2NhdGlvbjo6cmVxdWVzdFBlcm1pc3Npb24o KQotLSAKMS42LjMuMwoK