27886 2009-07-31 09:36:24 -0700 Build QtWebKit without benchmark tests for Qt < 4.5 2009-07-31 09:55:35 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jpetsovits webkit-unassigned oldest_to_newest 136181 0 jpetsovits 2009-07-31 09:36:24 -0700 On one of my systems, I accidentally had Qt 4.4 installed, and decided to build the Qt port there. The QBENCHMARK macro is only available from 4.5 on though, and test files making use of QBENCHMARK are included unconditionally at the moment. The patch below fixes this, and makes WebKit/qt/tests compile with 4.4 again. 136184 1 33883 jpetsovits 2009-07-31 09:40:24 -0700 Created attachment 33883 Build QtWebKit without benchmark tests for Qt < 4.5 136185 2 33884 jpetsovits 2009-07-31 09:43:10 -0700 Created attachment 33884 Build QtWebKit without benchmark tests for Qt < 4.5 (try 2) Don't end a sentence with two periods, only one. 136187 3 jpetsovits 2009-07-31 09:55:35 -0700 Landed by Kenneth Rohde Christiansen with r46632. 33883 2009-07-31 09:40:24 -0700 2009-07-31 09:43:10 -0700 Build QtWebKit without benchmark tests for Qt < 4.5 qt-tests-no-benchmarks-for-4.4.diff text/plain 1116 jpetsovits ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGZhNTk4YzMuLmVkMjk3YzIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTA3LTMxICBKYWtv YiBQZXRzb3ZpdHMgIDxqYWtvYi5wZXRzb3ZpdHNAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIFF0V2ViS2l0IHdp dGhvdXQgYmVuY2htYXJrIHRlc3RzIGZvciBRdCA8IDQuNS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODg2CisKKyAgICAgICAgVGhlIFFCRU5DSE1B UksgbWFjcm8gaXMgb25seSBhdmFpbGFibGUgZnJvbSA0LjUgb24sCisgICAgICAgIHNvIGJ1aWxk cyBmb3IgUXQgPCA0LjUgc2hvdWxkbid0IHRyeSB0byBidWlsZCB0aG9zZS4uCisKKyAgICAgICAg KiB0ZXN0cy90ZXN0cy5wcm86CisKIDIwMDktMDctMzEgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gVHJl YXQuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvdGVzdHMucHJvIGIvV2ViS2l0L3F0L3Rl c3RzL3Rlc3RzLnBybwppbmRleCA3MDAwZDMyLi5lNzE3ZThmIDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvdGVzdHMvdGVzdHMucHJvCisrKyBiL1dlYktpdC9xdC90ZXN0cy90ZXN0cy5wcm8KQEAgLTEs NCArMSw0IEBACiAKIFRFTVBMQVRFID0gc3ViZGlycwogU1VCRElSUyA9IHF3ZWJmcmFtZSBxd2Vi cGFnZSBxd2ViZWxlbWVudCBxd2ViaGlzdG9yeWludGVyZmFjZSBxd2VidmlldyBxd2ViaGlzdG9y eQotU1VCRElSUyArPSBiZW5jaG1hcmtzL3BhaW50aW5nL3RzdF9wYWludGluZy5wcm8gYmVuY2ht YXJrcy9sb2FkaW5nL3RzdF9sb2FkaW5nLnBybworZ3JlYXRlclRoYW4oUVRfTUlOT1JfVkVSU0lP TiwgNCk6IFNVQkRJUlMgKz0gYmVuY2htYXJrcy9wYWludGluZy90c3RfcGFpbnRpbmcucHJvIGJl bmNobWFya3MvbG9hZGluZy90c3RfbG9hZGluZy5wcm8K 33884 2009-07-31 09:43:10 -0700 2009-07-31 09:46:07 -0700 Build QtWebKit without benchmark tests for Qt < 4.5 (try 2) qt-tests-no-benchmarks-for-4.4.diff text/plain 1115 jpetsovits ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGZhNTk4YzMuLjQ3OGUyNmMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTA3LTMxICBKYWtv YiBQZXRzb3ZpdHMgIDxqYWtvYi5wZXRzb3ZpdHNAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIFF0V2ViS2l0IHdp dGhvdXQgYmVuY2htYXJrIHRlc3RzIGZvciBRdCA8IDQuNS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODg2CisKKyAgICAgICAgVGhlIFFCRU5DSE1B UksgbWFjcm8gaXMgb25seSBhdmFpbGFibGUgZnJvbSA0LjUgb24sCisgICAgICAgIHNvIGJ1aWxk cyBmb3IgUXQgPCA0LjUgc2hvdWxkbid0IHRyeSB0byBidWlsZCB0aG9zZS4KKworICAgICAgICAq IHRlc3RzL3Rlc3RzLnBybzoKKwogMjAwOS0wNy0zMSAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBUcmVh dC4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy90ZXN0cy5wcm8gYi9XZWJLaXQvcXQvdGVz dHMvdGVzdHMucHJvCmluZGV4IDcwMDBkMzIuLmU3MTdlOGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9x dC90ZXN0cy90ZXN0cy5wcm8KKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3Rlc3RzLnBybwpAQCAtMSw0 ICsxLDQgQEAKIAogVEVNUExBVEUgPSBzdWJkaXJzCiBTVUJESVJTID0gcXdlYmZyYW1lIHF3ZWJw YWdlIHF3ZWJlbGVtZW50IHF3ZWJoaXN0b3J5aW50ZXJmYWNlIHF3ZWJ2aWV3IHF3ZWJoaXN0b3J5 Ci1TVUJESVJTICs9IGJlbmNobWFya3MvcGFpbnRpbmcvdHN0X3BhaW50aW5nLnBybyBiZW5jaG1h cmtzL2xvYWRpbmcvdHN0X2xvYWRpbmcucHJvCitncmVhdGVyVGhhbihRVF9NSU5PUl9WRVJTSU9O LCA0KTogU1VCRElSUyArPSBiZW5jaG1hcmtzL3BhaW50aW5nL3RzdF9wYWludGluZy5wcm8gYmVu Y2htYXJrcy9sb2FkaW5nL3RzdF9sb2FkaW5nLnBybwo=