27883 2009-07-31 09:03:56 -0700 [commit+] [v8] check if proxy is present before invoking a handler 2009-08-02 00:33:51 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 antonm webkit-unassigned abarth vitalyr oldest_to_newest 136168 0 antonm 2009-07-31 09:03:56 -0700 There is NPE crash (http://crash/reportdetail?reportid=19d99906cbceb8a7&product=Chrome&version=3.0.196.0&date=&signature=WebCore::V8Proxy::callFunction%28v8::Handle) which is most probably due NULL proxy. 136170 1 33878 antonm 2009-07-31 09:10:57 -0700 Created attachment 33878 Initial version To be honest, I would guess the code expects always not NULL proxy here as listeners are enabled. (but I think in that case it should be documented with ASSERT). So I am by no means insisting on this patch. One thing that stroke me is presence of GoogleUpdateClient in the call stack (see http://crash/reportdetail?reportid=19d99906cbceb8a7&product=Chrome&version=3.0.196.0&date=&signature=WebCore::V8Proxy::callFunction%28v8::Handle). My immediate reaction is something wasn't initialized properly. And I'll be on vacation two next weeks. 136173 2 33878 levin 2009-07-31 09:19:04 -0700 Comment on attachment 33878 Initial version > Index: third_party/WebKit/WebCore/ChangeLog > +2009-07-31 Anton Muhin <antonm@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + Please add: Bug Title Bug Link "prepare-ChangeLog --bug #" will do this for you. > + Do not invoke handler functio if proxy is NULL (that would lead to NPE anyway). typo: functio Change NULL to 0 (since WebKit doesn't use NULL). NPE is not an abbreviation that I'm familiar with but I guess you mean crash/access violation. It would be good to write it in a longer form without using an abbreviation. Also, this ChangeLog explains what but not why. Please add why. Can there be a layout test for whatever problem was encountered? If so, please add one. If not, why not? 136210 3 33893 antonm 2009-07-31 12:01:06 -0700 Created attachment 33893 Next iteration 136212 4 antonm 2009-07-31 12:07:35 -0700 (In reply to comment #2) > (From update of attachment 33878 [details]) > > Index: third_party/WebKit/WebCore/ChangeLog > > +2009-07-31 Anton Muhin <antonm@chromium.org> > > + > > + Reviewed by NOBODY (OOPS!). > > + > > Please add: > > Bug Title > Bug Link > > "prepare-ChangeLog --bug #" will do this for you. Hopefully done. Thanks a lot for pointing out a flag. Could this information be added to http://webkit.org/coding/contributing.html (just asking) > > > + Do not invoke handler functio if proxy is NULL (that would lead to NPE anyway). > > typo: functio Tnx, done. > > Change NULL to 0 (since WebKit doesn't use NULL). > > NPE is not an abbreviation that I'm familiar with but I guess you mean > crash/access violation. It would be good to write it in a longer form without > using an abbreviation. Hopefully done. > > Also, this ChangeLog explains what but not why. Please add why. The problem is I don't know why (that's why I think we could drop this patch)---I think error is higher level, but I don't know enough to find the proper place. > > > Can there be a layout test for whatever problem was encountered? > If so, please add one. > If not, why not? See above. Sorry for repetition, but you, David, may know better person to track this down---I believe the problem is in higher levels (but in that case I'd like to see ASSERT here instead my poor if)---I can understand that if event listener could be invoked, there should be proxy. However, I am definitely not a person to understand every minutae of the stuff. 136214 5 33893 abarth 2009-07-31 12:22:23 -0700 Comment on attachment 33893 Next iteration Thanks for the patch. Can you file a bug to investigate whether we're making a mistake at a higher level? As for modifying contributing.html, it's in SVN under WebKitSite. Feel free to file a bug and propose a patch. :) 136417 6 abarth 2009-07-31 23:18:43 -0700 In the future, please create patches with bugzilla-tool or svn-create-patch. This patch isn't correctly based, so we can't use our automatic tools. :( 136518 7 abarth 2009-08-02 00:33:51 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/custom/V8CustomEventListener.cpp Committed r46689 M WebCore/ChangeLog M WebCore/bindings/v8/custom/V8CustomEventListener.cpp r46689 = 0fe2074611f24744d6dc1a6d37d9bb5f7ab66d10 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46689 33878 2009-07-31 09:10:57 -0700 2009-07-31 12:01:06 -0700 Initial version webcore.patch text/plain 1297 antonm SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSB0aGlyZF9wYXJ0eS9XZWJLaXQvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjMxKQor KysgdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDctMzEgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBE byBub3QgaW52b2tlIGhhbmRsZXIgZnVuY3RpbyBpZiBwcm94eSBpcyBOVUxMICh0aGF0IHdvdWxk IGxlYWQgdG8gTlBFIGFueXdheSkuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhD dXN0b21FdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RXZlbnRMaXN0ZW5l cjo6Y2FsbExpc3RlbmVyRnVuY3Rpb24pOgorCiAyMDA5LTA3LTMxICBYYW4gTG9wZXogIDx4bG9w ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSb2xsIG91dCBwcmV2aW91cyBjaGFuZ2UgYXMgaXQg bWlnaHQgYmUgY2F1c2luZyBzb21lIHdlaXJkbmVzcyBpbgpJbmRleDogdGhpcmRfcGFydHkvV2Vi S2l0L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tRXZlbnRMaXN0ZW5lci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4Q3VzdG9tRXZlbnRMaXN0ZW5lci5jcHAJKHJldmlzaW9uIDQ2NTcwKQorKysgdGhpcmRf cGFydHkvV2ViS2l0L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tRXZlbnRMaXN0 ZW5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDggQEAgdjg6OkxvY2FsPHY4OjpW YWx1ZT4gVjhFdmVudExpc3RlbmVyOjpjYQogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBwYXJh bWV0ZXJzWzFdID0geyBqc0V2ZW50IH07CiAKICAgICBWOFByb3h5KiBwcm94eSA9IFY4UHJveHk6 OnJldHJpZXZlKG1fZnJhbWUpOworICAgIGlmICghcHJveHkpCisgICAgICAgIHJldHVybiB2ODo6 TG9jYWw8djg6OlZhbHVlPigpOwogICAgIHJldHVybiBwcm94eS0+Y2FsbEZ1bmN0aW9uKGhhbmRs ZXJGdW5jdGlvbiwgcmVjZWl2ZXIsIDEsIHBhcmFtZXRlcnMpOwogfQogCg== 33893 2009-07-31 12:01:06 -0700 2009-07-31 12:22:22 -0700 Next iteration webcore.patch text/plain 1379 antonm SW5kZXg6IFdlYktpdC9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjMxKQorKysgV2ViS2l0L1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMzEgIEFudG9uIE11 aGluICA8YW50b25tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbdjhdIGNoZWNrIGlmIHByb3h5IGlzIHByZXNlbnQgYmVmb3Jl IGludm9raW5nIGEgaGFuZGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjc4ODMgCisKKyAgICAgICAgRG8gbm90IGludm9rZSBoYW5kbGVyIGZ1bmN0 aW9uIGlmIHByb3h5IGlzIG51bGwgcG9pbnRlciAodGhhdCB3b3VsZCBsZWFkIHRvIGFjY2VzcyB2 aW9sYXRpb24KKyAgICAgICAgYW55d2F5KQorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9t L1Y4Q3VzdG9tRXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOEV2ZW50TGlz dGVuZXI6OmNhbGxMaXN0ZW5lckZ1bmN0aW9uKToKKwogMjAwOS0wNy0zMSAgWGFuIExvcGV6ICA8 eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUm9sbCBvdXQgcHJldmlvdXMgY2hhbmdlIGFz IGl0IG1pZ2h0IGJlIGNhdXNpbmcgc29tZSB3ZWlyZG5lc3MgaW4KSW5kZXg6IFdlYktpdC9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbUV2ZW50TGlzdGVuZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbUV2ZW50TGlz dGVuZXIuY3BwCShyZXZpc2lvbiA0NjU3MCkKKysrIFdlYktpdC9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOEN1c3RvbUV2ZW50TGlzdGVuZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04Myw2 ICs4Myw4IEBAIHY4OjpMb2NhbDx2ODo6VmFsdWU+IFY4RXZlbnRMaXN0ZW5lcjo6Y2EKICAgICB2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcGFyYW1ldGVyc1sxXSA9IHsganNFdmVudCB9OwogCiAgICAg VjhQcm94eSogcHJveHkgPSBWOFByb3h5OjpyZXRyaWV2ZShtX2ZyYW1lKTsKKyAgICBpZiAoIXBy b3h5KQorICAgICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpWYWx1ZT4oKTsKICAgICByZXR1cm4g cHJveHktPmNhbGxGdW5jdGlvbihoYW5kbGVyRnVuY3Rpb24sIHJlY2VpdmVyLCAxLCBwYXJhbWV0 ZXJzKTsKIH0KIAo=