<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27876</bug_id>
          
          <creation_ts>2009-07-31 05:44:42 -0700</creation_ts>
          <short_desc>Expose the Offline Web Application Cache API in the Qt API</short_desc>
          <delta_ts>2009-07-31 06:30:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Kenneth Rohde Christiansen">kenneth</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>136145</commentid>
    <comment_count>0</comment_count>
      <attachid>33873</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-07-31 05:44:42 -0700</bug_when>
    <thetext>Created attachment 33873
Add API to Qt for exposing the webcache

We need to expose the offline web app cache in the Qt API, so that users can at least set some sane defaults for their applications.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136152</commentid>
    <comment_count>1</comment_count>
      <attachid>33873</attachid>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2009-07-31 06:22:37 -0700</bug_when>
    <thetext>Comment on attachment 33873
Add API to Qt for exposing the webcache

looks good, but we have to do an api review of all of this offline/cache stuff before the release. a few nitpicks:

&gt; @@ -358,7 +358,6 @@ QWebSettings::QWebSettings()
&gt;      d-&gt;attributes.insert(QWebSettings::LocalStorageDatabaseEnabled, true);
&gt;      d-&gt;attributes.insert(QWebSettings::LocalContentCanAccessRemoteUrls, true);
&gt;      d-&gt;offlineStorageDefaultQuota = 5 * 1024 * 1024;
&gt; -
&gt;  }

Whitespace change, please remove.

&gt; @@ -785,10 +784,17 @@ qint64 QWebSettings::offlineStorageDefaultQuota()
&gt;  }
&gt;  
&gt;  /*
&gt; -    \internal
&gt; +    \since 4.6
&gt;      \relates QWebSettings
&gt;  
&gt;      Sets the path for HTML5 offline web application cache storage to \a path.

Please add linebreak here.

&gt; +    An application cache acts like an HTTP cache in some sense. For documents
&gt; +    that use the application cache via JavaScript, the loader mechinery will
&gt; +    first ask the application cache for the contents, before hitting the
&gt; +    network.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136154</commentid>
    <comment_count>2</comment_count>
      <attachid>33873</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2009-07-31 06:30:37 -0700</bug_when>
    <thetext>Comment on attachment 33873
Add API to Qt for exposing the webcache

Landed in 46628</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33873</attachid>
            <date>2009-07-31 05:44:42 -0700</date>
            <delta_ts>2009-07-31 06:30:37 -0700</delta_ts>
            <desc>Add API to Qt for exposing the webcache</desc>
            <filename>0001-2009-07-31-Kenneth-Rohde-Christiansen-kenneth-web.patch</filename>
            <type>text/plain</type>
            <size>5196</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSBjY2RhZGNjNTNkN2ViMzYzZjlkNDFkNTljYTIyOWZkZWZjZWRjNTNhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBGcmksIDMxIEp1bCAyMDA5IDA5OjQyOjAzIC0wMzAwClN1YmplY3Q6
IFtQQVRDSF0gMjAwOS0wNy0zMSAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRo
QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg
ICBFeHBvc2UgdGhlIE9mZmxpbmUgV2ViIEFwcGxpY2F0aW9uIENhY2hlIGluIHRoZSBRdCBBUEku
CgogICAgICAgICogQXBpL3F3ZWJzZXR0aW5ncy5jcHA6CiAgICAgICAgKFFXZWJTZXR0aW5nczo6
UVdlYlNldHRpbmdzKToKICAgICAgICAoUVdlYlNldHRpbmdzOjpzZXRPZmZsaW5lV2ViQXBwbGlj
YXRpb25DYWNoZVBhdGgpOgogICAgICAgIChRV2ViU2V0dGluZ3M6Om9mZmxpbmVXZWJBcHBsaWNh
dGlvbkNhY2hlUGF0aCk6CiAgICAgICAgKFFXZWJTZXR0aW5nczo6c2V0T2ZmbGluZVdlYkFwcGxp
Y2F0aW9uQ2FjaGVRdW90YSk6CiAgICAgICAgKFFXZWJTZXR0aW5nczo6b2ZmbGluZVdlYkFwcGxp
Y2F0aW9uQ2FjaGVRdW90YSk6CiAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmg6Ci0tLQogV2Vi
S2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwIHwgICA0NSArKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrLS0tLS0KIFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmggICB8ICAgIDUg
KysrKwogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysK
IDMgZmlsZXMgY2hhbmdlZCwgNTggaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAgYi9XZWJLaXQvcXQvQXBpL3F3
ZWJzZXR0aW5ncy5jcHAKaW5kZXggZmI5NGQ1NS4uNGYwZTUyOCAxMDA2NDQKLS0tIGEvV2ViS2l0
L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdz
LmNwcApAQCAtMzU4LDcgKzM1OCw2IEBAIFFXZWJTZXR0aW5nczo6UVdlYlNldHRpbmdzKCkKICAg
ICBkLT5hdHRyaWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OkxvY2FsU3RvcmFnZURhdGFiYXNl
RW5hYmxlZCwgdHJ1ZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpM
b2NhbENvbnRlbnRDYW5BY2Nlc3NSZW1vdGVVcmxzLCB0cnVlKTsKICAgICBkLT5vZmZsaW5lU3Rv
cmFnZURlZmF1bHRRdW90YSA9IDUgKiAxMDI0ICogMTAyNDsKLQogfQogCiAvKiEKQEAgLTc4NSwx
MCArNzg0LDE3IEBAIHFpbnQ2NCBRV2ViU2V0dGluZ3M6Om9mZmxpbmVTdG9yYWdlRGVmYXVsdFF1
b3RhKCkKIH0KIAogLyoKLSAgICBcaW50ZXJuYWwKKyAgICBcc2luY2UgNC42CiAgICAgXHJlbGF0
ZXMgUVdlYlNldHRpbmdzCiAKICAgICBTZXRzIHRoZSBwYXRoIGZvciBIVE1MNSBvZmZsaW5lIHdl
YiBhcHBsaWNhdGlvbiBjYWNoZSBzdG9yYWdlIHRvIFxhIHBhdGguCisgICAgQW4gYXBwbGljYXRp
b24gY2FjaGUgYWN0cyBsaWtlIGFuIEhUVFAgY2FjaGUgaW4gc29tZSBzZW5zZS4gRm9yIGRvY3Vt
ZW50cworICAgIHRoYXQgdXNlIHRoZSBhcHBsaWNhdGlvbiBjYWNoZSB2aWEgSmF2YVNjcmlwdCwg
dGhlIGxvYWRlciBtZWNoaW5lcnkgd2lsbAorICAgIGZpcnN0IGFzayB0aGUgYXBwbGljYXRpb24g
Y2FjaGUgZm9yIHRoZSBjb250ZW50cywgYmVmb3JlIGhpdHRpbmcgdGhlCisgICAgbmV0d29yay4K
KworICAgIFRoZSBmZWF0dXJlIGlzIGRlc2NyaWJlZCBpbiBkZXRhaWxzIGF0OgorICAgIGh0dHA6
Ly9kZXYudzMub3JnL2h0bWw1L3NwZWMvT3ZlcnZpZXcuaHRtbCNhcHBjYWNoZQogCiAgICAgXGEg
cGF0aCBtdXN0IHBvaW50IHRvIGFuIGV4aXN0aW5nIGRpcmVjdG9yeSB3aGVyZSB0aGUgY2FjaGUg
aXMgc3RvcmVkLgogCkBAIC03OTYsNyArODAyLDcgQEAgcWludDY0IFFXZWJTZXR0aW5nczo6b2Zm
bGluZVN0b3JhZ2VEZWZhdWx0UXVvdGEoKQogCiAgICAgXHNhIG9mZmxpbmVXZWJBcHBsaWNhdGlv
bkNhY2hlUGF0aCgpCiAqLwotdm9pZCBRV0VCS0lUX0VYUE9SVCBxdF93ZWJzZXR0aW5nc19zZXRP
ZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZVBhdGgoY29uc3QgUVN0cmluZyYgcGF0aCkKK3ZvaWQg
UVdlYlNldHRpbmdzOjpzZXRPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZVBhdGgoY29uc3QgUVN0
cmluZyYgcGF0aCkKIHsKICNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAg
IFdlYkNvcmU6OmNhY2hlU3RvcmFnZSgpLnNldENhY2hlRGlyZWN0b3J5KHBhdGgpOwpAQCAtODA0
LDE1ICs4MTAsMTUgQEAgdm9pZCBRV0VCS0lUX0VYUE9SVCBxdF93ZWJzZXR0aW5nc19zZXRPZmZs
aW5lV2ViQXBwbGljYXRpb25DYWNoZVBhdGgoY29uc3QgUVN0cmkKIH0KIAogLyoKLSAgICBcaW50
ZXJuYWwKKyAgICBcc2luY2UgNC42CiAgICAgXHJlbGF0ZXMgUVdlYlNldHRpbmdzCiAKICAgICBS
ZXR1cm5zIHRoZSBwYXRoIG9mIHRoZSBIVE1MNSBvZmZsaW5lIHdlYiBhcHBsaWNhdGlvbiBjYWNo
ZSBzdG9yYWdlCiAgICAgb3IgYW4gZW1wdHkgc3RyaW5nIGlmIHRoZSBmZWF0dXJlIGlzIGRpc2Fi
bGVkLgogCi0gICAgXHNhIHNldE9mZmxpbmVXZWJBcHBsaWNhdGlvbkNhY2hlUGF0aCgpCisgICAg
XHNhIHNldFdlYkFwcGxpY2F0aW9uQ2FjaGVQYXRoKCkKICovCi1RU3RyaW5nIFFXRUJLSVRfRVhQ
T1JUIHF0X3dlYnNldHRpbmdzX29mZmxpbmVXZWJBcHBsaWNhdGlvbkNhY2hlUGF0aCgpCitRU3Ry
aW5nIFFXZWJTZXR0aW5nczo6b2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVQYXRoKCkKIHsKICNp
ZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAgIHJldHVybiBXZWJDb3JlOjpj
YWNoZVN0b3JhZ2UoKS5jYWNoZURpcmVjdG9yeSgpOwpAQCAtODIxLDYgKzgyNywzMyBAQCBRU3Ry
aW5nIFFXRUJLSVRfRVhQT1JUIHF0X3dlYnNldHRpbmdzX29mZmxpbmVXZWJBcHBsaWNhdGlvbkNh
Y2hlUGF0aCgpCiAjZW5kaWYKIH0KIAorLyohCisgICAgXHNpbmNlIDQuNgorCisgICAgU2V0cyB0
aGUgdmFsdWUgb2YgdGhlIHF1b3RhIGZvciB0aGUgb2ZmbGluZSB3ZWIgYXBwbGljYXRpb24gY2Fj
aGUKKyAgICB0byBcYSBtYXhpbXVtU2l6ZS4KKyovCit2b2lkIFFXZWJTZXR0aW5nczo6c2V0T2Zm
bGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVRdW90YShxaW50NjQgbWF4aW11bVNpemUpCit7CisjaWYg
RU5BQkxFKE9GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUykKKyAgICBXZWJDb3JlOjpjYWNoZVN0b3Jh
Z2UoKS5zZXRNYXhpbXVtU2l6ZShtYXhpbXVtU2l6ZSk7CisjZW5kaWYKK30KKworLyohCisgICAg
XHNpbmNlIDQuNgorCisgICAgUmV0dXJucyB0aGUgdmFsdWUgb2YgdGhlIHF1b3RhIGZvciB0aGUg
b2ZmbGluZSB3ZWIgYXBwbGljYXRpb24gY2FjaGUuCisqLworcWludDY0IFFXZWJTZXR0aW5nczo6
b2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVRdW90YSgpCit7CisjaWYgRU5BQkxFKE9GRkxJTkVf
V0VCX0FQUExJQ0FUSU9OUykKKyAgICByZXR1cm4gV2ViQ29yZTo6Y2FjaGVTdG9yYWdlKCkubWF4
aW11bVNpemUoKTsKKyNlbHNlCisgICAgcmV0dXJuIDA7CisjZW5kaWYKK30KKwogLyoKICAgICBc
c2luY2UgNC41CiAgICAgXHJlbGF0ZXMgUVdlYlNldHRpbmdzCmRpZmYgLS1naXQgYS9XZWJLaXQv
cXQvQXBpL3F3ZWJzZXR0aW5ncy5oIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAppbmRl
eCA2MzE0NGNiLi5lMGQ0MzNiIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5n
cy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgKQEAgLTExNCw2ICsxMTQsMTEg
QEAgcHVibGljOgogICAgIHN0YXRpYyB2b2lkIHNldE9mZmxpbmVTdG9yYWdlRGVmYXVsdFF1b3Rh
KHFpbnQ2NCBtYXhpbXVtU2l6ZSk7CiAgICAgc3RhdGljIHFpbnQ2NCBvZmZsaW5lU3RvcmFnZURl
ZmF1bHRRdW90YSgpOwogCisgICAgc3RhdGljIHZvaWQgc2V0T2ZmbGluZVdlYkFwcGxpY2F0aW9u
Q2FjaGVQYXRoKGNvbnN0IFFTdHJpbmcmIHBhdGgpOworICAgIHN0YXRpYyBRU3RyaW5nIG9mZmxp
bmVXZWJBcHBsaWNhdGlvbkNhY2hlUGF0aCgpOworICAgIHN0YXRpYyB2b2lkIHNldE9mZmxpbmVX
ZWJBcHBsaWNhdGlvbkNhY2hlUXVvdGEocWludDY0IG1heGltdW1TaXplKTsKKyAgICBzdGF0aWMg
cWludDY0IG9mZmxpbmVXZWJBcHBsaWNhdGlvbkNhY2hlUXVvdGEoKTsKKwogICAgIHN0YXRpYyB2
b2lkIGNsZWFyTWVtb3J5Q2FjaGVzKCk7CiAKICAgICBpbmxpbmUgUVdlYlNldHRpbmdzUHJpdmF0
ZSogaGFuZGxlKCkgY29uc3QgeyByZXR1cm4gZDsgfQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0No
YW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggOGRkYTgwMS4uZTM0NjNhMSAxMDA2
NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTcgQEAKKzIwMDktMDctMzEgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8
a2VubmV0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEV4cG9zZSB0aGUgT2ZmbGluZSBXZWIgQXBwbGljYXRpb24gQ2FjaGUgaW4g
dGhlIFF0IEFQSS4KKworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAo
UVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpzZXRP
ZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZVBhdGgpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpv
ZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZVBhdGgpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpz
ZXRPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZVF1b3RhKToKKyAgICAgICAgKFFXZWJTZXR0aW5n
czo6b2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVRdW90YSk6CisgICAgICAgICogQXBpL3F3ZWJz
ZXR0aW5ncy5oOgorCiAyMDA5LTA3LTMwICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtl
bm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFRyZWF0LgotLSAK
MS42LjAuNAoK
</data>

          </attachment>
      

    </bug>

</bugzilla>