27875 2009-07-31 05:00:25 -0700 Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct 2009-08-05 23:58:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned abarth oliver oldest_to_newest 136141 0 zoltan 2009-07-31 05:00:25 -0700 Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1848. 136142 1 33872 zoltan 2009-07-31 05:04:50 -0700 Created attachment 33872 proposed patch 136505 2 abarth 2009-08-01 21:39:44 -0700 Oliver: Here's the another patch similar to the one you didn't like. Would you like to double check it? 137531 3 33872 abarth 2009-08-05 23:28:07 -0700 Comment on attachment 33872 proposed patch As is this one. 137537 4 33872 abarth 2009-08-05 23:58:00 -0700 Comment on attachment 33872 proposed patch Clearing review flag on attachment: 33872 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.h Committed r46837 M LayoutTests/platform/gtk/Skipped M LayoutTests/ChangeLog r46836 = 75353465f722f91d89afde0ce2a14f7179576a66 (trunk) M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.h r46837 = c4b3d98c6a56bb0a0b54922f9c686624656ddf8e (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46837 137538 5 abarth 2009-08-05 23:58:06 -0700 All reviewed patches have been landed. Closing bug. 33872 2009-07-31 05:04:50 -0700 2009-08-05 23:58:00 -0700 proposed patch ScopeNodeData.patch text/plain 1189 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjI1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMzEgIFpvbHRhbiBI b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9u IGNvbnRyb2wgZm9yIEphdmFTY3JpcHRDb3JlJ3MgU2NvcGVOb2RlRGF0YSBzdHJ1Y3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODc1CisKKyAgICAg ICAgSW5oZXJpdHMgU2NvcGVOb2RlRGF0YSBzdHJ1Y3QgZnJvbSBGYXN0QWxsb2NCYXNlIGJlY2F1 c2UgaXQgaGFzIGJlZW4gaW5zdGFudGlhdGVkIGJ5CisgICAgICAgICduZXcnIGluIEphdmFTY3Jp cHRDb3JlL3BhcnNlci9Ob2Rlcy5jcHA6MTg0OC4KKworICAgICAgICAqIHBhcnNlci9Ob2Rlcy5o OgorCiAyMDA5LTA3LTMwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpJbmRleDogSmF2YVNjcmlwdENvcmUvcGFyc2VyL05v ZGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcGFyc2VyL05vZGVzLmgJKHJldmlz aW9uIDQ2NjI1KQorKysgSmF2YVNjcmlwdENvcmUvcGFyc2VyL05vZGVzLmgJKHdvcmtpbmcgY29w eSkKQEAgLTEzNzgsNyArMTM3OCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBQYXJhbWV0 ZXJOb2RlKiBtX25leHQ7CiAgICAgfTsKIAotICAgIHN0cnVjdCBTY29wZU5vZGVEYXRhIHsKKyAg ICBzdHJ1Y3QgU2NvcGVOb2RlRGF0YSA6IEZhc3RBbGxvY0Jhc2UgewogICAgICAgICB0eXBlZGVm IERlY2xhcmF0aW9uU3RhY2tzOjpWYXJTdGFjayBWYXJTdGFjazsKICAgICAgICAgdHlwZWRlZiBE ZWNsYXJhdGlvblN0YWNrczo6RnVuY3Rpb25TdGFjayBGdW5jdGlvblN0YWNrOwogCg==