<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27871</bug_id>
          
          <creation_ts>2009-07-31 02:21:35 -0700</creation_ts>
          <short_desc>[commit+] Allow custom memory allocation control for JavaScriptCore&apos;s HashMap class</short_desc>
          <delta_ts>2009-08-01 11:36:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>136122</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-31 02:21:35 -0700</bug_when>
    <thetext>Inherits HashMap class from FastAllocBase because it has been instantiated by &apos;new&apos; in JavaScriptCore/API/JSClassRef.cpp:148.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136123</commentid>
    <comment_count>1</comment_count>
      <attachid>33864</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-31 02:24:35 -0700</bug_when>
    <thetext>Created attachment 33864
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136178</commentid>
    <comment_count>2</comment_count>
      <attachid>33864</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-07-31 09:29:41 -0700</bug_when>
    <thetext>Comment on attachment 33864
proposed patch

&gt; +        * wtf/RefPtrHashMap.h:
&gt; +        (WTF::):

Please don&apos;t leave broken lines like this in the change log just because the prepare-ChangeLog script put them there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136396</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-07-31 22:02:14 -0700</bug_when>
    <thetext>I had this failure again:
tables/mozilla/bugs/bug2479-4.html -&gt; failed

Starting to think it might not be related to these patches.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136471</commentid>
    <comment_count>4</comment_count>
      <attachid>33864</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-01 11:35:59 -0700</bug_when>
    <thetext>Comment on attachment 33864
proposed patch

Clearing review flag on attachment: 33864

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/RefPtrHashMap.h
Committed r46675
	A	LayoutTests/platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt
	M	LayoutTests/platform/win/Skipped
	M	LayoutTests/ChangeLog
r46674 = d76ae4ee615ab1d3fa82d062c8ef4299bd89bd76 (trunk)
	M	JavaScriptCore/wtf/RefPtrHashMap.h
	M	JavaScriptCore/ChangeLog
r46675 = a3b8eb2865ca4b26d3b75bc0f0e72e669b2e99ce (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46675</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>136472</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-08-01 11:36:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>33864</attachid>
            <date>2009-07-31 02:24:35 -0700</date>
            <delta_ts>2009-08-01 11:35:59 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>HashMap.patch</filename>
            <type>text/plain</type>
            <size>1348</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjI1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMzEgIFpvbHRhbiBI
b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgQWxsb3cgY3VzdG9t
IG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIEphdmFTY3JpcHRDb3JlJ3MgSGFzaE1hcCBj
bGFzcworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzg3
MQorCisgICAgICAgIEluaGVyaXRzIEhhc2hNYXAgY2xhc3MgZnJvbSBGYXN0QWxsb2NCYXNlIGJl
Y2F1c2UgaXQgaGFzIGJlZW4KKyAgICAgICAgaW5zdGFudGlhdGVkIGJ5ICduZXcnIGluIEphdmFT
Y3JpcHRDb3JlL0FQSS9KU0NsYXNzUmVmLmNwcDoxNDguCisKKyAgICAgICAgKiB3dGYvUmVmUHRy
SGFzaE1hcC5oOgorICAgICAgICAoV1RGOjopOgorCiAyMDA5LTA3LTMwICBYYW4gTG9wZXogIDx4
bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpJbmRl
eDogSmF2YVNjcmlwdENvcmUvd3RmL1JlZlB0ckhhc2hNYXAuaAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh
U2NyaXB0Q29yZS93dGYvUmVmUHRySGFzaE1hcC5oCShyZXZpc2lvbiA0NjYyNSkKKysrIEphdmFT
Y3JpcHRDb3JlL3d0Zi9SZWZQdHJIYXNoTWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTQyLDcgKzQy
LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgfTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQs
IHR5cGVuYW1lIE1hcHBlZEFyZywgdHlwZW5hbWUgSGFzaEFyZywgdHlwZW5hbWUgS2V5VHJhaXRz
QXJnLCB0eXBlbmFtZSBNYXBwZWRUcmFpdHNBcmc+Ci0gICAgY2xhc3MgSGFzaE1hcDxSZWZQdHI8
VD4sIE1hcHBlZEFyZywgSGFzaEFyZywgS2V5VHJhaXRzQXJnLCBNYXBwZWRUcmFpdHNBcmc+IHsK
KyAgICBjbGFzcyBIYXNoTWFwPFJlZlB0cjxUPiwgTWFwcGVkQXJnLCBIYXNoQXJnLCBLZXlUcmFp
dHNBcmcsIE1hcHBlZFRyYWl0c0FyZz4gOiBwdWJsaWMgRmFzdEFsbG9jQmFzZSB7CiAgICAgcHJp
dmF0ZToKICAgICAgICAgdHlwZWRlZiBLZXlUcmFpdHNBcmcgS2V5VHJhaXRzOwogICAgICAgICB0
eXBlZGVmIE1hcHBlZFRyYWl0c0FyZyBNYXBwZWRUcmFpdHM7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>