27870 2009-07-31 00:56:16 -0700 isContentEditable function in htmlediting.* can be removed 2009-08-01 23:52:12 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC All RESOLVED FIXED P4 Normal --- 1 rniwa rniwa eric justin.garcia oldest_to_newest 136118 0 rniwa 2009-07-31 00:56:16 -0700 isContentEditable function is added in http://trac.webkit.org/changeset/19452 to accomplish enclosingNodeOfType(node, &isContentEditable) but this seems to be equivalent to node->isContentEditable() today. 136201 1 33889 rniwa 2009-07-31 11:24:51 -0700 Created attachment 33889 removes the function 136202 2 33889 adele 2009-07-31 11:32:09 -0700 Comment on attachment 33889 removes the function My only comment is that the title of this bug could be "isContentEditable function in htmlediting.* can be removed" instead of "must", but that doesn't really matter. 136206 3 justin.garcia 2009-07-31 11:45:21 -0700 Clarified with Ryosuke. We're only ever using enclosingNodeOfType(node, &isContentEditable) to determine the editability of node. So it's OK to remove. 136513 4 rniwa 2009-08-01 23:52:12 -0700 Landed in http://trac.webkit.org/changeset/46681. 33889 2009-07-31 11:24:51 -0700 2009-07-31 11:32:09 -0700 removes the function fix27870 text/plain 6565 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjYzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMDktMDctMzEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaXND b250ZW50RWRpdGFibGUgZnVuY3Rpb24gaW4gaHRtbGVkaXRpbmcuKiBtdXN0IGJlIHJlbW92ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODcwCisK KyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIGlzQ29udGVudEVkaXRhYmxlIGZ1bmN0aW9uIGlu IGh0bWxlZGl0aW5nLmNwcCBhbmQKKyAgICAgICAgcmVwbGFjZXMgYWxsIHVzYWdlIGJ5IGNhbGxp bmcgTm9kZTo6aXNDb250ZW50RWRpdGFibGUgb3IgaXRzIGRlcml2YXRpdmVzLgorCisgICAgICAg ICogZWRpdGluZy9BcHBlbmROb2RlQ29tbWFuZC5jcHA6IGRpdHRvCisgICAgICAgIChXZWJDb3Jl OjpBcHBlbmROb2RlQ29tbWFuZDo6QXBwZW5kTm9kZUNvbW1hbmQpOiBkaXR0bworICAgICAgICAq IGVkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwOiBkaXR0bworICAgICAgICAoV2ViQ29y ZTo6SW5kZW50T3V0ZGVudENvbW1hbmQ6Om91dGRlbnRQYXJhZ3JhcGgpOiBkaXR0bworICAgICAg ICAqIGVkaXRpbmcvSW5zZXJ0Tm9kZUJlZm9yZUNvbW1hbmQuY3BwOiBkaXR0bworICAgICAgICAo V2ViQ29yZTo6SW5zZXJ0Tm9kZUJlZm9yZUNvbW1hbmQ6Okluc2VydE5vZGVCZWZvcmVDb21tYW5k KTogZGl0dG8KKyAgICAgICAgKiBlZGl0aW5nL2h0bWxlZGl0aW5nLmNwcDogZGl0dG8KKyAgICAg ICAgKFdlYkNvcmU6OmVuY2xvc2luZ05vZGVXaXRoVGFnKTogZGl0dG8KKyAgICAgICAgKFdlYkNv cmU6OmVuY2xvc2luZ05vZGVPZlR5cGUpOiBkaXR0bworICAgICAgICAoV2ViQ29yZTo6Y2FuTWVy Z2VMaXN0cyk6IGRpdHRvCisgICAgICAgICogZWRpdGluZy9odG1sZWRpdGluZy5oOiBVcGRhdGVk IHByb3RvdHlwZQorCiAyMDA5LTA3LTMxICBHcmVnIEJvbHNpbmdhICA8Ym9sc2luZ2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgpJbmRleDogV2ViQ29y ZS9lZGl0aW5nL0FwcGVuZE5vZGVDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Vk aXRpbmcvQXBwZW5kTm9kZUNvbW1hbmQuY3BwCShyZXZpc2lvbiA0NjYyMCkKKysrIFdlYkNvcmUv ZWRpdGluZy9BcHBlbmROb2RlQ29tbWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5 LDcgQEAgQXBwZW5kTm9kZUNvbW1hbmQ6OkFwcGVuZE5vZGVDb21tYW5kKFBhcwogICAgIEFTU0VS VChtX25vZGUpOwogICAgIEFTU0VSVCghbV9ub2RlLT5wYXJlbnQoKSk7CiAKLSAgICBBU1NFUlQo ZW5jbG9zaW5nTm9kZU9mVHlwZShQb3NpdGlvbihtX3BhcmVudC5nZXQoKSwgMCksIGlzQ29udGVu dEVkaXRhYmxlKSB8fCAhbV9wYXJlbnQtPmF0dGFjaGVkKCkpOworICAgIEFTU0VSVChtX3BhcmVu dC0+aXNDb250ZW50RWRpdGFibGUoKSB8fCAhbV9wYXJlbnQtPmF0dGFjaGVkKCkpOwogfQogCiB2 b2lkIEFwcGVuZE5vZGVDb21tYW5kOjpkb0FwcGx5KCkKSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9J bmRlbnRPdXRkZW50Q29tbWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL0lu ZGVudE91dGRlbnRDb21tYW5kLmNwcAkocmV2aXNpb24gNDY2MjApCisrKyBXZWJDb3JlL2VkaXRp bmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDQsNyArMjQ0 LDcgQEAgdm9pZCBJbmRlbnRPdXRkZW50Q29tbWFuZDo6b3V0ZGVudFBhcmFncgogICAgIFZpc2li bGVQb3NpdGlvbiB2aXNpYmxlRW5kT2ZQYXJhZ3JhcGggPSBlbmRPZlBhcmFncmFwaCh2aXNpYmxl U3RhcnRPZlBhcmFncmFwaCk7CiAKICAgICBOb2RlKiBlbmNsb3NpbmdOb2RlID0gZW5jbG9zaW5n Tm9kZU9mVHlwZSh2aXNpYmxlU3RhcnRPZlBhcmFncmFwaC5kZWVwRXF1aXZhbGVudCgpLCAmaXNM aXN0T3JJbmRlbnRCbG9ja3F1b3RlKTsKLSAgICBpZiAoIWVuY2xvc2luZ05vZGUgfHwgIWlzQ29u dGVudEVkaXRhYmxlKGVuY2xvc2luZ05vZGUtPnBhcmVudE5vZGUoKSkpICAvLyBXZSBjYW4ndCBv dXRkZW50IGlmIHRoZXJlIGlzIG5vIHBsYWNlIHRvIGdvIQorICAgIGlmICghZW5jbG9zaW5nTm9k ZSB8fCAhZW5jbG9zaW5nTm9kZS0+cGFyZW50Tm9kZSgpLT5pc0NvbnRlbnRFZGl0YWJsZSgpKSAg Ly8gV2UgY2FuJ3Qgb3V0ZGVudCBpZiB0aGVyZSBpcyBubyBwbGFjZSB0byBnbyEKICAgICAgICAg cmV0dXJuOwogCiAgICAgLy8gVXNlIEluc2VydExpc3RDb21tYW5kIHRvIHJlbW92ZSB0aGUgc2Vs ZWN0aW9uIGZyb20gdGhlIGxpc3QKQEAgLTI3Myw3ICsyNzMsNyBAQCB2b2lkIEluZGVudE91dGRl bnRDb21tYW5kOjpvdXRkZW50UGFyYWdyCiAgICAgICAgICAgICBpZiAoTm9kZSogc3BsaXRQb2lu dFBhcmVudCA9IHNwbGl0UG9pbnQtPnBhcmVudE5vZGUoKSkgewogICAgICAgICAgICAgICAgIGlm IChzcGxpdFBvaW50UGFyZW50LT5oYXNUYWdOYW1lKGJsb2NrcXVvdGVUYWcpCiAgICAgICAgICAg ICAgICAgICAgICYmICFzcGxpdFBvaW50LT5oYXNUYWdOYW1lKGJsb2NrcXVvdGVUYWcpCi0gICAg ICAgICAgICAgICAgICAgICYmIGlzQ29udGVudEVkaXRhYmxlKHNwbGl0UG9pbnRQYXJlbnQtPnBh cmVudE5vZGUoKSkpIC8vIFdlIGNhbid0IG91dGRlbnQgaWYgdGhlcmUgaXMgbm8gcGxhY2UgdG8g Z28hCisgICAgICAgICAgICAgICAgICAgICYmIHNwbGl0UG9pbnRQYXJlbnQtPnBhcmVudE5vZGUo KS0+aXNDb250ZW50RWRpdGFibGUoKSkgLy8gV2UgY2FuJ3Qgb3V0ZGVudCBpZiB0aGVyZSBpcyBu byBwbGFjZSB0byBnbyEKICAgICAgICAgICAgICAgICAgICAgc3BsaXRFbGVtZW50KHN0YXRpY19j YXN0PEVsZW1lbnQqPihzcGxpdFBvaW50UGFyZW50KSwgc3BsaXRQb2ludCk7CiAgICAgICAgICAg ICB9CiAgICAgICAgIH0KSW5kZXg6IFdlYkNvcmUvZWRpdGluZy9JbnNlcnROb2RlQmVmb3JlQ29t bWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL0luc2VydE5vZGVCZWZvcmVD b21tYW5kLmNwcAkocmV2aXNpb24gNDY2MjApCisrKyBXZWJDb3JlL2VkaXRpbmcvSW5zZXJ0Tm9k ZUJlZm9yZUNvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3IEBAIEluc2Vy dE5vZGVCZWZvcmVDb21tYW5kOjpJbnNlcnROb2RlQmVmb3IKICAgICBBU1NFUlQobV9yZWZDaGls ZCk7CiAgICAgQVNTRVJUKG1fcmVmQ2hpbGQtPnBhcmVudE5vZGUoKSk7CiAKLSAgICBBU1NFUlQo ZW5jbG9zaW5nTm9kZU9mVHlwZShQb3NpdGlvbihtX3JlZkNoaWxkLT5wYXJlbnROb2RlKCksIDAp LCBpc0NvbnRlbnRFZGl0YWJsZSkgfHwgIW1fcmVmQ2hpbGQtPnBhcmVudE5vZGUoKS0+YXR0YWNo ZWQoKSk7CisgICAgQVNTRVJUKG1fcmVmQ2hpbGQtPnBhcmVudE5vZGUoKS0+aXNDb250ZW50RWRp dGFibGUoKSB8fCAhbV9yZWZDaGlsZC0+cGFyZW50Tm9kZSgpLT5hdHRhY2hlZCgpKTsKIH0KIAog dm9pZCBJbnNlcnROb2RlQmVmb3JlQ29tbWFuZDo6ZG9BcHBseSgpCkluZGV4OiBXZWJDb3JlL2Vk aXRpbmcvaHRtbGVkaXRpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRpdGluZy9odG1s ZWRpdGluZy5jcHAJKHJldmlzaW9uIDQ2NjIwKQorKysgV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0 aW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIxLDExICsyMjEsNiBAQCBFbGVtZW50KiB1bnNw bGl0dGFibGVFbGVtZW50Rm9yUG9zaXRpb24oCiAgICAgcmV0dXJuIGVkaXRhYmxlUm9vdEZvclBv c2l0aW9uKHApOwogfQogCi1ib29sIGlzQ29udGVudEVkaXRhYmxlKGNvbnN0IE5vZGUqIG5vZGUp Ci17Ci0gICAgcmV0dXJuIG5vZGUtPmlzQ29udGVudEVkaXRhYmxlKCk7Ci19Ci0KIFBvc2l0aW9u IG5leHRDYW5kaWRhdGUoY29uc3QgUG9zaXRpb24mIHBvc2l0aW9uKQogewogICAgIFBvc2l0aW9u SXRlcmF0b3IgcCA9IHBvc2l0aW9uOwpAQCAtNjY0LDcgKzY1OSw3IEBAIE5vZGUqIGVuY2xvc2lu Z05vZGVXaXRoVGFnKGNvbnN0IFBvc2l0aW8KICAgICAgICAgCiAgICAgTm9kZSogcm9vdCA9IGhp Z2hlc3RFZGl0YWJsZVJvb3QocCk7CiAgICAgZm9yIChOb2RlKiBuID0gcC5ub2RlKCk7IG47IG4g PSBuLT5wYXJlbnROb2RlKCkpIHsKLSAgICAgICAgaWYgKHJvb3QgJiYgIWlzQ29udGVudEVkaXRh YmxlKG4pKQorICAgICAgICBpZiAocm9vdCAmJiAhbi0+aXNDb250ZW50RWRpdGFibGUoKSkKICAg ICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBpZiAobi0+aGFzVGFnTmFtZSh0YWdOYW1lKSkK ICAgICAgICAgICAgIHJldHVybiBuOwpAQCAtNjg0LDcgKzY3OSw3IEBAIE5vZGUqIGVuY2xvc2lu Z05vZGVPZlR5cGUoY29uc3QgUG9zaXRpb24KICAgICBmb3IgKE5vZGUqIG4gPSBwLm5vZGUoKTsg bjsgbiA9IG4tPnBhcmVudE5vZGUoKSkgewogICAgICAgICAvLyBEb24ndCByZXR1cm4gYSBub24t ZWRpdGFibGUgbm9kZSBpZiB0aGUgaW5wdXQgcG9zaXRpb24gd2FzIGVkaXRhYmxlLCBzaW5jZQog ICAgICAgICAvLyB0aGUgY2FsbGVycyBmcm9tIGVkaXRpbmcgd2lsbCBubyBkb3VidCB3YW50IHRv IHBlcmZvcm0gZWRpdGluZyBpbnNpZGUgdGhlIHJldHVybmVkIG5vZGUuCi0gICAgICAgIGlmIChy b290ICYmICFpc0NvbnRlbnRFZGl0YWJsZShuKSAmJiBvbmx5UmV0dXJuRWRpdGFibGVOb2RlcykK KyAgICAgICAgaWYgKHJvb3QgJiYgIW4tPmlzQ29udGVudEVkaXRhYmxlKCkgJiYgb25seVJldHVy bkVkaXRhYmxlTm9kZXMpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgaWYgKCgqbm9k ZUlzT2ZUeXBlKShuKSkKICAgICAgICAgICAgIHJldHVybiBuOwpAQCAtODIxLDcgKzgxNiw3IEBA IGJvb2wgY2FuTWVyZ2VMaXN0cyhFbGVtZW50KiBmaXJzdExpc3QsIEUKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgcmV0dXJuIGZpcnN0TGlzdC0+aGFzVGFnTmFtZShzZWNvbmRMaXN0LT50 YWdRTmFtZSgpKS8vIG1ha2Ugc3VyZSB0aGUgbGlzdCB0eXBlcyBtYXRjaCAob2wgdnMuIHVsKQot ICAgICYmIGlzQ29udGVudEVkaXRhYmxlKGZpcnN0TGlzdCkgJiYgaXNDb250ZW50RWRpdGFibGUo c2Vjb25kTGlzdCkvLyBib3RoIGxpc3RzIGFyZSBlZGl0YWJsZQorICAgICYmIGZpcnN0TGlzdC0+ aXNDb250ZW50RWRpdGFibGUoKSAmJiBzZWNvbmRMaXN0LT5pc0NvbnRlbnRFZGl0YWJsZSgpLy8g Ym90aCBsaXN0cyBhcmUgZWRpdGFibGUKICAgICAmJiBmaXJzdExpc3QtPnJvb3RFZGl0YWJsZUVs ZW1lbnQoKSA9PSBzZWNvbmRMaXN0LT5yb290RWRpdGFibGVFbGVtZW50KCkvLyBkb24ndCBjcm9z cyBlZGl0aW5nIGJvdW5kYXJpZXMKICAgICAmJiBpc1Zpc2libHlBZGphY2VudChwb3NpdGlvbkFm dGVyTm9kZShmaXJzdExpc3QpLCBwb3NpdGlvbkJlZm9yZU5vZGUoc2Vjb25kTGlzdCkpOwogICAg IC8vIE1ha2Ugc3VyZSB0aGVyZSBpcyBubyB2aXNpYmxlIGNvbnRlbnQgYmV0d2VlbiB0aGlzIGxp IGFuZCB0aGUgcHJldmlvdXMgbGlzdApJbmRleDogV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5n LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5nLmgJKHJldmlzaW9u IDQ2NjIwKQorKysgV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5nLmgJKHdvcmtpbmcgY29weSkK QEAgLTU0LDcgKzU0LDYgQEAgVmlzaWJsZVBvc2l0aW9uIGxhc3RFZGl0YWJsZVBvc2l0aW9uQmVm bwogaW50IGNvbXBhcmVQb3NpdGlvbnMoY29uc3QgUG9zaXRpb24mLCBjb25zdCBQb3NpdGlvbiYp OwogaW50IGNvbXBhcmVQb3NpdGlvbnMoY29uc3QgVmlzaWJsZVBvc2l0aW9uJiwgY29uc3QgVmlz aWJsZVBvc2l0aW9uJik7CiBOb2RlKiBsb3dlc3RFZGl0YWJsZUFuY2VzdG9yKE5vZGUqKTsKLWJv b2wgaXNDb250ZW50RWRpdGFibGUoY29uc3QgTm9kZSopOwogUG9zaXRpb24gbmV4dENhbmRpZGF0 ZShjb25zdCBQb3NpdGlvbiYpOwogUG9zaXRpb24gbmV4dFZpc3VhbGx5RGlzdGluY3RDYW5kaWRh dGUoY29uc3QgUG9zaXRpb24mKTsKIFBvc2l0aW9uIHByZXZpb3VzQ2FuZGlkYXRlKGNvbnN0IFBv c2l0aW9uJik7Cg==