27868 2009-07-30 22:43:52 -0700 http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others 2009-07-30 23:54:50 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED http://www.ruthhuntcandy.com/ InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 136105 0 beidson 2009-07-30 22:43:52 -0700 http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in Firefox. They have this HTML in their main resource: <META HTTP-EQUIV="Refresh" CONTENT="0; URL='http://www.ruthhuntcandy.com/default.asp"> The quotes are mismatched: Opens with a ' but closes with a ". parseHTTPRefresh() chokes in this case. So we can't parse the URL and default to the main page URL of http://www.ruthhuntcandy.com/. We do the scheduled refresh over and over, never moving on to http://www.ruthhuntcandy.com/default.asp This is truly a site bug, but Firefox, Opera 10, and IE6+ are all tolerant of this. In radar as <rdar://problem/7106968> 136108 1 beidson 2009-07-30 22:55:02 -0700 All the other browsers handle opening with a ' but closing with a " But none of them handle opening with a " and closing with a ' This is (probably and obviously) because ' is a legal URL character, but " isn't. So we just have to plug this specific case of '-" and leave "-' unanswered. 136110 2 beidson 2009-07-30 23:22:55 -0700 I completely missed the point here, actually. The meta-equiv is: "0; URL='http://www.ruthhuntcandy.com/default.asp" The opening and closing quotes are stripped in this context as a matching pair, leaving us with: 0; URL='http://www.ruthhuntcandy.com/default.asp The opening single quote has no closer. Thats the case we need to fix. 136112 3 33860 beidson 2009-07-30 23:44:29 -0700 Created attachment 33860 Fix + Layout Test 136113 4 33860 mrowe 2009-07-30 23:48:47 -0700 Comment on attachment 33860 Fix + Layout Test > Index: WebCore/platform/network/HTTPParsers.cpp > =================================================================== > --- WebCore/platform/network/HTTPParsers.cpp (revision 46514) > +++ WebCore/platform/network/HTTPParsers.cpp (working copy) > @@ -100,6 +100,12 @@ bool parseHTTPRefresh(const String& refr > if (refresh[urlEndPos] == quotationMark) > break; > } > + > + // https://bugs.webkit.org/show_bug.cgi?id=27868 > + // Sometimes there is no closing quote for the end of the URL even though there was an opening quote. > + // All of the other browsers handle this case. > + if (urlEndPos == urlStartPos) > + urlEndPos = len; > } The comment could be a little clearer about what it is we do to handle the stray quote (eg, skip over it). I had to read back up in the code to work out how this code related to the quote at all. r=me 136114 5 beidson 2009-07-30 23:54:50 -0700 Sending LayoutTests/ChangeLog Adding LayoutTests/http/tests/misc/meta-refresh-stray-single-quote-expected.txt Adding LayoutTests/http/tests/misc/meta-refresh-stray-single-quote.html Adding LayoutTests/http/tests/misc/resources/success-notify-done.html Sending WebCore/ChangeLog Sending WebCore/platform/network/HTTPParsers.cpp Transmitting file data ...... Committed revision 46624. 33860 2009-07-30 23:44:29 -0700 2009-07-30 23:48:46 -0700 Fix + Layout Test patch.txt text/plain 4167 beidson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjYyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMzAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MTA2OTY4PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI3ODY4CisgICAgICAgIGh0dHA6Ly93d3cucnV0aGh1bnRjYW5keS5jb20vIGdv ZXMgaW50byBpbmZpbml0ZSByZWZyZXNoIGluIFdlYktpdCwgd29ya3MgaW4gb3RoZXJzLgorICAg ICAgICAKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy9taXNjL21ldGEtcmVmcmVzaC1zdHJheS1z aW5nbGUtcXVvdGUuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vy cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYXJzZUhUVFBSZWZyZXNoKTogQWxsb3cgZm9yIGEg c3RyYXkgcXVvdGUgY2hhcmFjdGVyIGF0IHRoZSBzdGFydCBvZiB0aGUgVVJMIHN0cmluZy4KKwog MjAwOS0wNy0zMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkZWxlIFBldGVyc29uIGFuZCBKb24gSG9uZXljdXR0LgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuY3BwCShyZXZpc2lvbiA0NjUxNCkKKysrIFdlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEw MCw2ICsxMDAsMTIgQEAgYm9vbCBwYXJzZUhUVFBSZWZyZXNoKGNvbnN0IFN0cmluZyYgcmVmcgog ICAgICAgICAgICAgICAgIGlmIChyZWZyZXNoW3VybEVuZFBvc10gPT0gcXVvdGF0aW9uTWFyaykK ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CisgICAgICAgICAgICAK KyAgICAgICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Nzg2OAorICAgICAgICAgICAgLy8gU29tZXRpbWVzIHRoZXJlIGlzIG5vIGNsb3NpbmcgcXVvdGUg Zm9yIHRoZSBlbmQgb2YgdGhlIFVSTCBldmVuIHRob3VnaCB0aGVyZSB3YXMgYW4gb3BlbmluZyBx dW90ZS4KKyAgICAgICAgICAgIC8vIEFsbCBvZiB0aGUgb3RoZXIgYnJvd3NlcnMgaGFuZGxlIHRo aXMgY2FzZS4KKyAgICAgICAgICAgIGlmICh1cmxFbmRQb3MgPT0gdXJsU3RhcnRQb3MpCisgICAg ICAgICAgICAgICAgdXJsRW5kUG9zID0gbGVuOwogICAgICAgICB9CiAKICAgICAgICAgdXJsID0g cmVmcmVzaC5zdWJzdHJpbmcodXJsU3RhcnRQb3MsIHVybEVuZFBvcyAtIHVybFN0YXJ0UG9zKS5z dHJpcFdoaXRlU3BhY2UoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NjIzKQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMzAg IEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MTA2OTY4PiBhbmQg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODY4CisgICAgICAgIGh0 dHA6Ly93d3cucnV0aGh1bnRjYW5keS5jb20vIGdvZXMgaW50byBpbmZpbml0ZSByZWZyZXNoIGlu IFdlYktpdCwgd29ya3MgaW4gb3RoZXJzLgorCisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL21l dGEtcmVmcmVzaC1zdHJheS1zaW5nbGUtcXVvdGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBodHRwL3Rlc3RzL21pc2MvbWV0YS1yZWZyZXNoLXN0cmF5LXNpbmdsZS1xdW90ZS5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2MvcmVzb3VyY2VzL3N1Y2Nlc3Mtbm90 aWZ5LWRvbmUuaHRtbDogQWRkZWQuCisKIDIwMDktMDctMzAgIEFkYW0gVHJlYXQgIDxhZGFtLnRy ZWF0QHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBBZGQgZXhwZWN0ZWQgcmVzdWx0cyBmaWxl IGZvciBuZXcgdGVzdC4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9tZXRhLXJl ZnJlc2gtc3RyYXktc2luZ2xlLXF1b3RlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvbWV0YS1yZWZyZXNoLXN0cmF5LXNpbmdsZS1xdW90ZS1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mv bWV0YS1yZWZyZXNoLXN0cmF5LXNpbmdsZS1xdW90ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEgQEAKK1NVQ0NFU1MKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlz Yy9tZXRhLXJlZnJlc2gtc3RyYXktc2luZ2xlLXF1b3RlLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL21ldGEtcmVmcmVzaC1zdHJheS1zaW5nbGUtcXVvdGUu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9tZXRhLXJl ZnJlc2gtc3RyYXktc2luZ2xlLXF1b3RlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTkg QEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikgeworCWxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwlsYXlvdXRUZXN0 Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9Cis8L3NjcmlwdD4KKworPG1ldGEgaHR0cC1l cXVpdj0iUmVmcmVzaCIgY29udGVudD0iMDsgdXJsPSdyZXNvdXJjZXMvc3VjY2Vzcy1ub3RpZnkt ZG9uZS5odG1sIj4KKworPC9oZWFkPgorPGJvZHk+Cis8YSBocmVmPSJodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4NjgiPmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNzg2ODwvYT48YnI+CitTb21lIGF1dGhvcnMgaGF2ZSBhY2NpZGVudGFs bHkgd3JpdHRlbiBodHRwLWVxdXYgcmVmcmVzaCBoZWFkZXJzIHdpdGggYSBzdHJheSAnIGRlbm90 aW5nIHRoZSBVUkw8YnI+CitBbGwgb2YgdGhlIG90aGVyIGJyb3dzZXJzIGhhbmRsZSB0aGlzLCBz byB3ZSBzaG91bGQgYWxzbyBmb3IgY29tcGF0aWJpbGl0eS48YnI+CitUaGlzIHBhZ2Ugd2lsbCBl aXRoZXIgZ28gaW50byBpbmZpbml0ZSByZWZyZXNoLCBvciB3aWxsIGNvcnJlY3RseSByZWRpcmVj dCBvbmNlLjxicj4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVz dHMvbWlzYy9yZXNvdXJjZXMvc3VjY2Vzcy1ub3RpZnktZG9uZS5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9yZXNvdXJjZXMvc3VjY2Vzcy1ub3RpZnktZG9u ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3Jlc291 cmNlcy9zdWNjZXNzLW5vdGlmeS1kb25lLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNyBA QAorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisJbGF5b3V0VGVz dENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworPC9zY3JpcHQ+Cis8Ym9keT4KK1NVQ0NFU1MKKzwv Ym9keT4K