27866 2009-07-30 21:48:48 -0700 [requires-fixup] [Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible default 2009-08-02 00:59:09 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned abarth hausmann kenneth oldest_to_newest 136097 0 laszlo.gombos 2009-07-30 21:48:48 -0700 QtLauncher is crashing if a page with HTML5 App Cache is visited. This is because the app cache is designed so that WebCore::cacheStorage().setCacheDirectory() needs to be called with a path before the app cache can be used. As far as I can tell QtWebKit does not call WebCore::cacheStorage().setCacheDirectory to set the path for the app cache neither provides a public API for QtWebKit clients to set the path; the closes I found an internal API called qt_websettings_setOfflineWebApplicationCachePath() which indeed can be used as a work-around. As I first step I would like to propose that QtWebKit would set the app cache path to a sensible default so that QtWebKit clients does not have to deal with the issue. Later we might want to revisit how can a client set the path puth a public APi if there is a need for that. 136099 1 33856 laszlo.gombos 2009-07-30 21:59:56 -0700 Created attachment 33856 proposed patch 136140 2 kenneth 2009-07-31 04:50:05 -0700 We definately need to deal better with both WebDatabase WebStorage - Local and Session OfflineWebApplicationCache I actually have a patch adding support for that latter sitting around somewhere, but I stopped working on it as our API for these technologies is currently confusing, due to spec renaming. For instance our WebDatabase is called OfflineStorageDatabase, which leads people to think that it has to do with the appcache or the webstorage. Also, the webdatabase is not limited to offline usage. I believe that we need to deal with all this as soon as possible. 136147 3 kenneth 2009-07-31 05:47:18 -0700 OK, I posted the patch in question https://bugs.webkit.org/show_bug.cgi?id=27876 136153 4 kenneth 2009-07-31 06:30:04 -0700 OK, my patch has been committed (r46628), feel free to update your patch. Notice that you can set the max size now as well. 136155 5 kenneth 2009-07-31 06:32:35 -0700 When you set defaults, please update the documentation of the methods to mention these. 136156 6 33856 vestbo 2009-07-31 06:34:47 -0700 Comment on attachment 33856 proposed patch Looks good! A minor nitpick, just fix before landing: > +static void WebKitInitializeApplicationCachePathIfNecessary() Should be named initializeApplicationCachePathIfNecessary(), ie no WebKit prefix, and start with lower-case. Actually this is not in the coding style guidelines, but I think the lower case variant is more prevalent. 136524 7 abarth 2009-08-02 00:59:09 -0700 Landed with my bare hands due to https://bugs.webkit.org/show_bug.cgi?id=27930 Sending WebKit/qt/Api/qwebpage.cpp Sending WebKit/qt/ChangeLog Transmitting file data .. Committed revision 46691. 33856 2009-07-30 21:59:56 -0700 2009-07-31 06:34:47 -0700 proposed patch patch_27866.txt text/plain 2639 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDY2MjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMzAgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gSW5pdGlhbGl6ZSBIVE1MNSBBcHBsaWNhdGlvbiBDYWNoZSBmb3Ig UXRXZWJLaXQgdG8gYSBzZW5zaWJsZSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzg2NgorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNw cDoKKyAgICAgICAgKFdlYktpdEluaXRpYWxpemVBcHBsaWNhdGlvbkNhY2hlUGF0aElmTmVjZXNz YXJ5KToKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6UVdlYlBhZ2VQcml2YXRlKToKKwogMjAw OS0wNy0zMCAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBUcmVhdC4KSW5kZXg6IFdlYktpdC9xdC9BcGkv cXdlYnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCShy ZXZpc2lvbiA0NjU0MikKKysrIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNiw2ICszNiw3IEBACiAjaW5jbHVkZSAiRnJhbWVMb2FkZXJDbGllbnRRdC5oIgog I2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1ZGUgIkZvcm1TdGF0ZS5oIgorI2luY2x1ZGUg IkFwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlLmgiCiAjaW5jbHVkZSAiQ2hyb21lQ2xpZW50UXQuaCIK ICNpbmNsdWRlICJDb250ZXh0TWVudS5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51Q2xpZW50UXQu aCIKQEAgLTc1LDYgKzc2LDcgQEAKICNpbmNsdWRlIDxRQmFzaWNUaW1lcj4KICNpbmNsdWRlIDxR Qml0QXJyYXk+CiAjaW5jbHVkZSA8UURlYnVnPgorI2luY2x1ZGUgPFFEZXNrdG9wU2VydmljZXM+ CiAjaW5jbHVkZSA8UURyYWdFbnRlckV2ZW50PgogI2luY2x1ZGUgPFFEcmFnTGVhdmVFdmVudD4K ICNpbmNsdWRlIDxRRHJhZ01vdmVFdmVudD4KQEAgLTI2Myw2ICsyNjUsMzAgQEAgc3RhdGljIGlu bGluZSBRdDo6RHJvcEFjdGlvbiBkcmFnT3BUb0RybwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAK K3N0YXRpYyB2b2lkIFdlYktpdEluaXRpYWxpemVBcHBsaWNhdGlvbkNhY2hlUGF0aElmTmVjZXNz YXJ5KCkKK3sKKyNpZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQorICAgIHN0YXRp YyBib29sIGluaXRpYWxpemVkID0gZmFsc2U7CisgICAgICAgIAorICAgIGlmIChpbml0aWFsaXpl ZCkKKyAgICAgICAgcmV0dXJuOworCisgICAgLy8gRGV0ZXJtaW5lIHRoZSBwYXRoIGZvciBIVE1M NSBBcHBsaWNhdGlvbiBDYWNoZSBEQgorICAgIFFTdHJpbmcgYXBwQ2FjaGVQYXRoOworI2lmIFFU X1ZFUlNJT04gPj0gMHgwNDA1MDAKKyAgICBhcHBDYWNoZVBhdGggPSBRRGVza3RvcFNlcnZpY2Vz OjpzdG9yYWdlTG9jYXRpb24oUURlc2t0b3BTZXJ2aWNlczo6Q2FjaGVMb2NhdGlvbik7CisjZWxz ZQorICAgIGFwcENhY2hlUGF0aCA9IFFEZXNrdG9wU2VydmljZXM6OnN0b3JhZ2VMb2NhdGlvbihR RGVza3RvcFNlcnZpY2VzOjpEYXRhTG9jYXRpb24pOworI2VuZGlmCisKKyAgICBpZiAoYXBwQ2Fj aGVQYXRoLmlzRW1wdHkoKSkKKyAgICAgICAgYXBwQ2FjaGVQYXRoID0gUURpcjo6aG9tZVBhdGgo KSArIFFMYXRpbjFTdHJpbmcoIi8uIikgKyBRQ29yZUFwcGxpY2F0aW9uOjphcHBsaWNhdGlvbk5h bWUoKTsKKworICAgIFdlYkNvcmU6OmNhY2hlU3RvcmFnZSgpLnNldENhY2hlRGlyZWN0b3J5KGFw cENhY2hlUGF0aCk7CisgICAgaW5pdGlhbGl6ZWQgPSB0cnVlOworI2VuZGlmCit9ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCisKIFFXZWJQYWdlUHJpdmF0 ZTo6UVdlYlBhZ2VQcml2YXRlKFFXZWJQYWdlICpxcSkKICAgICA6IHEocXEpCiAgICAgLCB2aWV3 KDApCkBAIC0yNzEsNiArMjk3LDcgQEAgUVdlYlBhZ2VQcml2YXRlOjpRV2ViUGFnZVByaXZhdGUo UVdlYlBhZwogICAgIFdlYkNvcmU6OkluaXRpYWxpemVMb2dnaW5nQ2hhbm5lbHNJZk5lY2Vzc2Fy eSgpOwogICAgIEpTQzo6aW5pdGlhbGl6ZVRocmVhZGluZygpOwogICAgIFdlYkNvcmU6OkZyYW1l TG9hZGVyOjpzZXRMb2NhbExvYWRQb2xpY3koV2ViQ29yZTo6RnJhbWVMb2FkZXI6OkFsbG93TG9j YWxMb2Fkc0ZvckxvY2FsQW5kU3Vic3RpdHV0ZURhdGEpOworICAgIFdlYktpdEluaXRpYWxpemVB cHBsaWNhdGlvbkNhY2hlUGF0aElmTmVjZXNzYXJ5KCk7CiAKICAgICBjaHJvbWVDbGllbnQgPSBu ZXcgQ2hyb21lQ2xpZW50UXQocSk7CiAgICAgY29udGV4dE1lbnVDbGllbnQgPSBuZXcgQ29udGV4 dE1lbnVDbGllbnRRdCgpOwo=