27861 2009-07-30 15:42:11 -0700 [commit+] [Chromium] remove ChromeClientChromium::setToolTip() 2009-07-31 23:11:04 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 xji webkit-unassigned abarth oldest_to_newest 136056 0 xji 2009-07-30 15:42:11 -0700 This is a follow-up of Webkit patch for issue 24187 -- RTL: tooltip does not get its directionality from its element's directionality. In the above patch, Webkit passed in both tooltip text and its element directionality to client. To make Chromium build OK after the signature change in Webkit, an overloaded virtual function ChromeClientChromium::setToolTip(const String&, TextDirection) was introduced. Now since Chrome changed its signature in its Webkit glue layer (ChromeClientImpl::setToolTip()), the overloaded ChromeClientChromium::setToolTip() is no longer needed. 136062 1 33847 xji 2009-07-30 16:00:13 -0700 Created attachment 33847 patch 136415 2 abarth 2009-07-31 23:11:04 -0700 Appears to have already been landed. Please close the bug when you land something. 33847 2009-07-30 16:00:13 -0700 2009-07-30 16:04:43 -0700 patch 27861 text/plain 1447 xji SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjYwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMzAgIFhpYW9tZWkgSmkgIDx4amlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBDaHJvbWVDbGllbnRDaHJvbWl1bTo6c2V0VG9vbFRpcCgpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4NjEKKworICAgICAgICBUaGlzIHBhdGNo IGlzIGp1c3QgdG8gcmVtb3ZlIGEgdGVtcG9yYXJpbHkgaW50cm9kdWNlZCBvdmVybG9hZGVkIGVt cHR5CisgICAgICAgIHZpcnR1YWwgZnVuY3Rpb24uIE5vIHRlc3QgaXMgbmVlZGVkLgorCisgICAg ICAgICogcGFnZS9jaHJvbWl1bS9DaHJvbWVDbGllbnRDaHJvbWl1bS5oOgorCiAyMDA5LTA3LTMw ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3BhZ2UvY2hyb21pdW0vQ2hyb21lQ2xp ZW50Q2hyb21pdW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvY2hyb21pdW0vQ2hyb21l Q2xpZW50Q2hyb21pdW0uaAkocmV2aXNpb24gNDY2MDQpCisrKyBXZWJDb3JlL3BhZ2UvY2hyb21p dW0vQ2hyb21lQ2xpZW50Q2hyb21pdW0uaAkod29ya2luZyBjb3B5KQpAQCAtNDgsOSArNDgsNiBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8vIHBvcHVwIHdpbGwgYmUgaGFuZGxlZCBi eSB0aGUgZXh0ZXJuYWwgZW1iZWRkZXIuCiAgICAgICAgIHZpcnR1YWwgdm9pZCBwb3B1cE9wZW5l ZChQb3B1cENvbnRhaW5lciogcG9wdXBDb250YWluZXIsIGNvbnN0IEludFJlY3QmIGJvdW5kcywK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgZm9jdXNPblNob3csIGJvb2wg aGFuZGxlRXh0ZXJuYWwpID0gMDsKLSAgICAgICAgLy8gVE9ETyh4amkpOiBhZGRlZCB0ZW1wcmFy aWx5IHRvIG1ha2UgQ2hyb21pdW0gY29tcGlsZSBhZnRlciBwaWNrIHVwIHRoaXMKLSAgICAgICAg Ly8gV2Via2l0IHBhdGNoLiBTaG91bGQgYmUgcmVtb3ZlZCBhZnRlciBhZGRpbmcgaXQgaW4gQ2hy b21pdW0ncyBvd24gY29kZS4KLSAgICAgICAgdmlydHVhbCB2b2lkIHNldFRvb2xUaXAoY29uc3Qg U3RyaW5nJiB0b29sdGlwX3RleHQsIFRleHREaXJlY3Rpb24gZGlyKSB7IH0KICAgICB9OwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==