278522 2024-08-22 08:03:25 -0700 RELEASE_ASSERT that ObjectIdentifier is valid when constructed from a raw value 2024-08-22 21:01:19 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez webkit-bug-importer oldest_to_newest 2054703 0 cdumez 2024-08-22 08:03:25 -0700 We recently made it so that ObjectIdentifier no longer has a default constructor or an "invalid" state. However, a call site could still in theory construct an ObjectIdentifier with a raw value of 0 to construct an invalid identifier. Doing so would only hit an assertion in debug builds. For hardening, I'm suggesting we turn this debug assertion into a release one. This tested as performance neutral. 2054705 1 cdumez 2024-08-22 08:05:22 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32590 2054865 2 ews-feeder 2024-08-22 21:00:10 -0700 Committed 282646@main (576330780972): <https://commits.webkit.org/282646@main> Reviewed commits have been landed. Closing PR #32590 and removing active labels. 2054866 3 webkit-bug-importer 2024-08-22 21:01:19 -0700 <rdar://problem/134545098>