27852 2009-07-30 12:45:46 -0700 Add --minimal option to webkit-build 2009-07-30 13:57:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jpetsovits webkit-unassigned manyoso oldest_to_newest 135941 0 jpetsovits 2009-07-30 12:45:46 -0700 Instead of disabling all optional features with --no-svg, --no-video, --no-xslt, etc., it would be nice to disable all of those at once and only get those options that were explicitely enabled. My relationship to Perl is not the most loving one, but here's a patch anyways. Please review, thanks! 135945 1 33807 jpetsovits 2009-07-30 12:49:12 -0700 Created attachment 33807 Add --minimal option to webkit-build 135948 2 33808 jpetsovits 2009-07-30 12:53:04 -0700 Created attachment 33808 Add --minimal option to webkit-build (try 2) New version, this one gets the --minimal option out of @ARGV and thus makes it work with subsequent code that makes use of @ARGV still, like Qt's qmake stuff. 135959 3 33812 jpetsovits 2009-07-30 13:08:19 -0700 Created attachment 33812 Add --minimal option to webkit-build (try 3) Fix for a spelling issue, pointed out by Adam Treat: explicitely -> explicitly. 135970 4 33812 aroben 2009-07-30 13:17:13 -0700 Comment on attachment 33812 Add --minimal option to webkit-build (try 3) I think it would be better and clearer for --minimal to be parsed like all the other options. After the GetOptions call, if $minimal is true you can just loop over @features and set all the values that don't match the default to 0. 135985 5 33812 aroben 2009-07-30 13:41:36 -0700 Comment on attachment 33812 Add --minimal option to webkit-build (try 3) Jakob convinced me that my suggested approach is not better. r=me 135996 6 manyoso 2009-07-30 13:57:55 -0700 Landed with r46597. 33807 2009-07-30 12:49:12 -0700 2009-07-30 12:53:04 -0700 Add --minimal option to webkit-build build-webkit-minimal-option.diff text/plain 2130 jpetsovits ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3YTJiZTQ3Li5lZDFkYWMxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDct MzAgIEpha29iIFBldHNvdml0cyAgPGpha29iLnBldHNvdml0c0B0b3JjaG1vYmlsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIC0tbWlu aW1hbCBvcHRpb24gdG8gd2Via2l0LWJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4NTIKKworICAgICAgICBUaGlzIG9wdGlvbiBkaXNhYmxl cyBhbGwgb3B0aW9uYWwgYnVpbGQgZmVhdHVyZXMgdW5sZXNzCisgICAgICAgIHRoZXkgYXJlIGV4 cGxpY2l0ZWx5IGVuYWJsZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwog MjAwOS0wNy0yOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAg IDxodHRwOi8vd2Via2l0Lm9yZy9iLzI3ODE1PiBidWd6aWxsYS10b29sOiBhZGQgLW0vLS1kZXNj cmlwdGlvbiB0byBwb3N0LWNvbW1pdHMgY29tbWFuZApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApp bmRleCA5NDQ1ZjI5Li41MDk5NjI5IDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1 aWxkLXdlYmtpdAorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNDIs NiArNDIsNyBAQCBjaGRpcldlYktpdCgpOwogCiBteSAkc2hvd0hlbHAgPSAwOwogbXkgJGNsZWFu ID0gMDsKK215ICRtaW5pbWFsID0gMDsKIG15ICRtYWtlQXJnczsKIAogbXkgKCR0aHJlZURSZW5k ZXJpbmdTdXBwb3J0LCAkY2hhbm5lbE1lc3NhZ2luZ1N1cHBvcnQsICRkYXRhYmFzZVN1cHBvcnQs ICRkb21TdG9yYWdlU3VwcG9ydCwKQEAgLTE0MCw4ICsxNDEsMTYgQEAgaWYgKGlzUXQoKSkgewog fQogCiAjIEluaXRpYWxpemUgdmFsdWVzIGZyb20gZGVmYXVsdHMKK2ZvcmVhY2ggKEBBUkdWKSB7 CisgICAgaWYgKCRfIGVxICctLW1pbmltYWwnKSB7CisgICAgICAgICRtaW5pbWFsID0gMTsKKyAg ICAgICAgbGFzdDsKKyAgICB9Cit9CisKKyMgSW5pdGlhbGl6ZSB2YWx1ZXMgZnJvbSBkZWZhdWx0 cwogZm9yZWFjaCAoQGZlYXR1cmVzKSB7Ci0gICAgJHskXy0+e3ZhbHVlfX0gPSAkXy0+e2RlZmF1 bHR9IHx8IDA7CisgICAgJHskXy0+e3ZhbHVlfX0gPSAoJF8tPntkZWZhdWx0fSAmJiAhJG1pbmlt YWwpIHx8IDA7CiB9CiAKICRzdmdTdXBwb3J0ID0gJHN2Z1N1cHBvcnQgfHwgJHN2Z0FuaW1hdGlv blN1cHBvcnQgfHwgJHN2Z0FzSW1hZ2VTdXBwb3J0CkBAIC0xNjIsNiArMTcxLDggQEAgVXNhZ2U6 ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW29wdGlvbnMgdG8gcGFzcyB0byBidWlsZCBzeXN0ZW1d CiAKICAgLS1tYWtlYXJncz08YXJndW1lbnRzPiAgICAgICAgICAgIE9wdGlvbmFsIE1ha2VmaWxl IGZsYWdzCiAKKyAgLS1taW5pbWFsICAgICAgICAgICAgICAgICAgICAgICAgIE5vIG9wdGlvbmFs IGZlYXR1cmVzLCB1bmxlc3MgZXhwbGljaXRlbHkgZW5hYmxlZC4KKwogRU9GCiAKIG15ICVvcHRp b25zID0gKApAQCAtMTczLDggKzE4NCw4IEBAIG15ICVvcHRpb25zID0gKAogIyBCdWlsZCB1c2Fn ZSB0ZXh0IGFuZCBvcHRpb25zIGxpc3QgZnJvbSBmZWF0dXJlcwogZm9yZWFjaCAoQGZlYXR1cmVz KSB7CiAgICAgbXkgJG9wdCA9IHNwcmludGYoIiUtMzVzIiwgIiAgLS1bbm8tXSRfLT57b3B0aW9u fSIpOwotICAgICR1c2FnZSAuPSAiJG9wdCAkXy0+e2Rlc2N9IChkZWZhdWx0OiAkeyRfLT57dmFs dWV9fSlcbiI7Ci0gICAgJG9wdGlvbnN7IiRfLT57b3B0aW9ufSEifSA9ICAkXy0+e3ZhbHVlfTsK KyAgICAkdXNhZ2UgLj0gIiRvcHQgJF8tPntkZXNjfSAoZGVmYXVsdDogJF8tPntkZWZhdWx0fSlc biI7CisgICAgJG9wdGlvbnN7IiRfLT57b3B0aW9ufSEifSA9ICRfLT57dmFsdWV9OwogfQogCiBH ZXRPcHRpb25zKCVvcHRpb25zKTsK 33808 2009-07-30 12:53:04 -0700 2009-07-30 13:08:19 -0700 Add --minimal option to webkit-build (try 2) build-webkit-minimal-option.diff text/plain 2216 jpetsovits ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3YTJiZTQ3Li5lZDFkYWMxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDct MzAgIEpha29iIFBldHNvdml0cyAgPGpha29iLnBldHNvdml0c0B0b3JjaG1vYmlsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIC0tbWlu aW1hbCBvcHRpb24gdG8gd2Via2l0LWJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4NTIKKworICAgICAgICBUaGlzIG9wdGlvbiBkaXNhYmxl cyBhbGwgb3B0aW9uYWwgYnVpbGQgZmVhdHVyZXMgdW5sZXNzCisgICAgICAgIHRoZXkgYXJlIGV4 cGxpY2l0ZWx5IGVuYWJsZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwog MjAwOS0wNy0yOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAg IDxodHRwOi8vd2Via2l0Lm9yZy9iLzI3ODE1PiBidWd6aWxsYS10b29sOiBhZGQgLW0vLS1kZXNj cmlwdGlvbiB0byBwb3N0LWNvbW1pdHMgY29tbWFuZApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApp bmRleCA5NDQ1ZjI5Li5iNjFlNzNkIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2J1 aWxkLXdlYmtpdAorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNDIs NiArNDIsNyBAQCBjaGRpcldlYktpdCgpOwogCiBteSAkc2hvd0hlbHAgPSAwOwogbXkgJGNsZWFu ID0gMDsKK215ICRtaW5pbWFsID0gMDsKIG15ICRtYWtlQXJnczsKIAogbXkgKCR0aHJlZURSZW5k ZXJpbmdTdXBwb3J0LCAkY2hhbm5lbE1lc3NhZ2luZ1N1cHBvcnQsICRkYXRhYmFzZVN1cHBvcnQs ICRkb21TdG9yYWdlU3VwcG9ydCwKQEAgLTE0MCw4ICsxNDEsMTYgQEAgaWYgKGlzUXQoKSkgewog fQogCiAjIEluaXRpYWxpemUgdmFsdWVzIGZyb20gZGVmYXVsdHMKK2ZvcmVhY2ggKEBBUkdWKSB7 CisgICAgaWYgKCRfIGVxICctLW1pbmltYWwnKSB7CisgICAgICAgICRtaW5pbWFsID0gMTsKKyAg ICAgICAgbGFzdDsKKyAgICB9Cit9CisKKyMgSW5pdGlhbGl6ZSB2YWx1ZXMgZnJvbSBkZWZhdWx0 cwogZm9yZWFjaCAoQGZlYXR1cmVzKSB7Ci0gICAgJHskXy0+e3ZhbHVlfX0gPSAkXy0+e2RlZmF1 bHR9IHx8IDA7CisgICAgJHskXy0+e3ZhbHVlfX0gPSAoJF8tPntkZWZhdWx0fSAmJiAhJG1pbmlt YWwpIHx8IDA7CiB9CiAKICRzdmdTdXBwb3J0ID0gJHN2Z1N1cHBvcnQgfHwgJHN2Z0FuaW1hdGlv blN1cHBvcnQgfHwgJHN2Z0FzSW1hZ2VTdXBwb3J0CkBAIC0xNjIsMTkgKzE3MSwyMiBAQCBVc2Fn ZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBbb3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3Rl bV0KIAogICAtLW1ha2VhcmdzPTxhcmd1bWVudHM+ICAgICAgICAgICAgT3B0aW9uYWwgTWFrZWZp bGUgZmxhZ3MKIAorICAtLW1pbmltYWwgICAgICAgICAgICAgICAgICAgICAgICAgTm8gb3B0aW9u YWwgZmVhdHVyZXMsIHVubGVzcyBleHBsaWNpdGVseSBlbmFibGVkLgorCiBFT0YKIAogbXkgJW9w dGlvbnMgPSAoCiAgICAgJ2hlbHAnID0+IFwkc2hvd0hlbHAsCiAgICAgJ2NsZWFuJyA9PiBcJGNs ZWFuLAogICAgICdtYWtlYXJncz1zJyA9PiBcJG1ha2VBcmdzLAorICAgICdtaW5pbWFsJyA9PiBc JG1pbmltYWwsCiApOwogCiAjIEJ1aWxkIHVzYWdlIHRleHQgYW5kIG9wdGlvbnMgbGlzdCBmcm9t IGZlYXR1cmVzCiBmb3JlYWNoIChAZmVhdHVyZXMpIHsKICAgICBteSAkb3B0ID0gc3ByaW50Zigi JS0zNXMiLCAiICAtLVtuby1dJF8tPntvcHRpb259Iik7Ci0gICAgJHVzYWdlIC49ICIkb3B0ICRf LT57ZGVzY30gKGRlZmF1bHQ6ICR7JF8tPnt2YWx1ZX19KVxuIjsKLSAgICAkb3B0aW9uc3siJF8t PntvcHRpb259ISJ9ID0gICRfLT57dmFsdWV9OworICAgICR1c2FnZSAuPSAiJG9wdCAkXy0+e2Rl c2N9IChkZWZhdWx0OiAkXy0+e2RlZmF1bHR9KVxuIjsKKyAgICAkb3B0aW9uc3siJF8tPntvcHRp b259ISJ9ID0gJF8tPnt2YWx1ZX07CiB9CiAKIEdldE9wdGlvbnMoJW9wdGlvbnMpOwo= 33812 2009-07-30 13:08:19 -0700 2009-07-30 13:41:36 -0700 Add --minimal option to webkit-build (try 3) build-webkit-minimal-option.diff text/plain 2214 jpetsovits ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3YTJiZTQ3Li4yNjY5YmFhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDct MzAgIEpha29iIFBldHNvdml0cyAgPGpha29iLnBldHNvdml0c0B0b3JjaG1vYmlsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIC0tbWlu aW1hbCBvcHRpb24gdG8gd2Via2l0LWJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4NTIKKworICAgICAgICBUaGlzIG9wdGlvbiBkaXNhYmxl cyBhbGwgb3B0aW9uYWwgYnVpbGQgZmVhdHVyZXMgdW5sZXNzCisgICAgICAgIHRoZXkgYXJlIGV4 cGxpY2l0bHkgZW5hYmxlZC4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OgorCiAy MDA5LTA3LTI5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAg PGh0dHA6Ly93ZWJraXQub3JnL2IvMjc4MTU+IGJ1Z3ppbGxhLXRvb2w6IGFkZCAtbS8tLWRlc2Ny aXB0aW9uIHRvIHBvc3QtY29tbWl0cyBjb21tYW5kCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL2J1aWxkLXdlYmtpdCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0Cmlu ZGV4IDk0NDVmMjkuLjNiMTAzNTggMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC00Miw2 ICs0Miw3IEBAIGNoZGlyV2ViS2l0KCk7CiAKIG15ICRzaG93SGVscCA9IDA7CiBteSAkY2xlYW4g PSAwOworbXkgJG1pbmltYWwgPSAwOwogbXkgJG1ha2VBcmdzOwogCiBteSAoJHRocmVlRFJlbmRl cmluZ1N1cHBvcnQsICRjaGFubmVsTWVzc2FnaW5nU3VwcG9ydCwgJGRhdGFiYXNlU3VwcG9ydCwg JGRvbVN0b3JhZ2VTdXBwb3J0LApAQCAtMTQwLDggKzE0MSwxNiBAQCBpZiAoaXNRdCgpKSB7CiB9 CiAKICMgSW5pdGlhbGl6ZSB2YWx1ZXMgZnJvbSBkZWZhdWx0cworZm9yZWFjaCAoQEFSR1YpIHsK KyAgICBpZiAoJF8gZXEgJy0tbWluaW1hbCcpIHsKKyAgICAgICAgJG1pbmltYWwgPSAxOworICAg ICAgICBsYXN0OworICAgIH0KK30KKworIyBJbml0aWFsaXplIHZhbHVlcyBmcm9tIGRlZmF1bHRz CiBmb3JlYWNoIChAZmVhdHVyZXMpIHsKLSAgICAkeyRfLT57dmFsdWV9fSA9ICRfLT57ZGVmYXVs dH0gfHwgMDsKKyAgICAkeyRfLT57dmFsdWV9fSA9ICgkXy0+e2RlZmF1bHR9ICYmICEkbWluaW1h bCkgfHwgMDsKIH0KIAogJHN2Z1N1cHBvcnQgPSAkc3ZnU3VwcG9ydCB8fCAkc3ZnQW5pbWF0aW9u U3VwcG9ydCB8fCAkc3ZnQXNJbWFnZVN1cHBvcnQKQEAgLTE2MiwxOSArMTcxLDIyIEBAIFVzYWdl OiAkcHJvZ3JhbU5hbWUgW29wdGlvbnNdIFtvcHRpb25zIHRvIHBhc3MgdG8gYnVpbGQgc3lzdGVt XQogCiAgIC0tbWFrZWFyZ3M9PGFyZ3VtZW50cz4gICAgICAgICAgICBPcHRpb25hbCBNYWtlZmls ZSBmbGFncwogCisgIC0tbWluaW1hbCAgICAgICAgICAgICAgICAgICAgICAgICBObyBvcHRpb25h bCBmZWF0dXJlcywgdW5sZXNzIGV4cGxpY2l0bHkgZW5hYmxlZC4KKwogRU9GCiAKIG15ICVvcHRp b25zID0gKAogICAgICdoZWxwJyA9PiBcJHNob3dIZWxwLAogICAgICdjbGVhbicgPT4gXCRjbGVh biwKICAgICAnbWFrZWFyZ3M9cycgPT4gXCRtYWtlQXJncywKKyAgICAnbWluaW1hbCcgPT4gXCRt aW5pbWFsLAogKTsKIAogIyBCdWlsZCB1c2FnZSB0ZXh0IGFuZCBvcHRpb25zIGxpc3QgZnJvbSBm ZWF0dXJlcwogZm9yZWFjaCAoQGZlYXR1cmVzKSB7CiAgICAgbXkgJG9wdCA9IHNwcmludGYoIiUt MzVzIiwgIiAgLS1bbm8tXSRfLT57b3B0aW9ufSIpOwotICAgICR1c2FnZSAuPSAiJG9wdCAkXy0+ e2Rlc2N9IChkZWZhdWx0OiAkeyRfLT57dmFsdWV9fSlcbiI7Ci0gICAgJG9wdGlvbnN7IiRfLT57 b3B0aW9ufSEifSA9ICAkXy0+e3ZhbHVlfTsKKyAgICAkdXNhZ2UgLj0gIiRvcHQgJF8tPntkZXNj fSAoZGVmYXVsdDogJF8tPntkZWZhdWx0fSlcbiI7CisgICAgJG9wdGlvbnN7IiRfLT57b3B0aW9u fSEifSA9ICRfLT57dmFsdWV9OwogfQogCiBHZXRPcHRpb25zKCVvcHRpb25zKTsK