<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>278499</bug_id>
          
          <creation_ts>2024-08-21 15:52:02 -0700</creation_ts>
          <short_desc>[Grid] Some intrinsic sizing for grid item methods incorrectly named in GridTrackSizingAlgorithm</short_desc>
          <delta_ts>2024-08-22 18:04:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sammy Gill">sgill26</reporter>
          <assigned_to name="Sammy Gill">sgill26</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2054553</commentid>
    <comment_count>0</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2024-08-21 15:52:02 -0700</bug_when>
    <thetext>GridTrackSizingAlgorithm defines minContentForGridItem, maxContentForGridItem, and minSizeForGridItem to represent the min content contribution, max content contribution, and minimum contributions, respectively. We should rename these to properly represent the spec terms as currently they can be misleading in certain contexts. For example, the min content size of a grid item is different min content contribution as the former does not consider the minimum size property while the latter does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054554</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-08-21 15:52:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/134451435&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054559</commentid>
    <comment_count>2</comment_count>
    <who name="Sammy Gill">sgill26</who>
    <bug_when>2024-08-21 16:14:58 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/32561</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054856</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-08-22 18:04:23 -0700</bug_when>
    <thetext>Committed 282643@main (51781e32c383): &lt;https://commits.webkit.org/282643@main&gt;

Reviewed commits have been landed. Closing PR #32561 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>