27849 2009-07-30 12:09:14 -0700 bugzilla-tool post-commits obsoletes its own work :( 2009-07-31 13:39:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned ddkilzer oldest_to_newest 135921 0 eric 2009-07-30 12:09:14 -0700 Working around bug 27847 for now, so I passed a manual list of revisions: bugzilla-tool post-commits -b 25494 fe5ba4cc272372cbd6c14261081e8d0b856cde87 7a3f6b9a5aabf51fe0d54688805d0fd0e9dc657c 4c929dac07dd08bf2328b755a1054189e158478f Fetching: https://bugs.webkit.org/show_bug.cgi?id=25494&ctype=xml Obsoleting 6 old patches on bug 25494 Logging in as eric@webkit.org... Obsoleting attachment: 29924 Obsoleting attachment: 29926 Obsoleting attachment: 29927 Obsoleting attachment: 30846 Obsoleting attachment: 30847 Obsoleting attachment: 30848 Adding patch "Add more position constructors" to bug 25494 --- 6 files changed, 62 insertions(+), 8 deletions(-) Fetching: https://bugs.webkit.org/show_bug.cgi?id=25494&ctype=xml Obsoleting 1 old patch on bug 25494 Obsoleting attachment: 33799 Adding patch "Rename positionBeforeNode to positionInParentBeforeNode" to bug 25494 --- 16 files changed, 96 insertions(+), 46 deletions(-) Fetching: https://bugs.webkit.org/show_bug.cgi?id=25494&ctype=xml Obsoleting 1 old patch on bug 25494 Obsoleting attachment: 33800 Adding patch "Move them back to Position.h per mjs's request" to bug 25494 --- 7 files changed, 68 insertions(+), 45 deletions(-) It should have not obsoleted the patches it just posted! 135998 1 eric 2009-07-30 14:01:33 -0700 I think this is due to the complexity of trying to support posting commits to different bugs... if options.obsolete_patches and bug_id not in have_obsoleted_patches: PostDiffAsPatchToBug.obsolete_patches_on_bug(bug_id, tool.bugs) have_obsoleted_patches.update(bug_id) is supposed to catch this case, but doesn't seem to be working. 136005 2 33835 eric 2009-07-30 14:05:34 -0700 Created attachment 33835 2009-07-30 Mike Fenton <mike.fenton@torchmobile.com> Reviewed by Adam Treat. Add previously defined out support to PopupMenuQt for marking entries as disabled and for selecting the desired item. https://bugs.webkit.org/show_bug.cgi?id=27772 * platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46593 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 2 files changed, 24 insertions(+), 1 deletions(-) 136006 3 33836 eric 2009-07-30 14:05:37 -0700 Created attachment 33836 Simple fix --- 2 files changed, 12 insertions(+), 1 deletions(-) 136007 4 33837 eric 2009-07-30 14:06:09 -0700 Created attachment 33837 Simple fix --- 2 files changed, 12 insertions(+), 1 deletions(-) 136027 5 33837 ddkilzer 2009-07-30 14:53:03 -0700 Comment on attachment 33837 Simple fix r=me if this fixes the bug. Why does add() work better than update() here (from a Python language perspective)? 136030 6 ddkilzer 2009-07-30 14:54:24 -0700 (In reply to comment #5) > Why does add() work better than update() here (from a Python language > perspective)? Oh, is updating clearing the contents of the set each time and adding just the new bug_id (instead of adding it to the set)? That would make sense. 136050 7 eric 2009-07-30 15:25:38 -0700 in our case 't' is not a set. I think python is simply silently failing here: s.update(t) s |= t return set s with elements added from t I think update is doing nothing, where as .add() is doing what we want. 136063 8 ddkilzer 2009-07-30 16:09:02 -0700 (In reply to comment #7) > in our case 't' is not a set. I think python is simply silently failing here: > > s.update(t) s |= t return set s with elements added from t > > I think update is doing nothing, where as .add() is doing what we want. Thanks! python-- 136233 9 ddkilzer 2009-07-31 13:39:31 -0700 Fixed in r46637. <http://trac.webkit.org/changeset/46637> Found Bug 27894 when trying to land this patch. 33835 2009-07-30 14:05:34 -0700 2009-07-30 14:06:03 -0700 2009-07-30 Mike Fenton <mike.fenton@torchmobile.com> bug-27849-20090730140533.patch text/plain 1655 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjkwN2RkZC4uMWJiN2RlYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0zMCAgTWlrZSBGZW50b24g IDxtaWtlLmZlbnRvbkB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gVHJlYXQuCisKKyAgICAgICAgIEFkZCBwcmV2aW91c2x5IGRlZmluZWQgb3V0IHN1cHBvcnQg dG8gUG9wdXBNZW51UXQgZm9yIG1hcmtpbmcgZW50cmllcyBhcworICAgICAgICAgZGlzYWJsZWQg YW5kIGZvciBzZWxlY3RpbmcgdGhlIGRlc2lyZWQgaXRlbS4KKworICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NzcyCisKKyAgICAgICAgICogcGxhdGZv cm0vcXQvUG9wdXBNZW51UXQuY3BwOgorICAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudTo6cG9w dWxhdGUpOgorCiAyMDA5LTA3LTMwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vcXQvUG9wdXBNZW51UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Qb3B1cE1lbnVR dC5jcHAKaW5kZXggNjNhNzUyMy4uMTFkZmU0MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9xdC9Qb3B1cE1lbnVRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Qb3B1cE1lbnVR dC5jcHAKQEAgLTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlIDxRTGlzdFdpZGdldEl0ZW0+CiAjaW5j bHVkZSA8UU1lbnU+CiAjaW5jbHVkZSA8UVBvaW50PgorI2luY2x1ZGUgPFFTdGFuZGFyZEl0ZW1N b2RlbD4KICNpbmNsdWRlIDxRV2lkZ2V0QWN0aW9uPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBA IC02MywxMiArNjQsMjIgQEAgdm9pZCBQb3B1cE1lbnU6OnBvcHVsYXRlKGNvbnN0IEludFJlY3Qm IHIpCiAgICAgY2xlYXIoKTsKICAgICBRX0FTU0VSVChjbGllbnQoKSk7CiAKKyAgICBRU3RhbmRh cmRJdGVtTW9kZWwqIG1vZGVsID0gcW9iamVjdF9jYXN0PFFTdGFuZGFyZEl0ZW1Nb2RlbCo+KG1f cG9wdXAtPm1vZGVsKCkpOworICAgIFFfQVNTRVJUKG1vZGVsKTsKKwogICAgIGludCBzaXplID0g Y2xpZW50KCktPmxpc3RTaXplKCk7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBzaXplOyBpKysp IHsKICAgICAgICAgaWYgKGNsaWVudCgpLT5pdGVtSXNTZXBhcmF0b3IoaSkpCiAgICAgICAgICAg ICBtX3BvcHVwLT5pbnNlcnRTZXBhcmF0b3IoaSk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgZWxz ZSB7CiAgICAgICAgICAgICBtX3BvcHVwLT5pbnNlcnRJdGVtKGksIGNsaWVudCgpLT5pdGVtVGV4 dChpKSk7CisKKyAgICAgICAgICAgIGlmIChtb2RlbCAmJiAhY2xpZW50KCktPml0ZW1Jc0VuYWJs ZWQoaSkpCisgICAgICAgICAgICAgICAgbW9kZWwtPml0ZW0oaSktPnNldEVuYWJsZWQoZmFsc2Up OworCisgICAgICAgICAgICBpZiAoY2xpZW50KCktPml0ZW1Jc1NlbGVjdGVkKGkpKQorICAgICAg ICAgICAgICAgIG1fcG9wdXAtPnNldEN1cnJlbnRJbmRleChpKTsKKyAgICAgICAgfQogICAgIH0K IH0= 33836 2009-07-30 14:05:37 -0700 2009-07-30 14:06:06 -0700 Simple fix bug-27849-20090730140536.patch text/plain 1215 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzOWYyNzAzLi4yODM4Mjk3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDct MzAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wgcG9zdC1jb21taXRzIG9i c29sZXRlcyBpdHMgb3duIHdvcmsgOigKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3ODQ5CisKKyAgICAgICAgU2ltcGxlIGZpeC4gIFVzZSAuYWRkKCkg aW5zdGVhZCBvZiAudXBkYXRlKCkKKworICAgICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9vbDoK KwogMjAwOS0wNy0zMCAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KIAogICAg ICAgICBbUXRdIEZpeCBidWlsZCB3aXRoIEdDQyA0LjQuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRv b2wKaW5kZXggZDRhMzkzNC4uOGZjMDc5NiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9idWd6aWxsYS10b29sCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbApA QCAtNDM3LDcgKzQzNyw3IEBAIGNsYXNzIFBvc3RDb21taXRzQXNQYXRjaGVzVG9CdWcoQ29tbWFu ZCk6CiAKICAgICAgICAgICAgIGlmIG9wdGlvbnMub2Jzb2xldGVfcGF0Y2hlcyBhbmQgYnVnX2lk IG5vdCBpbiBoYXZlX29ic29sZXRlZF9wYXRjaGVzOgogICAgICAgICAgICAgICAgIFBvc3REaWZm QXNQYXRjaFRvQnVnLm9ic29sZXRlX3BhdGNoZXNfb25fYnVnKGJ1Z19pZCwgdG9vbC5idWdzKQot ICAgICAgICAgICAgICAgIGhhdmVfb2Jzb2xldGVkX3BhdGNoZXMudXBkYXRlKGJ1Z19pZCkKKyAg ICAgICAgICAgICAgICBoYXZlX29ic29sZXRlZF9wYXRjaGVzLmFkZChidWdfaWQpCiAKICAgICAg ICAgICAgIGRlc2NyaXB0aW9uID0gb3B0aW9ucy5kZXNjcmlwdGlvbiBvciBjb21taXRfbWVzc2Fn ZS5kZXNjcmlwdGlvbihsc3RyaXA9VHJ1ZSwgc3RyaXBfdXJsPVRydWUpCiAgICAgICAgICAgICBj b21tZW50X3RleHQgPSBOb25l 33837 2009-07-30 14:06:09 -0700 2009-07-31 13:39:17 -0700 Simple fix bug-27849-20090730140608.patch text/plain 1215 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzOWYyNzAzLi4yODM4Mjk3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDct MzAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wgcG9zdC1jb21taXRzIG9i c29sZXRlcyBpdHMgb3duIHdvcmsgOigKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3ODQ5CisKKyAgICAgICAgU2ltcGxlIGZpeC4gIFVzZSAuYWRkKCkg aW5zdGVhZCBvZiAudXBkYXRlKCkKKworICAgICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9vbDoK KwogMjAwOS0wNy0zMCAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KIAogICAg ICAgICBbUXRdIEZpeCBidWlsZCB3aXRoIEdDQyA0LjQuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wgYi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRv b2wKaW5kZXggZDRhMzkzNC4uOGZjMDc5NiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9idWd6aWxsYS10b29sCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbApA QCAtNDM3LDcgKzQzNyw3IEBAIGNsYXNzIFBvc3RDb21taXRzQXNQYXRjaGVzVG9CdWcoQ29tbWFu ZCk6CiAKICAgICAgICAgICAgIGlmIG9wdGlvbnMub2Jzb2xldGVfcGF0Y2hlcyBhbmQgYnVnX2lk IG5vdCBpbiBoYXZlX29ic29sZXRlZF9wYXRjaGVzOgogICAgICAgICAgICAgICAgIFBvc3REaWZm QXNQYXRjaFRvQnVnLm9ic29sZXRlX3BhdGNoZXNfb25fYnVnKGJ1Z19pZCwgdG9vbC5idWdzKQot ICAgICAgICAgICAgICAgIGhhdmVfb2Jzb2xldGVkX3BhdGNoZXMudXBkYXRlKGJ1Z19pZCkKKyAg ICAgICAgICAgICAgICBoYXZlX29ic29sZXRlZF9wYXRjaGVzLmFkZChidWdfaWQpCiAKICAgICAg ICAgICAgIGRlc2NyaXB0aW9uID0gb3B0aW9ucy5kZXNjcmlwdGlvbiBvciBjb21taXRfbWVzc2Fn ZS5kZXNjcmlwdGlvbihsc3RyaXA9VHJ1ZSwgc3RyaXBfdXJsPVRydWUpCiAgICAgICAgICAgICBj b21tZW50X3RleHQgPSBOb25l