<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>278375</bug_id>
          
          <creation_ts>2024-08-20 01:47:25 -0700</creation_ts>
          <short_desc>Remove Quirk shouldHideSearchFieldResultsButton for *google.*</short_desc>
          <delta_ts>2024-10-04 02:22:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://google.com</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>GoodFirstBug, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>223700</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Karl Dubost">karlcow</reporter>
          <assigned_to name="Karl Dubost">karlcow</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2054026</commentid>
    <comment_count>0</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2024-08-20 01:47:25 -0700</bug_when>
    <thetext>&lt;rdar://75792913&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054027</commentid>
    <comment_count>1</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2024-08-20 01:53:26 -0700</bug_when>
    <thetext>1. Open Safari iOS
2. Go to https://www.google.com/
3. Open Safari on macOS 
4. Plug your mobile phone to your laptop with a USB cable
5. Develop → Choose the name of your device → Choose www.google.com
3. click on the little icon on the top left inside the Web inspector
4. Choose Disable site specific hacks


Reload the page.
Does it show two magnifiers or only one?

if only one, this is fixed.

I believe in my tests that this is fixed and that we can remove the quirk. 

See the code to be removed. 
https://searchfox.org/wubkat/search?q=shouldHideSearchFieldResultsButton&amp;path=&amp;case=false&amp;regexp=false</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2065397</commentid>
    <comment_count>2</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2024-10-04 00:59:02 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/34685</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2065419</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-10-04 02:22:28 -0700</bug_when>
    <thetext>Committed 284672@main (124527c205a0): &lt;https://commits.webkit.org/284672@main&gt;

Reviewed commits have been landed. Closing PR #34685 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>