27834 2009-07-30 05:49:18 -0700 [commit+] Allow custom memory allocation control for JavaScriptCore's ScopeChain class 2009-08-01 16:00:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED INVALID P2 Normal --- 1 zoltan webkit-unassigned abarth oliver oldest_to_newest 135826 0 zoltan 2009-07-30 05:49:18 -0700 Inherits ScopeChain class from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109. 135828 1 33774 zoltan 2009-07-30 05:51:50 -0700 Created attachment 33774 proposed patch 136433 2 33774 abarth 2009-08-01 01:19:54 -0700 Comment on attachment 33774 proposed patch Clearing review flag on attachment: 33774 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/ScopeChain.h Committed r46668 M JavaScriptCore/runtime/ScopeChain.h M JavaScriptCore/ChangeLog r46668 = 90053501e66706eafcc6a1899f728634c387850f (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46668 136434 3 abarth 2009-08-01 01:19:58 -0700 All reviewed patches have been landed. Closing bug. 136484 4 33774 oliver 2009-08-01 13:21:32 -0700 Comment on attachment 33774 proposed patch This patch needs to be rolled out - it was using placement new, ScopeChain is not a heap allocated type. 136485 5 oliver 2009-08-01 13:23:38 -0700 Reopening as it this patch needs to be rolled out - the bug is invalid. 136486 6 zoltan 2009-08-01 13:26:37 -0700 You are right! Thanks for your attention. 136490 7 mrowe 2009-08-01 16:00:46 -0700 Rolled out in r46679. 33774 2009-07-30 05:51:50 -0700 2009-08-01 13:21:31 -0700 proposed patch ScopeChain.patch text/plain 1124 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2NTc2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDctMzAgIFpvbHRhbiBI b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgQWxsb3cgY3VzdG9t IG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIEphdmFTY3JpcHRDb3JlJ3MgU2NvcGVDaGFp biBjbGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjc4MzQKKworICAgICAgICBJbmhlcml0cyBTY29wZUNoYWluIGNsYXNzIGZyb20gRmFzdEFsbG9j QmFzZSBiZWNhdXNlIGl0IGhhcyBiZWVuCisgICAgICAgIGluc3RhbnRpYXRlZCBieSAnbmV3JyBp biBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTRnVuY3Rpb24uaDoxMDkuCisKKyAgICAgICAgKiBy dW50aW1lL1Njb3BlQ2hhaW4uaDoKKwogMjAwOS0wNy0yOSAgTGFzemxvIEdvbWJvcyAgPGxhc3ps by4xLmdvbWJvc0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvcmdlIFN0YWlr b3MuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlQ2hhaW4uaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlQ2hhaW4uaAkocmV2aXNpb24gNDY1NzUp CisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlQ2hhaW4uaAkod29ya2luZyBjb3B5KQpA QCAtMTU0LDcgKzE1NCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgY2xhc3MgTm9TY29wZUNo YWluIHt9OwogCi0gICAgY2xhc3MgU2NvcGVDaGFpbiB7CisgICAgY2xhc3MgU2NvcGVDaGFpbiA6 IHB1YmxpYyBGYXN0QWxsb2NCYXNlIHsKICAgICAgICAgZnJpZW5kIGNsYXNzIEpJVDsKICAgICBw dWJsaWM6CiAgICAgICAgIFNjb3BlQ2hhaW4oTm9TY29wZUNoYWluKQo=