27826 2009-07-29 23:37:35 -0700 [V8] Remove bug-bait V8Proxy::context() 2009-08-06 01:27:17 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 27703 1 abarth abarth dglazkov fishd oldest_to_newest 135785 0 abarth 2009-07-29 23:37:35 -0700 The zero-argument version of V8Proxy::context() is never the right way to get the context. We should remove this bug-bait function once we finish removing all the clients. (ScheduledAction is the only remaining client, see Bug 27703). 135786 1 33760 abarth 2009-07-29 23:40:48 -0700 Created attachment 33760 Patch v1 135787 2 33760 levin 2009-07-29 23:50:08 -0700 Comment on attachment 33760 Patch v1 > Index: WebCore/bindings/v8/V8Proxy.cpp > + v8::Context::Scope contextScope(m_context); This is more than just a transform on this line. This line would be equivalent to what was there before: v8::Context::Scope contextScope(v8::Local<v8::Context>::New(m_context)); So r+ if you make this change to make it equivalent to before. 135788 3 33761 abarth 2009-07-29 23:52:47 -0700 Created attachment 33761 Patch v1 135988 4 abarth 2009-07-30 13:44:57 -0700 Assigning to myself while we remove the remaining client. 137547 5 33761 abarth 2009-08-06 01:27:11 -0700 Comment on attachment 33761 Patch v1 Clearing review flag on attachment: 33761 Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8Proxy.cpp Sending WebCore/bindings/v8/V8Proxy.h Transmitting file data ... Committed revision 46840. http://trac.webkit.org/changeset/46840 137548 6 abarth 2009-08-06 01:27:17 -0700 All reviewed patches have been landed. Closing bug. 33760 2009-07-29 23:40:48 -0700 2009-07-29 23:52:33 -0700 Patch v1 bug-27826-20090729234047.patch text/plain 2532 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjU3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhd IFJlbW92ZSBidWctYmFpdCBWOFByb3h5Ojpjb250ZXh0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODI2CisKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OnVwZGF0ZURvY3VtZW50 V3JhcHBlckNhY2hlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OmluaXRDb250ZXh0SWZO ZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6bWFpbldvcmxkQ29udGV4dCk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5oOgorCiAyMDA5LTA3LTI5ICBKaWFuIExpICA8 amlhbmxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAkocmV2aXNpb24gNDY1NzApCisrKyBXZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MjcsNyArNjI3LDcg QEAgdm9pZCBWOFByb3h5OjpjbGVhckRvY3VtZW50V3JhcHBlcigpCiB2b2lkIFY4UHJveHk6OnVw ZGF0ZURvY3VtZW50V3JhcHBlckNhY2hlKCkKIHsKICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxl U2NvcGU7Ci0gICAgdjg6OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRTY29wZShjb250ZXh0KCkpOwor ICAgIHY4OjpDb250ZXh0OjpTY29wZSBjb250ZXh0U2NvcGUobV9jb250ZXh0KTsKIAogICAgIC8v IElmIHRoZSBkb2N1bWVudCBoYXMgbm8gZnJhbWUsIE5vZGVUb1Y4T2JqZWN0IG1pZ2h0IGdldCB0 aGUKICAgICAvLyBkb2N1bWVudCB3cmFwcGVyIGZvciBhIGRvY3VtZW50IHRoYXQgaXMgYWJvdXQg dG8gYmUgZGVsZXRlZC4KQEAgLTk4Nyw3ICs5ODcsNyBAQCB2b2lkIFY4UHJveHk6OmluaXRDb250 ZXh0SWZOZWVkZWQoKQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBTdGFydGluZyBmcm9tIG5v dywgdXNlIGxvY2FsIGNvbnRleHQgb25seS4KLSAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IHY4 Q29udGV4dCA9IGNvbnRleHQoKTsKKyAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IHY4Q29udGV4 dCA9IHY4OjpMb2NhbDx2ODo6Q29udGV4dD46Ok5ldyhtX2NvbnRleHQpOwogICAgIHY4OjpDb250 ZXh0OjpTY29wZSBjb250ZXh0U2NvcGUodjhDb250ZXh0KTsKIAogICAgIC8vIFN0b3JlIHRoZSBm aXJzdCBnbG9iYWwgb2JqZWN0IGNyZWF0ZWQgc28gd2UgY2FuIHJldXNlIGl0LgpAQCAtMTExNiw3 ICsxMTE2LDcgQEAgdjg6OkxvY2FsPHY4OjpDb250ZXh0PiBWOFByb3h5OjptYWluV29ybAogICAg ICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpDb250ZXh0PigpOwogCiAgICAgcHJveHktPmluaXRD b250ZXh0SWZOZWVkZWQoKTsKLSAgICByZXR1cm4gcHJveHktPmNvbnRleHQoKTsKKyAgICByZXR1 cm4gdjg6OkxvY2FsPHY4OjpDb250ZXh0Pjo6TmV3KHByb3h5LT5tX2NvbnRleHQpOwogfQogCiB2 ODo6TG9jYWw8djg6OkNvbnRleHQ+IFY4UHJveHk6OmN1cnJlbnRDb250ZXh0KCkKSW5kZXg6IFdl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGlu Z3MvdjgvVjhQcm94eS5oCShyZXZpc2lvbiA0NjU3MCkKKysrIFdlYkNvcmUvYmluZGluZ3Mvdjgv VjhQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMjYsMTIgKzMyNiw2IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgc3RhdGljIGludCBzb3VyY2VMaW5lTnVtYmVyKCk7CiAgICAgICAg IHN0YXRpYyBTdHJpbmcgc291cmNlTmFtZSgpOwogCi0gICAgICAgIC8vIFJldHVybnMgYSBsb2Nh bCBoYW5kbGUgb2YgdGhlIGNvbnRleHQuCi0gICAgICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4g Y29udGV4dCgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6OkNv bnRleHQ+OjpOZXcobV9jb250ZXh0KTsKLSAgICAgICAgfQotCiAgICAgICAgIGJvb2wgc2V0Q29u dGV4dERlYnVnSWQoaW50IGlkKTsKICAgICAgICAgc3RhdGljIGludCBjb250ZXh0RGVidWdJZCh2 ODo6SGFuZGxlPHY4OjpDb250ZXh0Pik7 33761 2009-07-29 23:52:47 -0700 2009-08-06 01:27:11 -0700 Patch v1 bug-27826-20090729235246.patch text/plain 2628 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjU3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhd IFJlbW92ZSBidWctYmFpdCBWOFByb3h5Ojpjb250ZXh0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODI2CisKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OnVwZGF0ZURvY3VtZW50 V3JhcHBlckNhY2hlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OmluaXRDb250ZXh0SWZO ZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6bWFpbldvcmxkQ29udGV4dCk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5oOgorCiAyMDA5LTA3LTI5ICBKaWFuIExpICA8 amlhbmxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAkocmV2aXNpb24gNDY1NzApCisrKyBXZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MjcsNyArNjI3LDgg QEAgdm9pZCBWOFByb3h5OjpjbGVhckRvY3VtZW50V3JhcHBlcigpCiB2b2lkIFY4UHJveHk6OnVw ZGF0ZURvY3VtZW50V3JhcHBlckNhY2hlKCkKIHsKICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxl U2NvcGU7Ci0gICAgdjg6OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRTY29wZShjb250ZXh0KCkpOwor ICAgIC8vIEZJWE1FOiBXZSBwcm9iYWJseSBkb24ndCBuZWVkIHRvIG1ha2UgYSBsb2NhbCBoYW5k bGUgaGVyZS4KKyAgICB2ODo6Q29udGV4dDo6U2NvcGUgY29udGV4dFNjb3BlKHY4OjpMb2NhbDx2 ODo6Q29udGV4dD46Ok5ldyhtX2NvbnRleHQpKTsKIAogICAgIC8vIElmIHRoZSBkb2N1bWVudCBo YXMgbm8gZnJhbWUsIE5vZGVUb1Y4T2JqZWN0IG1pZ2h0IGdldCB0aGUKICAgICAvLyBkb2N1bWVu dCB3cmFwcGVyIGZvciBhIGRvY3VtZW50IHRoYXQgaXMgYWJvdXQgdG8gYmUgZGVsZXRlZC4KQEAg LTk4Nyw3ICs5ODgsNyBAQCB2b2lkIFY4UHJveHk6OmluaXRDb250ZXh0SWZOZWVkZWQoKQogICAg ICAgICByZXR1cm47CiAKICAgICAvLyBTdGFydGluZyBmcm9tIG5vdywgdXNlIGxvY2FsIGNvbnRl eHQgb25seS4KLSAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IHY4Q29udGV4dCA9IGNvbnRleHQo KTsKKyAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IHY4Q29udGV4dCA9IHY4OjpMb2NhbDx2ODo6 Q29udGV4dD46Ok5ldyhtX2NvbnRleHQpOwogICAgIHY4OjpDb250ZXh0OjpTY29wZSBjb250ZXh0 U2NvcGUodjhDb250ZXh0KTsKIAogICAgIC8vIFN0b3JlIHRoZSBmaXJzdCBnbG9iYWwgb2JqZWN0 IGNyZWF0ZWQgc28gd2UgY2FuIHJldXNlIGl0LgpAQCAtMTExNiw3ICsxMTE3LDcgQEAgdjg6Okxv Y2FsPHY4OjpDb250ZXh0PiBWOFByb3h5OjptYWluV29ybAogICAgICAgICByZXR1cm4gdjg6Okxv Y2FsPHY4OjpDb250ZXh0PigpOwogCiAgICAgcHJveHktPmluaXRDb250ZXh0SWZOZWVkZWQoKTsK LSAgICByZXR1cm4gcHJveHktPmNvbnRleHQoKTsKKyAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpD b250ZXh0Pjo6TmV3KHByb3h5LT5tX2NvbnRleHQpOwogfQogCiB2ODo6TG9jYWw8djg6OkNvbnRl eHQ+IFY4UHJveHk6OmN1cnJlbnRDb250ZXh0KCkKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvdjgv VjhQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCShy ZXZpc2lvbiA0NjU3MCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMjYsMTIgKzMyNiw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAg c3RhdGljIGludCBzb3VyY2VMaW5lTnVtYmVyKCk7CiAgICAgICAgIHN0YXRpYyBTdHJpbmcgc291 cmNlTmFtZSgpOwogCi0gICAgICAgIC8vIFJldHVybnMgYSBsb2NhbCBoYW5kbGUgb2YgdGhlIGNv bnRleHQuCi0gICAgICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dCgpCi0gICAgICAg IHsKLSAgICAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6OkNvbnRleHQ+OjpOZXcobV9jb250 ZXh0KTsKLSAgICAgICAgfQotCiAgICAgICAgIGJvb2wgc2V0Q29udGV4dERlYnVnSWQoaW50IGlk KTsKICAgICAgICAgc3RhdGljIGludCBjb250ZXh0RGVidWdJZCh2ODo6SGFuZGxlPHY4OjpDb250 ZXh0Pik7