27819 2009-07-29 16:12:18 -0700 [commit+] Need to update layout test for different timings of multi process message ports 2009-08-03 06:26:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jam webkit-unassigned abarth atwilson fishd oldest_to_newest 135705 0 jam 2009-07-29 16:12:18 -0700 With multi-process message ports, a message isn't delivered before a setTimeout(, 0) can execute. This breaks an assumptions in message-channel-gc.html. 135707 1 33748 jam 2009-07-29 16:14:43 -0700 Created attachment 33748 Proposed patch 135708 2 33749 jam 2009-07-29 16:18:29 -0700 Created attachment 33749 fixed bad merge 135716 3 33749 eric 2009-07-29 16:33:18 -0700 Comment on attachment 33749 fixed bad merge Why the set-timeout for the "done"? Looks fine otherwise. 135724 4 33752 jam 2009-07-29 16:40:42 -0700 Created attachment 33752 removed setTimeout Thanks for the quick review. You're right, no need. Updated patch. 135725 5 33752 eric 2009-07-29 16:41:22 -0700 Comment on attachment 33752 removed setTimeout LGTM. 135757 6 jam 2009-07-29 17:55:21 -0700 If someone can commit this for me, that'd be great. Thanks. 136464 7 33752 abarth 2009-08-01 10:58:19 -0700 Comment on attachment 33752 removed setTimeout Clearing review flag on attachment: 33752 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/events/message-channel-gc.html Committed r46673 M LayoutTests/ChangeLog M LayoutTests/fast/events/message-channel-gc.html r46673 = db4c3d1baaf0fa69e2af6d2d0516de6ca68f0cf7 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46673 136465 8 abarth 2009-08-01 10:58:24 -0700 All reviewed patches have been landed. Closing bug. 136620 9 jam 2009-08-03 06:26:33 -0700 (In reply to comment #8) > All reviewed patches have been landed. Closing bug. Thanks! 33748 2009-07-29 16:14:43 -0700 2009-07-29 16:18:29 -0700 Proposed patch mptest.txt text/plain 1653 jam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ2NTU5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDctMjkgIEpvaG4gQWJkLUVsLU1hbGVr ICA8amFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgdGVzdCB0byB3b3JrIHdpdGggbXVsdGktcHJvY2VzcyBtZXNz YWdlIHBvcnRzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNzgxOQorCisgICAgICAgICogZmFzdC9ldmVudHMvbWVzc2FnZS1jaGFubmVsLWdjLmh0 bWw6CisKIDIwMDktMDctMjkgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRtbAkocmV2aXNpb24g NDY1NTgpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMTcsNiArMTcsMjAgQEAgZnVuY3Rpb24gbG9nKG1lc3NhZ2Up CiAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZyIpLmlubmVySFRNTCArPSBtZXNzYWdl ICsgIjxicj4iOwogfQogCitmdW5jdGlvbiBkb25lKCkKK3sKKyAgICBjaGFubmVsLnBvcnQxLmNs b3NlKCk7CisgICAgY2hhbm5lbC5wb3J0Mi5jbG9zZSgpOworCisgICAgZ2MoKTsKKworICAgIHNl dFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgIGxvZygiRE9ORSIpOworICAgICAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIubm90aWZ5RG9uZSgpCisgICAgfSwgMCk7Cit9CisKIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwpAQCAtMjksNyArNDMsNyBA QCBnYygpOwogbG9nKCJTaG91bGQgYmUgJ2Jhcic6ICIgKyBjaGFubmVsLnBvcnQxLmZvbyk7CiAK IGNoYW5uZWwucG9ydDEub25tZXNzYWdlID0gZnVuY3Rpb24oKSB7IGxvZygib25tZXNzYWdlIik7 IH0KLWNoYW5uZWwucG9ydDEuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIGZ1bmN0aW9uKCkg eyBsb2coIm1lc3NhZ2UgbGlzdGVuZXIiKTsgfSwgZmFsc2UpOworY2hhbm5lbC5wb3J0MS5hZGRF dmVudExpc3RlbmVyKCJtZXNzYWdlIiwgZnVuY3Rpb24oKSB7IGxvZygibWVzc2FnZSBsaXN0ZW5l ciIpOyBkb25lKCk7IH0sIGZhbHNlKTsKIAogZ2MoKTsKIGNoYW5uZWwucG9ydDEuc3RhcnQoKTsK 33749 2009-07-29 16:18:29 -0700 2009-07-29 16:40:42 -0700 fixed bad merge mptest2.txt text/plain 1912 jam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ2NTU5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDctMjkgIEpvaG4gQWJkLUVsLU1hbGVr ICA8amFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgdGVzdCB0byB3b3JrIHdpdGggbXVsdGktcHJvY2VzcyBtZXNz YWdlIHBvcnRzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNzgxOQorCisgICAgICAgICogZmFzdC9ldmVudHMvbWVzc2FnZS1jaGFubmVsLWdjLmh0 bWw6CisKIDIwMDktMDctMjkgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRtbAkocmV2aXNpb24g NDY1NTgpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMTcsNiArMTcsMjAgQEAgZnVuY3Rpb24gbG9nKG1lc3NhZ2Up CiAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZyIpLmlubmVySFRNTCArPSBtZXNzYWdl ICsgIjxicj4iOwogfQogCitmdW5jdGlvbiBkb25lKCkKK3sKKyAgICBjaGFubmVsLnBvcnQxLmNs b3NlKCk7CisgICAgY2hhbm5lbC5wb3J0Mi5jbG9zZSgpOworCisgICAgZ2MoKTsKKworICAgIHNl dFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgIGxvZygiRE9ORSIpOworICAgICAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIubm90aWZ5RG9uZSgpCisgICAgfSwgMCk7Cit9CisKIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwpAQCAtMjksMjMgKzQzLDEz IEBAIGdjKCk7CiBsb2coIlNob3VsZCBiZSAnYmFyJzogIiArIGNoYW5uZWwucG9ydDEuZm9vKTsK IAogY2hhbm5lbC5wb3J0MS5vbm1lc3NhZ2UgPSBmdW5jdGlvbigpIHsgbG9nKCJvbm1lc3NhZ2Ui KTsgfQotY2hhbm5lbC5wb3J0MS5hZGRFdmVudExpc3RlbmVyKCJtZXNzYWdlIiwgZnVuY3Rpb24o KSB7IGxvZygibWVzc2FnZSBsaXN0ZW5lciIpOyB9LCBmYWxzZSk7CitjaGFubmVsLnBvcnQxLmFk ZEV2ZW50TGlzdGVuZXIoIm1lc3NhZ2UiLCBmdW5jdGlvbigpIHsgbG9nKCJtZXNzYWdlIGxpc3Rl bmVyIik7IGRvbmUoKTsgfSwgZmFsc2UpOwogCiBnYygpOwogY2hhbm5lbC5wb3J0MS5zdGFydCgp OwogY2hhbm5lbC5wb3J0Mi5wb3N0TWVzc2FnZSgibXNnIik7CiAKIGdjKCk7Ci1jaGFubmVsLnBv cnQxLmNsb3NlKCk7Ci1jaGFubmVsLnBvcnQyLmNsb3NlKCk7Ci0KLWdjKCk7Ci0KLXNldFRpbWVv dXQoZnVuY3Rpb24oKSB7Ci0gICAgbG9nKCJET05FIik7Ci0gICAgaWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikKLSAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp Ci19LCAwKTsKIAogPC9zY3JpcHQ+CiA8L2JvZHk+Cg== 33752 2009-07-29 16:40:42 -0700 2009-08-01 10:58:18 -0700 removed setTimeout mptest3.txt text/plain 1860 jam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ2NTU5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDctMjkgIEpvaG4gQWJkLUVsLU1hbGVr ICA8amFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgdGVzdCB0byB3b3JrIHdpdGggbXVsdGktcHJvY2VzcyBtZXNz YWdlIHBvcnRzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNzgxOQorCisgICAgICAgICogZmFzdC9ldmVudHMvbWVzc2FnZS1jaGFubmVsLWdjLmh0 bWw6CisKIDIwMDktMDctMjkgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRtbAkocmV2aXNpb24g NDY1NTgpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLWNoYW5uZWwtZ2MuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMTcsNiArMTcsMTggQEAgZnVuY3Rpb24gbG9nKG1lc3NhZ2Up CiAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZyIpLmlubmVySFRNTCArPSBtZXNzYWdl ICsgIjxicj4iOwogfQogCitmdW5jdGlvbiBkb25lKCkKK3sKKyAgICBjaGFubmVsLnBvcnQxLmNs b3NlKCk7CisgICAgY2hhbm5lbC5wb3J0Mi5jbG9zZSgpOworCisgICAgZ2MoKTsKKworICAgIGxv ZygiRE9ORSIpOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKwogaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CkBAIC0yOSwyMyAr NDEsMTMgQEAgZ2MoKTsKIGxvZygiU2hvdWxkIGJlICdiYXInOiAiICsgY2hhbm5lbC5wb3J0MS5m b28pOwogCiBjaGFubmVsLnBvcnQxLm9ubWVzc2FnZSA9IGZ1bmN0aW9uKCkgeyBsb2coIm9ubWVz c2FnZSIpOyB9Ci1jaGFubmVsLnBvcnQxLmFkZEV2ZW50TGlzdGVuZXIoIm1lc3NhZ2UiLCBmdW5j dGlvbigpIHsgbG9nKCJtZXNzYWdlIGxpc3RlbmVyIik7IH0sIGZhbHNlKTsKK2NoYW5uZWwucG9y dDEuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIGZ1bmN0aW9uKCkgeyBsb2coIm1lc3NhZ2Ug bGlzdGVuZXIiKTsgZG9uZSgpOyB9LCBmYWxzZSk7CiAKIGdjKCk7CiBjaGFubmVsLnBvcnQxLnN0 YXJ0KCk7CiBjaGFubmVsLnBvcnQyLnBvc3RNZXNzYWdlKCJtc2ciKTsKIAogZ2MoKTsKLWNoYW5u ZWwucG9ydDEuY2xvc2UoKTsKLWNoYW5uZWwucG9ydDIuY2xvc2UoKTsKLQotZ2MoKTsKLQotc2V0 VGltZW91dChmdW5jdGlvbigpIHsKLSAgICBsb2coIkRPTkUiKTsKLSAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlE b25lKCkKLX0sIDApOwogCiA8L3NjcmlwdD4KIDwvYm9keT4K