27805 2009-07-29 09:10:14 -0700 Old dead pointer wrapping code in the v8 bindings. 2009-07-29 10:34:43 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 deanm webkit-unassigned abarth dglazkov oldest_to_newest 135600 0 deanm 2009-07-29 09:10:14 -0700 We no longer use wrapCPointer / extractCPointer. 135601 1 33717 deanm 2009-07-29 09:13:17 -0700 Created attachment 33717 Patch. 135602 2 33717 dglazkov 2009-07-29 09:14:39 -0700 Comment on attachment 33717 Patch. super-duper! 135603 3 dglazkov 2009-07-29 09:18:16 -0700 Landed as http://trac.webkit.org/changeset/46543. 135625 4 abarth 2009-07-29 10:34:43 -0700 Yay! 33717 2009-07-29 09:13:17 -0700 2009-07-29 09:14:39 -0700 Patch. x.diff text/plain 2210 deanm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWFlZDdjYi4uN2NkOWUxNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wNy0yOSAgRGVhbiBNY05hbWVl ICA8ZGVhbm1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbW92ZWQgdW51c2VkIHdyYXBDUG9pbnRlci9leHRyYWN0Q1BvaW50 ZXIgZnJvbSB0aGUgdjggYmluZGluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNzgwNQorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFw cGVyLmg6CisKIDIwMDktMDctMjkgIEpha3ViIFdpZWN6b3JlayAgPGZhdzIxN0BnbWFpbC5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERP TVdyYXBwZXIuaAppbmRleCAxMDVmYjY0Li5mNjIzMGVjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01X cmFwcGVyLmgKQEAgLTEwOCwyMiArMTA4LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAg ICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8Qyo+KG9iamVjdC0+R2V0UG9pbnRlckZyb21J bnRlcm5hbEZpZWxkKFY4Q3VzdG9tOjprRE9NV3JhcHBlck9iamVjdEluZGV4KSk7CiAgICAgICAg IH0KIAotICAgICAgICAvLyBDcmVhdGUgYSBWOCB3cmFwcGVyIGZvciBhIEMgcG9pbnRlcgotICAg ICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHdyYXBDUG9pbnRlcih2b2lkKiBjcHRy KQotICAgICAgICB7Ci0gICAgICAgICAgICAvLyBSZXByZXNlbnQgdm9pZCogYXMgaW50Ci0gICAg ICAgICAgICBpbnQgYWRkciA9IHJlaW50ZXJwcmV0X2Nhc3Q8aW50PihjcHRyKTsKLSAgICAgICAg ICAgIEFTU0VSVCghKGFkZHIgJiAweDAxKSk7IC8vIFRoZSBhZGRyZXNzIG11c3QgYmUgYWxpZ25l ZC4KLSAgICAgICAgICAgIHJldHVybiB2ODo6SW50ZWdlcjo6TmV3KGFkZHIgPj4gMSk7Ci0gICAg ICAgIH0KLQotICAgICAgICAvLyBUYWtlIEMgcG9pbnRlciBvdXQgb2YgYSB2OCB3cmFwcGVyLgot ICAgICAgICB0ZW1wbGF0ZSA8Y2xhc3MgQz4KLSAgICAgICAgc3RhdGljIEMqIGV4dHJhY3RDUG9p bnRlcih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gb2JqKQotICAgICAgICB7Ci0gICAgICAgICAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8Qyo+KGV4dHJhY3RDUG9pbnRlckltcGwob2JqKSk7Ci0gICAgICAg IH0KLQogICAgICAgICB0ZW1wbGF0ZSA8Y2xhc3MgQz4KICAgICAgICAgc3RhdGljIEMqIGNvbnZl cnRET01XcmFwcGVyVG9Ob2RlKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gb2JqZWN0KQogICAgICAg ICB7CkBAIC0yNDYsMTQgKzIzMCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgLy8g U2V0IGhpZGRlbiByZWZlcmVuY2VzIGluIGEgRE9NV2luZG93IG9iamVjdCBvZiBhIGZyYW1lLgog ICAgICAgICBzdGF0aWMgdm9pZCBzZXRIaWRkZW5XaW5kb3dSZWZlcmVuY2UoRnJhbWUqLCBjb25z dCBpbnQgaW50ZXJuYWxJbmRleCwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0Pik7CiAKLSAgICAgICAg Ly8gVGFrZSBDIHBvaW50ZXIgb3V0IG9mIGEgdjggd3JhcHBlci4KLSAgICAgICAgc3RhdGljIHZv aWQqIGV4dHJhY3RDUG9pbnRlckltcGwodjg6OkhhbmRsZTx2ODo6VmFsdWU+IG9iamVjdCkKLSAg ICAgICAgewotICAgICAgICAgICAgQVNTRVJUKG9iamVjdC0+SXNOdW1iZXIoKSk7Ci0gICAgICAg ICAgICBpbnQgYWRkciA9IG9iamVjdC0+SW50MzJWYWx1ZSgpOwotICAgICAgICAgICAgcmV0dXJu IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGFkZHIgPDwgMSk7Ci0gICAgICAgIH0KLQogICAgICAg ICBzdGF0aWMgVjhDbGFzc0luZGV4OjpWOFdyYXBwZXJUeXBlIGh0bWxFbGVtZW50VHlwZShIVE1M RWxlbWVudCopOwogI2lmIEVOQUJMRShTVkcpCiAgICAgICAgIHN0YXRpYyBWOENsYXNzSW5kZXg6 OlY4V3JhcHBlclR5cGUgc3ZnRWxlbWVudFR5cGUoU1ZHRWxlbWVudCopOwo=