27802 2009-07-29 06:30:32 -0700 Encoding override is not applied to all the contents in the page. 2017-07-18 08:29:53 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All NEW P2 Normal --- 1 johnnyding.webkit webkit-unassigned ap johnnyding.webkit jshin koivisto xlyuan oldest_to_newest 135573 0 johnnyding.webkit 2009-07-29 06:30:32 -0700 (Original bug was filed by Jungshik) Ideally, When 'character encoding' is overriden manually by a user (in View > Text Encoding menu), that encoding should be applied to all contents and frames (main and subframes loaded in a few different ways - JS, iframe, frame, AJAX). But now WebKit's behavior is not. Jungshik described a testcase in chromium bug: http://code.google.com/p/chromium/issues/detail?id=7243 After analyzing the case, some contents don't change is because those contents are generated by external JS file, and the encoding in the C-T head of the external JS files is "EUC-KR". Now if there is encoding defined in C-T head of external JS resource, WebKit will use it to decode the contents of JS resource. (See Loader::Host::didReceiveResponse and CacheScript::setEncoding). To comply with IE's behavior, it looks like we need to give high priority to the override encoding when decoding the external js resource. But now FF3 preferntially tries to use the encoding declared in C-T header if it's available, like current WebKit does. If we decide to use IE's way. I have a patch to make it work. 135575 1 33713 johnnyding.webkit 2009-07-29 06:36:51 -0700 Created attachment 33713 patch v1 for loader 135582 2 33713 ap 2009-07-29 07:44:26 -0700 Comment on attachment 33713 patch v1 for loader This looks closely related to bug 22952, probably even a duplicate. It's definitely a bug, as WebCore caching shouldn't affect how pages look. But I don't think that the fix is sufficient - it changes the globally cached resource text when encoding override is in effect, but other documents may be using the same resource with other encodings, so they will be broken. E.g., if you open a page, set an encoding override, and then open the same page in a new window, subresources will be taken from cache with a wrong (overridden) encoding. 135781 3 johnnyding.webkit 2009-07-29 20:59:14 -0700 Thanks, Alexey. You are right, I shouldn't change the encoding of the global cached resource. A way comes to my mind to fix this issue is to 1) Firstly check the whether override encoding of revalidate resource is equal with the existing encoding of the base cached source(m_resourceToRevalidate). If yes, we done. 2) If no, we keep the revalidate resource and copy the data from base cached source. Then change the encoding of revalidate resource to override encoding. Is the way OK? 135831 4 33775 johnnyding.webkit 2009-07-30 06:02:08 -0700 Created attachment 33775 patch v2 for loader Alex, the patch v2 used the way I mentioned in comments #3. Please take a look. Thanks! 135834 5 johnnyding.webkit 2009-07-30 06:24:36 -0700 Please ignore my patch, I found a problem, will send the patch v2 later. Sorry for inconvenience. 135903 6 33775 ap 2009-07-30 11:39:36 -0700 Comment on attachment 33775 patch v2 for loader Clearing review flag per the above comment. 136043 7 ap 2009-07-30 15:11:24 -0700 By the way, if your patch will also fix bug 22952, I'd suggest posting it there, as it's much older. 33713 2009-07-29 06:36:51 -0700 2009-07-30 06:02:08 -0700 patch v1 for loader loader_patch.txt text/plain 2288 johnnyding.webkit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjUzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMjkgIEpvaG5ueSBEaW5nICA8am9obm55ZGluZy53ZWJr aXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFByZWZlcmVudGlhbGx5IHVzZSBvdmVycmlkZSBlbmNvZGluZyB0byBkZWNvZGUgdGhl IGNhY2hlZCByZXNvdXJjZSBpZiBpdCdzIGF2YWlsYWJsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODAyCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiAoT09QUyEpCisKKyAgICAgICAgKiBsb2FkZXIvbG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkxvYWRlcjo6SG9zdDo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKwogMjAwOS0wNy0yOSAgWW9u Z2p1biBaaGFuZyAgPHlvbmdqdW4uemhhbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvbG9hZGVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9sb2FkZXIuY3BwCShyZXZpc2lvbiA0NjUzMSkKKysr IFdlYkNvcmUvbG9hZGVyL2xvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcg QEAKICNpbmNsdWRlICJDYWNoZWRSZXNvdXJjZS5oIgogI2luY2x1ZGUgIkNTdHJpbmcuaCIKICNp bmNsdWRlICJEb2NMb2FkZXIuaCIKKyNpbmNsdWRlICJEb2N1bWVudExvYWRlci5oIgogI2luY2x1 ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVMb2FkZXIuaCIKICNpbmNsdWRlICJIVE1MRG9j dW1lbnQuaCIKQEAgLTQzOCwxMCArNDM5LDIwIEBAIHZvaWQgTG9hZGVyOjpIb3N0OjpkaWRSZWNl aXZlUmVzcG9uc2UoU3UKICAgICAgICAgcmV0dXJuOwogICAgIAogICAgIENhY2hlZFJlc291cmNl KiByZXNvdXJjZSA9IHJlcXVlc3QtPmNhY2hlZFJlc291cmNlKCk7CisKKyAgICAvLyBHaXZlIHRo ZSBvdmVycmlkZSBlbmNvZGluZyBoaWdoIHByaW9yaXR5LgorICAgIERvY0xvYWRlciogZG9jTG9h ZGVyID0gcmVxdWVzdC0+ZG9jTG9hZGVyKCk7CisgICAgQVNTRVJUKGRvY0xvYWRlci0+ZnJhbWUo KSk7CisgICAgU3RyaW5nIGVuY29kaW5nID0gZG9jTG9hZGVyLT5mcmFtZSgpLT5sb2FkZXIoKS0+ ZG9jdW1lbnRMb2FkZXIoKS0+b3ZlcnJpZGVFbmNvZGluZygpOwogICAgIAogICAgIGlmIChyZXNv dXJjZS0+aXNDYWNoZVZhbGlkYXRvcigpKSB7CiAgICAgICAgIGlmIChyZXNwb25zZS5odHRwU3Rh dHVzQ29kZSgpID09IDMwNCkgewogICAgICAgICAgICAgLy8gMzA0IE5vdCBtb2RpZmllZCAvIFVz ZSBsb2NhbCBjb3B5CisgICAgICAgICAgICAvLyBSZXNldCB0aGUgZW5jb2Rpbmcgb2YgY2FjaGVk IHJlc291cmNlIHRvIG92ZXJyaWRlIGVuY29kaW5nIGlmIGl0IGlzIGF2YWlsYWJsZS4KKyAgICAg ICAgICAgIGlmICghZW5jb2RpbmcuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICAgICAgQVNTRVJU KHJlc291cmNlLT5yZXNvdXJjZVRvUmV2YWxpZGF0ZSgpKTsKKyAgICAgICAgICAgICAgICByZXNv dXJjZS0+cmVzb3VyY2VUb1JldmFsaWRhdGUoKS0+c2V0RW5jb2RpbmcoZW5jb2RpbmcpOworICAg ICAgICAgICAgfQogICAgICAgICAgICAgbV9yZXF1ZXN0c0xvYWRpbmcucmVtb3ZlKGxvYWRlcik7 CiAgICAgICAgICAgICBsb2FkZXItPmNsZWFyQ2xpZW50KCk7CiAgICAgICAgICAgICByZXF1ZXN0 LT5kb2NMb2FkZXIoKS0+ZGVjcmVtZW50UmVxdWVzdENvdW50KCk7CkBAIC00NjMsNyArNDc0LDgg QEAgdm9pZCBMb2FkZXI6Okhvc3Q6OmRpZFJlY2VpdmVSZXNwb25zZShTdQogCiAgICAgcmVzb3Vy Y2UtPnNldFJlc3BvbnNlKHJlc3BvbnNlKTsKIAotICAgIFN0cmluZyBlbmNvZGluZyA9IHJlc3Bv bnNlLnRleHRFbmNvZGluZ05hbWUoKTsKKyAgICBpZiAoZW5jb2RpbmcuaXNFbXB0eSgpKQorICAg ICAgICBlbmNvZGluZyA9IHJlc3BvbnNlLnRleHRFbmNvZGluZ05hbWUoKTsKICAgICBpZiAoIWVu Y29kaW5nLmlzTnVsbCgpKQogICAgICAgICByZXNvdXJjZS0+c2V0RW5jb2RpbmcoZW5jb2Rpbmcp OwogICAgIAo= 33775 2009-07-30 06:02:08 -0700 2010-06-10 17:53:12 -0700 patch v2 for loader loader_patch.txt text/plain 3844 johnnyding.webkit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjU3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMzAgIEpvaG5ueSBEaW5nICA8am9obm55ZGluZy53ZWJr aXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFByZWZlcmVudGlhbGx5IHVzZSBvdmVycmlkZSBlbmNvZGluZyB0byBkZWNvZGUgdGhl IGNhY2hlZCByZXNvdXJjZSBpZiBpdCdzIGF2YWlsYWJsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3ODAyCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LiAoT09QUyEpCisKKyAgICAgICAgKiBsb2FkZXIvbG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkxvYWRlcjo6SG9zdDo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKwogMjAwOS0wNy0zMCAgWGFu IExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVq IFN0YWNob3dpYWsuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9sb2FkZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvbG9hZGVyL2xvYWRlci5jcHAJKHJldmlzaW9uIDQ2NTMxKQorKysgV2ViQ29y ZS9sb2FkZXIvbG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBAQAogI2lu Y2x1ZGUgIkNhY2hlZFJlc291cmNlLmgiCiAjaW5jbHVkZSAiQ1N0cmluZy5oIgogI2luY2x1ZGUg IkRvY0xvYWRlci5oIgorI2luY2x1ZGUgIkRvY3VtZW50TG9hZGVyLmgiCiAjaW5jbHVkZSAiRnJh bWUuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRlci5oIgogI2luY2x1ZGUgIkhUTUxEb2N1bWVudC5o IgpAQCAtNDM4LDI0ICs0MzksNDAgQEAgdm9pZCBMb2FkZXI6Okhvc3Q6OmRpZFJlY2VpdmVSZXNw b25zZShTdQogICAgICAgICByZXR1cm47CiAgICAgCiAgICAgQ2FjaGVkUmVzb3VyY2UqIHJlc291 cmNlID0gcmVxdWVzdC0+Y2FjaGVkUmVzb3VyY2UoKTsKKworICAgIC8vIEdpdmUgdGhlIG92ZXJy aWRlIGVuY29kaW5nIGhpZ2ggcHJpb3JpdHkuCisgICAgRG9jTG9hZGVyKiBkb2NMb2FkZXIgPSBy ZXF1ZXN0LT5kb2NMb2FkZXIoKTsKKyAgICBBU1NFUlQoZG9jTG9hZGVyLT5mcmFtZSgpKTsKKyAg ICBTdHJpbmcgZW5jb2RpbmcgPSBkb2NMb2FkZXItPmZyYW1lKCktPmxvYWRlcigpLT5kb2N1bWVu dExvYWRlcigpLT5vdmVycmlkZUVuY29kaW5nKCk7CiAgICAgCiAgICAgaWYgKHJlc291cmNlLT5p c0NhY2hlVmFsaWRhdG9yKCkpIHsKICAgICAgICAgaWYgKHJlc3BvbnNlLmh0dHBTdGF0dXNDb2Rl KCkgPT0gMzA0KSB7CiAgICAgICAgICAgICAvLyAzMDQgTm90IG1vZGlmaWVkIC8gVXNlIGxvY2Fs IGNvcHkKLSAgICAgICAgICAgIG1fcmVxdWVzdHNMb2FkaW5nLnJlbW92ZShsb2FkZXIpOwotICAg ICAgICAgICAgbG9hZGVyLT5jbGVhckNsaWVudCgpOwotICAgICAgICAgICAgcmVxdWVzdC0+ZG9j TG9hZGVyKCktPmRlY3JlbWVudFJlcXVlc3RDb3VudCgpOworICAgICAgICAgICAgLy8gUmVzZXQg dGhlIGVuY29kaW5nIG9mIGNhY2hlZCByZXNvdXJjZSB0byBvdmVycmlkZSBlbmNvZGluZyBpZiBp dCBpcyBhdmFpbGFibGUuCisgICAgICAgICAgICBDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2VUb1Jl dmFsaWRhdGUgPSByZXNvdXJjZS0+cmVzb3VyY2VUb1JldmFsaWRhdGUoKTsKKyAgICAgICAgICAg IEFTU0VSVChyZXNvdXJjZVRvUmV2YWxpZGF0ZSk7CisgICAgICAgICAgICBpZiAoIWVuY29kaW5n LmlzRW1wdHkoKSAmJiByZXNvdXJjZVRvUmV2YWxpZGF0ZS0+ZW5jb2RpbmcoKSAhPSBlbmNvZGlu ZykgeworICAgICAgICAgICAgICAgIC8vIElmIHRoZSBlbmNvZGluZyBvZiBiYXNlZCByZXNvdXJj ZShyZXNvdXJjZVRvUmV2YWxpZGF0ZSkgaXMgZGlmZmVyZW50IHdpdGggb292ZXJyaWRlIGVuY29k aW5nLAorICAgICAgICAgICAgICAgIC8vIHdlIG5lZWQgdG8ga2VlcCBjdXJyZW50IHJlc291cmNl IGluc3RlYWQgb2YgZGVsZXRpbmcgYmVjYXVzZSB0aGUgZGVjb2RlZCBkYXRhIG9mIHRoZSBjdXJy ZW50CisgICAgICAgICAgICAgICAgLy8gcmVzb3VyY2UgaXMgYWxzbyBkaWZmZXJlbnQuCisgICAg ICAgICAgICAgICAgcmVzb3VyY2UtPnNldEVuY29kaW5nKGVuY29kaW5nKTsKKyAgICAgICAgICAg ICAgICBsb2FkZXItPmFkZERhdGEocmVzb3VyY2VUb1JldmFsaWRhdGUtPmRhdGEoKS0+ZGF0YSgp LCByZXNvdXJjZVRvUmV2YWxpZGF0ZS0+ZGF0YSgpLT5zaXplKCksIHRydWUpOworICAgICAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBtX3JlcXVlc3RzTG9hZGluZy5yZW1vdmUobG9h ZGVyKTsKKyAgICAgICAgICAgICAgICBsb2FkZXItPmNsZWFyQ2xpZW50KCk7CisgICAgICAgICAg ICAgICAgcmVxdWVzdC0+ZG9jTG9hZGVyKCktPmRlY3JlbWVudFJlcXVlc3RDb3VudCgpOwogCi0g ICAgICAgICAgICAvLyBFeGlzdGluZyByZXNvdXJjZSBpcyBvaywganVzdCB1c2UgaXQgdXBkYXRp bmcgdGhlIGV4cGlyYXRpb24gdGltZS4KLSAgICAgICAgICAgIGNhY2hlKCktPnJldmFsaWRhdGlv blN1Y2NlZWRlZChyZXNvdXJjZSwgcmVzcG9uc2UpOworICAgICAgICAgICAgICAgIC8vIEV4aXN0 aW5nIHJlc291cmNlIGlzIG9rLCBqdXN0IHVzZSBpdCB1cGRhdGluZyB0aGUgZXhwaXJhdGlvbiB0 aW1lLgorICAgICAgICAgICAgICAgIGNhY2hlKCktPnJldmFsaWRhdGlvblN1Y2NlZWRlZChyZXNv dXJjZSwgcmVzcG9uc2UpOwogICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAocmVxdWVzdC0+ ZG9jTG9hZGVyKCktPmZyYW1lKCkpCi0gICAgICAgICAgICAgICAgcmVxdWVzdC0+ZG9jTG9hZGVy KCktPmZyYW1lKCktPmxvYWRlcigpLT5jaGVja0NvbXBsZXRlZCgpOworICAgICAgICAgICAgICAg IGlmIChyZXF1ZXN0LT5kb2NMb2FkZXIoKS0+ZnJhbWUoKSkKKyAgICAgICAgICAgICAgICAgICAg cmVxdWVzdC0+ZG9jTG9hZGVyKCktPmZyYW1lKCktPmxvYWRlcigpLT5jaGVja0NvbXBsZXRlZCgp OwogCi0gICAgICAgICAgICBkZWxldGUgcmVxdWVzdDsKKyAgICAgICAgICAgICAgICBkZWxldGUg cmVxdWVzdDsKIAotICAgICAgICAgICAgc2VydmVQZW5kaW5nUmVxdWVzdHMoKTsKLSAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICBzZXJ2ZVBlbmRpbmdSZXF1ZXN0cygpOworICAg ICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KICAgICAgICAgfSAKICAgICAgICAg Ly8gRGlkIG5vdCBnZXQgMzA0IHJlc3BvbnNlLCBjb250aW51ZSBhcyBhIHJlZ3VsYXIgcmVzb3Vy Y2UgbG9hZC4KICAgICAgICAgY2FjaGUoKS0+cmV2YWxpZGF0aW9uRmFpbGVkKHJlc291cmNlKTsK QEAgLTQ2Myw3ICs0ODAsOCBAQCB2b2lkIExvYWRlcjo6SG9zdDo6ZGlkUmVjZWl2ZVJlc3BvbnNl KFN1CiAKICAgICByZXNvdXJjZS0+c2V0UmVzcG9uc2UocmVzcG9uc2UpOwogCi0gICAgU3RyaW5n IGVuY29kaW5nID0gcmVzcG9uc2UudGV4dEVuY29kaW5nTmFtZSgpOworICAgIGlmIChlbmNvZGlu Zy5pc0VtcHR5KCkpCisgICAgICAgIGVuY29kaW5nID0gcmVzcG9uc2UudGV4dEVuY29kaW5nTmFt ZSgpOwogICAgIGlmICghZW5jb2RpbmcuaXNOdWxsKCkpCiAgICAgICAgIHJlc291cmNlLT5zZXRF bmNvZGluZyhlbmNvZGluZyk7CiAgICAgCg==