277862 2024-08-09 10:10:28 -0700 [Text Directionality] Fix directionality for shadow tree 2024-08-26 21:46:46 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=278698 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa webkit-bug-importer oldest_to_newest 2051677 0 sabouhallawa 2024-08-09 10:10:28 -0700 https://wpt.fyi/html/dom/elements/global-attributes/dir-shadow-06.html https://wpt.fyi/html/dom/elements/global-attributes/dir-shadow-36.html https://wpt.fyi/html/dom/elements/global-attributes/dir-shadow-38.html https://wpt.fyi/html/dom/elements/global-attributes/dir-shadow-39.html 2051678 1 webkit-bug-importer 2024-08-09 10:10:50 -0700 <rdar://problem/133549820> 2051735 2 472104 sabouhallawa 2024-08-09 12:33:00 -0700 Created attachment 472104 test case I am attaching a test case. It contains two host <div> elements. Both hosts have <p> elements with Arabic text and undefined dir property. We insert a `<slot dir="auto"></slot>` in the shadow tree of the first <div> host. This will add the first child of this host as a slotted element to `<slot>` element which is the <p> element. According to the specs if the dir property is "undefined": Return the parent directionality of element. So I am not sure what the parent of the first <p> should be. Should it be its host <div> which also has undefined dir property? Or should it be the <slot> element which has dir="auto"? 2054197 3 sabouhallawa 2024-08-20 13:39:52 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32482 2054872 4 ews-feeder 2024-08-22 21:16:23 -0700 Committed 282648@main (b6ee5d981582): <https://commits.webkit.org/282648@main> Reviewed commits have been landed. Closing PR #32482 and removing active labels. 472104 2024-08-09 12:33:00 -0700 2024-08-09 12:33:00 -0700 test case dir-shadow-06.html text/html 1286 sabouhallawa PHN0eWxlPgogICAgYm9keSB7CiAgICAgICAgd2lkdGg6IDYwMHB4OwogICAgfQogICAgZGl2IHsK ICAgICAgICBib3JkZXI6IDFweCBzb2xpZCBncmF5OwogICAgICAgIG1hcmdpbjogMWVtOwogICAg fQogICAgZGl2IHAgewogICAgICAgIHdpZHRoOiA1MCU7CiAgICAgICAgYm9yZGVyOiAxcHggZG90 dGVkOwogICAgfQo8L3N0eWxlPgo8Ym9keT4KICAgIDxwPmBkaXI9YXV0b2Agb24gdGhlICZsdDtz bG90Jmd0OywgcGFyYWdyYXBoIGluIHRoZSBsaWdodCB0cmVlPC9wPgogICAgPGRpdiBpZD0iaG9z dDEiPjxwPiYjMTU3NTsmIzE1ODI7JiMxNTc4OyYjMTU3NjsmIzE1ODU7LjwvcD48L2Rpdj4KICAg IDxkaXYgaWQ9Imhvc3QyIj48cD4mIzE1NzU7JiMxNTgyOyYjMTU3ODsmIzE1NzY7JiMxNTg1Oy48 L3A+PC9kaXY+CiAgICA8cCBpZD0icmVzdWx0MSI+VGhlIEhUTUwgZGlyZWN0aW9uIC8gY29tcHV0 ZWQgQ1NTIGBkaXJlY3Rpb25gIHZhbHVlIGZvciBwYXJhZ3JhcGggMSBpczogPC9wPgogICAgPHAg aWQ9InJlc3VsdDIiPlRoZSBIVE1MIGRpcmVjdGlvbiAvIGNvbXB1dGVkIENTUyBgZGlyZWN0aW9u YCB2YWx1ZSBmb3IgcGFyYWdyYXBoIDIgaXM6IDwvcD4KCiAgICA8c2NyaXB0PgogICAgICAgIGZ1 bmN0aW9uIGh0bWxfZGlyZWN0aW9uKGVsZW1lbnQpIHsKICAgICAgICAgICAgbGV0IGlzX2x0ciA9 IGVsZW1lbnQubWF0Y2hlcygiOmRpcihsdHIpIik7CiAgICAgICAgICAgIGxldCBpc19ydGwgPSBl bGVtZW50Lm1hdGNoZXMoIjpkaXIocnRsKSIpOwogICAgICAgICAgICBpZiAoaXNfbHRyID09IGlz X3J0bCkgewogICAgICAgICAgICAgICAgcmV0dXJuICJlcnJvciI7CiAgICAgICAgICAgIH0KICAg ICAgICAgICAgcmV0dXJuIGlzX2x0ciA/ICJsdHIiIDogInJ0bCI7CiAgICAgICAgfQoKICAgICAg ICBsZXQgcm9vdDEgPSBob3N0MS5hdHRhY2hTaGFkb3coe21vZGU6Im9wZW4ifSk7CiAgICAgICAg cm9vdDEuaW5uZXJIVE1MID0gYDxzbG90IGRpcj0iYXV0byI+PC9zbG90PmA7CgogICAgICAgIHJl c3VsdDEuaW5uZXJIVE1MICs9IGh0bWxfZGlyZWN0aW9uKGhvc3QxLmZpcnN0Q2hpbGQpICsgIiAv ICIgKyBnZXRDb21wdXRlZFN0eWxlKGhvc3QxLmZpcnN0Q2hpbGQpLmRpcmVjdGlvbiArICcuJzsK ICAgICAgICByZXN1bHQyLmlubmVySFRNTCArPSBodG1sX2RpcmVjdGlvbihob3N0Mi5maXJzdENo aWxkKSArICIgLyAiICsgZ2V0Q29tcHV0ZWRTdHlsZShob3N0Mi5maXJzdENoaWxkKS5kaXJlY3Rp b24gKyAnLic7CiAgICA8L3NjcmlwdD4KPC9ib2R5Pgo=