277855 2024-08-09 07:03:01 -0700 [Repaint] Inline box with layer fails to repaint 2024-08-10 05:15:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 276103 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 2051652 0 472097 zalan 2024-08-09 07:03:01 -0700 Created attachment 472097 Test case see test case 2051653 1 zalan 2024-08-09 07:04:50 -0700 regressed with 280578@main, processed with the revert at 281989@main. 2051654 2 zalan 2024-08-09 07:05:26 -0700 > regressed with 280578@main, processed with the revert at 281989@main. progressed even 2051733 3 472103 zalan 2024-08-09 12:22:08 -0700 Created attachment 472103 Patch 2051814 4 472109 zalan 2024-08-09 19:32:45 -0700 Created attachment 472109 Patch 2051815 5 472109 simon.fraser 2024-08-09 19:50:00 -0700 Comment on attachment 472109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472109&action=review > COMMIT_MESSAGE:6 > +Let's move RenderText's repaint handling from dirtyLinesFromChangedChild to RenderBlockFlow::layoutModernLines. More words about how this fixes the bug, please! > Source/WebCore/rendering/RenderBlockFlow.cpp:3886 > +static void issueFullRepaintOnParentInlineBoxBeforeLayoutIfNeeded(const RenderText& renderer) I wonder if this name should have "layer" in it somewhere. > Source/WebCore/rendering/RenderBlockFlow.cpp:3890 > + // Additionally, repaint at the block level (#3) takes care of regular inflow content. in-flow > Source/WebCore/rendering/RenderBlockFlow.cpp:3893 > + // share the same layer. I feel like this comment should continue to say what this code is doing to address those shortcomings. 2051818 6 472110 zalan 2024-08-09 20:04:19 -0700 Created attachment 472110 [fast-cq]Patch 2051879 7 ews-feeder 2024-08-10 05:14:01 -0700 Committed 282082@main (9d8503d5ba1a): <https://commits.webkit.org/282082@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472110. 2051880 8 webkit-bug-importer 2024-08-10 05:15:15 -0700 <rdar://problem/133596199> 472097 2024-08-09 07:03:01 -0700 2024-08-09 07:03:01 -0700 Test case inline-box-repaint.html text/html 298 zalan PHN0eWxlPgpib2R5IHsKICBwYWRkaW5nOiA0MHB4Owp9CgpkaXYgewogIGJhY2tncm91bmQtY29s b3I6IGdyZWVuOwp9CgpzcGFuIHsKICBmb250LWZhbWlseTogTW9ub3NwYWNlOwogIHBvc2l0aW9u OiByZWxhdGl2ZTsKICB0b3A6IC0yMHB4Owp9Cjwvc3R5bGU+CjxkaXY+PHNwYW4gaWQ9Y2hhbmdl X3RoaXM+ZmFpbDwvc3Bhbj48L2Rpdj4KPHNjcmlwdD4Kc2V0VGltZW91dChmdW5jdGlvbigpIHsK ICBjaGFuZ2VfdGhpcy5maXJzdENoaWxkLnJlcGxhY2VEYXRhKDAsIDQsICJwYXNzIik7Cn0sIDEw MCk7Cjwvc2NyaXB0Pg== 472103 2024-08-09 12:22:08 -0700 2024-08-09 19:32:43 -0700 Patch bug-277855-20240809122208.patch text/plain 4006 zalan RnJvbSBkM2JhNWRmOTU4MjAyMDM2ZGYxYWE4ODNmOWFjMDc4ZmVkNDE5ZTJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IEZyaSwgOSBBdWcgMjAyNCAxMjoxOTowMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFtSZXBhaW50 XSBJbmxpbmUgYm94IHdpdGggbGF5ZXIgZmFpbHMgdG8gcmVwYWludAogaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3Nzg1NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgpMZXQncyBtb3ZlIFJlbmRlclRleHQncyByZXBhaW50IGhhbmRsaW5nIGZyb20gZGlydHlM aW5lc0Zyb21DaGFuZ2VkQ2hpbGQgdG8gUmVuZGVyQmxvY2tGbG93OjpsYXlvdXRNb2Rlcm5MaW5l cy4KCiogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6CihXZWJD b3JlOjppc3N1ZUZ1bGxSZXBhaW50T25QYXJlbnRJbmxpbmVCb3hCZWZvcmVMYXlvdXRJZk5lZWRl ZCk6CihXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmxheW91dE1vZGVybkxpbmVzKToKKiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3BwOgooV2ViQ29yZTo6UmVu ZGVyTGluZUJveExpc3Q6OmRpcnR5TGluZXNGcm9tQ2hhbmdlZENoaWxkKToKLS0tCiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCAgfCAyMiArKysrKysrKysrKysr KysrKysrCiAuLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3BwICAgfCAg NSArLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXgg ZTdiNzMzMGE0NmM3Li45ODg1NTBjYzcxMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0zODgzLDYgKzM4ODMsMjUgQEAgc3RhdGljIGJvb2wg aGFzU2ltcGxlU3RhdGljUG9zaXRpb25Gb3JJbmxpbmVMZXZlbE91dE9mRmxvd0NoaWxkcmVuQnlT dHlsZShjb25zdAogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgdm9pZCBpc3N1ZUZ1bGxS ZXBhaW50T25QYXJlbnRJbmxpbmVCb3hCZWZvcmVMYXlvdXRJZk5lZWRlZChjb25zdCBSZW5kZXJU ZXh0JiByZW5kZXJlcikKK3sKKyAgICAvLyBSZXBhaW50cyAob24gc2VsZikgYXJlIG5vcm1hbGx5 IGlzc3VlZCBlaXRoZXIgZHVyaW5nIGxheW91dCB1c2luZyBMYXlvdXRSZXBhaW50ZXIgaW5zaWRl IDo6bGF5b3V0KCkgZnVuY3Rpb25zICgjMSkKKyAgICAvLyBvciBhZnRlciBsYXlvdXQsIHdoaWxl IHJlY3Vyc2luZyB0aGUgbGF5ZXIgdHJlZSAoIzIpLgorICAgIC8vIEFkZGl0aW9uYWxseSwgcmVw YWludCBhdCB0aGUgYmxvY2sgbGV2ZWwgKCMzKSB0YWtlcyBjYXJlIG9mIHJlZ3VsYXIgaW5mbG93 IGNvbnRlbnQuCisgICAgLy8gSG93ZXZlciBpbiBjYXNlIG9mIHRleHQgY29udGVudCwgd2UgZG9u J3QgaGF2ZSAoIzEpLCAoIzIpIGlzIHByaW1hcmlseSBhIGdlb21ldHJ5IGRpZmYgdHlwZSBvZiBy ZXBhaW50IG1lYW5pbmcKKyAgICAvLyBubyByZXBhaW50IGhhcHBlbnMgdW5sZXNzIGNvbnRlbnQg c2l6ZSBjaGFuZ2VzIGFuZCAoIzMpIG9ubHkgd29ya3Mgd2hlbiB0aGUgYmxvY2sgY29udGFpbmVy IGFuZCB0aGUgdGV4dCBjb250ZW50CisgICAgLy8gc2hhcmUgdGhlIHNhbWUgbGF5ZXIuCisgICAg QVNTRVJUKHJlbmRlcmVyLm5lZWRzTGF5b3V0KCkpOworICAgIENoZWNrZWRQdHIgcGFyZW50ID0g cmVuZGVyZXIucGFyZW50KCk7CisgICAgaWYgKCFwYXJlbnQpIHsKKyAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgaWYgKCFwYXJlbnQtPmlz SW5saW5lKCkgfHwgIXBhcmVudC0+aGFzTGF5ZXIoKSkKKyAgICAgICAgcmV0dXJuOworICAgIGRv d25jYXN0PFJlbmRlckxheWVyTW9kZWxPYmplY3Q+KCpwYXJlbnQpLmNoZWNrZWRMYXllcigpLT5z ZXRSZXBhaW50U3RhdHVzKFJlcGFpbnRTdGF0dXM6Ok5lZWRzRnVsbFJlcGFpbnQpOworfQorCiB2 b2lkIFJlbmRlckJsb2NrRmxvdzo6bGF5b3V0TW9kZXJuTGluZXMoYm9vbCByZWxheW91dENoaWxk cmVuLCBMYXlvdXRVbml0JiByZXBhaW50TG9naWNhbFRvcCwgTGF5b3V0VW5pdCYgcmVwYWludExv Z2ljYWxCb3R0b20pCiB7CiAgICAgYXV0byYgbGF5b3V0U3RhdGUgPSAqdmlldygpLmZyYW1lVmll dygpLmxheW91dENvbnRleHQoKS5sYXlvdXRTdGF0ZSgpOwpAQCAtMzkyMiw2ICszOTQxLDkgQEAg dm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmxheW91dE1vZGVybkxpbmVzKGJvb2wgcmVsYXlvdXRDaGls ZHJlbiwgTGF5b3V0VW5pdCYgcmVwYWkKICAgICAgICAgaWYgKCFyZW5kZXJlci5uZWVkc0xheW91 dCgpICYmICFyZW5kZXJlci5wcmVmZXJyZWRMb2dpY2FsV2lkdGhzRGlydHkoKSkKICAgICAgICAg ICAgIGNvbnRpbnVlOwogCisgICAgICAgIGlmIChhdXRvKiByZW5kZXJUZXh0ID0gZHluYW1pY0Rv d25jYXN0PFJlbmRlclRleHQ+KHJlbmRlcmVyKSkKKyAgICAgICAgICAgIGlzc3VlRnVsbFJlcGFp bnRPblBhcmVudElubGluZUJveEJlZm9yZUxheW91dElmTmVlZGVkKCpyZW5kZXJUZXh0KTsKKwog ICAgICAgICBhdXRvIHNob3VsZFJ1bkluRmxvd0xheW91dCA9IHJlbmRlcmVyLmlzSW5GbG93KCkg JiYgaXM8UmVuZGVyRWxlbWVudD4ocmVuZGVyZXIpICYmICFpczxSZW5kZXJMaW5lQnJlYWs+KHJl bmRlcmVyKSAmJiAhaXM8UmVuZGVySW5saW5lPihyZW5kZXJlcikgJiYgIWlzPFJlbmRlckNvdW50 ZXI+KHJlbmRlcmVyKTsKICAgICAgICAgaWYgKHNob3VsZFJ1bkluRmxvd0xheW91dCB8fCByZW5k ZXJlci5pc0Zsb2F0aW5nKCkpCiAgICAgICAgICAgICBkb3duY2FzdDxSZW5kZXJFbGVtZW50Pihy ZW5kZXJlcikubGF5b3V0SWZOZWVkZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGluZUJveExpc3QuY3BwCmluZGV4IDVjNTljOThlZmI5OC4uZmFmODIyZGI5M2FmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAKQEAg LTMxNCwxMSArMzE0LDggQEAgYm9vbCBSZW5kZXJMaW5lQm94TGlzdDo6aGl0VGVzdChSZW5kZXJC b3hNb2RlbE9iamVjdCogcmVuZGVyZXIsIGNvbnN0IEhpdFRlc3RSZXEKIHZvaWQgUmVuZGVyTGlu ZUJveExpc3Q6OmRpcnR5TGluZXNGcm9tQ2hhbmdlZENoaWxkKFJlbmRlckJveE1vZGVsT2JqZWN0 JiBjb250YWluZXIsIFJlbmRlck9iamVjdCYpCiB7CiAgICAgQVNTRVJUKGlzPFJlbmRlcklubGlu ZT4oY29udGFpbmVyKSB8fCBpczxSZW5kZXJCbG9ja0Zsb3c+KGNvbnRhaW5lcikpOwotICAgIGlm ICghY29udGFpbmVyLmlzU1ZHUmVuZGVyZXIoKSkgewotICAgICAgICBpZiAoY29udGFpbmVyLmlz SW5saW5lKCkgJiYgY29udGFpbmVyLmhhc0xheWVyKCkpCi0gICAgICAgICAgICBjb250YWluZXIu Y2hlY2tlZExheWVyKCktPnNldFJlcGFpbnRTdGF0dXMoUmVwYWludFN0YXR1czo6TmVlZHNGdWxs UmVwYWludCk7CisgICAgaWYgKCFjb250YWluZXIuaXNTVkdSZW5kZXJlcigpKQogICAgICAgICBy ZXR1cm47Ci0gICAgfQogCiAgICAgaWYgKCFjb250YWluZXIucGFyZW50KCkgfHwgKGlzPFJlbmRl ckJsb2NrRmxvdz4oY29udGFpbmVyKSAmJiBjb250YWluZXIuc2VsZk5lZWRzTGF5b3V0KCkpKQog ICAgICAgICByZXR1cm47Cg== 472109 2024-08-09 19:32:45 -0700 2024-08-09 20:04:17 -0700 Patch bug-277855-20240809193244.patch text/plain 4006 zalan RnJvbSBkM2JhNWRmOTU4MjAyMDM2ZGYxYWE4ODNmOWFjMDc4ZmVkNDE5ZTJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IEZyaSwgOSBBdWcgMjAyNCAxMjoxOTowMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFtSZXBhaW50 XSBJbmxpbmUgYm94IHdpdGggbGF5ZXIgZmFpbHMgdG8gcmVwYWludAogaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3Nzg1NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgpMZXQncyBtb3ZlIFJlbmRlclRleHQncyByZXBhaW50IGhhbmRsaW5nIGZyb20gZGlydHlM aW5lc0Zyb21DaGFuZ2VkQ2hpbGQgdG8gUmVuZGVyQmxvY2tGbG93OjpsYXlvdXRNb2Rlcm5MaW5l cy4KCiogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6CihXZWJD b3JlOjppc3N1ZUZ1bGxSZXBhaW50T25QYXJlbnRJbmxpbmVCb3hCZWZvcmVMYXlvdXRJZk5lZWRl ZCk6CihXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmxheW91dE1vZGVybkxpbmVzKToKKiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3BwOgooV2ViQ29yZTo6UmVu ZGVyTGluZUJveExpc3Q6OmRpcnR5TGluZXNGcm9tQ2hhbmdlZENoaWxkKToKLS0tCiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCAgfCAyMiArKysrKysrKysrKysr KysrKysrCiAuLi4vV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3BwICAgfCAg NSArLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXgg ZTdiNzMzMGE0NmM3Li45ODg1NTBjYzcxMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0zODgzLDYgKzM4ODMsMjUgQEAgc3RhdGljIGJvb2wg aGFzU2ltcGxlU3RhdGljUG9zaXRpb25Gb3JJbmxpbmVMZXZlbE91dE9mRmxvd0NoaWxkcmVuQnlT dHlsZShjb25zdAogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgdm9pZCBpc3N1ZUZ1bGxS ZXBhaW50T25QYXJlbnRJbmxpbmVCb3hCZWZvcmVMYXlvdXRJZk5lZWRlZChjb25zdCBSZW5kZXJU ZXh0JiByZW5kZXJlcikKK3sKKyAgICAvLyBSZXBhaW50cyAob24gc2VsZikgYXJlIG5vcm1hbGx5 IGlzc3VlZCBlaXRoZXIgZHVyaW5nIGxheW91dCB1c2luZyBMYXlvdXRSZXBhaW50ZXIgaW5zaWRl IDo6bGF5b3V0KCkgZnVuY3Rpb25zICgjMSkKKyAgICAvLyBvciBhZnRlciBsYXlvdXQsIHdoaWxl IHJlY3Vyc2luZyB0aGUgbGF5ZXIgdHJlZSAoIzIpLgorICAgIC8vIEFkZGl0aW9uYWxseSwgcmVw YWludCBhdCB0aGUgYmxvY2sgbGV2ZWwgKCMzKSB0YWtlcyBjYXJlIG9mIHJlZ3VsYXIgaW5mbG93 IGNvbnRlbnQuCisgICAgLy8gSG93ZXZlciBpbiBjYXNlIG9mIHRleHQgY29udGVudCwgd2UgZG9u J3QgaGF2ZSAoIzEpLCAoIzIpIGlzIHByaW1hcmlseSBhIGdlb21ldHJ5IGRpZmYgdHlwZSBvZiBy ZXBhaW50IG1lYW5pbmcKKyAgICAvLyBubyByZXBhaW50IGhhcHBlbnMgdW5sZXNzIGNvbnRlbnQg c2l6ZSBjaGFuZ2VzIGFuZCAoIzMpIG9ubHkgd29ya3Mgd2hlbiB0aGUgYmxvY2sgY29udGFpbmVy IGFuZCB0aGUgdGV4dCBjb250ZW50CisgICAgLy8gc2hhcmUgdGhlIHNhbWUgbGF5ZXIuCisgICAg QVNTRVJUKHJlbmRlcmVyLm5lZWRzTGF5b3V0KCkpOworICAgIENoZWNrZWRQdHIgcGFyZW50ID0g cmVuZGVyZXIucGFyZW50KCk7CisgICAgaWYgKCFwYXJlbnQpIHsKKyAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgaWYgKCFwYXJlbnQtPmlz SW5saW5lKCkgfHwgIXBhcmVudC0+aGFzTGF5ZXIoKSkKKyAgICAgICAgcmV0dXJuOworICAgIGRv d25jYXN0PFJlbmRlckxheWVyTW9kZWxPYmplY3Q+KCpwYXJlbnQpLmNoZWNrZWRMYXllcigpLT5z ZXRSZXBhaW50U3RhdHVzKFJlcGFpbnRTdGF0dXM6Ok5lZWRzRnVsbFJlcGFpbnQpOworfQorCiB2 b2lkIFJlbmRlckJsb2NrRmxvdzo6bGF5b3V0TW9kZXJuTGluZXMoYm9vbCByZWxheW91dENoaWxk cmVuLCBMYXlvdXRVbml0JiByZXBhaW50TG9naWNhbFRvcCwgTGF5b3V0VW5pdCYgcmVwYWludExv Z2ljYWxCb3R0b20pCiB7CiAgICAgYXV0byYgbGF5b3V0U3RhdGUgPSAqdmlldygpLmZyYW1lVmll dygpLmxheW91dENvbnRleHQoKS5sYXlvdXRTdGF0ZSgpOwpAQCAtMzkyMiw2ICszOTQxLDkgQEAg dm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmxheW91dE1vZGVybkxpbmVzKGJvb2wgcmVsYXlvdXRDaGls ZHJlbiwgTGF5b3V0VW5pdCYgcmVwYWkKICAgICAgICAgaWYgKCFyZW5kZXJlci5uZWVkc0xheW91 dCgpICYmICFyZW5kZXJlci5wcmVmZXJyZWRMb2dpY2FsV2lkdGhzRGlydHkoKSkKICAgICAgICAg ICAgIGNvbnRpbnVlOwogCisgICAgICAgIGlmIChhdXRvKiByZW5kZXJUZXh0ID0gZHluYW1pY0Rv d25jYXN0PFJlbmRlclRleHQ+KHJlbmRlcmVyKSkKKyAgICAgICAgICAgIGlzc3VlRnVsbFJlcGFp bnRPblBhcmVudElubGluZUJveEJlZm9yZUxheW91dElmTmVlZGVkKCpyZW5kZXJUZXh0KTsKKwog ICAgICAgICBhdXRvIHNob3VsZFJ1bkluRmxvd0xheW91dCA9IHJlbmRlcmVyLmlzSW5GbG93KCkg JiYgaXM8UmVuZGVyRWxlbWVudD4ocmVuZGVyZXIpICYmICFpczxSZW5kZXJMaW5lQnJlYWs+KHJl bmRlcmVyKSAmJiAhaXM8UmVuZGVySW5saW5lPihyZW5kZXJlcikgJiYgIWlzPFJlbmRlckNvdW50 ZXI+KHJlbmRlcmVyKTsKICAgICAgICAgaWYgKHNob3VsZFJ1bkluRmxvd0xheW91dCB8fCByZW5k ZXJlci5pc0Zsb2F0aW5nKCkpCiAgICAgICAgICAgICBkb3duY2FzdDxSZW5kZXJFbGVtZW50Pihy ZW5kZXJlcikubGF5b3V0SWZOZWVkZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGluZUJveExpc3QuY3BwCmluZGV4IDVjNTljOThlZmI5OC4uZmFmODIyZGI5M2FmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAKQEAg LTMxNCwxMSArMzE0LDggQEAgYm9vbCBSZW5kZXJMaW5lQm94TGlzdDo6aGl0VGVzdChSZW5kZXJC b3hNb2RlbE9iamVjdCogcmVuZGVyZXIsIGNvbnN0IEhpdFRlc3RSZXEKIHZvaWQgUmVuZGVyTGlu ZUJveExpc3Q6OmRpcnR5TGluZXNGcm9tQ2hhbmdlZENoaWxkKFJlbmRlckJveE1vZGVsT2JqZWN0 JiBjb250YWluZXIsIFJlbmRlck9iamVjdCYpCiB7CiAgICAgQVNTRVJUKGlzPFJlbmRlcklubGlu ZT4oY29udGFpbmVyKSB8fCBpczxSZW5kZXJCbG9ja0Zsb3c+KGNvbnRhaW5lcikpOwotICAgIGlm ICghY29udGFpbmVyLmlzU1ZHUmVuZGVyZXIoKSkgewotICAgICAgICBpZiAoY29udGFpbmVyLmlz SW5saW5lKCkgJiYgY29udGFpbmVyLmhhc0xheWVyKCkpCi0gICAgICAgICAgICBjb250YWluZXIu Y2hlY2tlZExheWVyKCktPnNldFJlcGFpbnRTdGF0dXMoUmVwYWludFN0YXR1czo6TmVlZHNGdWxs UmVwYWludCk7CisgICAgaWYgKCFjb250YWluZXIuaXNTVkdSZW5kZXJlcigpKQogICAgICAgICBy ZXR1cm47Ci0gICAgfQogCiAgICAgaWYgKCFjb250YWluZXIucGFyZW50KCkgfHwgKGlzPFJlbmRl ckJsb2NrRmxvdz4oY29udGFpbmVyKSAmJiBjb250YWluZXIuc2VsZk5lZWRzTGF5b3V0KCkpKQog ICAgICAgICByZXR1cm47Cg== 472110 2024-08-09 20:04:19 -0700 2024-08-10 05:14:02 -0700 [fast-cq]Patch bug-277855-20240809200419.patch text/plain 4213 zalan RnJvbSBlMTNkMWRhYjhmYmM0NDI0NzczMmRkMzdhYjRjZTAyYmQ4Mzg2NzVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IEZyaSwgOSBBdWcgMjAyNCAxMjoxOTowMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFtSZXBhaW50 XSBkaXJ0eUxpbmVzRnJvbUNoYW5nZWRDaGlsZCBzaG91bGQgbm90IGlzc3VlIHJlcGFpbnQKIGZv ciBpbmxpbmUgY29udGVudCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjc3ODU1CgpSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCgpkaXJ0eUxpbmVzRnJvbUNoYW5nZWRD aGlsZCBpcyBhIHJlYWxseSBvYnNjdXJlIHBsYWNlIHRvIGlzc3VlIHJlcGFpbnQgb24gaW5saW5l IGNvbnRlbnQuCkxldCdzIG1vdmUgaXQgdG8gUmVuZGVyQmxvY2tGbG93OjpsYXlvdXRNb2Rlcm5M aW5lcyB3aGVyZSBibG9jayBsZXZlbCByZXBhaW50IGhhcHBlbnMgdG9vLgoKKiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKFdlYkNvcmU6Omlzc3VlRnVsbFJl cGFpbnRPblBhcmVudElubGluZUJveEJlZm9yZUxheW91dElmTmVlZGVkKToKKFdlYkNvcmU6OlJl bmRlckJsb2NrRmxvdzo6bGF5b3V0TW9kZXJuTGluZXMpOgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHA6CihXZWJDb3JlOjpSZW5kZXJMaW5lQm94TGlzdDo6 ZGlydHlMaW5lc0Zyb21DaGFuZ2VkQ2hpbGQpOgotLS0KIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0Zsb3cuY3BwICB8IDIzICsrKysrKysrKysrKysrKysrKysKIC4uLi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAgICB8ICA1ICstLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4IGU3YjczMzBhNDZjNy4uOGM2 MGMxNWQwMTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxv Y2tGbG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93 LmNwcApAQCAtMzg4Myw2ICszODgzLDI2IEBAIHN0YXRpYyBib29sIGhhc1NpbXBsZVN0YXRpY1Bv c2l0aW9uRm9ySW5saW5lTGV2ZWxPdXRPZkZsb3dDaGlsZHJlbkJ5U3R5bGUoY29uc3QKICAgICBy ZXR1cm4gdHJ1ZTsKIH0KIAorc3RhdGljIHZvaWQgc2V0RnVsbFJlcGFpbnRPblBhcmVudElubGlu ZUJveExheWVySWZOZWVkZWQoY29uc3QgUmVuZGVyVGV4dCYgcmVuZGVyZXIpCit7CisgICAgLy8g UmVwYWludHMgKG9uIHNlbGYpIGFyZSBub3JtYWxseSBpc3N1ZWQgZWl0aGVyIGR1cmluZyBsYXlv dXQgdXNpbmcgTGF5b3V0UmVwYWludGVyIGluc2lkZSA6OmxheW91dCgpIGZ1bmN0aW9ucyAoIzEp CisgICAgLy8gb3IgYWZ0ZXIgbGF5b3V0LCB3aGlsZSByZWN1cnNpbmcgdGhlIGxheWVyIHRyZWUg KCMyKS4KKyAgICAvLyBBZGRpdGlvbmFsbHksIHJlcGFpbnQgYXQgdGhlIGJsb2NrIGxldmVsICgj MykgdGFrZXMgY2FyZSBvZiByZWd1bGFyIGluLWZsb3cgY29udGVudC4KKyAgICAvLyBIb3dldmVy IGluIGNhc2Ugb2YgdGV4dCBjb250ZW50LCB3ZSBkb24ndCBoYXZlICgjMSksICgjMikgaXMgcHJp bWFyaWx5IGEgZ2VvbWV0cnkgZGlmZiB0eXBlIG9mIHJlcGFpbnQgbWVhbmluZworICAgIC8vIG5v IHJlcGFpbnQgaGFwcGVucyB1bmxlc3MgY29udGVudCBzaXplIGNoYW5nZXMgKG9yIGZ1bGwgcmVw YWludCBiaXQgaXMgc2V0IG9uIHRoZSBsYXllcikKKyAgICAvLyBhbmQgKCMzKSBvbmx5IHdvcmtz IHdoZW4gdGhlIGJsb2NrIGNvbnRhaW5lciBhbmQgdGhlIHRleHQgY29udGVudCBzaGFyZSB0aGUg c2FtZSBsYXllci4KKyAgICAvLyBIZXJlIHdlIG1hcmsgdGhlIHBhcmVudCBpbmxpbmUgYm94J3Mg bGF5ZXIgZGlydHkgdG8gdHJpZ2dlciByZXBhaW50IGF0ICgjMikuCisgICAgQVNTRVJUKHJlbmRl cmVyLm5lZWRzTGF5b3V0KCkpOworICAgIENoZWNrZWRQdHIgcGFyZW50ID0gcmVuZGVyZXIucGFy ZW50KCk7CisgICAgaWYgKCFwYXJlbnQpIHsKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 CisgICAgICAgIHJldHVybjsKKyAgICB9CisgICAgaWYgKCFwYXJlbnQtPmlzSW5saW5lKCkgfHwg IXBhcmVudC0+aGFzTGF5ZXIoKSkKKyAgICAgICAgcmV0dXJuOworICAgIGRvd25jYXN0PFJlbmRl ckxheWVyTW9kZWxPYmplY3Q+KCpwYXJlbnQpLmNoZWNrZWRMYXllcigpLT5zZXRSZXBhaW50U3Rh dHVzKFJlcGFpbnRTdGF0dXM6Ok5lZWRzRnVsbFJlcGFpbnQpOworfQorCiB2b2lkIFJlbmRlckJs b2NrRmxvdzo6bGF5b3V0TW9kZXJuTGluZXMoYm9vbCByZWxheW91dENoaWxkcmVuLCBMYXlvdXRV bml0JiByZXBhaW50TG9naWNhbFRvcCwgTGF5b3V0VW5pdCYgcmVwYWludExvZ2ljYWxCb3R0b20p CiB7CiAgICAgYXV0byYgbGF5b3V0U3RhdGUgPSAqdmlldygpLmZyYW1lVmlldygpLmxheW91dENv bnRleHQoKS5sYXlvdXRTdGF0ZSgpOwpAQCAtMzkyMiw2ICszOTQyLDkgQEAgdm9pZCBSZW5kZXJC bG9ja0Zsb3c6OmxheW91dE1vZGVybkxpbmVzKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgTGF5b3V0 VW5pdCYgcmVwYWkKICAgICAgICAgaWYgKCFyZW5kZXJlci5uZWVkc0xheW91dCgpICYmICFyZW5k ZXJlci5wcmVmZXJyZWRMb2dpY2FsV2lkdGhzRGlydHkoKSkKICAgICAgICAgICAgIGNvbnRpbnVl OwogCisgICAgICAgIGlmIChhdXRvKiByZW5kZXJUZXh0ID0gZHluYW1pY0Rvd25jYXN0PFJlbmRl clRleHQ+KHJlbmRlcmVyKSkKKyAgICAgICAgICAgIHNldEZ1bGxSZXBhaW50T25QYXJlbnRJbmxp bmVCb3hMYXllcklmTmVlZGVkKCpyZW5kZXJUZXh0KTsKKwogICAgICAgICBhdXRvIHNob3VsZFJ1 bkluRmxvd0xheW91dCA9IHJlbmRlcmVyLmlzSW5GbG93KCkgJiYgaXM8UmVuZGVyRWxlbWVudD4o cmVuZGVyZXIpICYmICFpczxSZW5kZXJMaW5lQnJlYWs+KHJlbmRlcmVyKSAmJiAhaXM8UmVuZGVy SW5saW5lPihyZW5kZXJlcikgJiYgIWlzPFJlbmRlckNvdW50ZXI+KHJlbmRlcmVyKTsKICAgICAg ICAgaWYgKHNob3VsZFJ1bkluRmxvd0xheW91dCB8fCByZW5kZXJlci5pc0Zsb2F0aW5nKCkpCiAg ICAgICAgICAgICBkb3duY2FzdDxSZW5kZXJFbGVtZW50PihyZW5kZXJlcikubGF5b3V0SWZOZWVk ZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94 TGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3Bw CmluZGV4IDVjNTljOThlZmI5OC4uZmFmODIyZGI5M2FmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAKQEAgLTMxNCwxMSArMzE0LDggQEAgYm9v bCBSZW5kZXJMaW5lQm94TGlzdDo6aGl0VGVzdChSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVuZGVy ZXIsIGNvbnN0IEhpdFRlc3RSZXEKIHZvaWQgUmVuZGVyTGluZUJveExpc3Q6OmRpcnR5TGluZXNG cm9tQ2hhbmdlZENoaWxkKFJlbmRlckJveE1vZGVsT2JqZWN0JiBjb250YWluZXIsIFJlbmRlck9i amVjdCYpCiB7CiAgICAgQVNTRVJUKGlzPFJlbmRlcklubGluZT4oY29udGFpbmVyKSB8fCBpczxS ZW5kZXJCbG9ja0Zsb3c+KGNvbnRhaW5lcikpOwotICAgIGlmICghY29udGFpbmVyLmlzU1ZHUmVu ZGVyZXIoKSkgewotICAgICAgICBpZiAoY29udGFpbmVyLmlzSW5saW5lKCkgJiYgY29udGFpbmVy Lmhhc0xheWVyKCkpCi0gICAgICAgICAgICBjb250YWluZXIuY2hlY2tlZExheWVyKCktPnNldFJl cGFpbnRTdGF0dXMoUmVwYWludFN0YXR1czo6TmVlZHNGdWxsUmVwYWludCk7CisgICAgaWYgKCFj b250YWluZXIuaXNTVkdSZW5kZXJlcigpKQogICAgICAgICByZXR1cm47Ci0gICAgfQogCiAgICAg aWYgKCFjb250YWluZXIucGFyZW50KCkgfHwgKGlzPFJlbmRlckJsb2NrRmxvdz4oY29udGFpbmVy KSAmJiBjb250YWluZXIuc2VsZk5lZWRzTGF5b3V0KCkpKQogICAgICAgICByZXR1cm47Cg==