27767 2009-07-28 06:49:43 -0700 Kill the annoying (and misunderstandable) LEAK messages in debug mode 2010-03-08 06:37:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Enhancement --- 0 zherczeg webkit-unassigned kenneth vestbo oldest_to_newest 135182 0 zherczeg 2009-07-28 06:49:43 -0700 When QtLauncher quits in debug mode, it yields several LEAK messages. This is confusing, since one could think these are real leaks, and QtLauncher has difficulties freeing memory blocks. This patch mimics the mac version. 135186 1 33624 zherczeg 2009-07-28 06:53:11 -0700 Created attachment 33624 proposed patch 135237 2 kenneth 2009-07-28 09:00:29 -0700 "Kill the LEAK messages in Debug mode" for me sounds like you just removed the messages, but that is not actually what you did. Could you please make the ChangeLog more descriptive? 135500 3 33696 zherczeg 2009-07-28 23:39:51 -0700 Created attachment 33696 propsed patch v2 135526 4 33700 zherczeg 2009-07-29 01:30:04 -0700 Created attachment 33700 propsed patch v3 135527 5 33700 hausmann 2009-07-29 01:34:04 -0700 Comment on attachment 33700 propsed patch v3 r=me 135567 6 kenneth 2009-07-29 05:34:52 -0700 You forgot to say that you landed this!, please clear the patch review state. 33624 2009-07-28 06:53:11 -0700 2009-07-28 23:39:51 -0700 proposed patch 0001-QtLauncher-LEAK-messages-fix.patch text/plain 2716 zherczeg RnJvbSBlOTJhZmFjYWE3NTI1NzczMGRiNmYzYjQ1N2MxYzA5Mzg2YWNmZjhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBUdWUsIDI4IEp1bCAyMDA5IDE1OjUwOjU2ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gUXRMYXVuY2hlciBMRUFLIG1lc3NhZ2VzIGZpeAoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhl cmN6ZWcgPHpoZXJjemVnQGluZi51LXN6ZWdlZC5odT4KLS0tCiBXZWJLaXQvcXQvQXBpL3F3ZWJm cmFtZS5jcHAgICB8ICAgIDkgKysrKysrKysrCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAg ICB8ICAgMTIgKysrKysrKysrKysrCiBXZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcCB8ICAg MTIgKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDAgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwIGIvV2Vi S2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCmluZGV4IDIzY2I0NzMuLmUyNzM0MjcgMTAwNjQ0Ci0t LSBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcAorKysgYi9XZWJLaXQvcXQvQXBpL3F3ZWJm cmFtZS5jcHAKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRlICJGcmFtZVRyZWUuaCIKICNpbmNs dWRlICJGcmFtZVZpZXcuaCIKICNpbmNsdWRlICJHQ0NvbnRyb2xsZXIuaCIKKyNpbmNsdWRlICJD YWNoZS5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkhUTUxNZXRh RWxlbWVudC5oIgogI2luY2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKQEAgLTE4NSw2ICsxODYsMTQg QEAgdm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfZ2FyYmFnZUNvbGxlY3Rvcl9jb2xsZWN0T25B bHRlcm5hdGVUaHJlYWQoYm9vbCB3YWl0VW4KICAgICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29s bGVjdE9uQWx0ZXJuYXRlVGhyZWFkRm9yRGVidWdnaW5nKHdhaXRVbnRpbERvbmUpOwogfQogCit2 b2lkIFFXRUJLSVRfRVhQT1JUIHF0X2RydF9jYWNoZV9jbGVhcigpCit7CisgICAgaWYgKCFjYWNo ZSgpLT5kaXNhYmxlZCgpKSB7CisgICAgICAgIGNhY2hlKCktPnNldERpc2FibGVkKHRydWUpOwor ICAgICAgICBjYWNoZSgpLT5zZXREaXNhYmxlZChmYWxzZSk7CisgICAgfQorfQorCiBRV2ViRnJh bWVEYXRhOjpRV2ViRnJhbWVEYXRhKFdlYkNvcmU6OlBhZ2UqIHBhcmVudFBhZ2UsIFdlYkNvcmU6 OkZyYW1lKiBwYXJlbnRGcmFtZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViQ29y ZTo6SFRNTEZyYW1lT3duZXJFbGVtZW50KiBvd25lckZyYW1lRWxlbWVudCwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29uc3QgV2ViQ29yZTo6U3RyaW5nJiBmcmFtZU5hbWUpCmRpZmYg LS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAw M2I5MDEyLi44YzQ2MGNmIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dl YktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0yOCAgWm9sdGFuIEhl cmN6ZWcgIDx6aGVyY3plZ0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgS2lsbCB0aGUgTEVBSyBtZXNzYWdlcyBpbiBEZWJ1 ZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Nzc2NworCisgICAgICAgICogQXBpL3F3ZWJmcmFtZS5jcHA6CisgICAgICAgIChxdF9kcnRfY2Fj aGVfY2xlYXIpOgorICAgICAgICAqIFF0TGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChtYWlu KToKKwogMjAwOS0wNy0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv UXRMYXVuY2hlci9tYWluLmNwcCBiL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCmluZGV4 IDUwYzA2Y2EuLjA4OTM1NzIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4u Y3BwCisrKyBiL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCkBAIC01MSw2ICs1MSwxMSBA QAogI2luY2x1ZGUgPFFGaWxlPgogI2luY2x1ZGUgPGNzdGRpbz4KIAorI2lmbmRlZiBOREVCVUcK K3ZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X2dhcmJhZ2VDb2xsZWN0b3JfY29sbGVjdCgpOwor dm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfY2FjaGVfY2xlYXIoKTsKKyNlbmRpZgorCiBjbGFz cyBXZWJQYWdlIDogcHVibGljIFFXZWJQYWdlCiB7CiBwdWJsaWM6CkBAIC00NTAsNiArNDU1LDEz IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKICAgICAgICAgICAgIHdpbmRvdy0+ bmV3V2luZG93KGFyZ3MuYXQoaSkpOwogCiAgICAgICAgIHdpbmRvdy0+c2hvdygpOworI2lmbmRl ZiBOREVCVUcKKyAgICAgICAgaW50IHJldFZhbCA9IGFwcC5leGVjKCk7CisgICAgICAgIHF0X2Ry dF9nYXJiYWdlQ29sbGVjdG9yX2NvbGxlY3QoKTsKKyAgICAgICAgcXRfZHJ0X2NhY2hlX2NsZWFy KCk7CisgICAgICAgIHJldHVybiByZXRWYWw7CisjZWxzZQogICAgICAgICByZXR1cm4gYXBwLmV4 ZWMoKTsKKyNlbmRpZgogICAgIH0KIH0KLS0gCjEuNi4wLjQKCg== 33696 2009-07-28 23:39:51 -0700 2009-07-29 01:30:04 -0700 propsed patch v2 0001-Fix-to-remove-the-leak-messages-in-debug-mode.patch text/plain 2863 zherczeg RnJvbSAyMDVmMmVmZWM0YmE2Zjg0NWEyNDUzMzI1YTUwOTdkOWI4ZGFmODM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBXZWQsIDI5IEp1bCAyMDA5IDA4OjM2OjU5ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gRml4IHRvIHJlbW92ZSB0aGUgbGVhayBtZXNzYWdlcyBpbiBkZWJ1ZyBtb2RlCgpTaWduZWQt b2ZmLWJ5OiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2VkLmh1PgotLS0KIFdl YktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCAgIHwgICAgOSArKysrKysrKysKIFdlYktpdC9xdC9D aGFuZ2VMb2cgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViS2l0L3F0L1F0TGF1 bmNoZXIvbWFpbi5jcHAgfCAgIDEyICsrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAzNSBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcAppbmRleCAyM2NiNDcz Li5lMjczNDI3IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIv V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAi RnJhbWVUcmVlLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCiAjaW5jbHVkZSAiR0NDb250cm9s bGVyLmgiCisjaW5jbHVkZSAiQ2FjaGUuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIK ICNpbmNsdWRlICJIVE1MTWV0YUVsZW1lbnQuaCIKICNpbmNsdWRlICJIaXRUZXN0UmVzdWx0Lmgi CkBAIC0xODUsNiArMTg2LDE0IEBAIHZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X2dhcmJhZ2VD b2xsZWN0b3JfY29sbGVjdE9uQWx0ZXJuYXRlVGhyZWFkKGJvb2wgd2FpdFVuCiAgICAgZ2NDb250 cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3RPbkFsdGVybmF0ZVRocmVhZEZvckRlYnVnZ2luZyh3YWl0 VW50aWxEb25lKTsKIH0KIAordm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfY2FjaGVfY2xlYXIo KQoreworICAgIGlmICghY2FjaGUoKS0+ZGlzYWJsZWQoKSkgeworICAgICAgICBjYWNoZSgpLT5z ZXREaXNhYmxlZCh0cnVlKTsKKyAgICAgICAgY2FjaGUoKS0+c2V0RGlzYWJsZWQoZmFsc2UpOwor ICAgIH0KK30KKwogUVdlYkZyYW1lRGF0YTo6UVdlYkZyYW1lRGF0YShXZWJDb3JlOjpQYWdlKiBw YXJlbnRQYWdlLCBXZWJDb3JlOjpGcmFtZSogcGFyZW50RnJhbWUsCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFdlYkNvcmU6OkhUTUxGcmFtZU93bmVyRWxlbWVudCogb3duZXJGcmFtZUVs ZW1lbnQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYkNvcmU6OlN0cmlu ZyYgZnJhbWVOYW1lKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggMDNiOTAxMi4uOWY3NDNjZSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIw MDktMDctMjggIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAaW5mLnUtc3plZ2VkLmh1PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gSW4gZGVi dWcgbW9kZSwgdGhpcyBmaXggZnJlZXMgY2FjaGVkIHJlc291cmNlcworICAgICAgICBhbmQgb3Ro ZXIgdW5yZWZlcmVuY2VkIG9iamVjdHMgKGJ5IGNhbGxpbmcgdGhlCisgICAgICAgIGdhcmJhZ2Ug Y29sbGVjdG9yKSB0byByZW1vdmUgdGhlIExFQUsgbWVzc2FnZXMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzc2NworCisgICAgICAgICogQXBpL3F3 ZWJmcmFtZS5jcHA6CisgICAgICAgIChxdF9kcnRfY2FjaGVfY2xlYXIpOgorICAgICAgICAqIFF0 TGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChtYWluKToKKwogMjAwOS0wNy0yNyAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcCBiL1dl YktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCmluZGV4IDUwYzA2Y2EuLjA4OTM1NzIgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCisrKyBiL1dlYktpdC9xdC9RdExh dW5jaGVyL21haW4uY3BwCkBAIC01MSw2ICs1MSwxMSBAQAogI2luY2x1ZGUgPFFGaWxlPgogI2lu Y2x1ZGUgPGNzdGRpbz4KIAorI2lmbmRlZiBOREVCVUcKK3ZvaWQgUVdFQktJVF9FWFBPUlQgcXRf ZHJ0X2dhcmJhZ2VDb2xsZWN0b3JfY29sbGVjdCgpOwordm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9k cnRfY2FjaGVfY2xlYXIoKTsKKyNlbmRpZgorCiBjbGFzcyBXZWJQYWdlIDogcHVibGljIFFXZWJQ YWdlCiB7CiBwdWJsaWM6CkBAIC00NTAsNiArNDU1LDEzIEBAIGludCBtYWluKGludCBhcmdjLCBj aGFyICoqYXJndikKICAgICAgICAgICAgIHdpbmRvdy0+bmV3V2luZG93KGFyZ3MuYXQoaSkpOwog CiAgICAgICAgIHdpbmRvdy0+c2hvdygpOworI2lmbmRlZiBOREVCVUcKKyAgICAgICAgaW50IHJl dFZhbCA9IGFwcC5leGVjKCk7CisgICAgICAgIHF0X2RydF9nYXJiYWdlQ29sbGVjdG9yX2NvbGxl Y3QoKTsKKyAgICAgICAgcXRfZHJ0X2NhY2hlX2NsZWFyKCk7CisgICAgICAgIHJldHVybiByZXRW YWw7CisjZWxzZQogICAgICAgICByZXR1cm4gYXBwLmV4ZWMoKTsKKyNlbmRpZgogICAgIH0KIH0K LS0gCjEuNi4wLjQKCg== 33700 2009-07-29 01:30:04 -0700 2009-07-29 09:42:26 -0700 propsed patch v3 0001-Fix-to-remove-the-leak-messages-in-debug-mode.patch text/plain 1831 zherczeg RnJvbSA4Y2RmODEyNzE5NzM2MThmMmFiNDQ4MDkzMWFhOWViNjQ5MGE1YTdiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBXZWQsIDI5IEp1bCAyMDA5IDEwOjI3OjM4ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gRml4IHRvIHJlbW92ZSB0aGUgbGVhayBtZXNzYWdlcyBpbiBkZWJ1Zy1tb2RlCgpTaWduZWQt b2ZmLWJ5OiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2VkLmh1PgotLS0KIFdl YktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViS2l0 L3F0L1F0TGF1bmNoZXIvbWFpbi5jcHAgfCAgIDExICsrKysrKysrKysrCiAyIGZpbGVzIGNoYW5n ZWQsIDI1IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0 L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggMDNiOTAxMi4uOWY3NDNj ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDctMjggIFpvbHRhbiBIZXJjemVnICA8emhlcmN6 ZWdAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gSW4gZGVidWcgbW9kZSwgdGhpcyBmaXggZnJlZXMgY2FjaGVkIHJl c291cmNlcworICAgICAgICBhbmQgb3RoZXIgdW5yZWZlcmVuY2VkIG9iamVjdHMgKGJ5IGNhbGxp bmcgdGhlCisgICAgICAgIGdhcmJhZ2UgY29sbGVjdG9yKSB0byByZW1vdmUgdGhlIExFQUsgbWVz c2FnZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Nzc2NworCisgICAgICAgICogQXBpL3F3ZWJmcmFtZS5jcHA6CisgICAgICAgIChxdF9kcnRfY2Fj aGVfY2xlYXIpOgorICAgICAgICAqIFF0TGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChtYWlu KToKKwogMjAwOS0wNy0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv UXRMYXVuY2hlci9tYWluLmNwcCBiL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCmluZGV4 IDUwYzA2Y2EuLmQ5OTI4ZmYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4u Y3BwCisrKyBiL1dlYktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCkBAIC01MSw2ICs1MSwxMCBA QAogI2luY2x1ZGUgPFFGaWxlPgogI2luY2x1ZGUgPGNzdGRpbz4KIAorI2lmbmRlZiBOREVCVUcK K3ZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X2dhcmJhZ2VDb2xsZWN0b3JfY29sbGVjdCgpOwor I2VuZGlmCisKIGNsYXNzIFdlYlBhZ2UgOiBwdWJsaWMgUVdlYlBhZ2UKIHsKIHB1YmxpYzoKQEAg LTQ1MCw2ICs0NTQsMTMgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICAgICAg ICAgICAgd2luZG93LT5uZXdXaW5kb3coYXJncy5hdChpKSk7CiAKICAgICAgICAgd2luZG93LT5z aG93KCk7CisjaWZuZGVmIE5ERUJVRworICAgICAgICBpbnQgcmV0VmFsID0gYXBwLmV4ZWMoKTsK KyAgICAgICAgcXRfZHJ0X2dhcmJhZ2VDb2xsZWN0b3JfY29sbGVjdCgpOworICAgICAgICBRV2Vi U2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVzKCk7CisgICAgICAgIHJldHVybiByZXRWYWw7Cisj ZWxzZQogICAgICAgICByZXR1cm4gYXBwLmV4ZWMoKTsKKyNlbmRpZgogICAgIH0KIH0KLS0gCjEu Ni4wLjQKCg==