277654 2024-08-05 16:12:25 -0700 run-webkit-tests exit code shouldn't depend on number of unexpected results 2024-09-04 18:51:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 276081 https://bugs.webkit.org/show_bug.cgi?id=276081 InRadar P2 Normal --- 1 gsnedders webkit-unassigned aakash_jain emw jbedard webkit-bug-importer oldest_to_newest 2050760 0 gsnedders 2024-08-05 16:12:25 -0700 Currently, if we get the expected output but exit with non-zero, EWS will totally ignore this: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/CISupport/ews-build/steps.py#L4113-L4114 We practically have to do this, because the exit code is actually just the number of regressions: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/Scripts/webkitpy/port/base.py#L961-L966 It would be probably be better to define an exit code which means "we had regressions", as we then don't end up in situations where a single exit code can mean multiple things. 2050761 1 webkit-bug-importer 2024-08-05 16:12:38 -0700 <rdar://problem/133250341> 2056386 2 emw 2024-08-29 14:50:24 -0700 I think this is fixed by the changes landed in https://bugs.webkit.org/show_bug.cgi?id=276081. *** This bug has been marked as a duplicate of bug 276081 *** 2057785 3 gsnedders 2024-09-04 18:51:57 -0700 They got reverted in bug 277749 :(